From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4918C636D4 for ; Thu, 9 Feb 2023 07:23:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A5116B0072; Thu, 9 Feb 2023 02:23:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 42D0F6B0075; Thu, 9 Feb 2023 02:23:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A6D56B0078; Thu, 9 Feb 2023 02:23:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 17B256B0072 for ; Thu, 9 Feb 2023 02:23:28 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E06F6C0482 for ; Thu, 9 Feb 2023 07:23:27 +0000 (UTC) X-FDA: 80446912854.28.CE0C8DB Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf18.hostedemail.com (Postfix) with ESMTP id 2FD6B1C001B for ; Thu, 9 Feb 2023 07:23:26 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="QTvuFq/7"; spf=pass (imf18.hostedemail.com: domain of haoluo@google.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=haoluo@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675927406; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tddsbJmipDadgZuL4C+TKbP9J2syeyMjmHZxy6JDTt4=; b=xbNtxDZEoxfSmEb3KeCNPiHI7elJZfxepbxPmMUEQTgh/huSbHN02f0+oIAkQBwsh08GJP 4f+jHtFr9RvdJvfn1GFI/c/LzmVRM7Kn6WSk7pcbwvUYZeL7R0rHpV4UhBm3HDqo4yuJXQ xdFAWoNudTyTC0GtGJUcMfjuIFs5gZI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="QTvuFq/7"; spf=pass (imf18.hostedemail.com: domain of haoluo@google.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=haoluo@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675927406; a=rsa-sha256; cv=none; b=mInOq2C2ndJJu5X6W2jM8gfdrSKVaJpn8ujX0Z8Sf5ONw526IfmT51PO64f0mQYx2W5mae CcgSiW54LDZVayaP2swIHqXtqH3jjJzotpsL0OQLJBLm1j13RVBjf+i8nfn5+23KeiAMEh oTIE8jz+mQ9JxmVPZj+E5BpBY+pihfk= Received: by mail-pf1-f177.google.com with SMTP id r17so735455pff.9 for ; Wed, 08 Feb 2023 23:23:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=tddsbJmipDadgZuL4C+TKbP9J2syeyMjmHZxy6JDTt4=; b=QTvuFq/7v+CdkDisGU23a4Mg4sCbIx93MNu51rqdsSFelRH+bzFtnIoxiDz5XLtECD mVOdxoI+TDOdkZ+OftJL3dm7+U+HdYpulqUrb2jLjjKCqVg0ACdWdD2HO+m/yRYZ3tuw wkdhJGyPozWn+PtKhMrcQXV0lfoFGh+g0xgtz67cOirBzeCAtoScHKwH/q5zla5Efj+F bOGjzkshWM0wd9jjds9Jgo9wbbEimVjRaN2G/fPBSRVYTKbJ7QTToZAfK2O0wuDdv6lJ yO49Rn6wsAx0XAY45aXkgHk7bVpHRoWTWItBRJR4rEGqsJGkEgeumTF3u+UwIkz1j6EL 2c3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tddsbJmipDadgZuL4C+TKbP9J2syeyMjmHZxy6JDTt4=; b=bXBY+WPxuWuNQvHV3no2X5DbVXXjd96U+3LMfrJdh0Fpl2z5A/1leHyFFRG56zRDUl yUA5VgVofuGrFenTh8cIiKIkYe07Ap+seF5X4b2X8aju6G3ZQqpGyywO8AxEWuVr2Kw5 VHoHqi/9OrkIxXVJ/GmnAUB+q4kwkZQbGDQ3LjkmcrxDc3owEVpVBo2XHbCTFaDiqMXW y3KyqbzJOA04W0yFMq9F67NDqLzjnv736XDFjbTFOAjeOfnHjV+czaaIUOqtDpiXrkIM LbC2bFYe3UMdM077cxdtuKCtDwj3N84a1/XymV7ySqGvFTNyx2KBAkmtrCo9HFU9KQGr 5Hxg== X-Gm-Message-State: AO0yUKXMELttPTKzRjYgQQ9+zxer0noI4UC5iYalLTJ7RP4fXMZcdITD l6exUoXmEKpWnKUYKHtncHkNnIJdefiAd/RHcnG8AQ== X-Google-Smtp-Source: AK7set8147oifuJImE5p0zRAylkYykGYufjK3B5xwMaz7PIg/QVSQ6RfLCFlhgyJPReztt3sdy3IK2VJ1VcQgxbPxyU= X-Received: by 2002:a63:8f0c:0:b0:4fb:3232:8f70 with SMTP id n12-20020a638f0c000000b004fb32328f70mr1164056pgd.9.1675927404760; Wed, 08 Feb 2023 23:23:24 -0800 (PST) MIME-Version: 1.0 References: <20230201135737.800527-1-jolsa@kernel.org> <20230201135737.800527-3-jolsa@kernel.org> In-Reply-To: <20230201135737.800527-3-jolsa@kernel.org> From: Hao Luo Date: Wed, 8 Feb 2023 23:23:13 -0800 Message-ID: Subject: Re: [PATCH RFC 2/5] bpf: Use file object build id in stackmap To: Jiri Olsa Cc: Alexei Starovoitov , Andrii Nakryiko , Andrew Morton , Alexander Viro , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Daniel Borkmann Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: b3eatf5ru9ugi3z3ahjtbhuk8fty135e X-Rspamd-Queue-Id: 2FD6B1C001B X-HE-Tag: 1675927406-936866 X-HE-Meta: U2FsdGVkX1//hpK2dP/BzsZ+IcZj6uTGLzqYEqFnUNrGjpuG1s/P4+XLpNRBY0la/2w+XQPSi6R4oYYWZ5McNqmGp1FPWxRfli34u/Br2HoelgQhZROgv+td+ujq+DC972hTQgxkx49tajdjYIfOPOWGAVXcSPGE+Gf6qtGWFT5G3vGMciofNWNbHxkVkP7fwV9wBOEULuhhzv2IrWgHf5yVv7mFGxWv68CqkqZ66JRiTu5uUL5d/XFbLNLvq266tRH4bfuvdXYB5OtIfSmNEklHEjrdLkhUAM46UmnFu+2whwp5+F8fSNYUESJsFB5S5x5LWv3lFeX/VEviUPggiH0Fv4YmX97PX6tAftBy4VH93jYjrT+SChYJECYxZ5eQRqRzqDrVygijKkFsDTOfPYOsmKrsbZDUdZS2Gnjc0Iypd6zCFs/p29SvOptAgGrx+RKIW9Ew87n8R7Ese8yMUpoT58tRXFjQJRMwFbSCkBOu5KczaYljccf0Gxzjk/0Qzqb/FxAQ5Zt0k1gIBStEnnkC7lNyHzOKpUEAoFN0iEhE35QaItJEp+PdcB2k6sy+E53YQppJYJwk198XC3j6KYc1ojvApif0sb8kXxWNw9xIQ8L+0KNCuvYxf5smfQcoDv9aREGemYtp8t7OHpGzdB4LcSL/jbSavHspGLohyFxCYcNimgp8cogTG8S67vJGrsPr0YgmcX2ffh2mVipekE7jlIkUafeL0mCkYVYnekTxieI7+3eG6+X8A3eAsfxDKJtyPZGFeImg899ZcAdPIbCNiwWorRQm89NxrC0WjqOLwIcs7q5MgmYibjpMoG9OlrebcNVSowglIoQnKrA2BL4rVK+XUueC/hBvdH8UtWXQiBmlUX8zes9iQUCBjHvllGyblgaEM5dCTgU1/6jVxoqI9s6jXAVzpG1uJOlkt8asfG10IvnPCihI55egCUD9vhCcCHxIakAiOc5sG5x cs9FQzZF AEu8HAzP7VvMHZAayYSTzokqa2KsDnEXczDlpSQ6hIBS9FVh7LMoybGtNEO8C68ubUZ0zvLTGZTYlj0POoJjh+b2sOmO+RMrN7S8uJrWPjm6TA2aK7ZQqytd5w0CX/N2NKOixVZSViNvmlkkZY29udOqGicg1N1A36FYv8GInhIgP7siikl5B9WbStOZDARRwxuyLaYp/swJ/KQpFxZpG5JcclDXtPTs8LKJOefiRCBCVtEahgbpzr5+Xo6CBsF6FZMsctCjDiltHxzLpHv2GeYsHW3Jx4KSuD/Sju9W2kIY2p0ULs9VYDJJ3E4+xNYJpYPXm1f2lMDoxyj4hB6XhiFkvXUZi/QtIaLGddK36YG8O2fCuETrp0J8R5g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 1, 2023 at 5:58 AM Jiri Olsa wrote: > > Use build id from file object in stackmap if it's available. > > Signed-off-by: Jiri Olsa > --- Can we insert the lookup from vma->vm_file in build_id_parse() rather than its callers? > kernel/bpf/stackmap.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c > index aecea7451b61..944cb260a42c 100644 > --- a/kernel/bpf/stackmap.c > +++ b/kernel/bpf/stackmap.c > @@ -156,7 +156,15 @@ static void stack_map_get_build_id_offset(struct bpf_stack_build_id *id_offs, > goto build_id_valid; > } > vma = find_vma(current->mm, ips[i]); > +#ifdef CONFIG_FILE_BUILD_ID > + if (vma && vma->vm_file && vma->vm_file->f_bid) { > + memcpy(id_offs[i].build_id, > + vma->vm_file->f_bid->data, > + vma->vm_file->f_bid->sz); > + } else { > +#else > if (!vma || build_id_parse(vma, id_offs[i].build_id, NULL)) { > +#endif > /* per entry fall back to ips */ > id_offs[i].status = BPF_STACK_BUILD_ID_IP; > id_offs[i].ip = ips[i]; > -- > 2.39.1 >