From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DC88C4828D for ; Tue, 6 Feb 2024 08:42:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D46B6B006E; Tue, 6 Feb 2024 03:42:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 335056B0071; Tue, 6 Feb 2024 03:42:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AE666B0072; Tue, 6 Feb 2024 03:42:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0321A6B006E for ; Tue, 6 Feb 2024 03:42:02 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 69AC21C153F for ; Tue, 6 Feb 2024 08:42:01 +0000 (UTC) X-FDA: 81760736442.13.DBD51CD Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf24.hostedemail.com (Postfix) with ESMTP id 8EC8818000D for ; Tue, 6 Feb 2024 08:41:58 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NltZp9e9; spf=pass (imf24.hostedemail.com: domain of fangzheng.zhang1003@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=fangzheng.zhang1003@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707208918; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AUKpqPDICdyV+oEkFiuJfuSIu/Fo5FuwDkKvK9YAE2g=; b=Ey6zY6DeebVtZNcNFGNEIKLiF8FQquBEwHbwcyJNe13MYBSoCq+HARgwnuoAIa3SXlX0zq rwwfcDe/p22Cb/HDfrmzJ3HyWDNRywVKEgVTN0idIs4Y2wQfODAPgj3Mi4VMVu1YH48RKU cJczuf4rpPOmcm7Jyc3+O82i9iV9Moo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707208918; a=rsa-sha256; cv=none; b=hMvUSkIuRAkuFNsegXBc7KzLngURdwbwk6G4Pf69w6vQ/aty0rdKBtQ3xT3hfkAJNbVL9l Gxs+BMc61hmQZlFnTHQWEJmJnwnlh+QFPNYDFsmo4AweF1V8pG3XftyDXgkgKQbCyzwW7A fwsMKlZgNun93+XnLpl0V1Hr24rCecE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NltZp9e9; spf=pass (imf24.hostedemail.com: domain of fangzheng.zhang1003@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=fangzheng.zhang1003@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2cf1fd1cc5bso67033061fa.3 for ; Tue, 06 Feb 2024 00:41:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707208917; x=1707813717; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=AUKpqPDICdyV+oEkFiuJfuSIu/Fo5FuwDkKvK9YAE2g=; b=NltZp9e9RfbfGRFxlRC61sunezMv8ox06Mi54f4NWqqK627cgDA4qkaX36WzFZWeI9 J0e1kb3Lw/oGgZ1TJmxXSvo56da9X16aupFVUtOkPD3xlGbhgtKk38zfBPabtDnGguDl CiN11rBHcJihX3QvzrAzPRcMXzzjcq6FnTdDNjr0ucleoddKY/Zi7qOugiybk7Axurvb LHudBqLgGsgco/ev3gGGXgtWX2IYL5aGSuUE2T9uW7BMGBRGXhQ9rMA7Ww0znvHFUbvR dsd+BhZUntqeMWuvGcGIFU11oUDNygWLy+W1L9y/iLiBqSOnfBfC9gLfQwbozYkrBH79 YDrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707208917; x=1707813717; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AUKpqPDICdyV+oEkFiuJfuSIu/Fo5FuwDkKvK9YAE2g=; b=kyC4p3ZAER9PlYGVnWYllS7qC3eleiCa4ep2ahsJBVCMXAz9BSpHsNYYuU8OB6T1Ui Q4cM9kzmjt26u1PDxqRoRmRGRPAkSbwgxJBH7ToteLmGN91FCPXmM40jB9RSIyAdR+aW /BltTsEgW4N3IW4ZX52NrJ5ryaeaBy228Z7p5d4U9iH/c1rUvciOjvpVVFiHPphPHoJz YPUs5L0DyzZ3LztQXPUpHLXxrGxeF0b4g7/bTimHCpSH5Gsg1HrzvBCQzssjZcfKK+Ba IKcbTLYR5/YHn0a6OZrZpVz7/3ZsAnUFhSdUVRUOBNoeuapNozM39SVKD1FJXSumwHYX CpCA== X-Gm-Message-State: AOJu0Yw2pgSyRa+0RijSrPdf62D5q8oLHCkSvq340WDoI+mizAuCPA05 GWJ3rMqkRSJwA3H2CqhQea4jisNvepP8SQn9hkfCUUiuuwCbcrtptMJPhJYx0NJ//sOxxhMPqzx ylhdPHumPMGIqjOGDI7ulo7XIoA== X-Google-Smtp-Source: AGHT+IEiLZokYmAulBD5ZJ1Okyt1qxq6/trGvjRHR1eDF9duznqf4WUe8vzdZPOW923PbMxYt2hjqDfcYpBUdIxwa3A= X-Received: by 2002:a05:651c:10a3:b0:2d0:a464:5937 with SMTP id k3-20020a05651c10a300b002d0a4645937mr961659ljn.0.1707208916466; Tue, 06 Feb 2024 00:41:56 -0800 (PST) MIME-Version: 1.0 References: <20240131094442.28834-1-fangzheng.zhang@unisoc.com> <2024020441-version-chihuahua-1067@gregkh> <2f43774a-16cf-412e-b4b7-840889bb796b@suse.cz> <202402060127.4161Ri2X082625@SHSPAM01.spreadtrum.com> In-Reply-To: From: zhang fangzheng Date: Tue, 6 Feb 2024 16:41:45 +0800 Message-ID: Subject: Re: [PATCH] mm/slab: Add slabreclaim flag to slabinfo To: Vlastimil Babka , gregkh@linuxfoundation.org, cl@linux.com Cc: Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , =?UTF-8?B?6Z+p546J5piOIChZdW1pbmcgSGFuKQ==?= , Chunyan Zhang Content-Type: multipart/alternative; boundary="0000000000000600a00610b28d63" X-Stat-Signature: 4x6px8uwc8zahwjc8ybmgxsa5eop615q X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8EC8818000D X-Rspam-User: X-HE-Tag: 1707208918-600586 X-HE-Meta: U2FsdGVkX1+18mqv8+PDfb5Jztw7GEwVDYa2hM3IHwfvjXPt3p46uklcEjFcTrqu53ZVtVet/qf9rEC1ec8GAngtVX3NgYZjFhN/fwSyLrP36cWc5BaxGI6LJrZyPXiz2JQU2TYE+SpLv2IwWtm8Zp/Z3PbeDaZas0tBnrilvb57FG+huKm9UqXdfSV0fc2xCk0OQoXKOcNu+koKdot+K+W+acDX6mYfHW6p1/l7REYd5ZeJ+jsTzYLCaVPYUq7/FXJocOF3bFRXmyqHhheaHE9R8Iskk37jLdXgpSkrVFXn+N8v75sH/YRGEnfRfN6nRZfL1V+pgSGrgdvz4otyTcDzgKUYOFKBMCO81nEm0mXjZe8jFmMevzlpdSxt/7Q/kRKPQZGgmXKdaEMzoO7MS9vFefHQUwxSJIY0Ql4JbrYBKmrXj7nGm0/LDsaqIwPx5dqsp+fzDcRpqOIRAs4ezA/bTVDTaYj5sUtB3fzXRPtfVCw8BIaA7PQdBOHKfyvd6jOAq0gx4ihZ2cnW1/0gPDptglTPpXoEg3xYsPIoeJu6CwD7zhFb24gNXgLqFB6iGdxpS+zmich/9/VPB7ERMVSd1SMDV6G2/i2I7oJ3429KcmdmSg7T3uBp2uCg3WiQqd88LPQ5jDkPLjKaS9mPi1MAJwdAzR/c6BEyreFyCU34d5n+xvN/2IdIWK24o+kl6OLtTcGNuweKHacya//9ptOuv1uD6X2v+14X5RkgJAbHWJf6QU2c5WGhaB98PqGIAZ5PDtdR3pTNGWI9wENArn6QnT9SRZ09qQH14+X8vsh8MSq9ddI/6XhRoQ6SwHbRC+aW9EQrHeKK7jwPtUq7DcWjtGYKAMtqaMGuk2JS42Z0nhIEBQzoQhzdJaURgKbBK1yAYmLVwsvDssrs4gUXYJ4Cr2Jn+NtQky+trEZw6XYNoNnDh/J3AD0WZRgBkCkjTAfOHF+XTR52sKPMtNf 4b8m4eJS ogxjplz3nqxltMKQwzMUoIX9aQglzu9Skff40H4MH6oF6RnMs2l7uOqnNCcddluwF2fjDLYVRCrhEUs8YMem6eH1NHNEwAnEkmi55kCRGjOP13GlHYQuqLou6tT1CPmNvl2nuuZ7mNjMvOh1h+kegHnijufHaHbyXycXG2JpYdoHbFNVcMpEC2fA2l/4mEL3b5hHkuo6s8v7SlJA0f0vX111p9IjuAY4f0q+d5IKAcpVDfOoMf/Cs6hCeGd8q0nm8+2JGOiJoK8IkN0z2Fa4r7s8FQDzwuWTDgTjvYf9XwpzO4yyXK3QGgRHJ1Z7GVW3l305+K986cERBjOYVUJ5mSdgYXzGLbabN32OG/K3Hxo57fFvClbEQZTWonzuh2Zua/5lG94+ijfmiiYsVnPGTvclIqz4oD10DO+trQV1E9JGrDinbPAz9Xg+y730OsvSd8rM1bmWHUoA0GPQvbVqBlg/qMEBcRTbZm8ys+OWb+NuhO3GJ+euxGo+SYAiVzlUvs/jDwTrOR2G/gZOC08bv6tFYH0MhroExUZ3VVuyPYeANpo8kdu+Uk1YPUpOkB2vI4c9+auK5LbhiFISEAlZJoxV2FSzWRozX9tPW75zScUu/xT/jFdnjiPqn7FkQXx/xG4oNyJtC/x/hPTJKjqDWSbKcMmEBTA12++1fEu5Zu6DJPWGs0Ma2ahCiuTqaZNdKy5tOciottmjDh/v27tOGG7R3rF913VE4pBzEzKBQgGOFsAY7pC5QU0qnwBk3y2yHL47NVMJ6b9VW5AIUXlm9MVRBWbmCduvuYsSq0pbNhS6MTG0+jh1y72CrduHa7CF3/eDNNRyhVlZTzUS8I42wbqq8wc3YmSALgX2fFaIe/moV3ssPw5ZXErf0BWhejP7KJuQfXucOJsmwavmSVEKk9WURaMft1/Jkwh43pLn3MPe17YFWAQ7xrRvCY7AcYyokmrFiI7cfIJXhpOIeHcqzrrFwnCNW YXDI6HuL CsES20Qo4jsww3qTwRB7N5MpGyHtvnjREGMecVJ7iYiX6qnxrL0rflzH/LFGBBdwgDnXRaWE/G4dGsCAjm37pQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --0000000000000600a00610b28d63 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Feb 6, 2024 at 4:02=E2=80=AFPM =E5=BC=A0=E6=96=B9=E6=AD=A3 (Fangzhe= ng Zhang) < fangzheng.zhang@unisoc.com> wrote: > > Frist, thank you very much for your comments and I would like to say, when performing slab memory information maintenance, people often hope to see more detailed information through a simple slabinfo command. As Vlastimil mentioned the method, but it is very unintuitive to the status of the entire slab, so we add the slabreclaim column to slabinfo and directly output it using cmdline ' > cat proc/slabinfo'. And I think this approach will also be helpful for future work on memory statistics. And I found that there is no corresponding slabinfo output example in the proc.rst document. Can we add a output example so that userspace knows about it? > > Due to insufficient understanding of the code framework used by the slabinfo tool, this patch was not considered. Of course, I think in the next we will consider marking /proc/slabinfo as deprecated, and then use the "slabinfo" tool to implement the corresponding proc/slabinfo functions. > > Thanks again! > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Christoph Lameter (Ampere) > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B42=E6=9C=886=E6=97=A5 1= :55 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Vlastimil Babka > =E6=8A=84=E9=80=81: Greg KH ; =E5=BC=A0=E6=96= =B9=E6=AD=A3 (Fangzheng Zhang) < fangzheng.zhang@unisoc.com>; Pekka Enberg ; David Rientjes ; Joonsoo Kim ; Andrew Morton ; Roman Gushchin < roman.gushchin@linux.dev>; Hyeonggon Yoo <42.hyeyoo@gmail.com>; linux-mm@kvack.org; linux-kernel@vger.kernel.org; Fangzheng Zhang < fangzheng.zhang1003@gmail.com>; =E9=9F=A9=E7=8E=89=E6=98=8E (Yuming Han) ; Chunyan Zhang > =E4=B8=BB=E9=A2=98: Re: [PATCH] mm/slab: Add slabreclaim flag to slabinfo > > > =E6=B3=A8=E6=84=8F: =E8=BF=99=E5=B0=81=E9=82=AE=E4=BB=B6=E6=9D=A5=E8=87= =AA=E4=BA=8E=E5=A4=96=E9=83=A8=E3=80=82=E9=99=A4=E9=9D=9E=E4=BD=A0=E7=A1=AE= =E5=AE=9A=E9=82=AE=E4=BB=B6=E5=86=85=E5=AE=B9=E5=AE=89=E5=85=A8=EF=BC=8C=E5= =90=A6=E5=88=99=E4=B8=8D=E8=A6=81=E7=82=B9=E5=87=BB=E4=BB=BB=E4=BD=95=E9=93= =BE=E6=8E=A5=E5=92=8C=E9=99=84=E4=BB=B6=E3=80=82 > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. > > > > On Mon, 5 Feb 2024, Vlastimil Babka wrote: > > > On 2/4/24 14:09, Greg KH wrote: > >> On Wed, Jan 31, 2024 at 05:44:42PM +0800, Fangzheng Zhang wrote: > >>> In order to enhance slab debugging, we add slabreclaim flag to > >>> slabinfo. Slab type is also an important analysis point in slabinfo > >>> for per slab, when various problems such as memory leaks or memory > >>> statistics occur. > >>> > >>> Signed-off-by: Fangzheng Zhang > >>> --- > >>> mm/slab_common.c | 7 ++++--- > >>> 1 file changed, 4 insertions(+), 3 deletions(-) > >>> > >>> diff --git a/mm/slab_common.c b/mm/slab_common.c index > >>> 238293b1dbe1..aeeb2bfe6dda 100644 > >>> --- a/mm/slab_common.c > >>> +++ b/mm/slab_common.c > >>> @@ -1038,7 +1038,7 @@ static void print_slabinfo_header(struct seq_file *m) > >>> seq_puts(m, "slabinfo - version: 2.1\n"); > >>> seq_puts(m, "# name "); > >>> seq_puts(m, " : tunables "); > >>> - seq_puts(m, " : slabdata "); > >>> + seq_puts(m, " : slabdata > >>> + "); > >> > >> Doesn't this change the slabinfo version number above? Where is this > >> change documented so that userspace knows about it? > > I have never seen such a document. I would suggest incrementing the version to 2.2 since there is a minor extension of the format. > I found that there is no corresponding slabinfo output example in the Documentation/filesystems/proc.rst. Can we add an output example so that user space knows about it? > I tried to remove /proc/slabinfo in the past and have people use the more versatile /sys/kernel/slab interface. But /proc/slabinfo has a long legacy. > > Could we mark /proc/slabinfo as deprecated and recommend the use of either sysfs directly or use of the "slabinfo" tool that we have been providing in linux/tools/mm for a long time? > Due to insufficient understanding of the code framework used by the slabinfo tool, this patch was not considered. Of course, I think in the next work we will consider marking /proc/slabinfo as deprecated, and then use the "slabinfo" tool to implement the corresponding proc/slabinfo function. Thanks. --0000000000000600a00610b28d63 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Feb 6, 2024 at 4:02=E2=80=AFPM =E5=BC=A0= =E6=96=B9=E6=AD=A3 (Fangzheng Zhang) <fangzheng.zhang@unisoc.com> wrote:
>
> Frist= , thank you very much for your comments and I would like to say, when perfo= rming slab memory information maintenance, people often hope to see more de= tailed information through a simple slabinfo command. As Vlastimil mentione= d the method, but it is very unintuitive to the status of the entire slab, = so we add the slabreclaim column to slabinfo and directly output it using c= mdline ' > cat proc/slabinfo'. And I think this approach will al= so be helpful for future work on memory statistics. And I found that there = is no corresponding slabinfo output example in the proc.rst document. Can w= e add a output example so that userspace knows about it?
>
> Du= e to insufficient understanding of the code framework used by the slabinfo = tool, this patch was not considered. Of course, I think in the next we will= consider marking /proc/slabinfo as deprecated, and then use the "slab= info" tool to implement the corresponding proc/slabinfo functions.
= >
> Thanks again!
> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB= =B6-----
> =E5=8F=91=E4=BB=B6=E4=BA=BA: Christoph Lameter (Ampere) &l= t;cl@linux.com>
> =E5=8F=91=E9= =80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B42=E6=9C=886=E6=97=A5 1:55
> = =E6=94=B6=E4=BB=B6=E4=BA=BA: Vlastimil Babka <vbabka@suse.cz>
> =E6=8A=84=E9=80=81: Greg KH <gregkh@linuxfoundation.org>= ;; =E5=BC=A0=E6=96=B9=E6=AD=A3 (Fangzheng Zhang) <fangzheng.zhang@unisoc.com>; Pekka Enberg &l= t;penberg@kernel.org>; David R= ientjes <rientjes@google.com&= gt;; Joonsoo Kim <iamjoonsoo.k= im@lge.com>; Andrew Morton <akpm@linux-foundation.org>; Roman Gushchin <roman.gushchin@linux.dev>; Hyeonggon = Yoo <42.hyeyoo@gmail.com>;= linux-mm@kvack.org; linux-kernel@vger.kernel.org; Fangz= heng Zhang <fangzheng.z= hang1003@gmail.com>; =E9=9F=A9=E7=8E=89=E6=98=8E (Yuming Han) <yuming.han@unisoc.com>; Chuny= an Zhang <zhang.lyra@gmail.com>
> =E4=B8=BB=E9=A2=98: Re: [PATCH] mm/slab: Add slabreclaim fla= g to slabinfo
>
>
> =E6=B3=A8=E6=84=8F: =E8=BF=99=E5=B0= =81=E9=82=AE=E4=BB=B6=E6=9D=A5=E8=87=AA=E4=BA=8E=E5=A4=96=E9=83=A8=E3=80=82= =E9=99=A4=E9=9D=9E=E4=BD=A0=E7=A1=AE=E5=AE=9A=E9=82=AE=E4=BB=B6=E5=86=85=E5= =AE=B9=E5=AE=89=E5=85=A8=EF=BC=8C=E5=90=A6=E5=88=99=E4=B8=8D=E8=A6=81=E7=82= =B9=E5=87=BB=E4=BB=BB=E4=BD=95=E9=93=BE=E6=8E=A5=E5=92=8C=E9=99=84=E4=BB=B6= =E3=80=82
> CAUTION: This email originated from outside of the organi= zation. Do not click links or open attachments unless you recognize the sen= der and know the content is safe.
>
>
>
> On Mon, 5= Feb 2024, Vlastimil Babka wrote:
>
> > On 2/4/24 14:09, Gre= g KH wrote:
> >> On Wed, Jan 31, 2024 at 05:44:42PM +0800, Fang= zheng Zhang wrote:
> >>> In order to enhance slab debugging,= we add slabreclaim flag to
> >>> slabinfo. Slab type is als= o an important analysis point in slabinfo
> >>> for per slab= , when various problems such as memory leaks or memory
> >>>= statistics occur.
> >>>
> >>> Signed-off-by:= Fangzheng Zhang <fangzhen= g.zhang@unisoc.com>
> >>> ---
> >>> = =C2=A0mm/slab_common.c | 7 ++++---
> >>> =C2=A01 file change= d, 4 insertions(+), 3 deletions(-)
> >>>
> >>>= ; diff --git a/mm/slab_common.c b/mm/slab_common.c index
> >>&g= t; 238293b1dbe1..aeeb2bfe6dda 100644
> >>> --- a/mm/slab_com= mon.c
> >>> +++ b/mm/slab_common.c
> >>> @@ -= 1038,7 +1038,7 @@ static void print_slabinfo_header(struct seq_file *m)
= > >>> =C2=A0 =C2=A0 seq_puts(m, "slabinfo - version: 2.1\n= ");
> >>> =C2=A0 =C2=A0 seq_puts(m, "# name =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<active_objs> <num_objs> <= ;objsize> <objperslab> <pagesperslab>");
> >&g= t;> =C2=A0 =C2=A0 seq_puts(m, " : tunables <limit> <batchc= ount> <sharedfactor>");
> >>> - =C2=A0 seq_put= s(m, " : slabdata <active_slabs> <num_slabs> <sharedava= il>");
> >>> + =C2=A0 seq_puts(m, " : slabdata = <active_slabs> <num_slabs>
> >>> + <sharedava= il> <slabreclaim>");
> >>
> >> Doesn&= #39;t this change the slabinfo version number above?=C2=A0 Where is this> >> change documented so that userspace knows about it?
><= br>> I have never seen such a document. I would suggest incrementing the= version to 2.2 since there is a minor extension of the format.
>
= I found that there is no corresponding slabinfo output example in the Docum= entation/filesystems/proc.rst. Can we add an output example so that user sp= ace knows about it?

> I tried to remove /proc/slabinfo in the pas= t and have people use the more versatile /sys/kernel/slab interface. But /p= roc/slabinfo has a long legacy.
>
> Could we mark /proc/slabinf= o as deprecated and recommend the use of either sysfs directly or use of th= e "slabinfo" tool that we have been providing in linux/tools/mm f= or a long time?
>
Due to insufficient understanding of the code fr= amework used by the slabinfo tool, this patch was not considered. Of course= , I think in the next work we will consider marking /proc/slabinfo as depre= cated, and then use the "slabinfo" tool to implement the correspo= nding proc/slabinfo function.

Thanks.
--0000000000000600a00610b28d63--