From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FC03C4828D for ; Tue, 6 Feb 2024 09:09:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0191F6B0075; Tue, 6 Feb 2024 04:09:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE4DF6B0078; Tue, 6 Feb 2024 04:09:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5DE76B007B; Tue, 6 Feb 2024 04:09:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C0AFB6B0075 for ; Tue, 6 Feb 2024 04:09:09 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5C15FA0BF8 for ; Tue, 6 Feb 2024 09:09:09 +0000 (UTC) X-FDA: 81760804818.28.B8C97AF Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf12.hostedemail.com (Postfix) with ESMTP id 886AF40007 for ; Tue, 6 Feb 2024 09:09:06 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hUr4ej6L; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of fangzheng.zhang1003@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=fangzheng.zhang1003@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707210546; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n3bYfjQv3EOlzlAH6SnTprc6MRzkybq6MP8ULvKh3QU=; b=uQKN/ZOy2/ttMxXsocEgHb2cPQ4UUVBGKjNjJzwD0IUy9lHoYkr0RqNFypPkDhZsvJhAm5 /v7XjtcqwV6fr+IBQGlviONgk/yoWBCGLHsj6vIH9/m0LGR4DrWwBhqLOnOdeHJmu6rYyy MhCE0tT431a3FW01RQ7j/vyTHrY1nm8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hUr4ej6L; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of fangzheng.zhang1003@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=fangzheng.zhang1003@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707210546; a=rsa-sha256; cv=none; b=nLjoiV8jVIlFqEnOFCdmcVT1mX7KAv5HvWatR3o/sVmTuPFxOZ2OPcTmaOf/dLbO9nIMLX zRZMCTSCcvulG0LNECN9z1v/sCMITj/5oIR2NbrDrzrqtodW+t2gi7kcP1nYA7Z+VB3K70 8vaTiMXDqhZgjFslakl5hw1V9nuYZ1M= Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2d04c0b1cacso66945421fa.0 for ; Tue, 06 Feb 2024 01:09:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707210545; x=1707815345; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=n3bYfjQv3EOlzlAH6SnTprc6MRzkybq6MP8ULvKh3QU=; b=hUr4ej6L8UaUCOfzZqLtWhwWeLDHJHWg9HB/z0VcSVlZe1auO3EdZUA96IaLHxBUj6 ZJT+xHL3hbIfU22rtfwMtXYNtgYvLDWlJP3Z/jsrnVpY/TGDudRxMdV7AaS0/vWdFGYf bSuUFWubEEwSMr3o9UL1we/l7cLlTOSRe/eei81ooT5ZaJEGZsKmBF+4rcLxxakEWH+B RUVGnTGjdlhqrexiBKVpbdDJFI984j6ZuGOoBzof3EW88g8Y9k1XlpzngUY+4KxXj3aX AR7kJgoeizcO7Vd6sHlv9pFwD828kkh1VX1zvmfx+2MxgZWZyX9Z3P9tvel8o/upK4Nk /7gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707210545; x=1707815345; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n3bYfjQv3EOlzlAH6SnTprc6MRzkybq6MP8ULvKh3QU=; b=Z17lnkpOeGBPba/y+0FL2qH87XzqzPc4masMxa82vyR1aPAnO6Zim/v1w2Sfb5n1G1 SzPuRRwmH9q0zn0WRCYeNNpzC6T1t/3bbTMNQo6wDzkIPIiOwVxKPH1+uU69kBWJnRT0 fPtgLSkDX+ce4u1YKIlaVw8nqbt5UuenSrBC3qrEkJ8CBsW7gSwguNpJFf2UP0cylD/O vEn0Vff91VGuYLI+cv0uYyDqb8BhSwehT+OlJz/8jl7kdM1vRafeZr0cSk3UM3f73eJ1 SLvZty+jbyenEu5YX4NytGd9rDnG/tRYHTUupVOI5/nfFss6L9l/x7eH7eaL/tNr0tfo 3L0Q== X-Gm-Message-State: AOJu0YzjdWxHK/7hb8IBYVRepq9iLWgsGFWi/6y+/MIUI7EsIlowsLF0 +T2UEQvpzn7TmlrmJshcEzk9/T2h71/hQHRJDabEpz/8eO/RnnwNWq06ODyY16AlkiXSiNFY9fq jbvlvSrj7tu4Nrx9VHxV4JjiifQ== X-Google-Smtp-Source: AGHT+IGYvvPPJdsNReDALgL4bf4CddTEvWD64Y89A60pb0Wv4pCnc6aQ+IjbSJcarg4fKsvCTx541JtYLFO+ZrdbChk= X-Received: by 2002:a2e:9d05:0:b0:2d0:9cbf:f389 with SMTP id t5-20020a2e9d05000000b002d09cbff389mr1491170lji.26.1707210544507; Tue, 06 Feb 2024 01:09:04 -0800 (PST) MIME-Version: 1.0 References: <20240131094442.28834-1-fangzheng.zhang@unisoc.com> <2024020441-version-chihuahua-1067@gregkh> <2f43774a-16cf-412e-b4b7-840889bb796b@suse.cz> In-Reply-To: <2f43774a-16cf-412e-b4b7-840889bb796b@suse.cz> From: zhang fangzheng Date: Tue, 6 Feb 2024 17:08:53 +0800 Message-ID: Subject: Re: [PATCH] mm/slab: Add slabreclaim flag to slabinfo To: Vlastimil Babka Cc: Greg KH , Fangzheng Zhang , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yuming Han , Chunyan Zhang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: hxb5kwtrd75t66i8c58t8p65do36hkqr X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 886AF40007 X-HE-Tag: 1707210546-636849 X-HE-Meta: U2FsdGVkX19cKTXjalaPpFcnG0XlwYrYAJwS2InRBP6hUhf5QJj+7MBcoPcewtChWZ8xErm9PvO1RAqeBPZOYKSTFGSCq9XMPn3/Hs0TwkDlUegdFPuQnugpS+eG6K17muQdC+RtAvd4CqtMJtRBuATRxuWIQkg2qszHfnuHYSBJnn13Y3ls60D9lB5L2NZJq1ihkKUTwz22lijI3NnGtms+2nshopCXfonIXeRTX8FVnFE4XmOr3XD7Y7s1P+li5A2o6HnAS7DtIVNyikZmpeNIAdV7tR9PFAfdEcItRzYDyqquE3ks0og26NjD0FO1AgiYtkmrBYxgUi4eqRd7t5/Q06rpIPLU9lk5gehd2q1TJNN4GkZPDppgno1hozHwAC+xSy0lfjAqDzEqq87XNrBfTIh6GddRnjZGYwpHhNX4cCHCCLBCPy/8+qPaP3QIMyp5hkNkWJMRHn0iA2Hbm65HzzwnVrbKPQ2g7U7i2O8F+5NKSLheR4qrZfrOgYGUZK77Cy176oWAllxzlO6Kw4myZuwjSswayLxnDaEVHe2wbnvnx4cK0ItDPJTq84B37S0I+EXzbEk8DRwoWlsnHa+eqMQV8Qq6pWH1he81kh+oaTt/IAlD0YcOHb8sCUcuV/d+UyXGdSIn5B+KLj14IwsVJJ0AMA/wT3wV8Q5rw63MKBmPIIUM3sb/wyXNBRiHcubhznE2IUC5yj9Ik7mU21oIjkMErjwDQqe0QkqwOn9dH/F6t+YTDNj77+mNeXqF2CuGs5HcKvQiuFHDfluuY/oh2Jgm91FEu7HWMhLky1mMxV9kaoa863xrWC7zkcL1N7AZ6xXf1FHMHXHXX+BpMlC001Kve+kNlQiCBTtOZkv1VtGVvyRcbgzswByfeSI+1pEUgUcEHbPdorTM1kzBt4L72StQ5KCJV7jR4RXItcyUreidOG0YJyr9cezyYNhDozOIIX7W2HVC7iLJI8J uKymjBbE 8ft4zzpmE9R1m1VqnKn3D9lfXBcgifEenarPsRWcq9B3v9bMSKjOwOqMoQagqGv6j4Kp3wCHq2CiMoaTFY3hRADTN+xvOrYgpnwgyoekQMVAnNux/f/bBH8nEQCI5BCFjVhY3JY9XdF+EIqJcHXvvS+VVJWEt1sLdvzYkMKJ3EsCKbSacdbypwxs/lYMx81jH0g/oxPepoOP4I27cQd0gKkxm2zlCJOGmcrCayezEV3mNmbr91KXo0bj1F5ST56zrLO6GHlV96GGNqXzMTuaBTRkADjWS0LX65Mpn8UbY2wHNhHlufpo/A85ok1kyN1x+P4bPvnGm4ejTYHTZru/79b6tCtHHaD0SvyPfXH3xW2xa/qHN6HhfCrRtC5wV/SVfYZSuiXIy1CTxGQuItI6C4oRy4La0IFifHMz/PUg9UUfKVVeztewVRGXab7PW6xvf6mSic73EBPbCD8j4kXJlUoGuIaL40sQwDAEQrW4xH5qI/mCUueZZp/zFiSyiC+O8CItSl2BDNDQhmn8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 5, 2024 at 4:50=E2=80=AFPM Vlastimil Babka wro= te: > > On 2/4/24 14:09, Greg KH wrote: > > On Wed, Jan 31, 2024 at 05:44:42PM +0800, Fangzheng Zhang wrote: > >> In order to enhance slab debugging, we add slabreclaim flag to > >> slabinfo. Slab type is also an important analysis point in slabinfo > >> for per slab, when various problems such as memory leaks or memory > >> statistics occur. > >> > >> Signed-off-by: Fangzheng Zhang > >> --- > >> mm/slab_common.c | 7 ++++--- > >> 1 file changed, 4 insertions(+), 3 deletions(-) > >> > >> diff --git a/mm/slab_common.c b/mm/slab_common.c > >> index 238293b1dbe1..aeeb2bfe6dda 100644 > >> --- a/mm/slab_common.c > >> +++ b/mm/slab_common.c > >> @@ -1038,7 +1038,7 @@ static void print_slabinfo_header(struct seq_fil= e *m) > >> seq_puts(m, "slabinfo - version: 2.1\n"); > >> seq_puts(m, "# name = "); > >> seq_puts(m, " : tunables "); > >> - seq_puts(m, " : slabdata = "); > >> + seq_puts(m, " : slabdata = "); > > > > Doesn't this change the slabinfo version number above? Where is this > > change documented so that userspace knows about it? > Ok, I will modify the slabinfo version number to 2.2 and I find that there is no corresponding slabinfo output example in the proc.rst document. Can we add an output example so that user space knows about it? > Yeah I was vary about this. Do the other longer-time-than-me slab > maintainers recall how we handled this in the past? > Also the information is already available, even if harder to gather, in t= he > file /sys/kernel/slab/$cache/reclaim_account > First of all, thank you very much for your comments. I would like to say, when performing slab memory information maintenance, people often hope to see more detailed information through a simple slabinfo command. As you mentioned the method, but it is very unintuitive to the status of the entire slab, so we add the slabreclaim column to slabinfo and directly output it using cmdline ' > cat proc/slabinfo'. And I think this approach will also be helpful for future work on memory statistics. > > thanks, > > > > greg k-h > Thanks.