From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B416C369DC for ; Wed, 25 Sep 2024 12:45:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C16C6B00A5; Wed, 25 Sep 2024 08:45:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7716B6B00A6; Wed, 25 Sep 2024 08:45:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 639186B00A7; Wed, 25 Sep 2024 08:45:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 45AA16B00A5 for ; Wed, 25 Sep 2024 08:45:19 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DC7C2C0C18 for ; Wed, 25 Sep 2024 12:45:18 +0000 (UTC) X-FDA: 82603231116.24.11D8E41 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf15.hostedemail.com (Postfix) with ESMTP id 0B386A0002 for ; Wed, 25 Sep 2024 12:45:16 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GELhjrnH; spf=pass (imf15.hostedemail.com: domain of fangzheng.zhang1003@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=fangzheng.zhang1003@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727268197; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p2tgPDBQtwpuL9sTe+oKDRUiGqf+yu/MenDRJEbtBXI=; b=a1YyhuAzq66xLpBRrc1BUh+v/bXAmUf4xRHmvhmu2S0UQ1GcOInHjgXnGi1U/1pvbiDDWr wCTfoGyyEseQqJf14NDAbSHqS9+ha72kCeH0SitP2hIf9NHIGLkkG/2akuS3EGVQPpc/IS oZDGoKexGsNloI3lM7MNmhR/an3ZBX8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727268197; a=rsa-sha256; cv=none; b=IBXf2GT0Nwkofa/MUIshMIm+h95SDflW+LQDEvUAqzz+GFp0MYgwVRKoCilpfFMQcmtooU erhCGfQpMezoi5CiDOnMDwdZx0Q5kUWdBRY22eBdmjwtpwNJHERyTqkFY/KcxOVIaAkfUF U+LMeIIhYhVn7muQGVfpZItt7JNory4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GELhjrnH; spf=pass (imf15.hostedemail.com: domain of fangzheng.zhang1003@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=fangzheng.zhang1003@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-5365a9574b6so9773760e87.1 for ; Wed, 25 Sep 2024 05:45:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727268315; x=1727873115; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=p2tgPDBQtwpuL9sTe+oKDRUiGqf+yu/MenDRJEbtBXI=; b=GELhjrnHgYTVrjMm9ArwiwS2IqUasMSKFevTfaNMh1PPujS+XrUIa58Xcno+nc2XaK va7UAZDjnx6TLyxFPCFC64blm8SrF3XA7q6AzwHxsMxOmHmoK46+qOH5o1i0BeYJfyf/ Wd7eFxBzN5PGWFbaklWIuUVo3JoBd7V5VkU1Gf5cRuq1TUpbYqqQiANIVpthZc4+G8Ci Jiib3BmjALyiO8JhJ8U8pV05W1vRdiwsPKD5en6/JgyQJfd/fYOTMC7nuRNDVCLC6+8G YXkTXHUiHHuBpdBOYZMRBKiN9L9jfOnrlGosWEUBZuNSdqUv7VXfCFR6WjCT5AeerRav D9Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727268315; x=1727873115; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p2tgPDBQtwpuL9sTe+oKDRUiGqf+yu/MenDRJEbtBXI=; b=KsA9C3WnMm916vx7Ok12LheIc+B/e5n1TvsNr5xf/EGEb6ku1ariaTZUke31O8+KLz 8nqJEnOvKydLaa6091LOXW8NpvBUnxffjUqLOo/8h1GsFM6oFp7aYMWQvKArTs1dd5Ij syuWsXqMw4yoy/tCs1viTngl/HyIaN83nCdbj3cLcnPJ6suLw/BdyTpF2PbB/XZPorYK rNuaLHaBGuG0rQgr6DEjp1ky4P5wKPEnN8UgVsFCSPj0PsDsO7oJQLIPyDlZZOm7DQPw PKiZCa6qcVWA1NQPcSPHTSwcYnEdJn/x+TqFmLfh83dNTuQ/7FxLEz6WXgt4fDiFqI2U odnQ== X-Forwarded-Encrypted: i=1; AJvYcCUohgJxEQwMv/6mH30ntLUlV6cnctyXGO2R5lZY90QaDaUiinuqpB6QYjn4JQdb7L/Q1n2W9j+mwg==@kvack.org X-Gm-Message-State: AOJu0Yz1jCu1jeslcbd53l3p4AXs6Zl4Jzxk/iG8bcfpEdHJJCPKE4oL yUp5D8zsK5srDF+CeqMKFjd6W4JKnFZQJSFoyaWjuXY6kDn4sM83f5sF0fbW3c82pSTtFEJ3Rnm kXymlV52WvgX7MOYc1uT5chEBOw== X-Google-Smtp-Source: AGHT+IH7a6nP9rsmNCN8hfTCn3WWXnvbe8FqfI9D9j9sNWREXdO42zbQo7WAZXlSCchyttADHxAF2OG7kLidI6chDBg= X-Received: by 2002:a05:6512:3d0d:b0:536:796b:4d6c with SMTP id 2adb3069b0e04-53877530b57mr2157507e87.27.1727268314891; Wed, 25 Sep 2024 05:45:14 -0700 (PDT) MIME-Version: 1.0 References: <20240925032256.1782-1-fangzheng.zhang@unisoc.com> <20240925032256.1782-2-fangzheng.zhang@unisoc.com> <2024092556-tribunal-next-84ce@gregkh> In-Reply-To: <2024092556-tribunal-next-84ce@gregkh> From: zhang fangzheng Date: Wed, 25 Sep 2024 20:45:03 +0800 Message-ID: Subject: Re: [PATCH 1/2] mm/slub: Add panic function when slub leaks To: Greg KH Cc: Fangzheng Zhang , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tkjos@google.com, Yuming Han Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0B386A0002 X-Stat-Signature: uscp3at7q3intu1ri8uz13e6baapq9k1 X-HE-Tag: 1727268316-151083 X-HE-Meta: U2FsdGVkX1/R7bGNiJchphEj/Fr5GlDvb4Rys3rOjyRj0MXb8cR0QLSezUnH3gZMZOU8EusSIrOxXSfiDU/SxyvznHDeTw2SMmhWZPZNWDsoUqtMEtG09fv9c0Ogan6wQQkRgTilaw83wHcR7zq5aDXgPkxDVxu1G+SYmjFl4SvG6GDzyB4M9YJNTIzCCwTsjsBMvBsuGGlxLCif+qUso9/0KoIYIybee0NoyImtSwAqTSXIgZKnRbX/UEUE4SWzpBtw/9EiVPnc56fbvCRuRYXfUiVzVpojrgGI4nXVS0xsaus85CMNiVD3YnXGTVR9RNd+O3ZAGKj0oozbO82QU8EB2WngEfbezhBvWgx0kb6b9JrNvB1/08kmn3pTdzrBcXET85JvJUeBuJpy++UEAuUA2xfwPsanIaVjppjAjBePbw4ydb1tDAS8TV4LGBEWoVMjvYFhXF2D3qYcD8jCXfoiNlWhMORzrNwUkdAXNEeTCg+peY3gVTsBSviP+W8up/RNFZFf98PoEkdB8nQhCQxl6ZB9SvpDTS0mIPzyA2/Qaxae4/OUJpitNN182W95FbTZ6Ij8Sc3sbuL24Is/3N41HCiTwdeIKN4G9IT5oUbwWOjtZyOINVTQDmhqYnp+imxrDWDCTPOB2pGPbZbdjCp5b4S9xK0utAFfpc0paAIYn1yI9+BZ1UyqSC2INZL2/AlKEJ5yISpdcgid5L+M3H5IzR0yBGuAvTl25LW3hcarBbrowifwI9f1SFCXY8Nn1sBbnsrL/fdUh53IpYpC+/5spES2s6zVFZjweucLUUIPpjNF5RChEVTQiFPMuywLGhbsMR5e1sP10U/gu8P6bULAmQJZulhKqLwc2KtdHpP4xZXrIPTDYsP56KmSpuqSq6hvvpPcKlul7xDO/CNHciynoj8rbl+v+6JiXhdpu5bLo//g95VIZlMM3vm6wmSLbBL7WJ9cvFe9QbUNhSG YPz4j6Fv n4h/XXpRiyKQcHjcFR9woOWXCIGld4XGpKVd0+wzGxr6OEXAkLfGtIVhTm+E6oi+xmhg9cgDWdw7U2/aVJTXHlIN+8yPnNODzzx599T48zRW7lfwkcuB86GtYnh0hr2aBU/InrFOm2xxsxaiqvJeJSrZulhhgnOmq/5Bo4jzMlmErwXiZLgLqLm/A+3JsVtMEc1Wx1bB2y81GVwypfx2YtxvzIAkaEoImFIzNjPigCL1wnmYX4hUO/3yOtY2BeT/sd6K+afQZYsofSrQo7H46NtK7JmHbGWF+grTJFfqX6vd+Mj+Q8QpGZpwdaVzXSvyNPiwpvv5tG6uyb8rFhMAzRIkbZ5eBTrWruNNPuRfikdXN1puNzpjdt7GDPvo3ku6X5ds8BQTVaEtP+th+DKUD7cvfUQcf08Q/tU5MH9WgUEFuR8bnYamK1k2QT+37HqsY4I3batmOtdKxz6DcJi2L94PRmWcFj8smaJKaAIxZWct1S21JGZOHrQQdQ83WtzLLS92z20Qv/1AkNqkMIdQxYJt+1j0lPFyM19/C X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 25, 2024 at 4:10=E2=80=AFPM Greg KH wrote: > > On Wed, Sep 25, 2024 at 11:22:55AM +0800, Fangzheng Zhang wrote: > > Perform real-time memory usage monitoring on the slub page > > allocation paths, ie, kmalloc_large_alloced and alloc_slab_page. > > When the usage exceeds the set threshole value, the panic function > > will be triggered. > > > > Signed-off-by: Fangzheng Zhang > > --- > > mm/Kconfig | 11 ++++++++ > > mm/slub.c | 76 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 87 insertions(+) > > > > diff --git a/mm/Kconfig b/mm/Kconfig > > index 09aebca1cae3..60cf72d4f0da 100644 > > --- a/mm/Kconfig > > +++ b/mm/Kconfig > > @@ -255,6 +255,17 @@ config SLUB_TINY > > > > If unsure, say N. > > > > +config SLUB_LEAK_PANIC > > + bool "Trigger panic when slub leaks" > > + default y > > "default y" is only there if the feature is required to boot the machine > properly. That's not the case here, sorry. > > thanks, > > greg k-h Hi Greg, The reason why the "default y" is set here is that config is only valid for the functional code that works. To truly implement slub_leak_panic, the parameters must be set effectively. And, the current parameters are all in the default n. Thanks.