From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CCB3C433E1 for ; Mon, 1 Jun 2020 14:52:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CB3D02065C for ; Mon, 1 Jun 2020 14:52:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ualx6ZL3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB3D02065C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7108480007; Mon, 1 Jun 2020 10:52:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C10B8E0006; Mon, 1 Jun 2020 10:52:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B0B480007; Mon, 1 Jun 2020 10:52:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0222.hostedemail.com [216.40.44.222]) by kanga.kvack.org (Postfix) with ESMTP id 432AB8E0006 for ; Mon, 1 Jun 2020 10:52:08 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id EBACA289FB for ; Mon, 1 Jun 2020 14:52:07 +0000 (UTC) X-FDA: 76880933094.01.whip10_126b80fad553b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id EF9AA1802BDE5 for ; Mon, 1 Jun 2020 14:52:06 +0000 (UTC) X-HE-Tag: whip10_126b80fad553b X-Filterd-Recvd-Size: 7577 Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Mon, 1 Jun 2020 14:52:06 +0000 (UTC) Received: by mail-il1-f194.google.com with SMTP id h3so9595613ilh.13 for ; Mon, 01 Jun 2020 07:52:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=Nf/blbPcrjBbFJHwPsvnL7cuUdcfeFMZRwjvi+vCyzg=; b=ualx6ZL38OrIJJfwQl60gf2szUZBoDOZTp79Cl/jJORME+w6e5oR8eOOw8z8tilIm4 MMb72CWlV3RDBQXETAr6LMDDB/FaKCaTsFBQdPlOozVEWdWQElTTkgbNXQqT8qBzscEv kg79J0DBl8PUPtNNHQcBvN2Kytc9tuGLO2DWhPMcDnVCZrBnyp42eUZUIv47/OQKG14M 7rOosR0Ms7aQl91glMZxtHOGxe82lUk/PzteE2Xy4R8cjJJFlSh/2CU+qP+S3uhkS6gE muMuzc+SPGa8OVa5FR1yFnyDRush8Q9lgzR/bFdhnz86Nqi7pGmkg7+QojphOAqzQZRF Fwng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=Nf/blbPcrjBbFJHwPsvnL7cuUdcfeFMZRwjvi+vCyzg=; b=Kgpis1D7rPAXmSWaB29NqRWyQvEMvDBoJmyHEyZYCVuIMFHQlr9cXpnSKrkrlYZaYe oy+d9kX+F8walr5ggerJITQOA27ayi0KqSsgqwqwISdByPC1LJPrpWAGAGhXR1ZoPZ5G EH9DyOopd4aoePyCHSb23oFgkL4z57Bc0X7YVMYtbjuYaXgVthDgLrwi3WaVBdPxBxrE 9L094URxXU697LyyEdkEgLEevtqR23uTtb/MxduL1pYelQVVWL5//WUxsTxiVCHp9TAs up9+hcC3vXQ3whcTZyB2dJX3s+fRQFE6v90J+g8OK5q75Aq8zk1ceg2kHTKIO6WIgf91 Avew== X-Gm-Message-State: AOAM530sP2kJW02XiKEQKmYujdTYnXxR0UrbenloL/7l2BBqHeYFZXkn JWHrKkY/MATW2BRnrC215zaYS+UGTqvPzG51YjGkvMSmlq0= X-Google-Smtp-Source: ABdhPJzuPgyweQpwToozBwO+cc4t75unYUQT+9VfnEQEns6ZiF7ewa1T1PYSUr42PH/d0Ek4caDOm730eDAky6ToB/c= X-Received: by 2002:a92:9603:: with SMTP id g3mr12388953ilh.204.1591023125764; Mon, 01 Jun 2020 07:52:05 -0700 (PDT) MIME-Version: 1.0 References: <20200526195123.29053-1-axboe@kernel.dk> <230d3380-0269-d113-2c32-6e4fb94b79b8@kernel.dk> <455dd2c1-7346-2d43-4266-1367c368cee1@kernel.dk> <412ec6a7-90c9-5856-bafe-12c8fe2135e7@kernel.dk> In-Reply-To: <412ec6a7-90c9-5856-bafe-12c8fe2135e7@kernel.dk> Reply-To: sedat.dilek@gmail.com From: Sedat Dilek Date: Mon, 1 Jun 2020 16:51:55 +0200 Message-ID: Subject: Re: [PATCHSET v5 0/12] Add support for async buffered reads To: Jens Axboe Cc: io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: EF9AA1802BDE5 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 1, 2020 at 4:46 PM Jens Axboe wrote: > > On 6/1/20 8:43 AM, Sedat Dilek wrote: > > On Mon, Jun 1, 2020 at 4:35 PM Jens Axboe wrote: > >> > >> On 6/1/20 8:14 AM, Jens Axboe wrote: > >>> On 6/1/20 8:13 AM, Sedat Dilek wrote: > >>>> On Mon, Jun 1, 2020 at 4:04 PM Jens Axboe wrote: > >>>>> > >>>>> On 6/1/20 7:35 AM, Sedat Dilek wrote: > >>>>>> Hi Jens, > >>>>>> > >>>>>> with Linux v5.7 final I switched to linux-block.git/for-next and reverted... > >>>>>> > >>>>>> "block: read-ahead submission should imply no-wait as well" > >>>>>> > >>>>>> ...and see no boot-slowdowns. > >>>>> > >>>>> Can you try with these patches applied instead? Or pull my async-readahead > >>>>> branch from the same location. > >>>>> > >>>> > >>>> Yes, I can do that. > >>>> I pulled from linux-block.git#async-readahead and will report later. > >>>> > >>>> Any specific testing desired by you? > >>> > >>> Just do your boot timing test and see if it works, thanks. > >> > >> Actually, can you just re-test with the current async-buffered.6 branch? > >> I think the major surgery should wait for 5.9, we can do this a bit > >> easier without having to touch everything around us. > >> > > > > With linux-block.git#async-readahead: > > > > mycompiler -Wp,-MD,kernel/.sys.o.d -nostdinc -isystem > > /home/dileks/src/llvm-toolchain/install/lib/clang/10.0.1rc1/include > > -I./arch/x86/include -I./arch/x86/include/generated -I./include > > -I./arch/x86/include/uapi -I./arch/x86/include/generated/uapi > > -I./include/uapi -I./include/generated/uapi -include > > ./include/linux/kconfig.h -include ./include/linux/compiler_types.h > > -D__KERNEL__ -Qunused-arguments -Wall -Wundef > > -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing > > -fno-common -fshort-wchar -fno-PIE > > -Werror=implicit-function-declaration -Werror=implicit-int > > -Wno-format-security -std=gnu89 -no-integrated-as > > -Werror=unknown-warning-option -mno-sse -mno-mmx -mno-sse2 -mno-3dnow > > -mno-avx -m64 -mno-80387 -mstack-alignment=8 -mtune=generic > > -mno-red-zone -mcmodel=kernel -Wno-sign-compare > > -fno-asynchronous-unwind-tables -mretpoline-external-thunk > > -fno-delete-null-pointer-checks -Wno-address-of-packed-member -O2 > > -Wframe-larger-than=2048 -fstack-protector-strong > > -Wno-format-invalid-specifier -Wno-gnu -mno-global-merge > > -Wno-unused-const-variable -g -gz=zlib -pg -mfentry -DCC_USING_FENTRY > > -Wdeclaration-after-statement -Wvla -Wno-pointer-sign > > -Wno-array-bounds -fno-strict-overflow -fno-merge-all-constants > > -fno-stack-check -Werror=date-time -Werror=incompatible-pointer-types > > -fmacro-prefix-map=./= -fcf-protection=none -Wno-initializer-overrides > > -Wno-format -Wno-sign-compare -Wno-format-zero-length > > -Wno-tautological-constant-out-of-range-compare > > -DKBUILD_MODFILE='"kernel/sys"' -DKBUILD_BASENAME='"sys"' > > -DKBUILD_MODNAME='"sys"' -c -o kernel/sys.o kernel/sys.c > > fs/9p/vfs_addr.c:112:4: error: use of undeclared identifier 'filp' > > filp->private_data); > > ^ > > 1 error generated. > > make[5]: *** [scripts/Makefile.build:267: fs/9p/vfs_addr.o] Error 1 > > make[4]: *** [scripts/Makefile.build:488: fs/9p] Error 2 > > make[3]: *** [Makefile:1735: fs] Error 2 > > make[3]: *** Waiting for unfinished jobs.... > > > > I guess block.git#async-buffered.6 needs the same revert of "block: > > read-ahead submission should imply no-wait as well". > > Sorry, forgot to push out the updated version. But as per previous > email, I think that major work should wait. Just try the updated > async-buffered.6 branch instead. > Hehe, I was looking at git.k.o URLs. I just pulled from . - Sedat -