From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx131.postini.com [74.125.245.131]) by kanga.kvack.org (Postfix) with SMTP id 8BDA66B0032 for ; Tue, 3 Sep 2013 18:46:52 -0400 (EDT) Received: by mail-wg0-f44.google.com with SMTP id b13so1192834wgh.23 for ; Tue, 03 Sep 2013 15:46:50 -0700 (PDT) MIME-Version: 1.0 Reply-To: sedat.dilek@gmail.com In-Reply-To: References: <52205597.3090609@synopsys.com> <5224BCF6.2080401@colorfullife.com> <5225A466.2080303@colorfullife.com> <5225AA8D.6080403@colorfullife.com> <5225B716.3090708@colorfullife.com> Date: Wed, 4 Sep 2013 00:46:50 +0200 Message-ID: Subject: Re: ipc msg now works (was Re: ipc-msg broken again on 3.11-rc7?) From: Sedat Dilek Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Vineet Gupta Cc: Manfred Spraul , Linus Torvalds , Davidlohr Bueso , Davidlohr Bueso , linux-next , LKML , Stephen Rothwell , Andrew Morton , linux-mm , Andi Kleen , Rik van Riel , Jonathan Gonzalez On Tue, Sep 3, 2013 at 12:32 PM, Vineet Gupta wrote: > On 09/03/2013 03:47 PM, Manfred Spraul wrote: >> Hi Vineet, >> >> On 09/03/2013 11:51 AM, Vineet Gupta wrote: >>> On 09/03/2013 02:53 PM, Manfred Spraul wrote: >>>> The access to msq->q_cbytes is not protected. >>>> >>>> Vineet, could you try to move the test for free space after ipc_lock? >>>> I.e. the lock must not get dropped between testing for free space and >>>> enqueueing the messages. >>> Hmm, the code movement is not trivial. I broke even the simplest of cases (patch >>> attached). This includes the additional change which Linus/Davidlohr had asked for. >> The attached patch should work. Could you try it? >> > > Yes this did the trick, now the default config of 100k iterations + 16 processes > runs to completion. > Manfred's patch "ipc/msg.c: Fix lost wakeup in msgsnd()." is now upstream. - Sedat - [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=bebcb928c820d0ee83aca4b192adc195e43e66a2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org