From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8547C021A4 for ; Mon, 24 Feb 2025 12:35:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4289A6B0083; Mon, 24 Feb 2025 07:35:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D8836B0085; Mon, 24 Feb 2025 07:35:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A05C6B0088; Mon, 24 Feb 2025 07:35:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0CC486B0085 for ; Mon, 24 Feb 2025 07:35:34 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BFA3481392 for ; Mon, 24 Feb 2025 12:35:33 +0000 (UTC) X-FDA: 83154784146.27.8C578C3 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf15.hostedemail.com (Postfix) with ESMTP id EDE5BA0006 for ; Mon, 24 Feb 2025 12:35:31 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ykjYggoN; spf=pass (imf15.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740400532; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KwGppkIqqXz0kYgGn0M1BZMOQImlHLrnIXG0Z+KbG2M=; b=qGJSgpZzaESI+oIFAuX+aIAGKLJRoQgZtzHuQSkAP92dejP/WxwxXrW10aR11TFc8hxB9P P7oW8g5PoG+gqwVIxJyQQMpaOFz6uWxMGkwNC6nhSfflyEHf7CTiVIMKNmJfYVDfx9Z9pC bWkVi35IUv+JHoR/ffdC48xmHguCKPw= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ykjYggoN; spf=pass (imf15.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740400532; a=rsa-sha256; cv=none; b=m/CycI5pv+uoh0tS+k3EfxmF1G1rM/f42MVuiFB09Dyamqt9unX/pKlqJOh4SFcSEERDqs cd8jT2Vf7zk74GwQqyYFpmmFk0nHVrJfecSgwfENMXnjENbFl1gaWFwGwvg6w3ixnmzKtN wKRhSuZwRi+4dAdb/3mRKpbsjYc4l0c= Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-471fbfe8b89so584381cf.0 for ; Mon, 24 Feb 2025 04:35:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740400531; x=1741005331; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KwGppkIqqXz0kYgGn0M1BZMOQImlHLrnIXG0Z+KbG2M=; b=ykjYggoNTRFfKMeAMgEIHD2Nfj/uAL0AVWeAd2rhuEBpEj5t9mNCnX0ub6U9PL9Z0g 1jd9Y4/ozUXfjC8a2ZM5pC04U1pj56uQUSnUlITXz/ebzJY1gipcQCJWZK8W8fV/zlH2 4koHOUFn7mKzpvdmyEqGKSW87hSDpdttqDxfGnIkl6I39mnExnropbh2kXWtI1iW9lAE w0oifxZuqnGEKeX0B2KB+vcs3cGaSCsz3FldZpZkbtu3e9/NCWK/+nPrNxW8INYyXHP9 Q5+6irdYNkTRiYGGRrELTSdrGA+f0zqcldj67EVXecHBpQqqtXUDu7MDOdKfI6EIj5Lo nMmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740400531; x=1741005331; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KwGppkIqqXz0kYgGn0M1BZMOQImlHLrnIXG0Z+KbG2M=; b=xR7/3Tx8HtZ8cAbivz93prRdcjSJw9p/kWhZI/NVvA8C+jB4nf66OapBrNsr9WJqGO CLtaipa81wkrErvahUurPeqpyBbX9FNwUh7GCMt7wCxVDN+obFXlUmdiCfA0uieadrKb sHSrAaJJ+P171BPjelj0il4RiBr9uvYJwwaowHUEErCShgw3Oat5h8oYPsRVkGkTaL5V d683Sw515Gs6gCGGVhBnbEg22bhZ4NWQE/Kuz5yYFuFxZwBNXGcJl9KjKqWfUixPg7Hc WtpxngBF9V0FnG3LcpSCuN+xLxbcBZiGIj/YI9Kmz+NGDhToVyz+hwn5JBUJQ9jboOHB 416Q== X-Forwarded-Encrypted: i=1; AJvYcCU4cyWLoQy4XFLc1lLnTcjxT0+z5xM1noxEiJ539OfHbyt1QcCEr3VFHuByaqvXkDbRV8nSLnt7zQ==@kvack.org X-Gm-Message-State: AOJu0Yzuw83WmUoZpwE2yYIdnBmPKFW+YuHgpmzIq8bTwGI3EOxSZqrX VbJrEMYs4Q9O2XBTs+Vlm+NbHT48Kj0a45n2N9YHDucc6OE5cec0xLqHUS2mmpduz4SMZTQUs8y mJTFXcXJuBreTJLUOrK5oZXUaxECp/jcnlwAs X-Gm-Gg: ASbGncttf5dPPo+Yww08dNKPFsTDVQf5jl+REa9Nzz3A7XrCq7pWbLScpZHqLQCiYHp rC9s9CEaSHkQiMDsX7bwZm/PMRaCPG1Ov8k4HO6YRpGCSGpVxHRzGJTEb5Km0i56Jn5LbbziE22 hjCrGk5Ay+uyY7qndZQul55weF6g/Nv5Ov6m8QYQ== X-Google-Smtp-Source: AGHT+IEBq+/2+cGisSl+LUqC0WCB2F575B4VRnIur1yE5rC/jkLryxhsyIY0MWbIIqCpavGQ2dpiQ63RFqJZuzk8vjs= X-Received: by 2002:a05:622a:5cf:b0:472:7e8:a788 with SMTP id d75a77b69052e-472334cf3f3mr6561771cf.12.1740400530926; Mon, 24 Feb 2025 04:35:30 -0800 (PST) MIME-Version: 1.0 References: <20250214-clarify-steal-v1-1-79dc5adf1b79@google.com> <20250214212647.GB233399@cmpxchg.org> <764394d9-592c-4d68-8910-67362dd8810a@suse.cz> In-Reply-To: <764394d9-592c-4d68-8910-67362dd8810a@suse.cz> From: Brendan Jackman Date: Mon, 24 Feb 2025 13:35:17 +0100 X-Gm-Features: AWEUYZky2EJOd2B_fvbdC3A3HytUwtYJGPvQnMfxZFosmU0qGiqwHe1gWibELZg Message-ID: Subject: Re: [PATCH] mm/page_alloc: Clarify some migratetype fallback code To: Vlastimil Babka Cc: Johannes Weiner , Andrew Morton , Mel Gorman , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yosry Ahmed Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: EDE5BA0006 X-Stat-Signature: wss8fqj8r6ewhueai1exsuex5tuwpsri X-HE-Tag: 1740400531-88876 X-HE-Meta: U2FsdGVkX18y7piX9JYWBbLNB1U1R6uFP5diGbCnDt09NZCu384dfgh0GcLWB9IYZjQCA7+rAtPFR9U+lPhKas6GC6BYYIyIMczhQOaSkODywoUW7sJlam9eJjWmGPGdA3CZVs37nDlZZt946qVr/4T28ZV5HCvKtGhKpIj2qoiT8k+d00ULXasmPB2yuG5a4LnFbeegp9mvBQUTE6lZiQ0xohVd+NE+DlUgFAg/mDmbDBcP/2iSvzgkcDkeDQWQFx3IdET+dK6yMJKojp6mqzkuzSRZTi424GLlcOcJfqIXJk2khQkpOfnjf+/udpu8mPhbVa+4rtypFce6Q1C8AZlrm7mooK8/MxOTK71+HA9BydehWSXUGSlgHwKsR01dSHEHIDt/UUaR/XdqXXCX+F622UsK4WJtUAyQsuE4FIANjJ3xNZhynKJyW21uhWi/i/2to8nbN2yNYgUVca6EVsiWACRuTZfIdSvWkZSyPek+CqKVT9IY7AGh60Vn7NjOsfLlhREB1E9nDFqAmjjrLy0sclamXWuyY1fCoUXpBVbpDq88TnZVl6AST20ajmnCwH9sevpabzsNh4yWv79Fbm/Hi0kUGRG4Jsv2UVrX7aRIJ5/P3ExUqKSzmQC8WHKBs0OlDgt/xqrOTMNxUzJpSBbuoclw3sGYnQKSS27w52diHram2UWmaGurMW3Qn0Z1Pw+RhkA3asGkB92Df93rnp1Co5EYqoahHr3L90lV9p5oEhsJqWpYewyYCR/LwFPsREJEiOaSWq3E11OUz5EWzsHQ12mZal11CZ+DJggRX6AVdvVJg1ZEC6Y3K/XYRZQXjCtnMXoWaZWlg9S3TnDpAl9McO4nqolJQW+wELFn/wXjarMeFgJxJH9+Fl4MMFH9r5KXvf1IYiMZ3slZvemRc7Y2OzqCshz73UTBcDuuCWe828gSYi9UZd4h9w9Pq/oA6OjjxhZu7O++M4kmcJq VP8zA/sY ZmTTo7v5NpcCxUhn0BOVskssZgtfzY0WXDEbwBj3VUYQvVZB2yvJwxmtzpP7PMusQZ4sATlkfIoTOtO6bBNWq0YjOxmmsdmlqpc9/BIVDN9AtbdO/oaLFQWe9fI5UHxf5MGxITQ6mA5ZbeleFqxRSayw+o8bNkbiUSGXo9gyZE5CzeNUBmO4XjzXlZka1+VI4W/f3uEP/FQ/lJ4Z2n01dA18+dDXNRrTvu0mJC0wAsFCIY9c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 18 Feb 2025 at 11:20, Vlastimil Babka wrote: > Would it make sense to have only "bool *whole_block" parameter of > find_suitable_fallback? The value the caller initializes it, it means the > current need_whole_block, the value it has upon return it instructs the > caller what to do. It would mean __compact_finished() would no longer pass > an unused parameter. I thought I liked this idea but once I tried it out I changed my mind - the unused parameter is a bit of noise, but doing the above makes the function interface and implementation harder to understand. I also thought of allowing the caller to specify NULL which would have the current meaning of only_steal=true, but again I don't think it's worth it. So I'll skip this for v2 but we can always extend it later. I think it's likely that I'll end up proposing some other change to this interface for ASI anyway, let's see.