From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B69E5C021B2 for ; Tue, 25 Feb 2025 15:19:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C1436B008A; Tue, 25 Feb 2025 10:19:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 471036B008C; Tue, 25 Feb 2025 10:19:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 339906B0092; Tue, 25 Feb 2025 10:19:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 144366B008A for ; Tue, 25 Feb 2025 10:19:33 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 592A1161755 for ; Tue, 25 Feb 2025 15:19:30 +0000 (UTC) X-FDA: 83158826100.18.0D45265 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf26.hostedemail.com (Postfix) with ESMTP id 6BD25140014 for ; Tue, 25 Feb 2025 15:19:28 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gHoCtWu9; spf=pass (imf26.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740496768; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nZjUnnI4Tn83SqMGtKaeEULz7AjZuUVve25TBnfZYrU=; b=gdQpHBw3PyRNUD20GCFX8Qo1b7hNkbw5n9oGaSAKyQGHDoUk4SyOJwwwiwJnEE8QCjh4As e9Bojbe04HIrYMNLjjBNKcw/tjvgJ/NjoEan60cb/D7KspEGjgO1Bo8TPmsng+W1H2L474 wkAvNKPZ8/ZQBLoSsiybWNLmZ06ngb8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gHoCtWu9; spf=pass (imf26.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740496768; a=rsa-sha256; cv=none; b=Q3LaK2Fi53RnX4UGEskvb+gsc4Jwg0VYp2tHv4h9VcTOiS/GUeSQkg0Vb0x8Z29155yoTb 4U3BB+kc5QhqGjGMnSO73QRtwQ61dFpCQ1pvg4+F23LjZNdbEblEsetdFpHMslHI/ANUv5 mS1x0Ie5SkHrVoR1DUdGhhNUrrikepo= Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-472098e6e75so320661cf.1 for ; Tue, 25 Feb 2025 07:19:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740496767; x=1741101567; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nZjUnnI4Tn83SqMGtKaeEULz7AjZuUVve25TBnfZYrU=; b=gHoCtWu9382u0Ywf/BN4lbgNsijvomeOP7XMeZXApQRSK3azchCPhMLi3oFJjvoi6Z KuXtl4/KOTTkW1YwNzQToIpOdRqGRV/3zHhjQmCeMVHlj+yIhmgPeofs0uKDLr1YOGBT BgjlfSsqx09/EQhDWah7KM4vzl/ZNbSvZX2AfkLDxhGOPpJfHRq+4eI2cGat6VJbpEli V3aPyzq697U3zH8yc6pl9Nfvk5j7hRnWwAKtobGqhNubcTnOJ34QXnqX/Uce55uOBpIc RfwS1dtgcwI9xEIFs7Etq+C8ias4JqBC022SbG0XJTXIlPOV2Fl6Qcrb0sJ4/a1sLM56 LITg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740496767; x=1741101567; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nZjUnnI4Tn83SqMGtKaeEULz7AjZuUVve25TBnfZYrU=; b=bvGjNwdr3nITSr2+I47PBNJwJvbb7W/SSlBXiRhRAGhRx3QPFMYb7cLykuvBu5jHM+ +G1b5zZIQ5XrbGxvcqS2HF8Q8LDF82lqafZoWwdYD0aLdZM0esGTdcJ1JaGZSRLRLTcj o5wNA1b5TwU5rdgReCkrSrNVEsIcJ6mn0kqEH5DIJwwpcDN+LkCmhBU4HjdJgzRKe8C1 hcpeGlnD79G8ZCjU5fwriW9fVrFwESvnQ3Sg+JtoFzU1Qh7nfSS6el90ZatBPwKTHIWd +/SnpL6dzE8MfQZa15wfcQAwGtF6hAjUxe1f6sN2mLBKK59WqwCDGLirnshU2iygUYc1 y+sQ== X-Forwarded-Encrypted: i=1; AJvYcCXh3KpyyZzE0h+W0+Utx0x4y8v9Nct3RK1Yxab5lkTE1xc2Qn9CI0HJa6kxEVVz0I/NXcxshkwiLw==@kvack.org X-Gm-Message-State: AOJu0YynNYhx7uScKyRMDu0Ey0MOkZ0/xSx+tDXoR12MiRwveXGvedHI 47rO0sRrrThli8YxeRjF6Df7EgUT0hTryaNpD8W3Gn/lfLNsj0//rvXMcM5kIun1IRTKDrkxZ0T JAp0913VKefUquyCKlOganGHXPmUgJO2SxJwZ X-Gm-Gg: ASbGncu/uTz7WtU1vguwhu152Hrq+U06rQOO0zvGwOTHisRW0bh1YFHTMAz4VwxwtJW SXi5W258X/ENxpdpbOv5YOuSkn6HR1qFOpH6RU3Kpd4FObkLAEdsCgw6mH+9/VQjKjPDxVr34Hr dVnyOhNXVypSYgV5VR939yxGO7uylkwGwSSX3ONQ== X-Google-Smtp-Source: AGHT+IHU5WwBLnzqr94ytG6aqHFkY7VP8cLo4bWI0/eKaXEMfxGxmRvBUE5fV5vQNriiNYz8gqAQZ/MyNQoTqpHaZaA= X-Received: by 2002:a05:622a:290:b0:471:b772:c717 with SMTP id d75a77b69052e-47376fdb950mr4251781cf.26.1740496767223; Tue, 25 Feb 2025 07:19:27 -0800 (PST) MIME-Version: 1.0 References: <20250225001023.1494422-1-hannes@cmpxchg.org> <20250225001023.1494422-3-hannes@cmpxchg.org> <20250225150940.GB1499716@cmpxchg.org> In-Reply-To: <20250225150940.GB1499716@cmpxchg.org> From: Brendan Jackman Date: Tue, 25 Feb 2025 16:19:16 +0100 X-Gm-Features: AQ5f1JrJIvBv4zz0sLW321G6YCL1S-YogwoR_uXc6Pl0X_RbSIMsajEMNQGwF7g Message-ID: Subject: Re: [PATCH 2/3] mm: page_alloc: remove remnants of unlocked migratetype updates To: Johannes Weiner Cc: Andrew Morton , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 6BD25140014 X-Stat-Signature: 41rwxog99adaggchaoij4rm4jsm1g9rj X-Rspamd-Server: rspam03 X-HE-Tag: 1740496768-118070 X-HE-Meta: U2FsdGVkX1/K7Nwc+WIEiJ+ItVaTJ1G9uAf5TaOoLRSF8Ojd9twF8NlcVzJv7ObE9uG8VsuiMzMhlgVtA69g9ckoY3LaGy+CSQbgB5HeXr6/yCc1vIxAmb/l3ZRo12gmuRDJkCvb6Np63uFwsEM34k/ehNlXIpfCks0RPu75J/97bdMHWCtqeRodcWYFUKb8cjnSvHCOVO4hpTIFooW7TBoDhgUEWFa4N92baUmA82+t5Pzf0n5FTTPvhcA8TJAAVJ3SEj83BMR3zliQhJpaxuj21JivBK+ur1xXYL6VwK0tbKGTfkNrbC7zS5OFtRS2C1g/iluKCBO32COq1j/KezHgrCRbpy1bz0/9bx/cVqWDt3iUcQEW6V4/WBLajoyfP3kYMl04DFi3PvhbTBLR7+MLHzfJbpCEkIYiHTY7bkhsYaqmAJcxuyEc78VbX92phemNZcgOhCLAXEiIKignFXu7tespA0mOhw0P3C0TGr7Uc3npT4JFtGfjWilPSbQATPKOVbFDyCQ+jI5qOSwU9Jc2QYhvyKw8IrPS0EvpfogExOvPXrblkAKyQvU1SQDKj3GxFY7/iuzj7CQRlgRIr5ryutWkoMSpzsu0VvOiUrHmQ2JpLn36zqxi0IcwRm7u2i7dNatBBHGwSyLnz7L8utmWhqcx4TP9GCYnpZAqc0tH72JRnjrERH64b3mX7RJOjtXiy1/7pi9QcE6in8ERQOEVYzZ+5KZTeZmyXSC7kQimvhsGT9oEe9Zgwu3VbR6aRn8ajnW2iBvcgKpFeDuvcr2ys8DStxSnWwjKagMvQ2Of73u+cUL0mk4XTX0mtzetkYMMvqZmg697o0YCb13A72Lq7P0j3T5EZ4KsMMeEDccaY3AAeoHaIwyWH95zfHsUXlAcdFNTwdNz3w1JJE84vkX/DGZKWQl+WhB8xotNbwxMEeWFqSdJ+bvZQsKeoBzv3kuDnab4cjSieUk++eP eltJUHh5 reZhdtNAzNLUvgE1O4pXtfpsMe+5pVlgSyV0g9x8dVS53dwiiwEIrkLahrzXcSGAr0z2Vs7Eg9X6zb9TGXtJUctIK04Hk5WwV7WltUtxn0aNWh6HI/cQNAN7meRjx6SafNHNTChcx29oDPT168mV6tzfqyP40c9P4odEB0gMfz1U3FxW0cYagzGxhZq8VVmO54hLOmejehEg9Dyj+eQcWjsY8nHjNUG4kOs7p0uOLWoltEs5xl18CuGCkA8n2GF8gtchXVFgjOQs/4+5U6HTQaAhSEYixOnhy/jdsrTLxtYthGzw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000068, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 25 Feb 2025 at 16:09, Johannes Weiner wrote: > > Now that the locking is a bit cleaner, would it make sense to add a > > [VM_]WARN_ON[_ONCE] for underflow? > > Yeah I think that would be a nice additional cleanup. Do you want to > send a patch? Otherwise, I can. Yep I'll kick off some tests to check it doesn't fire and send it once that's done.