From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A83AC19F2E for ; Thu, 27 Feb 2025 12:58:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD7E56B007B; Thu, 27 Feb 2025 07:58:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D87C6280002; Thu, 27 Feb 2025 07:58:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4F6A6B0085; Thu, 27 Feb 2025 07:58:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A89AD6B007B for ; Thu, 27 Feb 2025 07:58:41 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5889C1A13F6 for ; Thu, 27 Feb 2025 12:58:41 +0000 (UTC) X-FDA: 83165728842.03.2BC2C4A Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by imf20.hostedemail.com (Postfix) with ESMTP id 987C11C0022 for ; Thu, 27 Feb 2025 12:58:39 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="LYr/mqky"; spf=pass (imf20.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.173 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740661119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CcZCFB7SoHZkFrArtueJCGhId3S5+D+C9zJ11KxR52A=; b=UdfaH9RqFlM4THN9sNh2aFkCioOo3KvTox7vBF64u9+JlkgdAK9z54cTjLvn13YhAeZRgd KXN1Cft2f7XCANNRUGWgPFmYInjM1DkDAD8zLfkA0RCRHzxopElnD8O/Id19/FYt5gbeDH E/CFzdOXFQj+BjWbUfQRa2OM783CjOg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="LYr/mqky"; spf=pass (imf20.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.173 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740661119; a=rsa-sha256; cv=none; b=XgQm9IJosyyT3sj2GwfK0uz9t9xvKRZOx7+CsH2/RWc+S3Qr8MYNfEJP9jU2EbVlkFQqiM IWYyuZodmjrPVtkSlfyNJxVE/d/ZfqE89wsphL0h8YqWJnhSreNjpmYKhLt3JjRnpZ8hfy 6RAtOWbpbflrPr3fnPym5YAWKhsVEdI= Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-472098e6e75so200771cf.1 for ; Thu, 27 Feb 2025 04:58:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740661119; x=1741265919; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=CcZCFB7SoHZkFrArtueJCGhId3S5+D+C9zJ11KxR52A=; b=LYr/mqkyYck3lqjKnytzMzGYiM0iT48YsXnquSJlwzxGV/ODnr/iapxJ5/F/N/KYp4 IvxdHkaO6FjHOsANs5kk4vIw0cAVd5ICXf76E5smVDYTtfNi4tL99EgGZZ1oX3ZcjILc Hw4+NM7TlobkaLGfFSfMR4V297+mzESSF6hDdrBTr6Vvh7SrUc9P887TxlBEAZ8XPnIh RJohM/PhACgdWUPdSYqxWzDbRQBWZLycCiAHGZuisqXiqJ/KDYFRFwyUdkDFdmCU+7HF 6fha0kPvF2u1FbChioEei2s14f17NLoGjgtnQ67jw2lR/gqe9bWmlnM4D1qbLwcM6Wn8 /gFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740661119; x=1741265919; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CcZCFB7SoHZkFrArtueJCGhId3S5+D+C9zJ11KxR52A=; b=Ldc87y7LKd+n+n/x+rC58OD9qkeDmsUwBKPSZeJGKJMLXDHIs4JG8zaPpI4IntMP9e XmZeubjZhGB3rAuLjPRhx/WxdaWoX+J60M99+OeoqWWCwKyi70lOy0sf2rzjjffDMe3e dOLOoJcG26cSqmoa7ru4+8JzGr52itjtiA8LrKAvpz1NEhHKCUueNp99HffY5VdSvn/4 FVcvvkxfS9CCHFMOghjhZu3/ILqjY7TABU3sV6v8gEM7fvbdAxjp6WwtezjkBq1EZdMg wQKnm6lGL5QvaUpgTcxPYxBH/CJwDKlrw2BGGbAsa2PMm0J3JNSeW9s5vKwk+3dAjaQm pWGw== X-Forwarded-Encrypted: i=1; AJvYcCWGqto0l3QFN3wO7Ht1eSykS5MpQ3eDmkyljlzcyQQUCSWtGeL/v2sINWUY9OnCWqOT/MviJrvhHw==@kvack.org X-Gm-Message-State: AOJu0YzzvzFITe8iyHuXXa++/eZ0tBXMk+7CJ681kTusU65KRNZ7TjWB v4n0K/WELKIejYBA4+Vk2l6vesR8SUA9KYzJvnW9m5BCEQ63XRX44W2cYQ87i+v3QcwBiTXWf9T gShFyUL5FQNXO5aRlXUJcAU5aclkAaEIREbX5 X-Gm-Gg: ASbGncuoS4NPqKgWtgzK59jI4v8KKlI9HQWmo+qEN2GuDx9F57UHG0YlwvJM6KMosAq NIUpFLuVOSl+5ojMG0WleaJES4MHe9XzU+wG8W88BzlmwI1cFfal6gz3WuVPrvCMfCrQf7TiX64 zktGTCTmMmGS2QWB+PslpwUcHORvTwrWf+21kB+Q== X-Google-Smtp-Source: AGHT+IEuBKSHpYxPNkV0mEO8sF0yf5/Lrk4PNkOlzERDCq6vsKG4jqX9UOkFNRukujqr7d02y1J5NqmBMP5NaitgJ5Q= X-Received: by 2002:a05:622a:1651:b0:465:c590:ed18 with SMTP id d75a77b69052e-474a79840f5mr2914841cf.9.1740661118636; Thu, 27 Feb 2025 04:58:38 -0800 (PST) MIME-Version: 1.0 References: <20250221-mm-selftests-v2-0-28c4d66383c5@google.com> <20250221-mm-selftests-v2-8-28c4d66383c5@google.com> In-Reply-To: From: Brendan Jackman Date: Thu, 27 Feb 2025 13:58:26 +0100 X-Gm-Features: AQ5f1JrLdoCao1EqWIf9mO14WcJe1tYISuwUsBkKuAzcC56r8Ht7D8KrPqBSm9U Message-ID: Subject: Re: [PATCH v2 8/9] selftests/mm: Skip map_populate on weird filesystems To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 987C11C0022 X-Stat-Signature: d7m4g6nxzkn149ykwdx7y5ibqo6jkdgh X-HE-Tag: 1740661119-829931 X-HE-Meta: U2FsdGVkX19Tt52Qph7dCdJ7diTpu+WSRGkF/Nf+gmIkibObayQfD22tG+QcdPbmytFHVEa+A8HHEPrj1wycqapceDSTVvw/n2XyTJsJY/xgu8RbIydtcw2lBrDThIi8jFBobaGnrX8b3neWLerdiFbIMvnyBdzcSj21L4B6hdqdvvRYiINwF9/lnxWis6Om17Ib3g2yqPE9BQady+lh4ckdM/y1907F36CQkVbm0iXA5vM9n7RFjY0gSowggjORlabtH5r917AG2HRLXoIFR6pFwmQ5XcZhB4RxHS0Oc+ibUlEokwRYpO4sG08UG5G74QPyfockJratkLVwhPW/7TAYfjVpAZ6E1uHd99Gu+jLKDL5GqySPWKh7olY1sTispI0rTeqCPVT3siv++qBOvxOO9jzppe1xixWjTuuoMUoOrVx62eVj/+F+DXKp/9Zg7UaOzXrvoNOguOijtreVZl7OZ9d+vU6xrjGsOUmhUdwqvNmFzKJJ0lZCzsFuhqjBVIwwQcxF6nEZXIznASBHRRE8lLtIp+Qk2bkRe3pteq916KycdcXUjerPo/qGwFc4zxr5cuHGJQkLamtRqKIguTcer5qh76XtJ9pyNZSI5TQk0gpIKgAdpzIeVsz6XEpHX/EDypfCfUbqOxlXEBWWHO8VZvvk4EGqzfSF2OAV7flUWttC4YScuqIbSdAj/1QGgUk3I5d3Zj93kInO76ygYCULAJ288OuHS82lVWou5caTaqJG4i+ZfF0dO1wiOwVjezhepWQGzIwbgy3dk5G/G13M4syQ3v6KjbVQKy7z2D6+fxmXLXee604iM0xFSD2KkNVjjfqJ15lYYgUe1c5gMOC9umDzXuRbb62fUqlXDeFk5R/y2eltE6fCVpKT4+1uB4jT8vxpOburijj40N52T/kAX8ikTiNOJEMtPrqr5czjIQRyW0p5O0oVOD6ZhavDslh83sk3LbmPJkyYKJU lfhuZBdq WyNJWPUR1Z5LJOTc/9XKRNg9r+309QoLBL5TxMu5YQgkGxVUBc920MRDO/o4TF/IPKJA8PAr5hboVrrSjcBv2lUE1fKTaErPPwIVkdiFtYsUtfZGkgQNlOkXHB2fi0rXB+rEFpEecBqWgrxeto36axLvaFuDVPf6CeRAvMzIWABhdk1kypvGVfu0WmIKuMjPEwn8w4OqEmv0GUqLKAxPh9rXiCk5sAhvP2mJQceQchYzbo22C5vviNj179IHa0SY+qv9ATD5OAK3q3gM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.235431, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 24 Feb 2025 at 11:25, Brendan Jackman wrote: > > On Fri, 21 Feb 2025 at 19:26, Brendan Jackman wrote: > > > > It seems that 9pfs does not allow truncating unlinked files, Mark Brown > > has noted that NFS may also behave this way. > > I have not investigated at all but I _think_ over the weekend I saw > ftruncate() failure on a QEMU guest where /tmp was tmpfs. > > Most likely explanation is user probably error (like /tmp wasn't > actually tmpfs or the tmpfile() did not actually come from /tmp). OK I double checked. It was in fact a 9p filesystem, turns out virtme-ng uses that unconditionally for its --rwdir/--rodir mounts even if the root is virtiofsd, and the tests operate on files in the CWD as well as in /tmp. I am still pondering ways to tackle this kinda problem more systematically but for now I think just skipping these tests is fine. > + ksft_exit_skip("ftruncate(fileno(tmpfile())) gave ENOENT, weird filesystem?"); This is missing a newline though, ditto in the subsequent patch. I will wait and see if any reviews come in before I send a fixup.