From: Brendan Jackman <jackmanb@google.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>
Cc: Dev Jain <dev.jain@arm.com>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 8/9] selftests/mm: Skip map_populate on weird filesystems
Date: Thu, 27 Feb 2025 13:58:26 +0100 [thread overview]
Message-ID: <CA+i-1C3SYay4WqhGUG1nDpVZT-FRDSzgLHEbH1ONQygjYJS9GQ@mail.gmail.com> (raw)
In-Reply-To: <CA+i-1C3qSSgxJKREyVxFqCwZxGfZ+2962P5fKMATYFLGFb7fWw@mail.gmail.com>
On Mon, 24 Feb 2025 at 11:25, Brendan Jackman <jackmanb@google.com> wrote:
>
> On Fri, 21 Feb 2025 at 19:26, Brendan Jackman <jackmanb@google.com> wrote:
> >
> > It seems that 9pfs does not allow truncating unlinked files, Mark Brown
> > has noted that NFS may also behave this way.
>
> I have not investigated at all but I _think_ over the weekend I saw
> ftruncate() failure on a QEMU guest where /tmp was tmpfs.
>
> Most likely explanation is user probably error (like /tmp wasn't
> actually tmpfs or the tmpfile() did not actually come from /tmp).
OK I double checked. It was in fact a 9p filesystem, turns out
virtme-ng uses that unconditionally for its --rwdir/--rodir mounts
even if the root is virtiofsd, and the tests operate on files in the
CWD as well as in /tmp.
I am still pondering ways to tackle this kinda problem more
systematically but for now I think just skipping these tests is fine.
> + ksft_exit_skip("ftruncate(fileno(tmpfile())) gave ENOENT, weird filesystem?");
This is missing a newline though, ditto in the subsequent patch. I
will wait and see if any reviews come in before I send a fixup.
next prev parent reply other threads:[~2025-02-27 12:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 18:25 [PATCH v2 0/9] selftests/mm: Some cleanups from trying to run them Brendan Jackman
2025-02-21 18:25 ` [PATCH v2 1/9] selftests/mm: Report errno when things fail in gup_longterm Brendan Jackman
2025-02-21 18:25 ` [PATCH v2 2/9] selftests/mm: Fix assumption that sudo is present Brendan Jackman
2025-02-21 18:25 ` [PATCH v2 3/9] selftests/mm: Skip uffd-stress if userfaultfd not available Brendan Jackman
2025-02-21 18:25 ` [PATCH v2 4/9] selftests/mm: Skip uffd-wp-mremap " Brendan Jackman
2025-02-21 18:25 ` [PATCH v2 5/9] selftests/mm/uffd: Rename nr_cpus -> nr_threads Brendan Jackman
2025-02-21 18:25 ` [PATCH v2 6/9] selftests/mm: Print some details when uffd-stress gets bad params Brendan Jackman
2025-02-28 12:47 ` Brendan Jackman
2025-02-21 18:25 ` [PATCH v2 7/9] selftests/mm: Don't fail uffd-stress if too many CPUs Brendan Jackman
2025-02-21 18:25 ` [PATCH v2 8/9] selftests/mm: Skip map_populate on weird filesystems Brendan Jackman
2025-02-24 10:25 ` Brendan Jackman
2025-02-27 12:58 ` Brendan Jackman [this message]
2025-02-21 18:25 ` [PATCH v2 9/9] selftests/mm: Skip gup_longerm tests " Brendan Jackman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+i-1C3SYay4WqhGUG1nDpVZT-FRDSzgLHEbH1ONQygjYJS9GQ@mail.gmail.com \
--to=jackmanb@google.com \
--cc=akpm@linux-foundation.org \
--cc=dev.jain@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox