From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F0AAC021B2 for ; Thu, 20 Feb 2025 15:17:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD29E2802F1; Thu, 20 Feb 2025 10:17:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D82DA2802ED; Thu, 20 Feb 2025 10:17:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4AE62802F1; Thu, 20 Feb 2025 10:17:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AC2B62802ED for ; Thu, 20 Feb 2025 10:17:34 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4EB4F522CF for ; Thu, 20 Feb 2025 15:17:34 +0000 (UTC) X-FDA: 83140677228.26.7F493FD Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf03.hostedemail.com (Postfix) with ESMTP id 5468820006 for ; Thu, 20 Feb 2025 15:17:32 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=f+D0PpT9; spf=pass (imf03.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740064652; a=rsa-sha256; cv=none; b=De8sWeiI2cS/zclKnTSj8Whiym4NBo+AKvO5m0aRj+eUS2h9CWW/Kyek5MmMdKI+BZaMmu 3Dl7i7voYht7RPTlMyKWixzLykjLps13R5Kafn+7P/GMvgx3pN2mmo0LyALQdLBxhvgAYB +0fXmTLNuhqDW9FhZE2vhTRjXdxB1cA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=f+D0PpT9; spf=pass (imf03.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740064652; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nfqLAf2Bt1MZOxsTzROGpX4mEJpPOhYETeaZVqIiLtY=; b=TEs+lNfTR+RTd2fKMTSsQwxNaQsc6oUnnBPYKquOmXfcjprehHNwCO2d7/B15uCQhSQpOp CZSjXUyK2iDVgLUNGh0gkbiPjzu7RvsxxcH7TKwGQ1WPYVPtCOdfLf1K4F4X8Kcpaax4Rl PHNXhMB85v2E8f3F8KSeyiglchIYHLE= Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-472098e6e75so286431cf.1 for ; Thu, 20 Feb 2025 07:17:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740064651; x=1740669451; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nfqLAf2Bt1MZOxsTzROGpX4mEJpPOhYETeaZVqIiLtY=; b=f+D0PpT9J1hmFOWCeDFE7sPWv+WKmdn9rY0OQF+pwVHC6u+IhFp9xl2N6crn+/gmtG pTn/gIRbX0sIXblAbol2484lia6P4TSgYpPgVOM8b1qV7o40fK6uEIhhaNQu8qhXkzM/ 0hoSPQVUBBZOZcUNKiEvYORoWLHr89LVQs6zsxXf46bq4qKHWfpfGcX4WrYKoTetGTni uQ5n8cgsySVri5OJG4icvH1YoxweIGgwV/a6UUKX54w4gc6ZsJZUQiSMDXrAJ8zbCNy5 Ayf/8UXLozBNQVVpdoMkt7EVdK150rhk+YQIMNkQkXBBu80Uk0stPvuILkexkx7h6k7z J9Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740064651; x=1740669451; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nfqLAf2Bt1MZOxsTzROGpX4mEJpPOhYETeaZVqIiLtY=; b=vsCUuGiVd0FPfpefiueY+HP1n7+4Azpi1H8jzFeJvfFsxNBLVbJ8wsYeY3RVP8jLVz 8CzL7Vczhs9k8TTi6U4jBifHW17xDGtbFIPHVvo5b/QDy/i/EYcjLOgTaA2eHl8CLA55 MuCc+KTUZITK8npHdGbKSq4XjIkO/KVgGWO/8sltgB1I5vlolyWolZwt6DAz+0SuVLSn jx/sJbAMIfBZVmieCJ731Pq2K0e9HXWoYAQ3UuJuYlTraNbOvlwqxcfu0PDjrmayWlyg iOof84fJrIO8lvgGR1NgVwEmUTamvnJpmPMnun9+IpmEy6qsIlhFc3pjx5nQc9htGxhm F17w== X-Forwarded-Encrypted: i=1; AJvYcCUSdjhNV5UlQad6iecPUTdgzdAYPdsbQfmWBNO+9LGtruGEB5vFHHeCa7eGeuycDU1kOnxB7lynww==@kvack.org X-Gm-Message-State: AOJu0Yydt05G+BfN/Kp0ltW5bdVNriW0ZYqh3t6CTn0iiaJiPK+86mq2 lHym7y8xL9GJynCUlqUfnf42v173SAAf/XHrKaMAWFPjbhTe88v64jKZxzXt6jU3tFUMZwHAGGG K7NB5ZerRIwrEcoLqI3JWeQxQKY3aZTyBvbOe X-Gm-Gg: ASbGnctRLzsNfUbmEOyDWfYCZm3wS0Wm5qJk9IQeoRFTsJWWVRQDRAEvutokn2v5Ov2 IRHXmMmSZOY7VZpoKpUaenTDm8Fx/z4O7fDwaVktP/yj2PC9qeovsRLH64SdLtXVa82KxAyzI2t 8DwM3Fta0PkiDvvKMkZXAd/RkaaTI= X-Google-Smtp-Source: AGHT+IGhyGVmDHiveCYislzBLpxmEyFf8bbj2ICmMKfXu+YhRG0z57YQ28qadOmItdhl4ZLbIN/D33o1DiOb1WYbGYM= X-Received: by 2002:a05:622a:1a88:b0:471:9ece:b13b with SMTP id d75a77b69052e-4721708fbf4mr3622511cf.1.1740064651173; Thu, 20 Feb 2025 07:17:31 -0800 (PST) MIME-Version: 1.0 References: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> <20250220-mm-selftests-v1-5-9bbf57d64463@google.com> In-Reply-To: <20250220-mm-selftests-v1-5-9bbf57d64463@google.com> From: Brendan Jackman Date: Thu, 20 Feb 2025 16:17:19 +0100 X-Gm-Features: AWEUYZkyoMHZt5wOSmW4C7MoQ1154jjgu5NFAI7r6rF-taWxuY5uZ_vFpxeDUv8 Message-ID: Subject: Re: [PATCH 5/6] selftests/mm: Print some details when uffd-stress gets bad params To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Mateusz Guzik , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 5468820006 X-Stat-Signature: 8iqp1px8mbhi4r4u864k7goyk3hq55xn X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740064652-875382 X-HE-Meta: U2FsdGVkX19KrBf0MCBMz5dDJcM5KUiv+lOCb1jrFz0KdE5cQ97a5vaMACnyxx6GnYaBdowK1OcNJlu0OGB8DXz8wm0ZqJVPS8yw+qQg1jM5lU9XA9O9n4DuzS6gzMMA+vY9Z6M77tbCxJ5HotKGqKersaKbhAZRbmGY2a0OopOU5uEVaRu8ylliGfZy186tsZbZz+ptKEwNc3fdq0llzDFaO41TcajX0f5Qsf5c9bYIJRiFsoUueB52rI9AROjQU2z4wKulOCTa4D/AkmV+GnwOwMm2SWb7h1CaD1jTRbl1s05lqULfdU3RleMW4mhrhPEePU93H5VpCBqKhOvGom4Y5VzEipQkZgXbe3b+FPRdEDWhlq6mokRFgymH7VaJjS4WEoiZw5dpFp79NO2qO/2yFatv/6pz3Ruhn/fSMbjFjjKXD1fCrh4cX2IbGWWbLxOUZiaagK3LQsaSUUn8CIDIuVMW8qxs2x1pN3CYE5+VWkA+ByxrBsLBetUq2issBOijJwoDIQbcVFPYlFZm8OMt6yecSDMuW3MKjWcotfXP/BPN146JQrCaFhqB5OQD20jp0BPzFE7NBDydMKwkn+7Q/h5F7sZ7kPMKFWNhgVvreAxrnWLz8zMPNyverx4dyx4/4G6MLJmeDD5BQqz0Rj3UKF3OUl/Go/9jgqFIR05MRi5ZB+Ciwq13B6U/QAVr7KHHMszAmk+Ml5xOLaG0To7TdZzMbRgRu14sIW/F7uQZ4KhSezv+esIkonZWsDdRJG5OZ6C7UBLYWtSxEepPCidrOSoNEB0KYlEdXG4CAAMAH4tTGtFdOwhlwaHHHUuQmi4ELN6Coo1ftvOxT3CKlNN+PopwW5KH1Ky0ARlsIbcfcT/tD9kaApq0qknlVGQWEgu8b0fhxKiN/nZw1im3xHbM135yyRbcIy2bRL5pVl3YfkPeKzV91vgUyzmIo1mjIflppkGxILWOiuY2XpF TLcdv2/6 zu/F/GW/GF/LZZYymmKJ0hMHtui8LLRAgvvCXbFEJOP02wxF+uChhukC2ieXh5oeUBEcLtK7l26IGJXLB5aq1iXBoAhazmG5aL56xsEXE0xdBdaUvP7XrqHIkiDh+e5qCb/rJAvUFYl1kZ54nuDEdQThI138gmJspLpOqEJlCyhme0KvfE1IhZ1Actq15ViQRUdGgd0bpQtl2JA1T2T7ik+c2CA== X-Bogosity: Unsure, tests=bogofilter, spamicity=0.499986, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 20 Feb 2025 at 16:03, Brendan Jackman wrote: > nr_pages_per_cpu = bytes / page_size / nr_cpus; > if (!nr_pages_per_cpu) { > - _err("invalid MiB"); > + _err("invalid MiB %lu (%lu / %lu / %lu)", > + nr_pages_per_cpu, bytes, page_size, nr_cpus); Oh this is actually wrong - the number it's printing isn't MiB. Assuming there's a v2 I'll fix that up. Otherwise honestly this patch could just be dropped, it's not important.