From: Brendan Jackman <jackmanb@google.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>
Cc: Mateusz Guzik <mjguzik@gmail.com>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] selftests/mm: Print some details when uffd-stress gets bad params
Date: Thu, 20 Feb 2025 16:17:19 +0100 [thread overview]
Message-ID: <CA+i-1C3K=Fm=OfNy_5a40HYDwp_FBy4BBV9+4L0gF3S1grE5sw@mail.gmail.com> (raw)
In-Reply-To: <20250220-mm-selftests-v1-5-9bbf57d64463@google.com>
On Thu, 20 Feb 2025 at 16:03, Brendan Jackman <jackmanb@google.com> wrote:
> nr_pages_per_cpu = bytes / page_size / nr_cpus;
> if (!nr_pages_per_cpu) {
> - _err("invalid MiB");
> + _err("invalid MiB %lu (%lu / %lu / %lu)",
> + nr_pages_per_cpu, bytes, page_size, nr_cpus);
Oh this is actually wrong - the number it's printing isn't MiB.
Assuming there's a v2 I'll fix that up. Otherwise honestly this patch
could just be dropped, it's not important.
next prev parent reply other threads:[~2025-02-20 15:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 15:03 [PATCH 0/6] selftests/mm: Some cleanups from trying to run them Brendan Jackman
2025-02-20 15:03 ` [PATCH 1/6] selftests/mm: Report errno when things fail Brendan Jackman
2025-02-20 15:32 ` Dev Jain
2025-02-20 15:03 ` [PATCH 2/6] selftests/mm: Fix assumption that sudo is present Brendan Jackman
2025-02-20 15:03 ` [PATCH 3/6] selftests/mm: Skip uffd-stress if userfaultfd not available Brendan Jackman
2025-02-20 18:06 ` Dev Jain
2025-02-20 18:17 ` Brendan Jackman
2025-02-20 15:03 ` [PATCH 4/6] selftests/mm: Skip uffd-wp-mremap " Brendan Jackman
2025-02-20 15:03 ` [PATCH 5/6] selftests/mm: Print some details when uffd-stress gets bad params Brendan Jackman
2025-02-20 15:17 ` Brendan Jackman [this message]
2025-02-20 15:03 ` [PATCH 6/6] selftests/mm: Don't fail uffd-stress if too many CPUs Brendan Jackman
2025-02-20 15:48 ` Dev Jain
2025-02-20 15:55 ` Brendan Jackman
2025-02-20 16:01 ` Brendan Jackman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+i-1C3K=Fm=OfNy_5a40HYDwp_FBy4BBV9+4L0gF3S1grE5sw@mail.gmail.com' \
--to=jackmanb@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mjguzik@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox