From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CD93C021B6 for ; Tue, 25 Feb 2025 11:20:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6BDD6B0085; Tue, 25 Feb 2025 06:20:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E1D6B6B0088; Tue, 25 Feb 2025 06:20:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE4956B0089; Tue, 25 Feb 2025 06:20:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AF1BF6B0085 for ; Tue, 25 Feb 2025 06:20:48 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 64B9F506E3 for ; Tue, 25 Feb 2025 11:20:48 +0000 (UTC) X-FDA: 83158224576.10.F21FD44 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf23.hostedemail.com (Postfix) with ESMTP id 61A1E140015 for ; Tue, 25 Feb 2025 11:20:46 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Zpo0CWA0; spf=pass (imf23.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740482446; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZfKFZZC2tmOCbwC1r8CVgXiCVrT0QAUCI8q2gJHsnIA=; b=lUuqU2OWwV/oahy1zvw/oi6sm//c6Xm2DuPZOAHmQnC9vp31IZ7BmbRfjyRV/mS4sg2a6F sVlfPEHbnYhXNuNE2jluqbEyIE0GLpreXxEAuyeUVpAE8l5YD3Pkk4ZjcCxFJMmjRsJdX3 CgtNRF54WENPkAr17gekS1Upqu9dI3M= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Zpo0CWA0; spf=pass (imf23.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740482446; a=rsa-sha256; cv=none; b=Zh4xwHF16t+GGVVv7Ipv58an5dj/oDVGghRXEaSE13X3S6a39bXgxcGBK9re6l0vhlmL7h 0ogUYOZWzZmejzJilCmvDXW+IInynqRzr/j+koLUsikKWB0g4GTYTh6v9FYrFJmzK/1BGK EYtYWjLXAKn6ok4Xb6zzxXFQq0EbNfk= Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-471f1dd5b80so171821cf.1 for ; Tue, 25 Feb 2025 03:20:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740482445; x=1741087245; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZfKFZZC2tmOCbwC1r8CVgXiCVrT0QAUCI8q2gJHsnIA=; b=Zpo0CWA0r8KNmLmklFfJEgV09R+JJTt+0hfbkeeFVQpjDYkmAuPatN9ApVsmslKLxy HADFy2QoJeS+WRuDtUz7b657lt/dgkTABvD1d7KzX8KsYGVN/egI7INwlq8/zzJKBx5U Q3Zs3X0tz9w7KXuCp1B2SJo1TDOK+Q6lfvVyFw3AdEcQJxfbfe8tkwTogF70H2GVOaCM WWq2AeMm6s06EEp+6K7PuvyRINUpnq2YEwdJ4gc6/LUTIr2akmHxPpoWvQgKbUUx2u6F r30fLLqK/O1tWmF8hZnG3NWWQ7x/FvrQ9Ulrty/ODdDbIzW5+iKDPBC65ZuKQmk68Rhv nJvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740482445; x=1741087245; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZfKFZZC2tmOCbwC1r8CVgXiCVrT0QAUCI8q2gJHsnIA=; b=OIfYkIuG07WW4XFnlcgBVc4FrHADk2GnwEWTkcYXSljezUcSgicGncTo2uPyEUCjNx GVe405u9QAhDuKr7XRVciUpRzl+dUoAp7sj26Ks1as0/ouJdayoAwfQ7jFFAcXaQ9Dn+ 5ifS9Uvj2H1oQ5B+jT4dZ1R0xg/IjNZtKS9S7OUe38FrKfxpXpIm5X3ro1AmSs0WFUWs KlomGXeafoZU/l5VwqmvLGklmiNyuJYb45Y0WDt5vve53gBQuc0NvdvalkCl4PMxOuBL /9uxlokMBHhVNHQlazvL1O3FeeUuXIyPRlve9kUyIgNa7iX6JRNmdQeIDcWuiSN8IWzf um8Q== X-Forwarded-Encrypted: i=1; AJvYcCX8qDDu/LqEpqOMa58UutzJJ2IB9HJNQCjbvkgxrJc7ANVsx4OeC+yIFrBKe8mzpuJ/YS11dH1z6A==@kvack.org X-Gm-Message-State: AOJu0Ywc8eH+rDcs8bnt4grrpZ1ZYJzHIRlIuvx7LTvykTfaLu0AJFpJ kZa7q/A60VSpB94/2X7L1u3BFYBKx0EHdOw0eQLhv/gNOjqUTgB0suJ6PL4TzTzcSAcvgfUWfSi zwbR7K+GoujOSFYw6zLHowyewJ/+RZa9UjTz1 X-Gm-Gg: ASbGnctOvHtpiW3CSD1ncWMznNTrCe+6FUy3FTTfZspbjDhAd9jxrGLFdLgMmLmBWCB dEnJvtZVmV/gUEFhF9mf/cs76P/OH566VIWzYZfOErXkX6om3AKby+BkB2AUKlsPuZNlLV+BKcq 5GXdP7Uomk8Rm7Rwse6enKg2UJSBg5DQvuW6zO1w== X-Google-Smtp-Source: AGHT+IHFjJ0yKRObJdxsUgiD7JtmY8937g0CLtK//OiCCtPNNX1uIrk24753sc2sHUgmgRxIlWeBRTGfby6XhQp16yk= X-Received: by 2002:ac8:7d12:0:b0:471:f2dd:4184 with SMTP id d75a77b69052e-47376e80f47mr4296161cf.11.1740482445292; Tue, 25 Feb 2025 03:20:45 -0800 (PST) MIME-Version: 1.0 References: <20250224-page-alloc-kunit-v1-0-d337bb440889@google.com> <20250224-page-alloc-kunit-v1-3-d337bb440889@google.com> In-Reply-To: From: Brendan Jackman Date: Tue, 25 Feb 2025 12:20:34 +0100 X-Gm-Features: AQ5f1JqLPRqnWEZHqnvgC9tC15jeAnKsKuFlQFRcyxCvqPiNNGA6fSRNHtlD5as Message-ID: Subject: Re: [PATCH RFC 3/4] mm/page_alloc_test: Add logic to isolate a node for testing To: Yosry Ahmed Cc: Brendan Higgins , David Gow , Rae Moar , Andrew Morton , David Hildenbrand , Oscar Salvador , Lorenzo Stoakes , Vlastimil Babka , Michal Hocko , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 61A1E140015 X-Stat-Signature: axirrwo46mr8tg9qezetg5bg8udac85p X-HE-Tag: 1740482446-298943 X-HE-Meta: U2FsdGVkX1/s4H8DbxaDG7fzglwnisEbHzS+SaMgfgcjOvjXMMhC7zfZ8lRdxJOhMym1nN39rYCC7Te05z277iqIfyrXmWZ0mYqRfISaqAHlBOXnha1nYFpaQNJNx6RrfGWILv38aCwsTYSw/lg0mTjDm71W4ut/Rn88xXSLnVOrCbPkGaabZgGw4/P+6ChIx5YIU9FnIY3T/XecQX365mowM80/qoaGb+TIFCrkh7boZuw2EkAo0ZVytigVjpsbcYWmkFTt5QzGoyFy1bTGB9Fl8Nk5s1vYLyoCsnmVb98CCAYZ/Wj9r38ZpjbKLvJTGeH9Kr6oqFFK2sLCIwT8ccQOx3TUSmAo1FnQ5J0M8PYiYzd3vrdMaITmSL4OPB7M+pJ0zoRq0mYKzD1KDnizaGt+ukFCm3QD+1HSqzvv4iyBP6rVwumkHiBsDnSstYqspt3VWpczjdZ3hga0CR9N5ZfsUNCjc4xTiSXFb4V33nMVnnfmVzdGfzglKsOjVUVhN2OLxAKxX+wtDiRHgtBWz0efSgR4fvqXqG6nGLuNcdGwprxKh+4K+v9piKyAk2XDDcfzoA1j4tcZ5a6wg/tddr+KeePkOS0sTddM8PGkGhuHdT2EMbVxOdxal9tnBRBlF+QzK7wz9rRHMqf/DralzoZYsdJ00t5YiSmHjqBYymO/aLSX2RNM+PQYJoX4ZI7IvLff8NCpvWlAgEUquL2zyNqWBhzevZWv1Zjz0C/Yqv6mIiZAICLZiY2emQ3cCst8T27JnjTWykgmDVL4JxzQ8s554449XX9Fcr1ukQTg7Wsn2W336cEP6bnN6LlhZgSLknoy4+mv58Kuc6riDkz//ECQn343bNwJOu0sLpBIr99CQ1Z4Ic8UJo0Nr4Rt/p6tX9DKDt+i3RM7PSV/LIbEy6iwQGKSQKSgebu6MbhsjJnDqJg5yuxEZxrNCr/e6Gu6NCk0T4WNCnNH/SsNFcM HN2tnEtr YD4pcuHTWgMCl4dSYoV3H+OrHpcCoJU7TBfwTk7Q1Xj6cyaVAKXt8ilVfPQ+qIY6p7FMRHciYQhkAvfr4Ztq9xECVBxdt/0ItYcsllComrraDKLhCbNlOElGwwxiTuqjMUK+X6BIq0tf5HmRseVvCHkT+YsjqRQp9FETpMPXhYhbO1LPSpChIW/5+XyWbZPGWwGwQr2gJEytf1RS+W3xKnaE/UvCPrih9uSPoK8wBQxSMb1twl3URkH7hhw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.197701, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 24 Feb 2025 at 19:34, Yosry Ahmed wrote: > > +#ifdef CONFIG_KUNIT > > Why not CONFIG_PAGE_ALLOC_KUNIT_TEST? VISIBLE_IF_KUNIT is paired with #ifdef CONFIG_KUNIT elsewhere (I think there might even be docs that do this in an example) so I just followed the pattern. #ifdef CONFIG_KUNIT -> things are consistent and you just don't have to think about this very much. #ifdef CONFIG_PAGE_ALLOC_KUNIT_TEST -> better scoping. So yeah, shrug. Maybe David/Rae/Brendan has an opinion.