From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E91DC02198 for ; Wed, 12 Feb 2025 13:33:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C437F6B0085; Wed, 12 Feb 2025 08:33:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BF3876B0088; Wed, 12 Feb 2025 08:33:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABB076B0089; Wed, 12 Feb 2025 08:33:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8AB396B0085 for ; Wed, 12 Feb 2025 08:33:13 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4AFBE1A1D6D for ; Wed, 12 Feb 2025 13:33:13 +0000 (UTC) X-FDA: 83111383866.30.D357E5D Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf29.hostedemail.com (Postfix) with ESMTP id 68359120002 for ; Wed, 12 Feb 2025 13:33:11 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=c8KaBj4E; spf=pass (imf29.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739367191; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=814iHEDDutusXvvl7Bda5iR8JAhTEOQHD9FkFVmlgo0=; b=PrLhoUNYOo46WvMG81driCEyUef657aE+Ic1uJuHCDpPAf5HcPSsz7406Atf8hCUuBr6Ar LRne6jaSrLACKd6ITHwYxF0Hf/2pkpuT9Z66DNSkYwrpVrP8a332W/MbH6PfkBPC8s9Tjr Xwk9wsbyN2lTXEJMf0JncBz9hdErbPY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=c8KaBj4E; spf=pass (imf29.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739367191; a=rsa-sha256; cv=none; b=hkQ920nnxrYwHnE9p4hH1y3iptRLWhcJxgfC8IibdU+OP4MpGUt77y3lor+527i1L/ne+q f/XNLmTvGhv58b70ZYDkF7B8qr+KbPl6vNfaoJvkGLsG3FcAPFtyOP3J3PelLVdt9oWpsK IZidtEdB7yfd6oHiU+UAFbC5/9zd69U= Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-4718e224eb1so164581cf.1 for ; Wed, 12 Feb 2025 05:33:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1739367190; x=1739971990; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=814iHEDDutusXvvl7Bda5iR8JAhTEOQHD9FkFVmlgo0=; b=c8KaBj4ESpEhdx6vEUr1+a4vJb4VaX7yK2ojXBkPLS+Y4ghOEAU+dkkhkGlwY0DzdI oTbJF1bcOig+bSPYe/d8GObrBTZhnAIu6OhWVmHddgodsTpSgLBKXFQUMcKP8wOqOQ5W 7MRRC2e5netNcn3D4YWHBGNtCGhxgdBcPRQ6gB1hwLoiEtVv+1G8IwP6ijoClcohoWhm gU/w86LcycT/79uNg9eXMUdw8E50XKFp8Xkw+Er1UXywiUHJUuAIoM1BQebLrDsIkiKE VHulNhPXSLLIcKzmNGcNYxIb5XCu31S0xnWiEFkxt0nk/iKJCgIaESRgDHqud/uk8Oyb e8ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739367190; x=1739971990; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=814iHEDDutusXvvl7Bda5iR8JAhTEOQHD9FkFVmlgo0=; b=A/Lopw0s6JoPOEv8SOy4OiWNjYt51UqwgV8IxcSGd5Cgf0Sdsw/WmfpFJO8INlBcMr +s4hzT6iFZapVRb8ZZTpNzRPNFiedUgyjZCMhMNh2dvV6gfwceCNUwS7n+FHB1R0vvQ9 hEss6epFUo+VlHBsWSFC4LmI5UU/9rZ1rl7NEj5v7NVQIJkDp+LI/pAQ1XDUiFoKdjHj 4dcoabzGYuSaelGY6JrhlU1V82qnfVFV7Wd7fR5Gr1Vuvi6SsezJBxzw7JkstnuSWnv+ Nuc+1gqGj6KQTihtyO6O7Lq8nkqVaH5WHAXvF3GlaOZo5j8NIUjIAD7jcQJjECICZ4CK FK7A== X-Forwarded-Encrypted: i=1; AJvYcCXvu6uuF7l/XfF8FigOmHwEYW7+IR1kGODF/d3ha6yFeVzoJl+zPAnMziGXDkCcquwwlQRrm87cHA==@kvack.org X-Gm-Message-State: AOJu0YyDwCInQzI8Ur2yR+s6lEEAdYiJSZSjr2AJCZJyjL7YU+4mTh3c UnmxZMK9OBXnIbgB4e2+oSZXxxYW2O8sc0WB7gayK25jjergGtV9Pkg0oK+ow3szlkLFxJz7UQh xneOo/+QCyP3sfL5+yHlVkzDiz4BtkeGxukkq X-Gm-Gg: ASbGncvKTYO9T0lFeJ4zDQIfWWuzafvzQrVOKuD1JpIvDPQrrf0sRypP+m7yAEICrB+ wuZp1Znypt1tQCxuZ1shzI7SaO8DgtMmr+EfCr+PaAhjlU7TifLP2eDohoWpTevWObA7ov9lpTZ GDk1KdQQlDs6qbidR4RWqhk1aBybE= X-Google-Smtp-Source: AGHT+IHICDlIangdiDQT3Xw8Tr3gOveP7vM3B/Sc4ndJi/x+/hVYoXLbNJ39b7nnkHJt1riTKHH+IfVbIOuPLjDYJUI= X-Received: by 2002:a05:622a:4893:b0:46c:78e4:a9cc with SMTP id d75a77b69052e-471b1e3ee78mr3422071cf.25.1739367190462; Wed, 12 Feb 2025 05:33:10 -0800 (PST) MIME-Version: 1.0 References: <20250211210823.242681-1-riel@surriel.com> <20250211210823.242681-11-riel@surriel.com> In-Reply-To: <20250211210823.242681-11-riel@surriel.com> From: Brendan Jackman Date: Wed, 12 Feb 2025 14:32:59 +0100 X-Gm-Features: AWEUYZkiGLiKgxUEboUcIkVGtUOF1eylbrTa0sOIn3QmsoiC4NgJcoUkRsTEfqI Message-ID: Subject: Re: [PATCH v10 10/12] x86/mm: do targeted broadcast flushing from tlbbatch code To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 68359120002 X-Stat-Signature: 8zfp7pomng3co7mnagupms5qepzn6cob X-HE-Tag: 1739367191-811629 X-HE-Meta: U2FsdGVkX193j73JzSYjfwn4ROtthZGfI3Krh7SN7CZ+vXFjFhldPXY/AIoG6ybaz9WKTJ0RSx9Jr2Jv+Ve2fMrJR/RLTVWQQEZOpHeNXgIee2/lvwuyabADeOcuv8HRGpLEfSptFhLwK2ZNPHk1ZavjW4fivpBipLYV5+jBA5Q+/XGRUVJ51KWNoa6/qhOPJ3lvGz3xEPzoqlMURvV7QLTsPDqMhSQWQjWUvNLVKDGcAgxLrHdFL3sgzC9oOVBRnsAATzWS9FwgfPi3vx9GIlaj9xOXSGhyv/TXrM8gUIY9L5O9IiPr+aaoDkhlaLysiaFP4SdZeCd7rZ5Qxswf50lnJYbqHgPgC0es1F3ibvLdEopEvyPWxgJjpmrOwSEM/EbE1c523u46Q4jsU3IYBsVviez6YIkV1sah7Lw8wJznc1Ano4dJTPkErFjNIXGHLtr36aFrWzgqVMqbbZYzyjA18Kfh9rC7O+/RUNbegNCIzKqCQjIBQ6ZIg3xTi88Uux2R+qMbgrQFkhNSNygJarVBeiyzwwGMAcZktW2LLmUVa54pdlCkBo9xBIrG3eTUzZUwyzrDqLluhgKyLvTG65sq+aXFpuBZGQAwCkef2cVGYZVyWYexlnTIW3Fc2yTi8xpvcRWDn4JIRZGdwQIjkbY6fc1hqie1ZDbGWPRhyncxZbrdM+3hW5cvJF8Q6SKItPPPYblF6QE+qN25qWt2WagJmo7i5REPbJLgDSfKsvTKNanw4nEXdBfHXeoI588rif8SRPe2ztnU/dmx9LuFmRf9FE2J3uKrCGE7mWN1VIR0Ba2opwAmXFG7XFhwudp/UEC2OFHmg9o5vS6Cxn/9qO0c11kLPWt47E0RHx5YAdothB4A8Rp2SWU2x91dX877RTAIZ++Su+tbSqHq3QqchXYgnIzd8GOLh599xxxIf6qn5hRxBxzurN5seHb35u59qSKVHpFm6Z19yg6KvzN fzkh6P/C f2eToILwVk3E5vm6pkJBQifsBb8edEEjGzOgMHN+ksoVrr+Vx+J8/CBZNMbjfJ8DwlUfa/GxUL+SZuK2x+w+Vwz0pSJIS2z9QxDpFBZdoOqm0YCU7xSRpInxhpNE1zwZBhO+b8I21uJFzQHNR+kW/HILosk2uIfCTP1FvBtRrtIu/Ig5nItaevdxw3OD9J5oCH3mAiYkpNJ3eg63Nf56j93MEP8jWITocyR3AX0W+1JSdKwAmHSA68xDzqhF8Y++zigENROcvxer0fYn6guteXi5UT+kN0R5jANjdinTNOS+teu5+PA0RsX0CK5vP3D7Jgj5Vs7G2TAylqpsG/VZw2YRWj3K8OQTTINSk X-Bogosity: Ham, tests=bogofilter, spamicity=0.176095, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 11 Feb 2025 at 22:09, Rik van Riel wrote: > @@ -798,6 +829,8 @@ void switch_mm_irqs_off(struct mm_struct *unused, struct mm_struct *next, > if (IS_ENABLED(CONFIG_PROVE_LOCKING)) > WARN_ON_ONCE(!irqs_disabled()); > > + tlbsync(); > + Reminder to add comments or move this: https://lore.kernel.org/linux-kernel/e8a156d4c8f5db07cf03b55fb81c75d523cac680.camel@surriel.com/ I actually sent another reply which is not yet visible in Lore continuing to advocate for doing this in arch_start_context_switch() - I won't die on that hill but I do think we need either that or the commentary.