From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EA04C021A0 for ; Thu, 13 Feb 2025 18:39:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98EEB6B0089; Thu, 13 Feb 2025 13:39:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 93F886B008A; Thu, 13 Feb 2025 13:39:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82DE76B008C; Thu, 13 Feb 2025 13:39:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6423C6B0089 for ; Thu, 13 Feb 2025 13:39:12 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 04FE980EE5 for ; Thu, 13 Feb 2025 18:39:11 +0000 (UTC) X-FDA: 83115783744.29.970A609 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by imf01.hostedemail.com (Postfix) with ESMTP id 2DFE340013 for ; Thu, 13 Feb 2025 18:39:10 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eGo2uSLz; spf=pass (imf01.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739471950; a=rsa-sha256; cv=none; b=RyqJNz430Epg6VQW0qelzwCDMPTQpr+efpR4cyjRE6vFilRmNcHUY1jPPwEcAKWjbPRZpy IYQ2lcSp56a6D9tleZSDVwMVYRUx02S4w3P3+P7p2i/ZvJpOEilgNwoNWYgZNKJ7TC5rD7 YwZIiDMkejyzdnaZsI8yCSdgVWZWtHA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eGo2uSLz; spf=pass (imf01.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739471950; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GKTxK6jMbo+VU1rfVK8YLyS2gGtvcGk8MihuWJgrpPU=; b=20ZHzPtvj71TYvcC3XgwF/lkkoUH8UMwsUsBz0THoPQmwQFB+9MGX3YVoxzKCDHzyklyDg F9pm5G3SRnFCYSn6NGxhxzJs03CmQvlXCs+wNYtUaCbzYG1F75YHF/NnNCEmqFUFIexeZk d6WEO7aiIx4fZUvo0lPg1QaA+/ZGD9M= Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-4718aea0718so27661cf.0 for ; Thu, 13 Feb 2025 10:39:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1739471949; x=1740076749; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=GKTxK6jMbo+VU1rfVK8YLyS2gGtvcGk8MihuWJgrpPU=; b=eGo2uSLzcxakV8pnge/xBKPGLChSiN+K7dQuRGlTvZqwqMtOGgLn2nNb+sXINhZfZd bL3Sd5UVaP/mU4W7JRSymRPqAMJX5udXqg5NB4GpTUs93wW0bI4EfbhqUT/q1RRGZPHh Gg5BVCrlSbuTEfcmBG5YqcmbHMaAPzraaP1oAFkh/qfUJ1Wc9pheoyEifuAZ4LOdp4Va OQunHzlry2tdDlSwWtU5MjFgXEWzetVD5OjK1388fS9hUWXmnHWxwAWmFGPICfO9t/FQ Jk+8T1Or1A8hha3xAaZYOZzz3oeELTf3D3v+TSzbmnY9dExYSQRvtEaFQcUsp2Jc5Uxh kqjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739471949; x=1740076749; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GKTxK6jMbo+VU1rfVK8YLyS2gGtvcGk8MihuWJgrpPU=; b=t/1/f64TtO7BJTT4tqzpknaAXXyi7pUaBXNE/IG83reJGmK4E261h0iEtmup9OgAxi WXeU5Q2CQyaQ3z2wnb576mr0IgYEZKLp9ZNP4+35snsYSkIIBMB94zmZX4SblZnuBQGQ 1ggpQGuW41OOP2DVXYzSU6LkgbjHS5U2ty6Coz9aolyi92iBndwA/wGBlQ4oaJ81JbaP Sbjv4PeCeoJQI64K3GW+rtQvWTKzta8zkLPuPPchFBfYm6EH006UWziIU8u+hbS6Gme8 eW2aT9qKSjYKWDNWtVpdKUGxXmYOTBFg/lBzzNzXg+XaHB1LdL6WEnB+W0/wAqPo8eAH oZuQ== X-Forwarded-Encrypted: i=1; AJvYcCW3CgvKDPqWhXtO2360wRLMdgzZ/92A+kuG7vEOEJzH4UvDEnm4YWOnvZP0an7Eo32+e2iEkk+mhQ==@kvack.org X-Gm-Message-State: AOJu0YyrFvNiXZMYtsaT0T9c6BfjcbntAkFTVUkVFabTfEmAHPDFNAuV UK8WGI2u9OC+NA/6JCRK3kCFYGrjyDkzHPGR+IGgLedy5drZ5uO+1bQn3TTTe/xaAs4SZ/nIORp kZGlGGWT4ndBzI6JdyDrNiBIflYlwhALUlhd/ X-Gm-Gg: ASbGncvHJD1aPyQ1LlixyeXhUGrjCFSd/OuI6yyNp45EJmzVG1WmoDHaGUNONsC8plK DuTDqUcidC6KrHg7nl/nmKIVdJuuOie0Zscu/KL0/1DRULY2dWrHgbtu5cu8C5SfEdEtdfIOwwy tgyvTT3/xM1XKO6/4NX83hA3/fcQ== X-Google-Smtp-Source: AGHT+IF4xDaNzVce9dgGH9MryCcDiuY/x5c5oPtwTfyn7soJu4rCHUKi+VgtPavxik6VS4RbdhEgbR5aAQ70HhZbaVE= X-Received: by 2002:ac8:5fcd:0:b0:466:8887:6751 with SMTP id d75a77b69052e-471c1f9f9c0mr3966461cf.23.1739471949091; Thu, 13 Feb 2025 10:39:09 -0800 (PST) MIME-Version: 1.0 References: <20250213161423.449435-1-riel@surriel.com> In-Reply-To: From: Brendan Jackman Date: Thu, 13 Feb 2025 19:38:56 +0100 X-Gm-Features: AWEUYZlaxpnS4U_6JUBnYARQqPpT_gsCK9VIfU9Obm74133CrRJ47J6A9ECOiTY Message-ID: Subject: Re: [PATCH v11 00/12] AMD broadcast TLB invalidation To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 2DFE340013 X-Stat-Signature: 5xjn5dqji3c1mqnewob7owot8cnwsppm X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1739471950-46225 X-HE-Meta: U2FsdGVkX1+Avr1JE9cw7bR2wWRDlxrrtAvRJv2HTyrzYf6PLm9pFACeKiLVvOp4vxKYhUppRUv1bd9rBrvG7lxmT3eKnVFuc2LSkeC1MRbK94pKK7rxnmGiK/if6yjYxO7QZhFT/H/CLMj4INmRqVuFqMi/WWyRkYjegqhr8UQDty4dXu5X8jb3tbMbBNZuXMqgx8P4e283/KkgqDUXMVumpUQVGLF0uANGxkaiBjxMtAnx6VH6ZcsINyAOuHphgQhaiIt64OI+Fe7ZTvAn9tflRW3cel4x/KzO+NmxHlD2cpg9KT+b3f0OpFKxjjMoqMePDvqZg8o03HqZHTIGwJHklhlSK7VuwolS8N8+0hP5LZ2R9KGccwFukh4vZ4fNxMuhfpMlZG8Jtuny7oYzX61qjYz4MoCYbY4fYa2eEGPY2yx4tLh+MQH1Ys6X8nCv8PNMbReVPf4ySOHUdlQT7DFkhv31gpAunxZGEpe8CeR/CPvm9Q7d+vYfxUUPg7fqTIYvMvLUZBiFk7wADOOV0/hvnTgW+mJUuZjtgyGafIv//IwM5bBC3bIzLgSIf4zXI7Lx1moyVwDmOa1sCI9khQE2rKdnDlrDlFNww2MgkkCGrTIIqC9cDRBb7zm2rOUrZEeIikPt7SP0UEBzFF+9dU1LIE96oNrp1TvMXtZTdi/DY3M1eIOXNJNarHzRqXSYQp9fMKX1/YoII+nRJG/ZiU3aguiNVNNvFQQpdUfPmlOgRLt2oI51RtyJJk6Q8sarmJOHB0VO7XwMo7tk83eQIintKz3ryy9acz6jzmVda8sKjYQHkRfSnPyS6g5M39+8DclO55VE2M6Bcw/6rDczGzU2ZON775yISVL29rEqcd5E86IxeeLthcomv/RTJITR8nzokinBaItYci5KURzovtdLQnN8ua17Q6qospde1LN0fEDIrFfk9jvJyDj3AcfNkmg0BGchy+7ObdvGV31 vAwgv0tV c4FYs1ADQfZ5ABPi8t0BEShMp5IBKO4wIq3oauGPbjcdlGjlbZGb/D6sbMmUO2OOUtiInEliizdR4swSQWdsrqWZZLZ22vf1rPJQW2k17MNSvEYUM59kWmmyeqIXev57ctEHeD1c09B0WcywqOwb0/Z95Dz0N0EWQVpVQXFYGfCMlUPCwQ6YNMmaGGTyF9vcz7PVl2pZzs7B+KpOYgzJJhg2rFwZJFpKvhiXVyH97Te3IAzpzBdSrRsz1L9EIyElGHokxp4S3IzqsWgDUOZDe4NERiCCswKqQZZfH8rDaEaP1djL0bcf4rkfGPkaAUweaA/9SJTRUdR7pX5gKf7hmuQ4559zjOdGtkMpkAjH40XN643IO+QrhSoowbAc4/CuxzY4FogtdRTy9qdV9xbPSQkfnnc2yCp7pNYLJx7sZiPpnv8WDhC89JWyY4NtvjdNFbI+UdQHegM82qKA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.007692, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 13 Feb 2025 at 19:31, Brendan Jackman wrote: > > On Thu, 13 Feb 2025 at 17:20, Rik van Riel wrote: > > > > Add support for broadcast TLB invalidation using AMD's INVLPGB instruction. > > Oh - what if the user sets nopcid. We need to disable invlpgb in that > case right? > > (I assume it could be made to work, but doesn't seem like a case worth > optimising). BTW there are still a couple of unresolved threads from previous versions. KPTI comment: https://lore.kernel.org/linux-kernel/CA+i-1C2zuctxx6oPVVu0zBJ=Q=Hs73mgrWs5jsp8obARNcUS9g@mail.gmail.com/ and https://lore.kernel.org/linux-kernel/20250212104239.GF19118@noisy.programming.kicks-ass.net/ Clarify context-switch sync: https://lore.kernel.org/linux-kernel/CA+i-1C2CcQmrbdv0wLUJFD6m85D7LekejU=VdgMxnqZW=DRPxA@mail.gmail.com/ (there's another mention of it somewhere that I can't find) Suggestion for WARN_ON_ONCE: https://lore.kernel.org/linux-kernel/CA+i-1C3-F-VAy_JccwKx_AcD1mXsVcGHGwUFvi_ruAiqusiXZQ@mail.gmail.com/