From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 438CFC021B2 for ; Thu, 20 Feb 2025 16:01:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABD20440203; Thu, 20 Feb 2025 11:01:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A6D0E4401FE; Thu, 20 Feb 2025 11:01:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90DD3440203; Thu, 20 Feb 2025 11:01:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7454C4401FE for ; Thu, 20 Feb 2025 11:01:52 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C278C1623BD for ; Thu, 20 Feb 2025 16:01:51 +0000 (UTC) X-FDA: 83140788822.21.7EAED95 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf08.hostedemail.com (Postfix) with ESMTP id 5ED61160031 for ; Thu, 20 Feb 2025 16:01:48 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=F6oo3TNG; spf=pass (imf08.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740067309; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6f30t0FycP7wwwGERE0OSDlKv139yOSwMDMH3gonzjQ=; b=zM0BQ59MnCnd/q52mUoSPxIHuaCTjMLIpt/D+5Bo+ae/n3xF7R4hzYpzxPQeDVtw5W3KjZ ndCpqh2+FZ4zirZ0FbRkow8mltVeQwORxa1Wxm7icAghFLaqBMrs2qQgvigRovme3wrNfa yJOjvkiMr6AC5FiALXZF3sX1DXq5Xd8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=F6oo3TNG; spf=pass (imf08.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740067309; a=rsa-sha256; cv=none; b=HWMMyPVg7Y60555/+X839AFZ3ISeShMejOVv+eBnNYT5MkGajEd0YhExGXdBmRctnJWxv1 Sj+VYwqH7FN2lWB/UgYCt5tWht00OTeJEljeWXGHg4yl2W7H0U8Q+YFcdSFwBM9QkJWlqd i9IYfu0COzEbkAlLv9IcehadebRWIqw= Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-471fa3b19bcso307031cf.0 for ; Thu, 20 Feb 2025 08:01:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740067306; x=1740672106; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6f30t0FycP7wwwGERE0OSDlKv139yOSwMDMH3gonzjQ=; b=F6oo3TNGiC7PMrJjaKiKhalIGehu7hTFDiKM0JKl0Gqc3L+MEuOSqarC8xL/SDEl3o yhDtPK6yqDxwR8quJZkAtsmEWNzpmG3TTyQ1EY4vfeB4xuRfZJb6swYF07iKKBcnC3Hc +nC00tPGCNxZnZiC0mo+pT9IQSHETEVmZY/vtJqV6cv7TGCEMl9TWpUdR39Q7hgld4qC I2CkFk6QtLP2ftPKg+z7LQQ5JoSfiawigtVN/23f6EC4mYwISfkT8Ffs3o/wqhUN4/QI Ev/qNo1C3TEizMeFZiKxQoo/aDyYKoyS+VOjtAqjxhsdrFzfHJuxPvjiyf20Rwtb9K25 LAvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740067306; x=1740672106; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6f30t0FycP7wwwGERE0OSDlKv139yOSwMDMH3gonzjQ=; b=GYFwln8aQzEtIew2CL0ylqMJzrGl69uumYyskrCms49cef/VbeJu/Ebz82vcIaWZpf 4sStLCgoLTHXpU30/L5cJvBaCIG97nc81LcSWgccR0tUANSIl0j2YaXdt1yREDhjGyYV z4xGHI36bRWatg66naiHTmD18Uy+aox9e6tIeX0ikhecoGfAmTm0Le3cF9A20ieUbzB4 AHpkn+MRuRl+xi/fn3WUBA6tNtw6ledLR1V5oc8j3oOD9cVK/c7rA9MJzppLTPfiD5Eg z+39RMj3VLVnuosAP1AO+uDYxkRpNydpWj7bAb3qM4M17H6emBaxLAh8/3tYTEEhabWG F9vg== X-Forwarded-Encrypted: i=1; AJvYcCWLjcq5/FvzqLpACIc3kHJ8eHVqOShEStXXT0Qzq+C8fvrCsV5Bv+mwJkPJuS7FEmi26gFeKXTaHw==@kvack.org X-Gm-Message-State: AOJu0YzOWxIubd4LzaAraqWSKSIVv46p0oB2b158V3TNT6qzUXVxdUMv TfQADPJyt79GRgQ8zst/5KHH/eE/Ckxbrx6Dv5cWbAT8TTN/twpTTnJqO3ovNJ7VX3C0E44FUM/ xir2lYdFVPbVb+v9DS9hnw4GShJon3Gh0Z0/Z X-Gm-Gg: ASbGnctNV8SZzVVX/EHLfQdKPRft/tiOTSEjboKFpE40QzH5fgQ8DTrWC1mO/5Dy/3s yTUe+J3/e+ajGZfzDjzI7bZjP6zZqkbGMR2s00/qFS2ADx6gLWiiliV6HcmRHtqZO5F30rb0Mzb mIyW/vF9oOw3kG2jLBJrYrJI0+pNo= X-Google-Smtp-Source: AGHT+IHooJi+toMZzU34UpvZpQN12onTQrE7RJ6EGpciFt65M9cIektFHfEiQcxn19hTRXYVvPqlYBs3LU7ABqSCJiY= X-Received: by 2002:ac8:7f0e:0:b0:471:9480:a14b with SMTP id d75a77b69052e-47215bec013mr4381041cf.12.1740067306032; Thu, 20 Feb 2025 08:01:46 -0800 (PST) MIME-Version: 1.0 References: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> <20250220-mm-selftests-v1-6-9bbf57d64463@google.com> In-Reply-To: From: Brendan Jackman Date: Thu, 20 Feb 2025 17:01:34 +0100 X-Gm-Features: AWEUYZn5jQYXZnAzrw-ROi-YfDD7dcdvcVZBy_GodR3_QHZfRC5arYIJp-Gr774 Message-ID: Subject: Re: [PATCH 6/6] selftests/mm: Don't fail uffd-stress if too many CPUs To: Dev Jain Cc: Lorenzo Stoakes , Andrew Morton , Shuah Khan , Mateusz Guzik , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: tp78hfwydryfbq9s9dxkw8xfxtukn55k X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5ED61160031 X-HE-Tag: 1740067308-476168 X-HE-Meta: U2FsdGVkX18ujGMGsRZfekbphDAy6R7Qu6culmxVLCTEU/tvNr/jZEO5+YJC9O9T3QI5QMUhspma958xpKsx0wsY0AetHMMrlReIYmzYwKYsCU25vW+w1jkmM4nhUYuDv5xxnV/Um71bMNeWu47+gBuPdEQZb7nIPSGWKNJxwSeEcOBEiveK/HOPhllwtsFYJJelos4kJi9hJ8iUs+8jWfpr8Sx1N7GV1N/8HZp7vUGy7XB/uFloXE6lGdetFubJ3klMVulhrQw/oBHqEVSJqC5z+lsbEwVRWXofd0ZYz5Bza/TZvKInvaHijdDsxEOy+zpzZuPrCFvwAKZYkeqUZ3GIXMZUaJF2DL9yMmLcwssy9xBqDbYGFo20fR7lZIaCfKtjcN8a9ldQ8m8x+y7ADThKRdRXRSTDbepA7iSIzg81L6qE95hASanLKjC9mKywQN6nIBch1aZjIgMSZPgWtuFaaJu7xfxVR/28viTu4JlBNtWP32676kFJuHUG9vNdjcnbSg0ghi63L007Y7WKDvUaHtmrAKPcZq+FofwwwDjrk6wK3Nh5gpGYirPIza606qxaEJQuIyjdRH5hfrgoUuPDEETGLFN9sn2B8Xwv1wc7YiWKBJyRvddjSUQzgLkxz4jmMjpTx4DHpF54l8EEZRXVkJNZYKmg7g6NV8Jj7kCFjlyPfZ9obNbWbhknVE/HmLYfPWoxkKYYCEI1Ew/2y7VV7BHtyR/GtmVglKjQOqY5HpH2c8TZtiuPzZi9tJmwXfaxMB0DQsN3ICkyvlfyYOvIb5czZvZWhWz7niw5RselIZ/s8I1yDS6mmWlnH5rz/oYdKjnAi4yuYXiyz6Za3h7kjwHMq+9DjgFavju16W2SOpAzKv46OYqghvlPxnyA+wtz0k8ftWfVVzTCwGZlUy3+gSxRA97RFCWLZuWKfzfXVX+lK4FiEmhig+wuRORIqDR4H1cQJXTDxMNgzIr /TTxq5su u01Fdm2QILVZLMZS+uelL39Cl8Ldg70JFnJMwrU2BxtxGIdaUVyriwOWWNCUJhlDM1tLaBTDKKUn6gI7wMXHqOoWmZJXCAwo/NuZJVSpKAtBacXP5VBhNgKz+zkshSqaWDvx4JRT9ED7v+Ud6YWnWX0wwqnoSnQmzNOkZxDv6lukZQypuzXQmWHVzfLmQ5blyW1AIEpe6zzoMUTe5sc3AzATHfJjb0hfUYJxMwbo6yeU0IoVSa/mJAYdWF3FL8S0rZkhiEvl9hlUYWkj5d78vaey5eA== X-Bogosity: Unsure, tests=bogofilter, spamicity=0.455044, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 20 Feb 2025 at 16:55, Brendan Jackman wrote: > > On Thu, 20 Feb 2025 at 16:48, Dev Jain wrote: > > > > > > > > On 20/02/25 8:33 pm, Brendan Jackman wrote: > > > This calculation divides a fixed parameter by an environment-dependent > > > parameter i.e. the number of CPUs. > > > > > > The simple way to avoid machine-specific failures here is to just put a > > > cap on the max value of the latter. > > > > I haven't read the test, but if nr_cpus is being computed, then this > > value must be important to the test somehow? Would it potentially be > > wrong to let the test run for nr_cpus != actual number of cpus? > > Based on my _extremely hasty_ reading, the variable is misnamed and > it's actually a thread count not a CPU count. I can double check > that's the case and rename it. Oh yeah actually, it's only misnamed because I made it misnamed. So this patch needs to rename it for sure, thanks for pointing it out. (But yeah I upgraded my extremely hasty reading to an only hasty reading and I still don't think this test cares about the actual CPU topology).