From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2422C02199 for ; Fri, 7 Feb 2025 15:11:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FA30280004; Fri, 7 Feb 2025 10:11:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 282B9280001; Fri, 7 Feb 2025 10:11:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12470280004; Fri, 7 Feb 2025 10:11:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E3F04280001 for ; Fri, 7 Feb 2025 10:11:06 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6AD004B904 for ; Fri, 7 Feb 2025 15:11:06 +0000 (UTC) X-FDA: 83093486532.25.A659711 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf01.hostedemail.com (Postfix) with ESMTP id 623A140012 for ; Fri, 7 Feb 2025 15:11:04 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CxALK3UW; spf=pass (imf01.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738941064; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mOI0Xr28dC45rJb2BCYhdZJmAWpUY5gWtBmNeq91+Ak=; b=LsPT8Ckk+CkRbCpBkylIGtuS0qUnHN5NolAn8kS9Xy/A1eBGMuENpVbIN3tkbqEg+8Di9g Kq53MCMLHGtqHAJBmFdKOQtxZQ5zyn069/oNr6JkPoXyQ+QLq8K0N3sXjRejaRJ6BOPu8c QrCEtMUtWYgMVRCwAEbrHYPclaLrJ1I= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CxALK3UW; spf=pass (imf01.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738941064; a=rsa-sha256; cv=none; b=uas3dvhmkYRP0kgl1AfS8t1v4T2O7RDzUougM8KU40zeeiltzbzKFlqqMNleUjE5H1nhEj FWEgF97lONcQJzyafVBq7Sg8VGIfTA7+XX/pzGAE1NyEnbLky9GjSuJqj1aARjHQFyEvi7 hTruPld/eD4iUbFGD/Uzc1MhXn8GOHw= Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-467abce2ef9so267801cf.0 for ; Fri, 07 Feb 2025 07:11:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738941063; x=1739545863; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=mOI0Xr28dC45rJb2BCYhdZJmAWpUY5gWtBmNeq91+Ak=; b=CxALK3UWjoM4AFSfChSDDXdzKxOUu65+ybJkSSP7oKT8Fq0wNElRLLr/Cb9evPHsGS wgydCK1pR9TaDvVy6IuCkwDlu2lP84mlU+zvkGHZ3zWgwPK1nV3OzP8x5LmMj/L7VmZu aovUzAkU/N75IuXKmYZLLLcBSheV4sE2tFbvLC7RUQ/XLVPXWwWLw5/diXsgAqCua5km O8L8J388vsWs/w1uEl8WzodLcY4EHLMzcf8H+F6RNp24gB5ztlgCqggphbkvoRg8a94e 4ltkPD00jj6Sn+oK6NLdZOk/YMhvwIxN7QHVJu1y2Gok6prjyE0g+qPKLaXWfugDf4Gg Hq6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738941063; x=1739545863; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mOI0Xr28dC45rJb2BCYhdZJmAWpUY5gWtBmNeq91+Ak=; b=gIeGA5NnSo631DihntChVvBXKaiSEDOsFqDcAUEAw/UDwNUr/xs9KpKDiVHibZfuvr PecN5mtAe1YXyfANEI3faBnPiDKGtMsyD8xYGXI78X5eGHObxpVwcB3sWJVE2Zwt4jlC gdhs+bwja/Qem/TX6I8W+KnLmTLt+ETAekX2htJe4kuc6oo9rIajKHdyiFp83uZmnqtf HmsS7G/Dg0B3NWyTXZ8OfXP24N50C2mymomwvGzf/Rw/4SFVTe+iNjvAoGaKKcoKpD/6 zSu+8tO3dJFtWs90szNohb0lNuKeITA32CFopULdegr8MM88LoCUkPOKd+4b79E6kvar 0UeQ== X-Forwarded-Encrypted: i=1; AJvYcCUjAwODXYZIlpLa9XbGa2wZbKvUU7hFJ85JXxwUkCHvcIgqxvXcg1gjCWcHMbWjLwJiVmikpvLuRg==@kvack.org X-Gm-Message-State: AOJu0Yz+g95Qc/r034O9jY7Ag5EmAgcjGbmvmEvwfhH67gaRzq1k7NAO hbwVpOI7KHfpOqNncuaFiloHdd1bZ5+rCg32FrDWNGY5vZYK6Fv3Tahn9Ujx0FfqyEf+A9IOfi2 +t6UViUO5kRVPkP73QUkYPNNLzczry4sjEXB0 X-Gm-Gg: ASbGncsqDs5kUEIzjqvaUm2bigiGq9Y3G8Kz9coQtA9ANtzhPrib4AtF9a7NMjD8yNs fjNW6vJk9slyPU2fURUIoovgGwVrg5Ry8d1j1HsxhbBYp+JIYFMCslSCnxHC1+7RNB+fXnodJyB vSK+/n+EImLlADozHDL4ldQm4GGfM= X-Google-Smtp-Source: AGHT+IF/nJGpEi9xq5E9CylW+Z8B2gDg5xgGCl6lUjy7uExSa7txt20qsNhXGypcQPbWVJbTbWF5PKZZZAvb9UVcaW4= X-Received: by 2002:a05:622a:1890:b0:46e:1ded:e31f with SMTP id d75a77b69052e-47168488f6cmr3517401cf.4.1738941062862; Fri, 07 Feb 2025 07:11:02 -0800 (PST) MIME-Version: 1.0 References: <20250206044346.3810242-1-riel@surriel.com> <20250206044346.3810242-5-riel@surriel.com> In-Reply-To: <20250206044346.3810242-5-riel@surriel.com> From: Brendan Jackman Date: Fri, 7 Feb 2025 16:10:51 +0100 X-Gm-Features: AWEUYZko8Tepey1C9O-kaFhzHCNOILtT4NNbtqj2Ew_kIzYbNfBDcLDOYu8rd6o Message-ID: Subject: Re: [PATCH v9 04/12] x86/mm: get INVLPGB count max from CPUID To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 623A140012 X-Stat-Signature: 4xkofcsabyb5yfatpteozysnh3u3gkik X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1738941064-884681 X-HE-Meta: U2FsdGVkX194gqFQJ69R9fz5fGEbA3HYMl91n1+SD3lCzn9pz7iKAiLvpN3mAo9F89uA7kYhbeP/Svi0/j/0l0jeKsEY95cgc21wXI2+vcKZYQ2R5TGcMhFTCth1ODalB3tX0n2keTO0wApzJ2bWngIL9m5Ys+pN1yciNo+IwFLMXCzK//mM971r42/ys0DsnUX069h96NaI4ManaD/CMF+EWhRhzlfblff3outlBjdDMpJHyKhS+qdJMdGlGGIZpbC1OhBzivi9QePSlbSUXkklPUitHth0fe0J1g3dHr5bMOcwlSZU3LflU1DQq4fiMt+x3Aja1jBLEDIVcwontDT9UQ4cmTSN+Chgd3KfQX6fvr8XG4F+pAAwB7c0aY1TyoEryold6TFoJ3zvna+HgkQ2LdYcXcWe+7IzMKG9aPfQ4yIbaqQ9QrMl+6nw8e5I/bkDcZ8kREhteOgMZYCdTZwsOJxXAmXxHl1mKp/y3SlngOXAzQeHTRKB9vdBMKI6U6QGVVXa6VfPpReiZbiaorUbcq+/Dp7zNLkxopmXonSfx1T2Cm59U2X0Fzhl1z+8h2GX0IDGwgkwxLidktFqtuiVjDWcAAedkC63Ny+ICvjp1tBpIJKUO8dSWBG7XyyPkGCgSFpQPGufc23MtIzsTfjJBV15q9kBwrx/UPaXmmBzP8FQtWOJQZIDfDi/HQK6zBvYr8r7cBOB9kFr5o0/J0VYIle7RnRSUIYaCpLkEr/TyOsqm120NDDE3NGrBNHuS+NhIE2js52isMBO/h2FJzG6anXHgBX98gKLUDT7YajBgkyW0FpvvdYvEKaYwgFNfN62Nm9kcWnLV6Jn5l1rbvKFClKsrgmRj+HKWHKg9JXq5ORu9R0/oLtuFUvwq6T3AuJL8YtVwuaiR9lHZdf/un2Io8kI8QRbtPgw8r0yUtNNb6/mmBbhFnGfw7V+aDkMehNyhCZW2onWN5mnxdc ONaSn88T 2uMkmXssrIlO1RPvZaoDqAVTgEDL4ocUzLEPbLwF3EYhzog24iqcKxLJlj9Lfpbegmx1cvi9tE8aX4rIcT0SruZWimuOgfrhGD1IMAy6hV61FNXLkQmuTbIdYn4cu9cq34FFaarjOIGf6QbGPen/W7d8MQ8+LPrUzecQRjtuDHef3gNWadmK1xED6PZhN4wpGi2zQ+jYyy76OfvjW6DQbiDfcnC4jv1gZlN0LVdogt5BS04eYOaR8PusWbzZXedn4NEp/Bzp+fPBbDsk56JQTDGxgvOnfxkmZ7t9GcDiVvStJigbxsmEucl9bKkYvU9WFZYhrULbJ3qGW9s4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000148, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 6 Feb 2025 at 05:45, Rik van Riel wrote: > diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h > index 17b6590748c0..f9b832e971c5 100644 > --- a/arch/x86/include/asm/cpufeatures.h > +++ b/arch/x86/include/asm/cpufeatures.h > @@ -338,6 +338,7 @@ > #define X86_FEATURE_CLZERO (13*32+ 0) /* "clzero" CLZERO instruction */ > #define X86_FEATURE_IRPERF (13*32+ 1) /* "irperf" Instructions Retired Count */ > #define X86_FEATURE_XSAVEERPTR (13*32+ 2) /* "xsaveerptr" Always save/restore FP error pointers */ > +#define X86_FEATURE_INVLPGB (13*32+ 3) /* INVLPGB and TLBSYNC instruction supported. */ Why no "invlpgb" here? Seems like having this flag visible in cpuinfo would be worthwhile. If there's a reason to hide it maybe add a comment to explain the reason? Sorry if this is a stupid question - I also can't see an obvious rationale for why existing flags do or don't get a name at runtime.