From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 369F3C021A9 for ; Mon, 17 Feb 2025 13:22:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A21428004F; Mon, 17 Feb 2025 08:22:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 82C3D28004D; Mon, 17 Feb 2025 08:22:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A3E528004F; Mon, 17 Feb 2025 08:22:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4DE7628004D for ; Mon, 17 Feb 2025 08:22:24 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CEF4BA01E9 for ; Mon, 17 Feb 2025 13:22:23 +0000 (UTC) X-FDA: 83129500566.06.F249A80 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf14.hostedemail.com (Postfix) with ESMTP id 0E4E5100004 for ; Mon, 17 Feb 2025 13:22:21 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=4qXgdOQ+; spf=pass (imf14.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739798542; a=rsa-sha256; cv=none; b=0Tel/sYXF/cllVcmsT2FR7a6EeqzLw00VOcP74Zd4YuXupeYOMuUdJK/zq8IKCr1zXvsJF fOigOnbIE3msuUeVzrzp9rYsbm7qjFwvFGuxVm7VW+c9hGkoWYnj4Y3/t8y3lGFWACA4qB E5lMDLa4cvJolep9hhylWVeq2nhcojE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=4qXgdOQ+; spf=pass (imf14.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739798542; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vq9CJlm9LZioC/TdF9O153jfo2iM3nlQAWvAD/w6QrI=; b=UEIU9qc5dpmdebZHkQGABs++nwYCTcs/C3UkYP86EhY7kOmaisFZJTD9J7zbdU+1iE1ZOb LKckjMIKEkVWDh6rc75m9K7WL8OPkDePV6PkEYlNs6RIQqZJ1tjq9OMilqiw6rrjOEs7+E iTOnZ2RkJ+xi9up5Z+mTbuBMNstvSfo= Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-471f1dd5b80so179521cf.1 for ; Mon, 17 Feb 2025 05:22:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1739798540; x=1740403340; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vq9CJlm9LZioC/TdF9O153jfo2iM3nlQAWvAD/w6QrI=; b=4qXgdOQ+e1ht3dtfP9harpFOF97jgonD2byZy2qLuOqmULnpgm/Ix6CYnszrIJje2I 8ElsG3lgGDp+Ap0k9RgDRaEvh0ha/ot7CbDbP97TosyVFcjF5vu9Iij3QIUZxrQBk7a1 oHTfPsKF/Ns4CbMOnLhKWFd/RFJPl29cCp9jbuBFr3+/UDSfdU2rosHnIzgXMFzA2M1j CzNP+UfLT3bPWrNod0UnM2S/tMONoeatA9xBG/gowW7BjJ6kPjoisIwVkkD60S0vqnf4 20npT+rGNN8GPjQECqDxRTYDzWRZwzopr/lUFOjxhpPqdarDnoy+5Ggt5wZkBo2VS+hS UDRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739798540; x=1740403340; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vq9CJlm9LZioC/TdF9O153jfo2iM3nlQAWvAD/w6QrI=; b=uLxhvWZwDSTH8Uft8lpYV6v7svx3ptqbvO5lc2OjkIwLZxS34tosKuEd97qNWjscxl 8/TTfP5s29GoBTgEpIFtE3PZp7tNfGjIfbQ7KAYmtxwa+epp4Qw9utXSUBsrbzdhXCy3 7YFINQqzXv7PQALsg3PHhBABSwyGw4qbwDIPvu/HIbtSoOg15T75mWbDBfVv3y9qs9KX CF4c+eEfX84Nn4wW9wR3UfMRpeklnMgfmNzU5esyKH0tg1G9MrS7c6lSAj/xXU0821XO HGr3rzzGCuwwRQqtu6i++aUFeOw2hoHCOs0lVUmQH4fymAtWpihswItyBKBNAhYNYryg 8cFA== X-Forwarded-Encrypted: i=1; AJvYcCV5gGbgIai1KfQcGtneWZ4/iCqeHg36isCTG1T+V0EAIkVMZs7DTnWmxi+piovo/RdLy3MyHgU7XQ==@kvack.org X-Gm-Message-State: AOJu0YxuMtTm1ElklI+6e+/irBsj+mNe9+XhXSNVYK1yW+5RQzc1Llfx 6qJqNpIoMkXbtfsKJrl3eDmZ9lQww79lIWGaQZBiHAhNqUhPVyAc3I6WpNhxmSiSChM4bLcYj5O 2aTpK3UbH0qSsOcOM41qRBC9slcpZQ8FgD/NP X-Gm-Gg: ASbGnctY4w3UZqGY+3eF2REod9tiRmoxa2QZ16SG84BX3bTM/B+zQDzUEhR6G0dHST3 b6AGyi17y/MjdemA/49uVbq2pLk9FNuVQ+jXSsnrFZc4ME+2AhAyLtJtbrLiPbjJMyrfYobPn43 EOujhWjKr0SRzsB5vK9CTQ/nvhWhc= X-Google-Smtp-Source: AGHT+IHPb2N/Ql2QklTpLkD7IklZWxXHiU6D+knUHd+msp5Utd9AH8vt3AvwQmgYE4W9XOtxZdSn2sDo/2Lh+Ipx1nE= X-Received: by 2002:a05:622a:4d2:b0:466:975f:b219 with SMTP id d75a77b69052e-471dc776c37mr7257111cf.8.1739798540440; Mon, 17 Feb 2025 05:22:20 -0800 (PST) MIME-Version: 1.0 References: <20250213161423.449435-1-riel@surriel.com> <20250213161423.449435-10-riel@surriel.com> In-Reply-To: From: Brendan Jackman Date: Mon, 17 Feb 2025 14:22:08 +0100 X-Gm-Features: AWEUYZkcGmtgXspwSIHGcORyrrSbO5XSN0cgRWQ-uvFbLyT8pNr5z7geDMZUGAk Message-ID: Subject: Re: [PATCH v11 09/12] x86/mm: enable broadcast TLB invalidation for multi-threaded processes To: Dave Hansen Cc: Rik van Riel , x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: eayspmzpzwmy7htgrnx47136tesj1y4b X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0E4E5100004 X-Rspam-User: X-HE-Tag: 1739798541-312899 X-HE-Meta: U2FsdGVkX1/eKEujKd3rxikAnmIfrwhxxq5btoN9ErPsYZb9hxNFkZGFP8Lno/mMsCz7zSwmXPfcWbF1SRIHzznO27fh96zdg5vgCbhLADl8yYwas2r7qULvi1TFDS2ULwWkwuAhQCs4WsQCcQnSOcNyRc2vFmbJwXQmWKqzpPZKcEXIkIWNsoz0PJ1AZYfX7NarujAvtoXWmxvSh/GlJAzzvDrOlNM3T9iqMTURwxHBWjJoCk6CVcqr36TQuFeH8Jdu/XoLbGxnZQ/3wUoO90KiADlfyUYUbpXxVKV60lD9bTOKiA+od53Ds8kbkDdNbXpr5p/G1Jf/ZMSmM2uotpgDGzfwkHsZOnceboG1z4Doh9jzgwcoiqMFEVDmosls1t8/I/qszj/diQ0m8K0vGKeTd6jzQsOT9Q+tlzXd97PYsH8fVxtll28vkXTeLxMl2r35Mcf1mOIZR1EXGCrwz/tBBsk+wIi74CsvUCYORoxy/+g4ThL4Y0D6Z4wGHcYPnoGvYK06dp3IiOddHbXl+gOJtSC4KOMbWI6RUUHWM5Wil57VgyykQF7kGAWBJg5J48/NGCF+xBChfAK7rD+60C4nV1cGFEeAp812JVzBQK5ttNHVXElBi7dO6ta/fHZX9YctY57c5uagUAPo33paNDMOnt4PibLd7m4G3O8G3Ho/gcA/EbI3uPiYfGvV5YRJp5Ibz4L1p9WvxntlXR4Ez4bAS5zw3qpRTONyKTJ7b9RNO18Lh4cRlrvdmH3j6RejK94rZC33MCl1aH3WOZuws89gWcPveJFCaaDOBVoveUq25p0GL6qOYItCjTz/SMCexeRdCyWCA2zMRL9oWmnfySwWElQvixpdTp4llyOY7m0UDsBKBpu35SWVrutrXP3b/qVmfIpZIe6JR/J3Ei7c4f8N5zEUVpx2FhiUNy00RgjWZutpHceIi0Oi3vbafZcJAjTpT6Gbjmi0dDyWO9V 3Fcg3Von iN9sfEEhqF6q5/OUvgOGnp91BCwNsfIW3uVOLm+VYlUmsf3CrQwXQ7v+GZVtkdSxPvGPn4+EnQ75Z2iqBl9YSSMmHD2+qZB6uKH5A+RWLHtYwrCvizxaAC1t7HgEwr7j0KdnmE0pZYZMtwMb8iQqeuapeI2zeVYI5b0246clg73KnwjlpQP+XvBRwY35fS5bmvl8dTSRSvWcDcTueZa/B+/qYprCdf1VqZl5PXZtoHFj5VyceeFHh18rzCQSnRorhBa0n5O6oD1pvvxXHpLdu/goddaq5G92h7Bjo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 14 Feb 2025 at 20:53, Dave Hansen wrote: > > + /* > > + * TLB consistency for global ASIDs is maintained with broadcast TLB > > + * flushing. The TLB is never outdated, and does not need flushing. > > + */ > > This is another case where I think using the word "broadcast" is not > helping. > > Here's the problem: INVLPGB is a "INVLPG" that's broadcast. So the name > INVLPGB is fine. INVLPGB is *a* way to broadcast INVLPG which is *a* > kind of TLB invalidation. > > But, to me "broadcast TLB flushing" is a broad term. In arguably > includes INVLPGB and normal IPI-based flushing. Just like the function > naming in the earlier patch, I think we need a better term here. If we wanna refer to invlpgb-type things without saying invlpgb, and as you pointed out "broadcast" is too general, I think we just need the terminology to refer to the fact it's a special "hardware" feature. So "hardware-synchronized" or something like that. The former would abbrev to hwsync in identifiers, without any loss of clarity.