From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DAD0C021B8 for ; Wed, 26 Feb 2025 10:33:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E82A3280003; Wed, 26 Feb 2025 05:33:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E33C9280002; Wed, 26 Feb 2025 05:33:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF9F9280003; Wed, 26 Feb 2025 05:33:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B4163280002 for ; Wed, 26 Feb 2025 05:33:47 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1FCA91A11C9 for ; Wed, 26 Feb 2025 10:33:47 +0000 (UTC) X-FDA: 83161734894.27.C8E0A4B Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf12.hostedemail.com (Postfix) with ESMTP id 591CB40008 for ; Wed, 26 Feb 2025 10:33:45 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=be5hLGm9; spf=pass (imf12.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740566025; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OInzV5A00n7mGPHyOTHzxDyfR7GJd4/agyAg8/xaO+s=; b=j1yBPR2zbd6dyGFKAbV5tRE4/BNdyyDF5iwuQOKM/zvsXHV4eD+XLsYDJMnfE5t+E0PvDc K5S/H4zwxezASnV4yRKg7RexFMna5aUL6Vl9apZr/c6OgAmxWgbSsCaFLgeTvJYOLOc5H1 BWLBAJMJethdtzXfal48I8PuraehnJI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=be5hLGm9; spf=pass (imf12.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740566025; a=rsa-sha256; cv=none; b=XXKbcLqc8PmqgqCZV891mGNMAatNbzeDspDJEyz2UUirLWOjPM6EhKKzbFa0X86nGjwztZ pNEYAMofFQQUXalq4OgjWOhnO7NnWlluzzgFEcAN+jKI84gIATUMsgMtBH1fsDq06Npxpo GvYrn8JmbDuyKnTNYS5+eWewY+N+h1I= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-472098e6e75so214471cf.1 for ; Wed, 26 Feb 2025 02:33:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740566024; x=1741170824; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OInzV5A00n7mGPHyOTHzxDyfR7GJd4/agyAg8/xaO+s=; b=be5hLGm93crtOXfxWWzQzGTrcrt68tpOEuF2a8YqKuBIq9icwj/nqW1Bwe4YRFZCYz 6sfa/wGjnfKLe1PzqIKnxhf4FG+D/sUPJD3/oC6etbH6zBDL2OvupeLki5Z3qiHHjL59 2mXMbkj7z/8dqlxEnGyOxALMQodZDKapTvr8i9c6S3c7h6pRAD2Hs+Eo/JyvtDyOXRuW +dobnEv4LxZXdhvTqUcr3jXev0ntiLztCqsXEzb8Tk226cuDNpHXHT+cXm9fZRdSCRQV xNcDAFNMYbpgZQVW1SgbpCP0yF1GWpWNuOoVWIg861MHx25m+bPV7aJwBGvskzY/866p hYLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740566024; x=1741170824; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OInzV5A00n7mGPHyOTHzxDyfR7GJd4/agyAg8/xaO+s=; b=KYL5Hd8OhT8774uXk/64DuBTCkaMoYu/BwmiE0FWWZ3nBGjMRyhZ4jfGZyjkuk72vs dh2pYci4hE6a/bACDb9M6/3JgJ9rYP/zLMKS5MRhAP8NKQ3VzhRMhq6jArYsldGT+a/e L7w1i5LNO0HuavE1A8j+WhidlbpsafnzgZNX+e1KRkHiROTMkaZCeYP77Jbkjo065kvh sqPUAiLupCbBa8PItUo+bKM24ILNCiqBbYAPsZ/IwSKu0x4mOKts9K3mv4hXxuFY3uIA hgjflwz9MedhQ6eMbcE0bHUOesVVgKCneCITfpYZzblN6dpyx5eXZWe2dp+mNNdS2BQu 1Q2w== X-Forwarded-Encrypted: i=1; AJvYcCVuCYO3Sm+1N9QfxKdyG2ygMnYlNNoU8NBjftDZhJ5cT8Ce1oU1coeHGXcIhYLTrKJU9k73VHFQmA==@kvack.org X-Gm-Message-State: AOJu0YxK7PgcBRe1KSSFypG/YNCHwEc0UvqFCHzfCKU2bxs5fomIG2KT O1mthOgwzCnDbDK56PAJu1PUdR3jChegCnbL2l8vwWsfyLkSjDJT20hygoN4+gGRbnsKqXge6T0 x0e9/gpwzOl1k2P5dt36MmYif+PDk6S+ExC3G X-Gm-Gg: ASbGnct8QkYFKyFSYxydHkX6kwoyaMGosow5D8RQdIgPmcftt0IL5CAIyQ1W5WWeeye oiL6exD5IB44zL1RiT6R8cPbhql78keP3of1cIYjZyejbmInpr8gQO6sPai6eB4WAduUVUh/dtM PYIhLhV0gqfalq8TDZOpOidVcwv79aO7fa7Fo= X-Google-Smtp-Source: AGHT+IF1PpaLFEiA7f+EXz6qq+cFGjDAy9aw353F05vZULOtvLZWfHJ0lyt+gtzy2bQXRNEdC1uzl1vmxroPzPbxC0c= X-Received: by 2002:ac8:7d04:0:b0:465:c590:ed18 with SMTP id d75a77b69052e-47376e6ef18mr9498391cf.9.1740566024238; Wed, 26 Feb 2025 02:33:44 -0800 (PST) MIME-Version: 1.0 References: <20250224-page-alloc-kunit-v1-0-d337bb440889@google.com> <20250224-page-alloc-kunit-v1-3-d337bb440889@google.com> In-Reply-To: From: Brendan Jackman Date: Wed, 26 Feb 2025 11:33:33 +0100 X-Gm-Features: AQ5f1JqGuyBNSN8KYcK9T7xt4yQKGTXnaeYG0DwOUWhx-q_M4BMgBpShAvdqPrA Message-ID: Subject: Re: [PATCH RFC 3/4] mm/page_alloc_test: Add logic to isolate a node for testing To: Yosry Ahmed Cc: Brendan Higgins , David Gow , Rae Moar , Andrew Morton , David Hildenbrand , Oscar Salvador , Lorenzo Stoakes , Vlastimil Babka , Michal Hocko , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 591CB40008 X-Stat-Signature: 7zsng197y9saig33w9a1su3dra9g6rwm X-HE-Tag: 1740566025-619533 X-HE-Meta: U2FsdGVkX19NIZOAP4WELbI0sbnFTdZVDEhV+Jx9XEjOksrf5ePZJXczWWlSHxA01hJxj9oZZ6plolHIMzi786+Rtml4Jjf7hh7bKzsn26+jwSjmAJz0O2bK04aCLvBOlGsWEIokX6jT2yxMDzdLnxmNsFFGmndl0JlHEDR3ps9tO8UxCF3XbWm5bLHFnTtcgRoz51hXGgInD/uSPk9uUJpPr8qLRlFWXLQlHpwOgJ/aF0WwmHwXQd63o3/B7PXwoF2d4x49rp5UeaRTtplKDQ7yoAkxKuYbRdV5EbUhrzFQpfNHeynzRA3z18NTdOcSEvp4nyg2zjL5BrLXACdnQmXWlRRvGtkm0WfMwjRIQkTz4id5hqPSr7b2ds2Op7m8INw8vkrg67Cg8oRMzhlR+IrCQ5lIFiBH1yn81/bnXzbkyiF8JZV8Z9T8caXqO06LNVkYTXBU28f3xek9WFosAS4adjd4MBUTD2I863/Uv9QOYsB4G7HUt3c+ClzvOY1x/tqaMchC6js1b6AlEb4YHNu/nNnoa8Nq9IntMmUV1a4hgaciJ82yM4gYi5KsWpXp7cqzVyxLlIErVnPzRAHa4It/b6S5rQJ6X4muWOWPybpmPL0+fwD2ttkUhluP1A55saEsXWF3/ReSoZ9U39lUyt6ZI/wTyzv8yUwQKw1BfzYCs7NNtfyQ1D0TDdkCNUMuJTHwVyOSIxhBFt9CvEzwZh8HPX29Ls335OLC+8u7pj6mF7mKWpuR8w4x5HZmCp98ArXQgin2GvCOQM744aPxhh8KWm1YWYQmgtUn/dXJh+eeiHuj/Z3S+8a5jpUMyreHr2ODzdzEc2LylpG2GJeVRILE6qUU7tLLSdNlU8h1AvXDZLzzZj9nt96spjlCykNlp5ypn1TAbv+RafajL1yjjIIHuSKzMlCKShPFxnQHXyLH9WeQIsqYBQ6x2aL0Zg7rdfvYY9bM8MkEi+U2VZ/ cDL9+iZ1 wtOhW+70vtqhUbhoWU0afK7OdbaZOzps4ZKcrpamq3M20PYHLtvzL3IPZdwBpRGWkxLFsSL7yRE/DpmcT86E1LFadHc3JuwemcQ9vTFQ3SAvChsiJBXlJeJM/57/KsbWTUhbrqed2gpYgMpKazlm6wkzgwZxuUW0ZgLEwDJRdvEXbeyA5sHSkxMR4xU2tcGnD7eEyi/BOiO6vkUO2d6+X1A5N0HMNOeFdJfuk9NYa7NM72GIPsflifv0d1ixHecLzKIiyjR1rSKEJRFY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.230421, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 25 Feb 2025 at 12:20, Brendan Jackman wrote: > > On Mon, 24 Feb 2025 at 19:34, Yosry Ahmed wrote: > > > +#ifdef CONFIG_KUNIT > > > > Why not CONFIG_PAGE_ALLOC_KUNIT_TEST? > > VISIBLE_IF_KUNIT is paired with #ifdef CONFIG_KUNIT elsewhere (I think > there might even be docs that do this in an example) so I just > followed the pattern. > > #ifdef CONFIG_KUNIT -> things are consistent and you just don't have > to think about this very much. > > #ifdef CONFIG_PAGE_ALLOC_KUNIT_TEST -> better scoping. > > So yeah, shrug. Maybe David/Rae/Brendan has an opinion. Oh, actually I rescind my shrug. If we used #ifdef CONFIG_PAGE_ALLOC_KUNIT_TEST, then -Wmissing-prototypes would fire for people running other KUnit tests. So yeah the function needs to be non-static exactly when there's a prototype in the header.