From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33060C021B8 for ; Wed, 26 Feb 2025 10:54:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B497280007; Wed, 26 Feb 2025 05:53:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 963E4280002; Wed, 26 Feb 2025 05:53:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82CFC280007; Wed, 26 Feb 2025 05:53:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 618BF280002 for ; Wed, 26 Feb 2025 05:53:59 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DA79514126F for ; Wed, 26 Feb 2025 10:53:58 +0000 (UTC) X-FDA: 83161785756.07.1C8011D Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf16.hostedemail.com (Postfix) with ESMTP id 1F1A3180007 for ; Wed, 26 Feb 2025 10:53:56 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XxRTzaRd; spf=pass (imf16.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740567237; a=rsa-sha256; cv=none; b=LiTQcdmdlH2Pf7nlW5tDqNDr+ZXEJDWBKuczpEflR7xUlRn+nkZaJaoZrB6juka8eEbj2Z VPuVbE9oscu40d65hlJmSNIYZ7slORnCuaKEruxDuLeDQ30p9dXDsgaBCpDAXNOtKOAYB/ OxXR2yHPmGPl/wvu3ImT86VCLubMiSw= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XxRTzaRd; spf=pass (imf16.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740567237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8k9ussjgNfo7XH+19sy9pLzES4opNKoTTPxfbK8Va7w=; b=Cajpg30UzpKv1xOYY0Wn1tBf6CODwQ1WHFN90pAzCiEFfI5OmnkfyjjSwTdLZAuTeR5eJs 3h3AVxtwbOMA85+MUQ+WRU3bhm9LBn2f2rgvmLs9hiel+9yrD5lrnygB8HfZjY+x7zQsp5 cR3u+qijM1+VNz/a4EUdqzJ8rjKC88w= Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-471fbfe8b89so295281cf.0 for ; Wed, 26 Feb 2025 02:53:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740567236; x=1741172036; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8k9ussjgNfo7XH+19sy9pLzES4opNKoTTPxfbK8Va7w=; b=XxRTzaRdUaG1HMKUq3+NiqZPN6+A4OQ9YruV2iuTNbAp3EWkUCS0/Cu5wlTh9o+egt 8rxQaDB1c0VzCWwVsPrhTXDguy7tNi5xOyj4rX8wft4OYfK9aj/KA+1RLXLvv+tZTusP KlFMjSnsDJhKX9LV2RlZLYiFPNmc5MSyB0S0j5tM+pz9DCgVkoh8AHlltBipScEC7gYl h4dyrQ2ibaOyx851YxHI5+azYqj+KI5JrrQxta6D6HJhZ1O/6xCnyVwtygvmDDVe4N3k IL2k7RXuQSfLfQiXuM6OSXKTLy4EIbKRVmnDroCvsbOKFOmWb/dyhq9m/vFRE52EafsS kMgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740567236; x=1741172036; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8k9ussjgNfo7XH+19sy9pLzES4opNKoTTPxfbK8Va7w=; b=N6nh04FhSW3SJYiY5IMJPKvHIyBNkrgmqkGmTemf6ic69V2o3nPPGs1ALesO/YWiug aU5e+5xKeegvuSxemAg/dkXsOg/9dTAZjP4RZZRMr/Uk7CGOwTB8HkNcUK449tGqBukd ljzRfo36ncNkzEVtA0xRan6Ne588FVs9e7dj+cg35hvIIhEMmIdZWsh9SRJsTyE5iYiY ktl7l3eOHAlDm8PLPxNtwKSwZY82sEZrxqOSMy4PZ0H8yShhCgUALr3J6goNoZO8HQpL WRhrplxaGK08g6YJvAYKNawmSL54Q9h29TuPWvIiTXEtzLlAY7v4/8oKie3PWnTyJw+c t9mA== X-Forwarded-Encrypted: i=1; AJvYcCVCf7zr6WKJLkvBi4b1eehDSBk0vZ9QjfEEsAuUDRIX3wWLWzuiLC/VzmeYu+wDDGNba846mzJUEA==@kvack.org X-Gm-Message-State: AOJu0Yw3aecA+8S9TYl7CgZpfibo8O7dYEKb4bSxbTcDrsRtgYw1AnoI Ty5FwrAg6KWDWdQvCxbDD0I039RdHX5iesGmyQuoINbctvvXfYhuFjp6nWp5rqS1qvw004NoWgo C7cvdZ352+GHITYrbD0CZbtQcoxpcYsDtas3HkQpNLoXgVITAyNhYdCw= X-Gm-Gg: ASbGncsxCUpoKolMJzim/7SlNMky6iUm9d6Jf4HFQz0rmeDW33w2i5jooqQvonnAacC lFqzhm6bs8JvCKaegcGlS0GcFybOH4NHYaCkFmExAvl+3xNdOv38nFkOV4u2WVTuhcNoDl0VOwN RiBuNu+CnxsURKisxuGZpC4n/JGyKXd4HsP8k= X-Google-Smtp-Source: AGHT+IEtUNEH5PpKZRBVaacFBgRUGjAhw23RRBB5/3TVjGiyJAVndyaT1T40ETOgSGf0gVSz9gyrvjommoMUte+jJtQ= X-Received: by 2002:ac8:5a10:0:b0:471:fefc:f002 with SMTP id d75a77b69052e-47376e81cf3mr8973501cf.9.1740566831709; Wed, 26 Feb 2025 02:47:11 -0800 (PST) MIME-Version: 1.0 References: <20250224-page-alloc-kunit-v1-0-d337bb440889@google.com> <20250224-page-alloc-kunit-v1-4-d337bb440889@google.com> In-Reply-To: <20250224-page-alloc-kunit-v1-4-d337bb440889@google.com> From: Brendan Jackman Date: Wed, 26 Feb 2025 11:47:00 +0100 X-Gm-Features: AQ5f1JrJDmTOqjWilOWeguYEmp9d0N0gM7ZtyDHGC2VpER2YE2U_sG3dR8rzJXg Message-ID: Subject: Re: [PATCH RFC 4/4] mm/page_alloc_test: Add smoke-test for page allocation To: Brendan Higgins , David Gow , Rae Moar , Andrew Morton , David Hildenbrand , Oscar Salvador Cc: Lorenzo Stoakes , Vlastimil Babka , Michal Hocko , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Yosry Ahmed Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 7wkabd6ze4ekzi4bt93i7griuiy4jubb X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1F1A3180007 X-Rspam-User: X-HE-Tag: 1740567236-733766 X-HE-Meta: U2FsdGVkX1+XaiHPUl6Et3N4mhJawhLqJ+AG9pIbZJqTp6w6XDB0GqNbuKqz6nzQHt8rFZMNDq/WE1IBINvqnkU6zbSpzD9vBd92wckUrjpIV8fGiqKqrwZWN9IPCvySmpNxs2hvNozEiAFdig64L1Ev4ONQ5Pxp2moJwXwu7WjlC+AUxSVQMhjxDDoBxkeeUUFDOWMsEnTg8+tm55TbuH6+Z8d3dqzPqVPI6kPsohs8eDNGTfs9R+JJ4PUPfmB2Iil07ZvpTnx2jZqfZQLPaF0LJtpdBBMHF8Aatcwn/BWG0XNgzWzUS1xCankrbSt4FPGSuq8uIq0CoZbuNtN5ZpltjIohgHC1i1bYCMwsTZONcgedB4wuaZF8Dtvbwm4qrpd1kawqNSZ4tbeWLBoWkVBnrinTgkYPx3+T/0RbOUGdWwQBOT6txKcvGbj70STB0TUyUbORUfhxREQ6o7MAdbtC9axThXVSkh8oyKlWDqU+kBhW7KOGJOIHGcAYZXj+jq1pYMUCr+ng4Quv8gTFKVkl/TihqlKxRgUhdS3Wv630uohimDQgffXKSoczvMOuFAnLWj2CSK4H9LobD1CRm7qjvSIy2UZZauFhFattmHxriQVXfLh7DSShL+fBftvUdixZC+InOums4RK/GAshGMmroh4yQd/Y5S60U8W0poOJrHSLTrvM7ODMyilzWO6+C5Acc1i0l6TAFXTGx7cNUncFOTHluZGsmuFTy3MpnCq6zOABsW0RibyyT1zhTnL0rm9z8dnwGsJO1DTr0J+AKN6QDI/CmqjQ1v9uVwzDeM9LTpMWLWtvdDo6EvoySzLX0cxPJIHoqGe4sbv5pG9YQReN1N4hu0T6nNb6P7fYvurocnjtc22hSMuvQNQPz+NLdZ3ea1T0NSNCEF/G5QtNYhOeAGdUBbyxudtQ3nH2xKvtcEHB6tXBa2zIUrW26RQ54+MgSfMog4+cMBp7dZf r8QK48Iz gNOzw5vRX1OS+H0FhWRi/oIBtBr+oagS8+ySA1UwY8Ho+WB47WhZnleTeVxylULoOdL9VpZAeB8S5i8WOc74sWVtGGCwsdfDsXbu+V45Gc6zu25pr+0MTd6J7D0p6wOls2i8eljhn29PLP+rcfn1CxzAIgkgPUokN3szjpRgw8LzLJ2DLgsYpm8V8shbRB+SrfIzR3No3CjjxMr//CEJd/iqM2lkZ6l4f4rjiMgk7NjJSSh8kUQ9uudR/2F07L6BAQWZYmcKfdHIoq2Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.008841, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 24 Feb 2025 at 15:47, Brendan Jackman wrote: > +static inline struct page *alloc_pages_force_nid(struct kunit *test, > + gfp_t gfp, int order, int nid) > +{ > + NODEMASK_ALLOC(nodemask_t, nodemask, GFP_KERNEL); > + struct page *page; > + > + KUNIT_ASSERT_NOT_NULL(test, nodemask); > + kunit_add_action(test, action_nodemask_free, &nodemask); > + nodes_clear(*nodemask); > + node_set(nid, *nodemask); > + > + page = __alloc_pages_noprof(GFP_KERNEL, 0, nid, nodemask); Oops, it's ignoring the gfp argument here. > + { .gfp_flags = GFP_DMA32, .want_zone = ZONE_NORMAL }, And with that fixed, it becomes clear DMA32 allocations can't be expected to succeed in this zone setup. (Anyway, it's a bit of a silly test regardless, just something to illustrate the KUnit idea).