From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C834C4167B for ; Tue, 31 Oct 2023 09:56:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A869D6B02C6; Tue, 31 Oct 2023 05:56:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A375C6B02C7; Tue, 31 Oct 2023 05:56:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 925A86B02C8; Tue, 31 Oct 2023 05:56:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 800BA6B02C6 for ; Tue, 31 Oct 2023 05:56:08 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 51C611CB83B for ; Tue, 31 Oct 2023 09:56:08 +0000 (UTC) X-FDA: 81405300816.07.B625AC0 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf23.hostedemail.com (Postfix) with ESMTP id 9EB81140006 for ; Tue, 31 Oct 2023 09:56:06 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="JKa/PneS"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=jackmanb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698746166; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AiYZVx3GOT8EznjFnDKfN8wW+8MrAYI+JYHj3fNOMU0=; b=SHjBy8hKPvk3CUvdEeEHWdunKO8ugqD8hJmfSLtsZ+2L5UtdzJMQbMvLfg9H9p0Uhc3Dy0 N9fwNzzwvMTVZvjeigEwbCySwNjh5dC4/7pVU88nh6WiLmqyem0I7/lFwZFQx/0r89ekbf NuRRZWAn+BUNe/EbKbVeii8lxSfVonY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="JKa/PneS"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=jackmanb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698746166; a=rsa-sha256; cv=none; b=kgXQQ0yEktbYTUgCx+O8kHvlRNKvIOMZXZkHCXZxjooY6CKnx3XxYzb1ZqQeFlVQ9OYYBS imxYuJDiDG/3DEsrzuUIcuCkZgA6heaYkPDPkKXMvJ4DiGSXc6kZmo646I6oEeJGzIUl38 Uc4tZG8UIyIfab53254BMifXZCQad3s= Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-41cb7720579so184641cf.1 for ; Tue, 31 Oct 2023 02:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698746166; x=1699350966; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=AiYZVx3GOT8EznjFnDKfN8wW+8MrAYI+JYHj3fNOMU0=; b=JKa/PneSKf7k8tBnsC28zXeFMWhwbuiaxeKrXH0XPH9ACSVBnIr/lN3jBLKhBYlBi4 MMpGSMksPdyOt+7NVOEgEuyte3ppuPVjPMIo6fS9lJq3MJBlQtT3JrwcWTUJeVZVrJhA AGoz4Q+2xPGsj63bz/Yyt3rwOxTwAS12GoZR7pWQrKsupvHnCGKJjSYnbZbIqMoye9/K 4BXwxfgUz7WXVmrGVlGdHS5asU7wT94K4cEpHwNAtSZXkXGRyAK5OfX0teJLL3cTpEDv yQ7Y2yN0Bp2QIwWRDQjBqFfAokkjYYx+fQLcZNMlcY6JjAh6/sXdA1FS6fv/pR+YUtNP JwEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698746166; x=1699350966; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AiYZVx3GOT8EznjFnDKfN8wW+8MrAYI+JYHj3fNOMU0=; b=ifVch3JErPX9RuNYZKORCMvWJDrjJgFZGC90Kw2iywzqIQjRSQ/mH1jXbsbs3X0P/O EJH5hjy0KDQ2BjmKHfb0MHX0bEh3ihBIm+l2SbNCC1q8VSEofjyznaev1HxoU9L6VvqK 7n+BOBkgmSbEW5xRFCr1ePjnVa7bgBXTZW1Eh6MZdTbbTPRFoJ1Jpc8Ro6Sp4TcvDCky tZco8AYoLq3KBOkoO7Y4byNYEtEOdOq4m0XnaZHp64CWKMH3ye1FEohQHarhmjelw6Y0 wTkAiKzfEnekN+lnGaxZ0K/M/BQLeDg/QOSBrAcIOVl1KGrjzHP0YH3ARKMN/5cHYJGa pDNw== X-Gm-Message-State: AOJu0YzPkxxyHhiN55LEDj79bj6nBZ5luYSJlNFbc1KGU+dBJrJhwEsq IW312u6dip0rAX6yNi+zy04CzuHiPItAq0gBBqbtTGBY8dU+LET0FSM= X-Google-Smtp-Source: AGHT+IF3CAN6Pa617blo0rAnZTTxemLpYjAi6/2Dms/IOENx7/lhUesrjuRK16Khtd/8N6rjgSgV4E+NaqE8pNLaOyc= X-Received: by 2002:a05:622a:2898:b0:3f0:af20:1a37 with SMTP id ke24-20020a05622a289800b003f0af201a37mr139557qtb.15.1698746165645; Tue, 31 Oct 2023 02:56:05 -0700 (PDT) MIME-Version: 1.0 References: <20231027132213.3817924-1-jackmanb@google.com> In-Reply-To: <20231027132213.3817924-1-jackmanb@google.com> From: Brendan Jackman Date: Tue, 31 Oct 2023 10:55:53 +0100 Message-ID: Subject: Re: [PATCH] mm/page_alloc: Dedupe some memcg uncharging logic To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, yosryahmed@google.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 9EB81140006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ppnucanij8umepth3y4syhuymr5n7imf X-HE-Tag: 1698746166-284127 X-HE-Meta: U2FsdGVkX18UBzLSB4cFsQ/kI0QyguWZV1kyIgDyODjA9HEiRYIq5VTDM3qa8QpqTlPLxRHU7kBezgqj+3qUUAGC/yyhcKbOZh7VS0lUo2SapqAF43ZD9e1NyFbXRLNPzPTr9sUExzQOmkVArnZLjrkG0LnswX6eIdtb7BncUwAJUTrBPxANhuGANJsVlR7R8Q5VFI3ftrLVBjP9gEXU66tA1aQUeJ9rAlYq7r0ARhU0F92c3Onrk38A1o70Nd/+pVpcWCUNmuup0J007jsgTOPGeJKgj5NT3sfn10taH2rvuaO9PlkfbHf3njY41m8rY6GldHYv6e9NMMlq5m+Jwal8olRCRDEaLvvPqxGIP8qYXSN2n0EeKXgTXGdgfpWI0lXWAMb4pwaI9Sx5hFOZCIDzu367jvIITpcrPb2dJCj8ItNQDvkyzGQD3JU+Y/Ol6uRc84kx2lJrWa4OD1cs+Vk6AsyYk4B+08wuAqbz9qQmstTRjlur2hsZMVjrFf5COPr6WDO3eIE2RyEKX8rrz2GtCJOpXJPw9RZHH23v0sd6bKnlJR+DuWp9KTuG0lMoZZ/jvzNQS86tTvGBtimydKt++0TJzHTrVtffAP2kMlAo4dLmwJzamotiUoRFPduS0cN1UBmcGFr8PigdlERkBqabwQ32fNuaxOi0T0bTHOKLfY/2iazDKuilZbtZ6Wzi7GqRTH1rz3grLsA2wJKDxNhwqAzLXjuLxoi3IscSIDqGtT4HLUdrwnLlruJ7516B7pXTtGTdAvkIlp5jPFoaxhykjBurL+VxEH8+2dGVV3KIJIAdNTtJlXP77ajFIWETm4muVmAZ0gmuulhfaXQ/2RNgo+vdiy65xYjtJqDlecX50U15nXLb/IXCzyo7c8Z2EPAZH7zZfpQcjGSqUcVo4n0pnwrpzNFJNWyGUTKM/IE9gp80fgpekpmWqyTW8PpqbsL+fkjwSZH3fxLt8v+ BXXSfbDa jepmsJ67Nydn9akRPsp0yyrzAAc0JhGjZ5QWwBxUqJDleKc3lqzVQ7N0VvC/gZ1SnDeQ65AVAPxpRs5kbl5xMW3pEw7U8EEPytnc/bpWtrtoJ68Dlgz5ZI+Z8Ep4fnU1ppNFB3xWn1kWd0GbH2U6GL6BmCd5QsftHg1G0GfBtLf0DXN/QViiWxC9v964GUnsK1lMxXFETgdlnTw+gtZOX9ZLPNdaBhTqpIxCX X-Bogosity: Ham, tests=bogofilter, spamicity=0.013037, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 27 Oct 2023 at 15:22, Brendan Jackman wrote: > Signed-Off-By: Brendan Jackman > Change-Id: Ibe0f9941b6b24fc98ea2510a75d0a0d1066a2a2e Agh, sorry, it just jumped into my head that I neglected to run checkpatch and of course the commit message is garbage. I will leave this a few days in case there are other comments before I send a v2. FWIW I did at least run the mm kselftests via QEMU, results are the same with and without the patch.