From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E15FAC02194 for ; Fri, 7 Feb 2025 14:50:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77D266B009D; Fri, 7 Feb 2025 09:50:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 72BC56B009E; Fri, 7 Feb 2025 09:50:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F3A16B009F; Fri, 7 Feb 2025 09:50:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3BC1E6B009D for ; Fri, 7 Feb 2025 09:50:17 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DF5FEA1BEB for ; Fri, 7 Feb 2025 14:50:16 +0000 (UTC) X-FDA: 83093434032.18.FB8A5CF Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf09.hostedemail.com (Postfix) with ESMTP id EC68614000F for ; Fri, 7 Feb 2025 14:50:14 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=S92NelXu; spf=pass (imf09.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738939815; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NRKA4B0QRywDECdhm0qngkV9qa48DT0PdcDzDfPKBaE=; b=6rch69oP8MyTFxX3BqmHHLeX27v42QcAMleUInaqEvge77wxUBB+x/sP9KQ+Gah1BFX5WH vQLOXiSIDllZtWwU96VPyIFKwokCvczktrl7D30B39Qxno103P6f7Fj9pC2zrSuOMsq/iW IzAHWQ2/6ocLKlqMrKi4isup/eP7SmE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=S92NelXu; spf=pass (imf09.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738939815; a=rsa-sha256; cv=none; b=KAYff0rGlNYhTdhRBI7zXp7Yz3MZMp6EureS4j5HmvbZdcHDsPreNZEvjMV9kLzpmUMZMV O6dkyt9xrLv5imahyb8ZjDyJilGJgDE0H0rGr0ox9EwoYHC1STLIOYcPlSSP8ZJWIakbaW /Zy6VOSNABAM1Mt1CNiwU2cOdp3YIQc= Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4679b5c66d0so247301cf.1 for ; Fri, 07 Feb 2025 06:50:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738939814; x=1739544614; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=NRKA4B0QRywDECdhm0qngkV9qa48DT0PdcDzDfPKBaE=; b=S92NelXuve8jCb5yXynThAb/oilWaaeOZ+XP87YGJygUJi8TLV0NKkoQTFljKW5gQ7 2Jsu1LZ/GZxghJULI1nE0nnBU2JZHG6rWMaFTVCEbGkznVLnQ995LKTQIoJGyFRB/TqM KTvw6hnbE+CONXUvhP3KEwHd6QyWFmT45U7f+Pd2v9oc+4roRND+bVJ+QsEeyABbnwe+ OIOcS6WVQKGH+A3ymSWdETwRBN1A4C7/WjGztr9FGvdG3+LziyoTZlIcY1IqEClBjRjE w7k1IRJEs0CAblvk7jKzD1BzVoyojMJDM9GLdGdSoJR1U0EPTvGpV12LFBVptgPIeseU jHpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738939814; x=1739544614; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NRKA4B0QRywDECdhm0qngkV9qa48DT0PdcDzDfPKBaE=; b=Yst9f4ib18XbO1dDVkdesE+EiN8IHLGbOLCfSbW9tCvn5/5ss4gTTWKpgQIe5ZiiX+ t4I90JaG6Qga2udkwEef+CbW/FycisJ+Ci46RaoxWhiSwBwki32FoWfmaINJIR3JCOAU p75T5HDBrlONgWTIJr7qA6fzK1C2HEoGU8bhgaFRhAbWh7NTfs/bNd8rWL/FvXVg8zUF FQvJUazPWc+cr08ydohp41rLjHeBRTfCt4rVT1Jiq/jF7tJT9JADivV+wrxDki7O5grX NqUpAUWJB5Pv8/x5+th4zLKXPFIvoRizeR9PN4pTm6QTdHXRnxwJvD8OTahSYBysI0nx oQcQ== X-Forwarded-Encrypted: i=1; AJvYcCUT+jtiCgcQENUEnoJ84UrSDCQ8QpH9Xf4Ser7JQ6HMDJfjo5oELgGc5+PpFmcrUUube/nNQ5/afg==@kvack.org X-Gm-Message-State: AOJu0Yw1k8J+dYXzqF2OkKGbU5tbI7w77aTpZRLAbAa7IMbBaHmb2VWo MreDdc/KPgJwkweRkSqKpSyIp/aCYzygd7Uqeer8zUpb9SndGU69PhzIZUTjoG5WfEWRJubpmYQ hNiC3AAUSgxRWh174t6Pp3P0RQzb4Wxrhbrze X-Gm-Gg: ASbGncs+jX0w6SGMi/59c4LWoChF6u2ccAxiUDr1ahTA2dLCuiwuEY6ikClVbAofFiT VQbp0xV3xPDjiP8cU9+wnKqQltJwHv5rXeSynWKUN7hVr2mzC6PkKMT3ls1s5tCEt+k33i7zVwN Uo+mu7OWAMo8G2gTudofONdPaCJ8w= X-Google-Smtp-Source: AGHT+IEAEEFNWNC3YMS7vHR/Vyhhb/JRh9NfR76IzHXO0WhPYtv2TQGy1e9f08A2ZgjFJyV5vQBOkp3X9qqEndoNfto= X-Received: by 2002:a05:622a:1116:b0:466:975f:b219 with SMTP id d75a77b69052e-4716848912dmr3745331cf.8.1738939813598; Fri, 07 Feb 2025 06:50:13 -0800 (PST) MIME-Version: 1.0 References: <20250206044346.3810242-1-riel@surriel.com> <20250206044346.3810242-4-riel@surriel.com> In-Reply-To: <20250206044346.3810242-4-riel@surriel.com> From: Brendan Jackman Date: Fri, 7 Feb 2025 15:50:02 +0100 X-Gm-Features: AWEUYZkO4iB2Buw9lBqK7vSPHHLWafRCrJ_epfjdTjiqPQZ0YV42rJSUamkNClA Message-ID: Subject: Re: [PATCH v9 03/12] x86/mm: consolidate full flush threshold decision To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Dave Hansen Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: z3akq3skcx7z3r7j4twiwurukmwdmody X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: EC68614000F X-HE-Tag: 1738939814-398407 X-HE-Meta: U2FsdGVkX19F6RsXeZF/ZQmhx3IGjgcaCAOL7shAgMwjfiYh00WRXlUgXgpgEsnrZVqpwofMDO23NeJ7HGLR/8eU5761OM6hNRmFj8Heg/2Qg994rBQfa9ayy3ii3I8F99DvYFWi9X+RgqRiDgfWtwufwHgRWEB9xMtj5SDv/x/sBI5M0QffoRK1Rwbwt1SotocUto/yASQl3q0MjIY8RzDDtULf31Q/hNtvV0YR/rWTwuEv740Z+mpZK6IvsSj2WCM6mUFqR8nsfi9oXUNYk3/dSdBTj3Oec/X+/ijvosh06PNlODXSlS+HMWtI7PjAUR4ApFNZq4EXRLvI0rW8wI+8Sxbb/G8WF24cw9D7+PIRB+03PC+0l6htaIPmW8HIq19Sf254PZZxnHOvQ354y1016tV8Fdqr+bwPifuKdNCAf9oC2aObsLoYZLnanCwYgmsECvhXU7PZKh/8p8KAnXqDe0HC4KGzm59iRewtCGa9UTTlPKaf8GFuymntnLqNTqgzg33dqtzrn7smtHSMHrr4qV93v3+nciwKTye5SE6l5n/nxJ1fKBTS1OEI91vgLis6ZJsbbYuTkJIGHT8ZdKTGyTT/SH5VzeH1+G5L7fOptCowNJzSSKpNud1+uRHfakG55ih706JdYKCWt/Ulwus/ydqp7V7BmFKiUuwHb3hqppgXuu20rkhhxAeTaxeZ/ydMfF25cSZyUaLqIvvwQYiqKu0oviopFoJZAJV1DOyfbRCud+W0WyRuKvqMqvyTsvZbLrP7gUT0TR5G5usL+oBiYD21MHml0n9rlEfGy6frOfIVYnenWGntSf/oiEOyGwnguq33AdFuilChC/6jJFq4mDyFBKpQ+hzuAzS/uCBdgryOf/0QmKEnBniVQXfJwEPmD0u07eXTWqNQQxB5ZQ3czfuF/rTyjp8fOTl41Jj8YCIyD80Q7ZxYhCKNXlLsx4yrLz/gPkROmEWE5EP GWQBCfAd Tw3IuEvrTNdgEQoLLPQeAY2Qjqdlplth/pECoOPmu/dCdnJo4RjreRgo9n2TcoYTS+wRyDNpJNM2l8H6RlYG6DPyVjcu7em0jQYptL61JBJp+E6l85+LOzqeS1vxvQZkgIBGdE3onWfxCUH44JGepyhy9rUVs9hOYg107vEFplx3PowYrgAfG7OP8KLHo9kzRUnyxHZmOEeEzYlqc8rfcS3N1KO507nLBZqcilg6huXzns8nu3EnoKPjSsAROiE2LkLHh1m0UuJnn7YXcxgZ/qGdLhPrFGWGPueQGBpUJSqEMl8GU8XRtlWsHr67PSqESdguBKae+/ONdKsQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000087, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 6 Feb 2025 at 05:45, Rik van Riel wrote: > @@ -1276,7 +1282,7 @@ void arch_tlbbatch_flush(struct arch_tlbflush_unmap_batch *batch) > > int cpu = get_cpu(); > > - info = get_flush_tlb_info(NULL, 0, TLB_FLUSH_ALL, 0, false, > + info = get_flush_tlb_info(NULL, 0, TLB_FLUSH_ALL, PAGE_SHIFT, false, > TLB_GENERATION_INVALID); [Why] do we need this change? If it's necessary here, why isn't it needed everywhere else that does TLB_FLUSH_ALL too, like flush_tlb_mm()?