From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA16BC3ABA3 for ; Fri, 2 May 2025 12:28:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A52D6B008A; Fri, 2 May 2025 08:28:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32CF96B008C; Fri, 2 May 2025 08:28:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21D236B0092; Fri, 2 May 2025 08:28:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F40CB6B008A for ; Fri, 2 May 2025 08:28:25 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8ED7B14147A for ; Fri, 2 May 2025 12:28:27 +0000 (UTC) X-FDA: 83397895854.15.C8BA792 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf14.hostedemail.com (Postfix) with ESMTP id B2067100006 for ; Fri, 2 May 2025 12:28:25 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ie3Zh2j9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of jackmanb@google.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=jackmanb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746188905; a=rsa-sha256; cv=none; b=BH8O8Vyz554ENQo8UntQZAVhPevaoHkp5H34vICq41zfYf1k4CfGEeFfCOwPvo3PGEGCGZ //XZUd+8ge6p0Iz24HuobPGsAI+6WZbj53csqe1wIj3eLjq7eyRgePnLxIMfT+/SQwrRAW PCDRmqr/rXDECKGrSVOIX+eMnyGXLoQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746188905; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zmh526Lnl87MPrhQzMnGE+FlZXPEehb2CwuFJUvrAvs=; b=dl/KWAW7en99+SjoaAesgnzdaLy4VppO4jC9ckl9BJpDP8KySQ6+X7oJG0GSUzsgAiQ9Kb +1EjHH+f+6Lz0c446EfowRUTa7BqDdcv/IbP4WzEHPWlStrPiTIUfnRjqOknrfnlBXfAv5 zw+QLNpzcLHKdFJzsfq5ncMulT81pQk= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ie3Zh2j9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of jackmanb@google.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=jackmanb@google.com Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2242ac37caeso97895ad.1 for ; Fri, 02 May 2025 05:28:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746188904; x=1746793704; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zmh526Lnl87MPrhQzMnGE+FlZXPEehb2CwuFJUvrAvs=; b=ie3Zh2j9e86gANdBmpPLg9aoVEVef1TMtLZOAw5+786lCAa95GKTb7uUbp3X/8Jiry qoZzJ4ida3m76c7WaUdNYNK9WoEqgP7ba4pHgyjR5eKQfnUyepAaWe9ma3C6P7vyqrs/ K5+z4MdxXpzPqaHyCl7EBsHYeYVumiDM4wOzG8y5ogMDdozCDuyobklVix//c+epE385 1QpaPwBHcODgHtbQb5Tg+V0tnXBWMdD0UipcvvZvuDID19N0SwsqtZJ0p+SZXaQBtvuc 0yOIW5dYcjAUg+9jcBx3Cg5lFWxiLLvHLNYWVDBtcFCMf8aUlQ75PnUghwfqTW+5XAPe Uj/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746188904; x=1746793704; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zmh526Lnl87MPrhQzMnGE+FlZXPEehb2CwuFJUvrAvs=; b=GTCVBXp36CnzUfaLjhMDUeBHYvp0X3jquIDxpirAVhMu/7sKWwi2vdZP4a+5t4Ty/x 4VVw3ymItUhCvY8Vd2MA4lvmfy5I9ng5F7SAwJF7RwAaapRghv86GwSlnB3tJc3azFyv JcCSTgRVGFH285bblZt1uriPuSn6/iNvt82ahb+qYw5a26mrv+4H6CHHMdTWiqV/ohAS b1ylopam5QibSGkVdNqcfrDDAy32VJgLIlCz3DXlRYrPJGB1mFd5MAyzjL3oYE38M3SN 37I7dw7uVWiH0ZglcfoLwdSSUS9PLznSuXW0t83F9xJ1uwQW16XV2BFG9/ttnCEZZNEy 8eAQ== X-Gm-Message-State: AOJu0YywgzBv6NBlMiIJ539T79TOc2iIFYMR3ByTI5+gd56HLB74UJCP LO8bHPbqT6raBkfFA9gfYe04urNCt22pZUzg9b/I4f6RP0UcIS6ajSBRKkx9PgZpUO+S3cc8/Nx 28ufw3dEydFUwrYP/aUHfOUMBOADGfn+Nn2tp X-Gm-Gg: ASbGncu674Org9jDgnU/gDUf5U0x/KhB56YT4l2V4bS8pNUyDHmjlmMMU1uDcYVWtrE 3IQvtunhjD+QwmxWUebzbAyxkBjeY3CWryS21slKUU0sCKPhkPE7OAze6nZj7sbH8DRfVLoL6X5 I8hq3kJ55zP5oHVWBmF1k= X-Google-Smtp-Source: AGHT+IHV5VcT8qrVNy0hr0jvUhSwI2dzYIiIIPkfLEO6b3DLFwV4/3IH9Q2Vd9a3EkRHSd6EP2O2Joz97r+Cabv47lM= X-Received: by 2002:a17:902:f24c:b0:220:ce33:6385 with SMTP id d9443c01a7336-22e0797c6c3mr4184255ad.9.1746188904130; Fri, 02 May 2025 05:28:24 -0700 (PDT) MIME-Version: 1.0 References: <20250501163827.2598-1-ujwal.kundur@gmail.com> <20250501163827.2598-2-ujwal.kundur@gmail.com> In-Reply-To: From: Brendan Jackman Date: Fri, 2 May 2025 14:28:11 +0200 X-Gm-Features: ATxdqUGJ69Ia6WcMuCEFCnuGbd5YAV_Udy5i81oo77n73ry6AVBvmtLYMJeu35Q Message-ID: Subject: Re: [PATCH 1/4] selftests/mm/uffd: Refactor non-composite global vars into struct To: Ujwal Kundur , akpm@linux-foundation.org, peterx@redhat.com, shuah@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B2067100006 X-Stat-Signature: dkezeoiy98fsbknwh96p6b7tofbeodg6 X-Rspam-User: X-HE-Tag: 1746188905-703081 X-HE-Meta: U2FsdGVkX1/yshZyNk47U8ePrwpacxwvKuMqg4Zd0r5BZ5b37yfod4IEkyp2l9CvGESpvDexqukg5yid1U9lB8BTaAiScCa/7fOrn7WrrBoLa8BlW4pv2DRur/fYJ7roaQZtOmGRp6fgBkHvWbEEskkMsBVxDKWZpLlZf37FDJaPRYxMIBc+9ZR7DK84MhCAYDAKeqx+QaswLL/BBKV9oSHlOJLWaite2XKzuE57+t6mq1JWmGdMNZCaxy/6g5h/UyY2asrBpm8xsOPcUmHjncAmqVeaKYI9jo7cs0H/j0qRfhQRrU5wMBNcgfJzWYMmp64NTErhDnb0T+1vC07pjKRAjEpN5pAiVC9BA2Qlcn/K22koFKwwcFxTPEORudR/bdmkXlwxlMGCqd+Ne4dJr8ATehY0qm1yl5Run6t0WnQyM6h4U9h5heUdExiJ7apeSOdONCTm/LKKaoXr0uYjjiQMXJ/O7ox6RO24FrIFnexxBTCMuprnz2vqAudhLxtn8s3ltSLLsIxxbGIT9yC3JyjujyvyE/oh1EQUml3fEjC9rOgOvZjvBAQcfwlQ/Uno54Eir2J5PTAJQwK2WYue3p3MI90soooDrVS1A2szrrfKdaLBp+b5ZPjcHmKWuRhZF2fdefEHY3R5WhPCPESnBaNwmpCJZOvcQsl7amfRfwmtntpjNFfGuVFvi3laP9fZk7sLTCwna3mWxyp2RND0BAkagM8d+SzQQKrLZcinIHzUAcX0/ixQ39j3ZLp6fpdj+qji2VlrhnB5Ax/+yxk79BUiZOunBuQn2exUPNoM1xzHwOehiMZxaRZsFYNq9Mm+eGbzft41A4mwkf4GnXOAn26kDsK/Q71NnZEOq9EWy2sIvo16h7Hz5eQ/Ko5KqRFv9Mi36btVk7z3Fv+AnYaH9mvGmgBsRJaL3I86+WqJxUsNZh+dhjrUlrFI+8x2Ds3EKghggOkJFt8qA8yOmhh ABUCNvdq xIac2Pa5zNk7ZkSoFiKESrpyQH32kvg+K0RXkEn6JS2oJkxNvhUv1JipcDRG5fq2yUp2RlQ2mk3dObkOiVMXg3zJSRjKVN1WPwY1l9vi9NSc5tmmh9aj9rT7Gle2IjPp9ZI5sq1h/N8kjUG94c1tko4G6VkZ5YIn/8fZdSxykRAQePmT+IyFSlTBZ82XhNtN2TiwtUJFlaoMr2kqWPV5cR7QGViqnHS9X3mcSi0fvKNz6m1ChiOdo3Vxr2je4t27qrrjyqmQ7rYLuu26KOGwdJZB1oktyS9WCb4Va X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2 May 2025 at 14:16, Brendan Jackman wrote: > Little bit of indentation mess here > > I don't understand this code but since I was hurt by these global > variables I had a look over the diff anyway, it LGTM (aside from the > formatting nits), thanks. > > Reviewed-by: Brendan Jackman Wait sorry, actually, this deletes the global vars before it deletes the references to them. That's gonna be a real pain for bisections, please can you restructure the series to prevent intervening build failures? (I.e. if I apply just 1/4, the selftests don't compile).