From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F4E2C02180 for ; Thu, 16 Jan 2025 13:22:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 816806B0082; Thu, 16 Jan 2025 08:22:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C6A96B0083; Thu, 16 Jan 2025 08:22:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6673E6B0085; Thu, 16 Jan 2025 08:22:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 495CA6B0082 for ; Thu, 16 Jan 2025 08:22:57 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EDA6380464 for ; Thu, 16 Jan 2025 13:22:56 +0000 (UTC) X-FDA: 83013380352.14.5FDC768 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf19.hostedemail.com (Postfix) with ESMTP id 281E71A0005 for ; Thu, 16 Jan 2025 13:22:54 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=an6fU4rS; spf=pass (imf19.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737033775; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SixtGEHyx0Ll20sNHrYW42AzL6XqkNRKNahYOvra4Ow=; b=q4hGslGfpLWE/laKFkP1mAsuof1Ke4OaqHaMZyNLtoEZgzw8wsDJJBWEGBap5l5SZscSK9 PsQvqs9xpdqEYBj8d5mSqipRQrPmVnaau374uzUDf7ZpS6fueRuJGMBUlGhLclun7Ew7MJ d+Q6CFk/r/XNV1CFw4QKntr3+tBkn00= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737033775; a=rsa-sha256; cv=none; b=hTkxhVF6Tilj0NOcFFy/PCc7mp5Qff65k6xD7IUYXY1iL3JNG3lbZZk0n2t2gsC07eAuaE WcBDuXbrXuVh9GGnS/W9bf5aTmkTwk3Y3UG+LL/6wttqyWSSHNIF8KrUNRa0+Zq8zJoRIv 0vznONamW4/InN8cn4ryo5taor5TlGY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=an6fU4rS; spf=pass (imf19.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-4679b5c66d0so194491cf.1 for ; Thu, 16 Jan 2025 05:22:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1737033774; x=1737638574; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SixtGEHyx0Ll20sNHrYW42AzL6XqkNRKNahYOvra4Ow=; b=an6fU4rSdQnB33jW9Sup1YagBtIDYSc3wM879Okze10aKJgA3eFnTPD9HBB3OTnCvs 7q+esC9u4EnsL/ohDU/1gLyr1OOUJarxWPO+Vg4rg8HoLsZm1zBbIrDnpor3tEOAK9Lj YZNpKcZgP8h1/N+8FCS2MnL6T57NE3QHBx0CKDS0dbQCnaPjF+KcwaO0R5VY44PfYISW Xp1U9IevnsPpqVlpEsv3NeTjVqfAu1fmboIps/4MpxeqDeaIIKyN5ZuNZsbPCaSe5CuW d7c/gEv0YpXXUPDkhlyknMMYvX/gHk9tALcpC/s/DpXLvw+8A0xpCG/iIGuKY71Cnsuz uWLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737033774; x=1737638574; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SixtGEHyx0Ll20sNHrYW42AzL6XqkNRKNahYOvra4Ow=; b=DOMrAthY7PEOs+2+pzaKXm3KHnojMOEUxYEm3N8dAllBaJf/zRhSIvVDL5FJzbBOMx MzvwXFKRHpPvLaVJuGHPBOGWWCnDP/NJjp2rwPYmLAfeKOkTruqFWoxY+jsTs+IZ9r4+ /6MRohyiH2uaAzEQ4yHnVGOclEjjAC0vNlK1GDSzU3j/1jFjj2xh6ZV9qv84w759sk7r q0laNkh0WGf6UkqV9jX6xREcOz7LgfqdpnhIGwzLRJJThcjr/KQye6Z00Lu5AHTdoQGP Wg8+iaSpuCjdsXoyBpJ1wh5pMOTCbC6lcGlfTk+bIIJW3mtsp/CVDjTocPsmbSp0v2sf nKyQ== X-Forwarded-Encrypted: i=1; AJvYcCUcofnw0Uf6lcbIfovIQ1nvKRxXCtkEyr9s1G8IH34lpI4OIgzfogDDkRMZILm8JG98ZbVf06Mwwg==@kvack.org X-Gm-Message-State: AOJu0Yx4aOel2Tc+LdFt96xzKyqfVp1cPAx6Nw/sjjyZRB8+vbnR0cIe Gpb2Sl778m4DBFqZlgRAK/2or/Qa6tMSabkSSt8IPAfmsaY4uiSmocQVVoRxWHtUD3P9oSvOfHk iN8rqk8nOYskprHCt9vpDDhy5Zp1WVLruU6ta X-Gm-Gg: ASbGnctNs13s975TsdZMREehPR14W0oUxKAscW2Ogc75vJ28KFldOadCpyWUOcs67TX JJcJUuQWM17Z2PIlSqt1gcKgngiDjngFuWA7rqhc/V1EKvUz7NBBUfI74KkKdXyaMUGk= X-Google-Smtp-Source: AGHT+IGgdmm3+dKyYphBOJrkDF9RqCEL6Tsx6LZHIZIcfENKNOrXYM9LEzERENIX0F6hf0/LX3P/eN8RFihp6QDk6j4= X-Received: by 2002:ac8:5f11:0:b0:466:7a06:2d03 with SMTP id d75a77b69052e-46e0545796amr2768561cf.1.1737033773706; Thu, 16 Jan 2025 05:22:53 -0800 (PST) MIME-Version: 1.0 References: <20250110-asi-rfc-v2-v2-0-8419288bc805@google.com> <20250110-asi-rfc-v2-v2-1-8419288bc805@google.com> <20250116001858.GDZ4hQctZe_PFvJ0AJ@fat_crate.local> <20250116102747.GAZ4jfI9HG3K-PW7nf@fat_crate.local> In-Reply-To: <20250116102747.GAZ4jfI9HG3K-PW7nf@fat_crate.local> From: Brendan Jackman Date: Thu, 16 Jan 2025 14:22:42 +0100 X-Gm-Features: AbW1kvbCtSg9vNMeYe9Cs6fkL4An-kckhSPmCiLhYkfVvSqDDbiTwg4NAXTmVUM Message-ID: Subject: Re: [PATCH RFC v2 01/29] mm: asi: Make some utility functions noinstr compatible To: Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Richard Henderson , Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Brian Cain , Huacai Chen , WANG Xuerui , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Chris Zankel , Max Filippov , Arnd Bergmann , Andrew Morton , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Uladzislau Rezki , Christoph Hellwig , Masami Hiramatsu , Mathieu Desnoyers , Mike Rapoport , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Dennis Zhou , Tejun Heo , Christoph Lameter , Sean Christopherson , Paolo Bonzini , Ard Biesheuvel , Josh Poimboeuf , Pawan Gupta , x86@kernel.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 281E71A0005 X-Stat-Signature: 57j9fy1xx1383n5nytxudz1pmmyqy66p X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1737033774-57417 X-HE-Meta: U2FsdGVkX1+EUtABeV3kDfUL/qPxMGZSa78Mcf9KlXtdTbjB+ARaIUtx3rYLYJ1XtKdV4BqYkgNCKDKLcKFGvj1x8CrE3KuHAGDC5ZZYSs/gEK4fXWHtQNNj0xnG4fCWcy0qd2rR4883YRre9Wyrcc8OXgBL6LOgvnGxgTLQ1JFfxpOLV7OIZx5mHreZ9ppwtr9woM/HBLyNYelRmH8VSdZHq5EXk6rvO15qbUhZQSgKOyZdAdMa7Gz/2nkJo1yyObG6dMp3H+9XeBV//gsKutE9wRpXqW+hQ6drKsk/G4E9qJ2lx7qBPNj+8MpfXSpa+203nafR0XG8lGXLxCrQ0R9S5rO7tWtERgEmgThYEccAdcQJ9ftPwxIDPHTUG1U8e4Evi+4B/7L2/c9HheNJPqKenUhGXI4WZkJlGw54jRyKwFzZOFHiiu8euhKwe+7ULuiqnfV6Ig2neqfxeT9CpsuCXQU0HHVKnajFTU+2MF8kKwfPaCxlKZ1+7Jc4PELuIjvxoDuxVmP+fF8AzKhrk8YFkkzkMHXh+XxPwKSu/V/63xGr3GeWWta9drs3klQCrzi7e2C5RoPKTekKKpOOTgvtHS99ttbrCoLs1lir8CTwIl9M69Av4O582Pq6ljnMQCoGLYIp0hgkY1/hR7WpYQ7fUEMwTZOrPmR7GqG+CJuYc6AE0e/vgyM0yJWoupPfoZi67N/Cpa88B0M2dQyQPPBGJD0i4SOoO/ZS9gZZEnD7qgu/ZIP3dJLp88eQjH4r07D4X1BGPTEANm5Gaa/Ips7JNMYqViPNwDUPpp5RqExQ57GDWWN3ntsH7iD6btRllmnY8k0JhuU6TfbxtkfgmTh5PsFKrqjfMG/n+bgeWzRZHb6qCwrSJuTRF7fCtw3fhuXfXN49gTOpaEAlxgUsAlyQBqSmoJsoOai1eYCIkR3BGGwsqxM4NMU42/Mmgh20gXvRDB9E7KX4lkilES4 L0VbBnF2 pOtgJ8Om4AE5j4eDtVloAyldWA1xC2+u7rIt0BfW17OWRfmAsi2/29S1YpORviYmKtUaU1ls8iuAQmiTvw9nFvd2Ab6oLC9PtQMw0vj5RjTSWJJ4dyNIOFUmSjM/sdK5R4/Xd24npEmqhFvUk5kRz9NW0jTvzAoeLC9yifGN4B3EKils7dWkw7ZJPMtToqOR8m0W7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 16 Jan 2025 at 01:21, Borislav Petkov wrote: > > Unfortunately Thomas pointed out this will prevent the function from > > being inlined at call sites in .text. > > > > So far I haven't been able[1] to find a formulation that lets us : > > 1. avoid calls from .noinstr.text -> .text, > > 2. while also letting the compiler freely decide what to inline. > > > > 1 is a functional requirement so here I'm just giving up on 2. Existing > > callsites of this code are just forced inline. For the incoming code > > that needs to call it from noinstr, they will be out-of-line calls. > > I'm not sure some of that belongs in the commit message - if you want to have > it in the submission, you should put it under the --- line below, right above > the diffstat. Sure. I'm actually not even sure that for a [PATCH]-quality thing this cross-cutting commit even makes sense - once we've decided on the general way to solve this problem, perhaps the changes should just be part of the commit that needs them? It feels messy to have a patch that "does multiple things", but on the other hand it might be annoying to review a patch that says "make a load of random changes across the kernel, which are needed at various points in various upcoming patches, trust me". Do you have any opinion on that? (BTW, since a comment you made on another series (can't find it on Lore...), I've changed my writing style to avoid stuff like this in comments & commit messages in general, but this text all predates that. I'll do my best to sort all that stuff out before I send anything as a [PATCH].) On Thu, 16 Jan 2025 at 11:29, Borislav Petkov wrote: > > On Thu, Jan 16, 2025 at 01:18:58AM +0100, Borislav Petkov wrote: > > Long story short, lemme try to poke around tomorrow to try to figure out what > > actually happens. It could be caused by the part of Rik's patches and this one > > inlining things. We'll see... > > Looks transient... The very similar guest boots fine on another machine. Let's > watch this... Oh, I didn't notice your update until now. But yeah I also couldn't reproduce it on a Sapphire Rapids machine and on QEMU with this patch applied on top of tip/master (37bc915c6ad0f).