From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 163B4C021B1 for ; Thu, 20 Feb 2025 15:55:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A437E4401F8; Thu, 20 Feb 2025 10:55:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F3D34401F7; Thu, 20 Feb 2025 10:55:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BB984401F8; Thu, 20 Feb 2025 10:55:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6E8874401F7 for ; Thu, 20 Feb 2025 10:55:51 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2BF1952080 for ; Thu, 20 Feb 2025 15:55:51 +0000 (UTC) X-FDA: 83140773702.14.C3B6EE0 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf08.hostedemail.com (Postfix) with ESMTP id 5C63A160012 for ; Thu, 20 Feb 2025 15:55:47 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=QhxuVNbi; spf=pass (imf08.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740066947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xqf65nED3NYJwmlnVPTvXBomckILIduk3AQAFu4O9k0=; b=qX25ai4KeWOyDdGYdKUsUscOjvF0P4nFs+NgvO+ClI1PqtSQR4IBGxiDVJv0WEv/F4Np7z /Mz0/BBKShTtX46GGLRnFwADNMIVqDpnb7WTTAzu2grJzkCs/gxxLAiGRq4C0J6rlo7mUj Rm4qKBFaBW1btyQVkZDcWBUNoQdc7Us= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=QhxuVNbi; spf=pass (imf08.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740066947; a=rsa-sha256; cv=none; b=zhpeiNwoF70BbbK2TMLRYMUQz1dvHFE0Kkjz5GyaIsuhvBLeJN7V+eBRe3Hb5HoBI0tnoE AeCkQA8HWPOGehZfV6QU/LkOo+0xKsNezVxTtRsDVChO3ySuKlpLGItB7UCOxh4IIMt2Qk 1JfKkUiBV2c1Z0ZPVHSzoPjDlIw4GDg= Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-472098e6e75so300081cf.1 for ; Thu, 20 Feb 2025 07:55:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740066946; x=1740671746; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Xqf65nED3NYJwmlnVPTvXBomckILIduk3AQAFu4O9k0=; b=QhxuVNbiqFVhoNthoV53ELhhvrQfoV1rr+mk8Fh3qu/wy8l9z/URFYM8BDvm11fv53 5z1oLY3OmE0E2nBDBNG0u7dmkAeaeWsxeEcgN7kmsfi+mboTanE9p/FX5OvdjjzrQQm1 Txw41r0li00/tkHUl1+z1GPo1ck1vvd4tCb7U+vQOzl3sQl09csP9t8fLeVetvmMdnGN MMLsD8HvqTMM/2mONIqtQv+16r3kuKT5/1H0+TseuDzzNzU+KijPkAA9bW6lb3UpnurG DYPWrHpMsx+AdGRe8WRhhXiZVxxYwwBSAodTSfaRzvvzxlaarNi1Gu8f6Hy/r9ehqWwW Ur0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740066946; x=1740671746; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Xqf65nED3NYJwmlnVPTvXBomckILIduk3AQAFu4O9k0=; b=J5QCuiuus/Ayk+kAQsUX8+fAtr/fLVklD3JaP9t83fjO3xJCyl3qZNuVPBPIcPgjHr EF824CXamRfPgjra2FZBxV0weyo2QJaGQwli7D2a/WKWF1uqzKSOBG7fRqTxfJc4eIow 6JllUMdQ0bUWAE6KE8JvbaNaCqL8qt/FEV+2FIyGNClGlJakqFWCFn9BzDJ8WSLi72FD HKWnWTubaSC2h+mm3peBd+MZrcf6KR4RE2d4vDUgDc5gerQQFXvcBee9JLtQs57mvcqg Buu9ES2arhC7t2b19tYulEgmsRsHz+KBS3WFaHhXtRMfjOmF9vc6sDUodoLm7IPZd6n/ OEMg== X-Forwarded-Encrypted: i=1; AJvYcCU5tKPxGa7qPyIdmjPa19b2MlFH1tAtImqdQz7hpYL5xx5D3ZkdBIN40DxXt0IO4YEOTwkGwkMDQA==@kvack.org X-Gm-Message-State: AOJu0YwlmgjQdSxx3rA5+PEfQV+AZYwQXXzGSqMdOdEPh0xeWlshvN/3 EPK6p6LR8v/y6ou6vFQVsJLMP99LUg5TAZ+eXESCHJXZXf0ZrbfXLJC1iyCl4U54qNhcf1E2k9M V/anoQ/8577R86rhA9uMh+KR0uZ2Gq292cZ1h X-Gm-Gg: ASbGncsvdAAUN9h0AeIkM03kQIEXBMFjFBAqqNMUqhHe3oe89uYwnRcEdajNeH/HZbK 1Clde6lohoEK4whadoFE5Qck7TcLrQtRHA+OWS3ec8ZE1E4DerXpa3CZrnl5Hh9nigX0zOna/eG Est1jkr4kO6NiwzwlqRqVPZ9O0xKk= X-Google-Smtp-Source: AGHT+IHOdWO/3Z/ofouQMFSA/yPXXraLlaV7hAkItx8s9YCocwCXJATlNZf0CcBawq4mps1HDugVCO75m47tbi/iLio= X-Received: by 2002:a05:622a:428a:b0:471:f257:7a5f with SMTP id d75a77b69052e-4721711149bmr4179751cf.13.1740066946034; Thu, 20 Feb 2025 07:55:46 -0800 (PST) MIME-Version: 1.0 References: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> <20250220-mm-selftests-v1-6-9bbf57d64463@google.com> In-Reply-To: From: Brendan Jackman Date: Thu, 20 Feb 2025 16:55:34 +0100 X-Gm-Features: AWEUYZlPMDgaqu__QrVZ4KFp2sTS1uCxjoo7b3B-CAxYQcbUHy2R1SAZIvagXmU Message-ID: Subject: Re: [PATCH 6/6] selftests/mm: Don't fail uffd-stress if too many CPUs To: Dev Jain Cc: Lorenzo Stoakes , Andrew Morton , Shuah Khan , Mateusz Guzik , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 5C63A160012 X-Stat-Signature: 55ywedmzz4693iuucewko7dn6x64esa5 X-HE-Tag: 1740066947-826975 X-HE-Meta: U2FsdGVkX1+Ryj+Vn58O7I+Sq0sHdCyjcON3oTnGp5tYSo+NUPiUYGhO95+X9fEHr5K8LMneasqGk1K/Mgt05DOqyvqGghk7M8/UDqJDfSGRrq5OExuoWgxC6W35WMsfUk82Ta4SWv2uveQUtFxCQfxyuKrwqbCMGGeUbWx6Yo4/IAH0qvo5u6KuOPz7OjYOtp1ym5oK3SXselSzbN3ZQTrQ3S5YGHyPLYqhrHdP2Vtva7ebxb2T6pfTMlyn9iAgClc8rZOVeADbuuo4sEivDy80o37uH4D7g/2BmO93pYVIHLWJtgFQhzZlBJcWUEq9FtUOm9QmUWae68B2p9wl2d2lD2iBlD1VPY6G6N3g4ncy1hz7YWhlDZ+8URWNgIyjtBDAV4olzUd3Mb7S2m7CpFwl4b3UvZsSxP1cuv9wXxsBAOvH65xWZG2sQrl43d/wER8nRJ60ZBkgOBDX1K23t1SNXFMGG6zKtReCkLlgxmfPGLtE3y2+Y9ORBCeY7d17eNXK5vsQzviaVxwwyXpVBNemB6uJ4Ax6Yr1stCuWgMejXFrCNeyVGH/sxkkOT88s1H3dI+TT8VolbCy3KfcEXGavftJMKxRTlxpXwG9EKKPvTS9lG5nXg8nPAGy4b09QskqAmpOyVQdsiRNfBuyrSsCAm+ljwHfY6JmcRjRShulDp7dKe/D+BqosJtbXfviXiQZjP8w6nGQi23GHkdraHH/8yQfNLjOQ2yB/b/iwBihphGP7rsIxOXGq2H3tPvixK0+VPGnzXqETGUKoLXM+0FPU/nGoHGKJCo26c1saQzUZGKb54n/uNnf3+t6kSt5yoxtvyIdOLDjrWeGKZ3ePwYG6thh1+0f748p0wdx8Pf5e3JuBr/Ij4ARnIwvCyLAenjNAgrii0/DJN47bQhbWr6wDazs0eB+WBsekYkBFjMa46n6NOOU6K9L56t9b7TNvDQy5EJr9pbDP4atAhZU fT0fd4cC f3Tr6VRhRFHn20lkxKBB9pCFv7UfQaimkpFLLN+Dp7ZVyOjQb081cBFiqLKdrD+f6lloa0ay/I4Xn+MgTK5CXTiEn2AHWljlMWWcQA/L5TvRweDHQsgR5hFXO98k2aNTfemh99OkhQzHwemjzSiMdO4hM+2thBlP3wSSfMV1zwJzOhE0M1Fwezw4KkppgVo98CpNCGgSCTI3JAQs7cMghbcX1M3v+mb+OtS413CwGA6QzA/yP2vP4ryBwabQEXFAILpo3 X-Bogosity: Unsure, tests=bogofilter, spamicity=0.496201, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 20 Feb 2025 at 16:48, Dev Jain wrote: > > > > On 20/02/25 8:33 pm, Brendan Jackman wrote: > > This calculation divides a fixed parameter by an environment-dependent > > parameter i.e. the number of CPUs. > > > > The simple way to avoid machine-specific failures here is to just put a > > cap on the max value of the latter. > > I haven't read the test, but if nr_cpus is being computed, then this > value must be important to the test somehow? Would it potentially be > wrong to let the test run for nr_cpus != actual number of cpus? Based on my _extremely hasty_ reading, the variable is misnamed and it's actually a thread count not a CPU count. I can double check that's the case and rename it. > Also, if the patch is correct then will it be better to also print a > diagnostic telling the user that the number of cpus is going to be > capped for the test to run? Sure. The level of detail in the logging and error messages is extremely low here so I didn't feel like being too anomalous, but why not.