From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80060C02185 for ; Fri, 17 Jan 2025 11:23:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D787C280002; Fri, 17 Jan 2025 06:23:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D0138280001; Fri, 17 Jan 2025 06:23:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA15A280002; Fri, 17 Jan 2025 06:23:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9B78D280001 for ; Fri, 17 Jan 2025 06:23:44 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1CE24816C4 for ; Fri, 17 Jan 2025 11:23:44 +0000 (UTC) X-FDA: 83016708768.07.FD984CB Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf16.hostedemail.com (Postfix) with ESMTP id 4ACD318000E for ; Fri, 17 Jan 2025 11:23:42 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=AYpQNaXW; spf=pass (imf16.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737113022; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FIGX2U5Y620ytLuHZv9C2YKRXU6LkFVVh5lOzeeXil4=; b=LuiF0rS+qBPEX3YZ9ZRaawgnxLzlE4FinOk0Q0q2brNaPAKXeLDCPayOPlgT138pygLwQ9 LX3WFpcrILFj3q6M2pd7/LYk0u2dRMFN/0KYY6PSf5Tsk/lncypow8xrVACan6z4UGFZRc k45KAYcanY6zBWcPDmRsMUCv1jySvyo= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=AYpQNaXW; spf=pass (imf16.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737113022; a=rsa-sha256; cv=none; b=R11qw8oeVOOGUNVbCeEXWrSw167e1kyD1LoIVXC7L4i+bxRQvwHfHklFy89vNIZlQ437oJ RwsjslzXJ7eV3KZMSHkHTgOEA/5bcf3PthgbEKe0r+FrdmXyJa4NipW4lDSA7PB1xx6aj/ f8cuiCOuZ+6Oe4XOVD/30/WClp4dOzs= Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-467896541e1so208421cf.0 for ; Fri, 17 Jan 2025 03:23:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1737113021; x=1737717821; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FIGX2U5Y620ytLuHZv9C2YKRXU6LkFVVh5lOzeeXil4=; b=AYpQNaXWQxWKNZN72F1E9MM1sD0xjyqy1JkQ7HfTwdXxtKyiKYIOyrz+lC5rL+GuU8 IXswLYwUk15Tay9MRfBQMa2AIoTXFI/8hS04iFyfFycnu5N2c2JZMY3avjSbcznzsZPu tXE/zWQZRaNaBwSN3F5E2Ey5jKLjJ8Tl+xi8pBMo7y5PiwY6vcoLrVC17fvJjXhKbevI xVFU86bb3HHQ+cyBwwNmBK4PkF9NdvX0SJpxqMrqOKif6yWtNJdiUw/LLzMAfvC+4kBN 7BQoSKbjLrHRwBATEItk8KPqf/AtxIvrEciPktXIrYJBeTszzfxyXpsLWTSTosOtMWtQ CCgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737113021; x=1737717821; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FIGX2U5Y620ytLuHZv9C2YKRXU6LkFVVh5lOzeeXil4=; b=OVk1SGTxlBV0VvRTdRh21ikVXRckXrJuEiwJ/+OUdz2WDPv+BWZtvs63lidhu8hCRg 7KOPP8KV0V7KvJskTgkclV40hXWZJg6rQZv9IyjLArdoqL+1sW8EqPoOkiq8GRG6MOWD zReZsyiri8BZuxyE7M9AyKzBBi9Ls1m6R/VwUrLCV4ZtXU8dJc5pGmyi0XTwFOO2dg9I msiBuZs2MxM0x+BZKmfKQN8XjGns/en/X8pKFHeMgDrcusaWs3rhs1kBz+/Ruv2YFXZd YlVSl3DafkU59xSIUgxOBOXmyRYVSfLOdculiOdPSq2gwqAHZnoa2kdwSFVla/A5coKO Zfdw== X-Forwarded-Encrypted: i=1; AJvYcCVRkGNHpD73+NJHpl7Tu9dIAt2JQrRM01QGzDTgx7AHAb0hsX500dySuHFK6/DQFb7DgmFnugTH5w==@kvack.org X-Gm-Message-State: AOJu0YwQGlsGKfow7QxX7CRMxk2TuKyGCUh8yMELjG/Iae1q3dwdNEkn TIjS7AZ6lmi6meCksQEiizKcKswX808E01myeJAsl/pbJp2tpr2DOeXpX+TkJHBCgqKyz44lj2p CaYXX/5KNADKVAIf2PM8kdIMCAlpm6BKDSV6m X-Gm-Gg: ASbGncu6+e8yjfYZswP8AKNZMZP1JxrkVjwI3KRpB8dAgUG+1wVL0hU7drlwTMNeN+1 cjXQbz9fqTzdYxWlu7ZXBPeY/Ob1Mr8pkZwaZP/MsHQWhVqr1+is/3TfV2gklzcME80pD X-Google-Smtp-Source: AGHT+IGncYyjy1GhHnzrsXOo74WzCLmIKZegqTWM730ikUDOlazbTaQH35QB0zgmvzL1yJ283cNPWINqKuKsZStNP0A= X-Received: by 2002:a05:622a:1997:b0:466:923f:a749 with SMTP id d75a77b69052e-46e130af265mr2539121cf.15.1737113021050; Fri, 17 Jan 2025 03:23:41 -0800 (PST) MIME-Version: 1.0 References: <20250110-asi-rfc-v2-v2-0-8419288bc805@google.com> <20250110-asi-rfc-v2-v2-16-8419288bc805@google.com> In-Reply-To: <20250110-asi-rfc-v2-v2-16-8419288bc805@google.com> From: Brendan Jackman Date: Fri, 17 Jan 2025 12:23:30 +0100 X-Gm-Features: AbW1kvZ_KaymUoc5jGYX-groCnX_p-Tg9PrSiJ2rBOnB_iSLYbhJZulsHf6-rd0 Message-ID: Subject: Re: [PATCH RFC v2 16/29] mm: asi: Map kernel text and static data as nonsensitive To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Richard Henderson , Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Brian Cain , Huacai Chen , WANG Xuerui , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Chris Zankel , Max Filippov , Arnd Bergmann , Andrew Morton , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Uladzislau Rezki , Christoph Hellwig , Masami Hiramatsu , Mathieu Desnoyers , Mike Rapoport , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Dennis Zhou , Tejun Heo , Christoph Lameter , Sean Christopherson , Paolo Bonzini , Ard Biesheuvel , Josh Poimboeuf , Pawan Gupta Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4ACD318000E X-Stat-Signature: ut9bxfpw84tcf7gf7r87ykr9itzquxqw X-Rspam-User: X-HE-Tag: 1737113022-151060 X-HE-Meta: U2FsdGVkX18LlvbDvx/uDWjhyGi7BxOHgsrYTDU8ZnNO8g6hkFyoOeSwRj35ndNqh9Pzgv+HIrpjZkvGn41V6mpwPnmf5Js/QZhBMigd2MDhyhiO6bX3J3KXuEF9ONEBb1Q67+cC9CLSNRLXOQwpzdn634gjtu2dJIjqSpx/DzJNld5CqOQtaraFr/iKXreFRa+lg4LnQcVjBFx3Px4DKUgeyPGulpmpwJR1bh55P80OpSYZCcWeHDLKYvR52rpnKZQ2TKt9OAIU9dbGngyCDzUiEH08mDkPZKDkf4EAaYZDZQ/vNHTDc/zF5848ISdjFCp80wJh1eVFa6adEQ/SHLb2ArUEWEmEciQg/vR+AmTRmBPs+2YtnQodfRzJcBQXfaWN/RqNcTPHcEbN2Erl+tbSr0Y8lEsqiBS+w0UNHRVXvFxSXzmLYvTmmJEl6IEVZ2b4H/pOdUuOhSqzSEKUVwsP5bXHFeDYXfa3tBBXj+Chumun6+YQxiyYrtfCtS5/5H8CaJgxaDc/Bhnn5zONuS5jKJCH0e9P4ztraeud++CJQ7ANzhkXvv8iPzr8r1LJUHuDKMlCDnurIB/X05gF3xv5Io+z5b8xZ/j1aiqHBUvoQbxgQg6C3WLkR9obsG5XEYi+Ngd59rH6hQ7fJAnRxzG2xR4h0S+k2uvc+kFv8bZVtGSLtv4IUJJ2Jx3eVrEm7PBlR9cQjqu+ADG6Jrb+wajC5eHtP0vBy3oPBI+t4ICSgAJorSit0jvVbbikH0CsUD5/IySO9r9piSv10kJ5S1TKqD9nvOYsTp3GZECzpqo6NcUbGnlvKYQEny917bxFZc5l+icGrCj0VepJZ8Hr+xupo69ufZOJfqMyyNHWvDpGR5Qx6PDm2Lfc5F3XMpwpCRtai8LYmwlaZRDIlOGdUZJVKQcZshSnQpBCcYABnJSOnSj9tIzZEnhvdL9/ar2XlV518hbvt9BBHNtJtew HUvgsOOX cth+8zBrs0NHMPbdpHoGhouQUN1sjeWL/4GctjG5cRA+klWzfWy2yf5EwdbBXYi405PZDxfy1H6JPhocfjdioNJXGhTbGy0iV6weKtkO14jdToqVpsc5fKaSGpOxFvxEboVmaahBckK2i3KTY2IdcyXNgOeLLbIJnIVSFQirk2ocXeO2YV74T8KQmIhbL4k45gGZV5iYiqnk1FFS41EQy0J84NNyLZNGyUjkY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 10 Jan 2025 at 19:41, Brendan Jackman wrote: > + asi_clone_pgd(asi_global_nonsensitive_pgd, init_mm.pgd, VMEMMAP_START); > + asi_clone_pgd(asi_global_nonsensitive_pgd, init_mm.pgd, > + VMEMMAP_START + (1UL << PGDIR_SHIFT)); There's a bug here that Yosry has fixed in our internal version, I neglected to incorporate that here. Under KASLR, vmemmap is not necessarily exactly 2 PGDs like this is assuming. In fact it can share a PGD entry with the vmalloc area. So to be correct this cloning logic needs to actually look at the alignment and then navigate the page table hierarchy appropriately. To be fixed for the next version. As Yosry noted internally we also need to think about vmmemap getting updated under memory hotplug.