From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 284E7C021A4 for ; Mon, 24 Feb 2025 18:42:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE43E28000F; Mon, 24 Feb 2025 13:42:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A95A828000A; Mon, 24 Feb 2025 13:42:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95C2728000F; Mon, 24 Feb 2025 13:42:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 74E9128000A for ; Mon, 24 Feb 2025 13:42:49 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 169FC516BC for ; Mon, 24 Feb 2025 18:42:49 +0000 (UTC) X-FDA: 83155709658.10.3739B5F Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf24.hostedemail.com (Postfix) with ESMTP id 2A063180008 for ; Mon, 24 Feb 2025 18:42:33 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="kfC+/gtT"; spf=pass (imf24.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740422553; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EuAQyl7XnaQsGehxxZgOv7ogE9kkHgi56Hln0LhoXzU=; b=EH9fYHB3uhSYBEiQoMgWdrWqe0NWAsy9P7hjMNr+kTiicHoYvmDd0XmmxYNSbIFS6uesXI f3d1K9NOU0jLdh9gPttx3+PVbO5BzDoB5SqRT1A+nlgsBfGQiAbXK45oAwBpmQZGnNvGSo 1ayYFVHxoMd4MdXQVakpZ9AhbvlMPqg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="kfC+/gtT"; spf=pass (imf24.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740422553; a=rsa-sha256; cv=none; b=W1Rr1hKWuxJRp++CU4YJ1w/Iuevrvq6uI2ZA9Cy/CrBROyvXgK7jwntV3KAys68770J9ea y/x5gk5+xvhW8m4hRB+8JB0RzjfHIf9nzHZ+5MhhaHzqPHj/ESj2UPHnwthWYq7PAyqBD5 xi6cKS5GuRN4So4tefPKYmagciB0mVw= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-472098e6e75so38721cf.1 for ; Mon, 24 Feb 2025 10:42:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740422552; x=1741027352; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=EuAQyl7XnaQsGehxxZgOv7ogE9kkHgi56Hln0LhoXzU=; b=kfC+/gtTUi6pGYP2CkiWEVPTiuW4DxeqgyqqnsdWq/TxoD3XttKRtPQ+RkhCEjW1Kl RAycD/TIqBceXAv+ZUbjqOjh2hkfhmoz2xzsxvsmKcNQC9eHqV6kQKC0+L2KWlHwof7g RqQWPg6soGYTNGFYIYEIt5vYyuuExiyBzOhZY36Dlb8V1LR+jSRlecjVSI5SOKRoDqE2 mThAGJDDY1ilYjHft1IRexyHGF1MUcs9PvFLkDixh3rNwbj+y60QJnIalcowcuA8uuvw WQhZnEkqEVAladtvv1+r+KirYSwApUm4NozmRpk+k9Tr8MKSxDVzKVOYzzmqFIIId4nx 4DCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740422552; x=1741027352; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EuAQyl7XnaQsGehxxZgOv7ogE9kkHgi56Hln0LhoXzU=; b=gZ7FFf/RkKXDSx688H5AhwSVODBxggOfHGH9QDpD7ntHMYVG+mdjso95ShcNpt54OG bhTRRTyNZL0PUIpu+El2vOF9qZKW7ghseUydzm3xrDigARBZHoDoOv/jQ+ZvQ5xT2wy9 k49N5fLqfAsmZsLu8ejlBAU0G/FPsxfmDJhM57rUTBp0a+2AO6lwkXaci34peitHGJxU WToUaUkO0GBgtO7NU/PHW2hG6m3spuFcsJooJJy6fWRjIq8KjmQ0t/j7rwhDXu3nLbUK uEFL/7e1tCVlsgw2n3lCuKbK0t+P0cAp7ZcW2VdHTnP8LKyHupSZNqH31y3ugzP38QxD EQUw== X-Forwarded-Encrypted: i=1; AJvYcCVOdrJWXn40t0bmwdLTGjhcZp5WkHGgZ3NwF+zI2H3m9ofF6aqGLtYE3VkZYnxphrDPq9lmYhEfNQ==@kvack.org X-Gm-Message-State: AOJu0YwMvj8twtC4b+d7npytjod1OkiZPosRf3/nq6OHkrUs8qpoDVvL JK+WEG7QYhXGPrXBEf7m26Z9ePAGNcjWyVLI5i775jtTlFM4hRmVkI/KojOlSRBtKZ9MpxBmRv/ WgtAO2vFyoKCj7m6yR2pQRjfSG60/IPLbo9MQ X-Gm-Gg: ASbGncvnW3SLPgB5vo1XHVVVg4j93OncSRPPMQFSjr33pC7GXUIJj5TkfwZFHFzONDU 0A55CphFGf9T9mTbdgXxGw2Hrs/jYzmU8q7nMHmHo5SXPQ4qDJXPaVnl0U/p0yZ8klbCQnjN6px Ps7Pksyeksq8LO7i3s51QUTteZqmIq9pRaoBttfA== X-Google-Smtp-Source: AGHT+IEoGcfNcSuptDf9uSVbRQnf3h3SPFcv/1nuGHOd0Tc8j29NqZ2LvylQ3qv3adysrhoE7E71DC8ULhk/C59cJxY= X-Received: by 2002:ac8:5751:0:b0:471:f5a4:548 with SMTP id d75a77b69052e-47376e5b15dmr606331cf.6.1740422552148; Mon, 24 Feb 2025 10:42:32 -0800 (PST) MIME-Version: 1.0 References: <20250224-clarify-steal-v2-0-be24da656764@google.com> <20250224-clarify-steal-v2-1-be24da656764@google.com> In-Reply-To: <20250224-clarify-steal-v2-1-be24da656764@google.com> From: Brendan Jackman Date: Mon, 24 Feb 2025 19:42:21 +0100 X-Gm-Features: AQ5f1JoPcttjNCx9C8bx9cArc3eGSQlcqi1K9JjnTlb9vIuH9ycA3afS5xfXM5s Message-ID: Subject: Re: [PATCH v2 1/2] mm/page_alloc: Clarify terminology in migratetype fallback code To: Andrew Morton Cc: Vlastimil Babka , Mel Gorman , Michal Hocko , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yosry Ahmed Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 2A063180008 X-Stat-Signature: k1pnwoeubt8ntxde6jrwwzoa87jjc8ca X-HE-Tag: 1740422553-227553 X-HE-Meta: U2FsdGVkX19Rh8w8/1CvsjxbsPzPBUWCEnQaNPs4Siqr/FRrO99tYDIHwFB8glbRASldiS/PIucWQ9oCPZ5Jx08kOPu02ZHw9F0JlWshLZwJu13ODnM+MFRgxawWrFpNsyrN9Il0/9TgXYEi2UxBHdwoip36j9GKws1xI136k7L4UREN7o9tESv4Ou62lPCjWTCPe8x2bHTD3IvMzwdbZ7uEiaI0YLvjmqafSY2eC/avJNPUpjV09v9C2t25k1Ts08vlkcGXrYoQO6Cke0EuSUhNQD0UWB84PORp/LstG3xgURSrfPtjQ2/ICKTBQD/IXbj7Zb+I7sxvQar9bCU8Pj5tEKpXKu5KShSSUr3JstZYe2bDWsIm9cXYkIHjtKglBZ/wvxDX2+N3B9ipJ11lsw41ulr9Sv6piwqa5/17m7meNWBIP/vAL1RI9KEcGlZ9wBvJN9vuloATeh4O+Z6WQM7xzq4E5mIntzVsdHm0q5eiOAV9H6tgcw8yISdRIdh+0jEKxbR1XYgE/Xu3Pd9HKMgBtEZqyGIgpC+QONQAw9QS1Fl162K+kiLusqwLw3///YV9dcgldO31XICe1X6UjhXj0cjUDwz6uRCnTfuLpYmRcc7Llk5q4De81Lek/jOF6AoJiZEHQkT5DDv9ONL8EgXX6CAGSpViyOoeLms61SOmbsdjg+XcVmNOXZKZTVvAwFuy7HxqrQILHS1J43Iyb36hIhfmfS4+0bda3AFH+Xs0QH+wNrrklNvBDIeRgbLUmzLqJpSVTIa/1WGP2bMZCUqXOoGfvgaSdnW32jwb+vEqIlCiXh8ZOP8KACADWFBzAJOv4C01Pzj5x8T2EZP8HlzkSQ79in1tVclF6vgYHnL7MWJSd9IuZH4OGVPTDFLBHzh1JJJCh2GvUVDhmCoIAKz+eqz+o1Zy7fpLH0w2I4EnvhZLLCEsl8xdul4abQszGUVrqZsWALMko0qg2wI JWEaj4uw em0rE4MVfM0a73BhWZOqK5G0dwduP4BuYCCotaXWlDZgLIQbtL4sx9ysRK3uzx/EeC6ONWwR0BklDihjGO2rc40WBwoaWsPxr4O8GPuWTJGVcRfU5agtax65b9UwbPJ3EvmfeR/R0GMiPjdtDa9gIembQYAD0+3iSgU30DRShtHy/f79ydoBFLEQadY+F3vaoedYLQfJE4RbLA6s+qj3YLThxg6Yuj8g/VFAEofx1eLUQ6TGi78luo07yrfw4kigUFocwy0iVLM54w48= X-Bogosity: Ham, tests=bogofilter, spamicity=0.065438, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 24 Feb 2025 at 13:37, Brendan Jackman wrote: > int find_suitable_fallback(struct free_area *area, unsigned int order, > - int migratetype, bool only_stealable, bool *can_steal); > + int migratetype, bool need_whole_block, bool *whole_block); Agh, sorry, I was meant to rename all of these to claim_block. Apparently I got halfway through doing that then got distracted. (Literally the whole point of this patch was to clean this up, and I somehow failed to actually do that!)