From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EA71E6B241 for ; Fri, 1 Nov 2024 10:07:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FFC86B007B; Fri, 1 Nov 2024 06:07:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AF3E6B0082; Fri, 1 Nov 2024 06:07:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39DE56B0083; Fri, 1 Nov 2024 06:07:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1D1AC6B007B for ; Fri, 1 Nov 2024 06:07:21 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A6401161C22 for ; Fri, 1 Nov 2024 10:07:11 +0000 (UTC) X-FDA: 82737097422.30.D7878A1 Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) by imf19.hostedemail.com (Postfix) with ESMTP id B4C311A0004 for ; Fri, 1 Nov 2024 10:06:34 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3f18UW8+; spf=pass (imf19.hostedemail.com: domain of jackmanb@google.com designates 209.85.166.175 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730455497; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qjn63ek4WImsoAqV+BDmfS1xuW6xzS9m5vZvn7z3SqM=; b=CTS2cA2YTq+bk2R/IY+qU6Qtvrz+SWdkADKFz184t2FLXJNL81J3qKNKzNYwTcjoMChS1L 2ylFrwDAk2q9lxHX6nPOiV/RO8q0qL5Wx4vSb3I7ixwARLbuWkjdM0hAywXZnS8/2UwvN9 xeEsjtZPfUDbY4vsShIdfefWrVmpjWQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730455497; a=rsa-sha256; cv=none; b=h4bHb6kIlGCJ5Cwwf6pDGEfUtOyv48pNyYJWk4dBhaTuSamLDQ/Ai72s/asO2M76BgHtyB fa+v3ZKFlHJ4AOeMt0jDJQDeTejRNCVu/81zMe4TuGh+Sb2UJ4FaRaBvSUqnKbY/CmmkI8 VKYzukwZriIgu+0DJkSuMJ3ZnnMFDLg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3f18UW8+; spf=pass (imf19.hostedemail.com: domain of jackmanb@google.com designates 209.85.166.175 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-il1-f175.google.com with SMTP id e9e14a558f8ab-3a4e4776f79so175445ab.0 for ; Fri, 01 Nov 2024 03:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730455629; x=1731060429; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Qjn63ek4WImsoAqV+BDmfS1xuW6xzS9m5vZvn7z3SqM=; b=3f18UW8+/QWQ3iaEMcB8an92Nk+MRGnZPmsJFF3UD1UHYqQMrnzAGZwGuSPwqslg9H 7MDEdMJdvikDLM231HZ7GnfDXVi+Rp+zpz+whZjIwYI01KbmiFC+6yadRFLV5dhDSDBW e3nUwRNVEyW1bagXCETegqgydnw7nZn2gxosyz7tTuEEqy0uqyUIU9UzRyAEWykwf4p8 c1ZOD2IU1i9dRwc7H0HtjU3sNVJWGIfP7oY/JFun0RphB2kfyZD6cClRnoKi6geZsKs4 nYkdk+qQxcFbmMXGXqj3ggPhWKKkaDN3KgoFyeJaCqtrvFaIWkeUsLWGSZ3ZrQ1DpuF/ 4uTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730455629; x=1731060429; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qjn63ek4WImsoAqV+BDmfS1xuW6xzS9m5vZvn7z3SqM=; b=ikMnuSNfBHZw+Ft1p9yzysbMUJQ0UQH/Wsp/lUAUNuyaQuAy89ycranHfAGXZpJPt2 75Qz5mUucTggpHy2JX14Xgp3ogz/CM0DEpX26vbsgZyf4rw0tm47b7095fbjlCRu12am Edrut6n/oEMrGmooeWG4DohGm2Kb/V1kJPM+ku+ICqRPJ7SzFBa7g7Uil/EP0TWEXWaV TCgKKpFM8Jt4vr+jX6WVM72ewHyVVSK5GSB0wao8xPJ9UNH7REQ4+NzWWonrVbi59Jib +MoZeCCTpv/HTTp+tXpMBoF5c8GqyWyojJJ8kFASwj6rhlPqXqtGfNsRcC/u+Gu8dnk6 VgNg== X-Forwarded-Encrypted: i=1; AJvYcCXRw+A6E9FxJwU9UKajW/i3VoftVBed7ZHxOPC6l2MiirbGuxF2LCUait5VQXyXDsQ/vhQw1pzdHg==@kvack.org X-Gm-Message-State: AOJu0YxS7W1v7G9p2iuLy40m4EblKYWuAuHhII9Ha/3ZvYoXb3cRar1N 1DPc8RpotA9ke+KZzG+r/3aCePhPFp7Oj75KQdh/rnuxZgZKyKMx+2V8npSKfTm/mQe7Tyqh5jH X/0uAGfngiHxX3FZVWC/0VLbrBUDRobihKVfB X-Gm-Gg: ASbGncsnToVoqUhWyXv5KMuI5dA/F9LcfqD+GV0fpr8KvDHlGS28LXoLKc9WcYCAcns R/3AHjFfXhLhPFQYhbzEApi2n+rCfzsCYIwQP4/R1LnXmb4rArmvtOJmtDvqS X-Google-Smtp-Source: AGHT+IE4pdolZqs/1Fb5VGhaHZXEPmot9uMPx/b9z9OT/5gEBhMY3DyJDsU3nlnPT5w485LLMMDaJtlZ55sPJ4zcwd0= X-Received: by 2002:a05:6e02:152d:b0:3a6:af68:667e with SMTP id e9e14a558f8ab-3a6af686864mr4500845ab.28.1730455628625; Fri, 01 Nov 2024 03:07:08 -0700 (PDT) MIME-Version: 1.0 References: <20240712-asi-rfc-24-v1-0-144b319a40d8@google.com> <20240712-asi-rfc-24-v1-1-144b319a40d8@google.com> <20241025113455.GMZxuCX2Tzu8ulwN3o@fat_crate.local> <878qu6205g.ffs@tglx> In-Reply-To: From: Brendan Jackman Date: Fri, 1 Nov 2024 11:06:57 +0100 Message-ID: Subject: Re: [PATCH 01/26] mm: asi: Make some utility functions noinstr compatible To: Junaid Shahid Cc: Thomas Gleixner , Borislav Petkov , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Sean Christopherson , Paolo Bonzini , Alexandre Chartre , Liran Alon , Jan Setje-Eilers , Catalin Marinas , Will Deacon , Mark Rutland , Andrew Morton , Mel Gorman , Lorenzo Stoakes , David Hildenbrand , Vlastimil Babka , Michal Hocko , Khalid Aziz , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Valentin Schneider , Paul Turner , Reiji Watanabe , Ofir Weisse , Yosry Ahmed , Patrick Bellasi , KP Singh , Alexandra Sandulescu , Matteo Rizzo , Jann Horn , x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B4C311A0004 X-Stat-Signature: 18b1tfztxnqdnu8nzeq91tye8j4hn98z X-HE-Tag: 1730455594-308944 X-HE-Meta: U2FsdGVkX191tkfclicL+WRHgaD0ZEdU4IHQhdwc63PzIbu3hvpRPuwYDqroiVfmW7ADVdr/EgLE6/3qBbSkHiFRqS28SM+4K/k0TOjt6rfMPhf7i6tHEDJuEYSFfLol6OPeOJ0/T2covtVBZxCkE0Hkm2PHv3NC6Dvh3JXYYYSFwle+jzrMNNHysXIoMNtYEt3z+SoWRTFKboItx8pH5yBPqb/TLGHsAgWLIx91M2HuCiS9jiVM6xz+kVv9muA9RSVj+4rqHj0GfD7OnayZc9mEfCLFyhOxYtm8tKBKDM0vqp0dz/NHfW2mQo9B3COw6Hi/d0Of1ItZPsOt14ucSejmE5vRdNMCD4g988mArmdFv7psEiBg0zEbo9aa3QRG+nZE9cw+uL+aplb7/4w+59E2rbUnpWsW8l0eThhVdthUmRbtz0N2h4IJqIfLJ4QIElhABENyEHp39IxdNXLTA4Lagb6+fTMvLLdjZEYes9vROTlx/qbOiQ3BPQDF+QtmNl0cuvKsqufvPWfDRQRAm0VxvF19iqAQiDmoZDaxxPXAg2c7WT6KHSTkxrlGtSiJQ6UmlZEslHygIuIOmxbcyTAvlCFikXq4IrovRsX0xugw2sM7ivdfJ2QVhXzG8DPDqZEo8nxJWmwLJyDieJ5Uc5rnYwxOg0d71zypZa2om3G+tO+YmXqe3M3B3odQRN/EcHXgZ7Qqm/SEnNOeYWsfYVuBHJfmXqxslhRw86JFeC6UtFw0UzVm65fW7AbBQantnPWXFevCOyf8GCilrrEPb60HO0UudSVoQvdtwQACD09vtSO370hF6RnzAZizc8VJk+1TOAsSH4BdU8Ntun8bdHYRpdNAGYFVTMjA1dIISdorCzKMoxGtVS0pA769yJd/oonp5YlUuUUgADcFOXYl/euUZ3/ndDyYvor6job5JdHk8Zxe56HnS6yls24LPBk1q0rpCj6MsQtsQLvNfCZ 2kDn5O44 /HQV6mriZbGoSc6PBSkmwy3V2lZJEOL3+IXFGUgmhNTHc8FGMxllHQYptPPvi8YmDuT74KLL8L8c3rRpwtkB5C5AOiNAuZfNrSRrbmQoswk21txLgzlMaCCWZPqLJ17GH1xsKhTkX72MbpjOuGqfgBPX1An3gCLQR1hsYce7UywaiO+xzsNibV64fUsY+HnKqciGnMsotOw5wWl2fWp3xT4S+BT74yRLLMjLr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 1 Nov 2024 at 02:44, Junaid Shahid wrote: > In any case, I guess we could just mark these functions as plain noinstr. I wonder if it also would be worth having something like /* * Inline this function so it can be called from noinstr, * but it wouldn't actually care itself about being instrumented. */ #define inline_for_noinstr __always_inline Maybe there are already __always_inline functions this would apply to. Then again, if you care about inlining them so much that you can't just write "noinstr", then it's probably hot/small enough that __always_inline would make sense regardless of noinstr. Probably I'm over-thinking it at this point.