From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D696C282DE for ; Wed, 5 Mar 2025 19:10:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 373C228000F; Wed, 5 Mar 2025 14:10:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FF21280004; Wed, 5 Mar 2025 14:10:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 129EC28000F; Wed, 5 Mar 2025 14:10:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E31F6280004 for ; Wed, 5 Mar 2025 14:10:51 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9F0B75148D for ; Wed, 5 Mar 2025 13:12:41 +0000 (UTC) X-FDA: 83187536922.22.378E90F Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf24.hostedemail.com (Postfix) with ESMTP id D394E180013 for ; Wed, 5 Mar 2025 13:12:39 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=cJeNAzTp; spf=pass (imf24.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741180359; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iOdrgfnKDo0adnIeWCzGbGdt+czcdG3OGWY151PLQj4=; b=tCcgZ6IrY5OOp+MZZNnwDMb0256Tvk5ITZ/NJ2jcJ4WMvcluwH6wTHFrc4pQLx+JK4vcpx ybKA1s1kMdrMRcenBw/Ortb5rgLoqLOs+3L050xI9L1yTAWwWYm4fhQlXreXTBsgc8UpgF TCmiwukbDsWaOIln4oahlXRwGeHXKG0= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=cJeNAzTp; spf=pass (imf24.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741180359; a=rsa-sha256; cv=none; b=F1epvFEWPw94ci+knUnjrv5dUtieha2PmpKSDp9C+tmqhjilOpy3+9J0Ros87pMh5yJStf XF/mPyHwTS6J568Uy6NPAvV7CwOfidBnWFqUfo8ql/7al7cARX0EiON/Hu7BbT79UkvAFj Wjb1kZ79aL6RmmlOJr4PAlxIcxH7XJI= Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-474e1b8c935so265621cf.0 for ; Wed, 05 Mar 2025 05:12:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741180359; x=1741785159; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=iOdrgfnKDo0adnIeWCzGbGdt+czcdG3OGWY151PLQj4=; b=cJeNAzTpErwnlD0EKH9f+8lj9iy0xhjONuzKYPMWBBxw9DIx/Qn3DAiiSOjYnjFRuw GdeN73oIRRWlyu0JeivQHJU5XhPMzVagFINUY6jB6w+0LH4wF+Q8Ib8UWGNeGwtm4pfD TZhSA3oitkG52bTSudT30ClZjrldwql6Nz+MJ/QbHP9ezrId26HhdJIvCBEPvJIcDEk/ 0FA3tHwZMiZWQnqdb/owyean2lxCHyDLaz20vd876wdIYRBVt1Gj7Iq6VM6xgqyRQwy+ 0dvik3kiaispYit0NG6H4XZw867CgZskGSoEKt6TTSDpSx9hN/a1pHBvOwoAspgEvuW7 ZY2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741180359; x=1741785159; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iOdrgfnKDo0adnIeWCzGbGdt+czcdG3OGWY151PLQj4=; b=h/FSTeVvSI3Im5RVsuxqzEEnVaC0iCPQEiT9g2kJKBDVv6WQ4yuP9Wy6yyCCVbVFxU O2LIGYZDbOkRn/ZPJL8RNFmBax1ZiiBg1X3bs1UKvmeI94R4LuWUdhl/MUSIFQ2maNsG ExDRsvw9vgdyVSDREFcRcvVs+zDItxbm1P6wdf7+uRx1Szj76ULHnmE2MLOANNJVxPbf w8sAgawwlJl/GsVWUpB4DMfZCSKL+F+bPUtEvg2p5SobOLqhhuSAxJkHuPwdxHJUovY9 RAPacEitxxVC60RbSWverxRTI0qUvrVr6BwJ4sXw0dDpUeyB2RGiHDCzWBf/GK2s1dYa yytQ== X-Forwarded-Encrypted: i=1; AJvYcCW1Qz3paCCbnLpSZJmniRvc/r7tDFVSQRE3zT6Htt/wGLFMSGchBhPe0EpXDD63hNUORn3UAmZd+g==@kvack.org X-Gm-Message-State: AOJu0YzCuz3eMCAIKmWkwbpyG95h4D5gc0x55IZ23QNy1e0EBd4aSRlJ hicsWo1gHBtkiI8ukQQ2tdlKSQwgjFNbPbvNOUbCCcshF3hBhkJitF/QCEbOlWGVQDsPepHUW6c CjDaKeG7BBQTR+CfBevFX0513jU2J5YI7QV1Z X-Gm-Gg: ASbGnctNt5RAeJ1ZNPThThyeiahQmdgAjF03mDeWvwXeVE5m8US+o8TH3v8Cz3L38Q1 rnnbVgzGorsNTUOMgEUY9vZoD1xpvVjq6qYR83nz1QhlhQ0FHUan9COtFHBdXwdyikJGoUt1XnQ LjPwVEUKeF58PYlifR+HEOY7vLKTHIJjh1QSUwO1Efbdc0PwiKuTvSXKnR X-Google-Smtp-Source: AGHT+IFIn6b7M1PNu9NZZ9KBzOuRO4deZPOixhL9M73rMvQkDHUtfUtYPha+8DdwHlmaLHcT+urAybKKpNAnQK1YFdU= X-Received: by 2002:a05:622a:110b:b0:471:f560:27dc with SMTP id d75a77b69052e-4750cae2127mr2406081cf.27.1741180357471; Wed, 05 Mar 2025 05:12:37 -0800 (PST) MIME-Version: 1.0 References: <20250110-asi-rfc-v2-v2-0-8419288bc805@google.com> <20250110-asi-rfc-v2-v2-2-8419288bc805@google.com> In-Reply-To: From: Brendan Jackman Date: Wed, 5 Mar 2025 14:12:25 +0100 X-Gm-Features: AQ5f1JrEWoe__i5J-gwzMxiuWZ9pJYk4XLPMWAQuPYUSu5vOhjZQNejm22RSyYE Message-ID: Subject: Re: [PATCH RFC v2 02/29] x86: Create CONFIG_MITIGATION_ADDRESS_SPACE_ISOLATION To: Mike Rapoport Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Richard Henderson , Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Brian Cain , Huacai Chen , WANG Xuerui , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Chris Zankel , Max Filippov , Arnd Bergmann , Andrew Morton , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Uladzislau Rezki , Christoph Hellwig , Masami Hiramatsu , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Dennis Zhou , Tejun Heo , Christoph Lameter , Sean Christopherson , Paolo Bonzini , Ard Biesheuvel , Josh Poimboeuf , Pawan Gupta , x86@kernel.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, Junaid Shahid Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: D394E180013 X-Rspamd-Server: rspam09 X-Stat-Signature: 65g1du65oufefx7om4ofytzdfo7om7tb X-HE-Tag: 1741180359-507524 X-HE-Meta: U2FsdGVkX19RyM273wJYKWghNaqxVYFXW5SnFg4U9Lo4PJEZjrJfgQyoczafyoIebV2UMLX6eOi5GvTrQsfqiNEElfcLiQa5pOeESMaI7V3SHy0TSmeCORYRTW6JEgWcPDqqac15tjk3/zS9rJ7ECDH2WMFh2nELVhS+2Y2pRUsDNzszCgsi8h8n6EKw/GK5uk7v5xBR/A8l7/KnoFtd0I371nNJRtQn06BMhJyK8eSo18YbpGOWW+MKwCXcSXrge3A45yntREzlwFXzRAGmifdeZaWEUolEO4SdFppG1Zivn1kb6r/wja1nXMsDVPEjJ74SwCCZlG3AFV6ZdCRLlIAR+he+AV/qUiueKuZK5kQ3sQRDYj2vFB9UQrH+2JxpGi1W2dr8LASvGShbhLWHHxrMqZglpwrxAovlFqu5jGOV9IHnNhg3ekgRGedX2NJ8ZbWPwYT21DxIneCBmj0vq0XynY6zk+wG3RWigeX6ISXrIwI2MzDrwyGPwfnrcyrwlzQNDvqX8pgqhnP/T4FY/WhQl/gcVgCTNsdnnt98nr/YAyDUkmoU1CLbuWV2nwqadlMNopbvbORS9QwoEkpEphKWeTfmTtW9QuUEGryTY87Y/fzbtEglciqwIti37CMRdK3kXwjcdO48IP/xmGfdcFYeHrHicHNMCADrv0qnkce6P2unhLR9SH4oNW0ICiq2AQADM9U5S8L9oyA705bFvCUmjt5/RCz4GQiO0J3zDKdI6icIUc6FZja9evElyQVC3pRPE6XfM5zvjNqnZihiRWj9DuTWRWScT1B7muop7SHQ98a5ucKehy/X9O5VA7wZ2dZB5VT/Q2q+OBalgdCQ3AIE1p0GuxlFgwumC4xnFIyCcrDaNR243jrnEuUWu4KIL68VmWfr+wT9cJ/Nkou1Z8wlPLAj796U23+T1jIlTO/6iL0G3xW63a6beVI5Ucm9qqKIrITL370siqnDbnY M9JL3S+T iUx6Boe+7tY8CuyAl1FFnmv8MHXLZF63K0WRETsrCDB/YSuCv1saFRrx0vG6cAbuImlobmr7kv3ac8qlTcfOkui49dx7jz5b62gLOixRzvJGN/vxTRQasx3jjj6JmuYxYMVIgMq6QcPRY5iA3CjaseapyGanuEYfgbWLbVB+KYRIheX8CnFvu12Xv+hy56Bhd7uSOTUiCq9dxIj2y3zLboXbmq+wr9FFtCtHsrxdKOyehE0NpdDLiwnAStOr7Vc9lVoQ1ktHqMH9n2LQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Mar 01, 2025 at 09:23:51AM +0200, Mike Rapoport wrote: > Hi Brendan, > > On Fri, Jan 10, 2025 at 06:40:28PM +0000, Brendan Jackman wrote: > > Currently a nop config. Keeping as a separate commit for easy review of > > the boring bits. Later commits will use and enable this new config. > > > > This config is only added for non-UML x86_64 as other architectures do > > not yet have pending implementations. It also has somewhat artificial > > dependencies on !PARAVIRT and !KASAN which are explained in the Kconfig > > file. > > > > Co-developed-by: Junaid Shahid > > Signed-off-by: Junaid Shahid > > Signed-off-by: Brendan Jackman > > --- > > arch/alpha/include/asm/Kbuild | 1 + > > arch/arc/include/asm/Kbuild | 1 + > > arch/arm/include/asm/Kbuild | 1 + > > arch/arm64/include/asm/Kbuild | 1 + > > arch/csky/include/asm/Kbuild | 1 + > > arch/hexagon/include/asm/Kbuild | 1 + > > arch/loongarch/include/asm/Kbuild | 3 +++ > > arch/m68k/include/asm/Kbuild | 1 + > > arch/microblaze/include/asm/Kbuild | 1 + > > arch/mips/include/asm/Kbuild | 1 + > > arch/nios2/include/asm/Kbuild | 1 + > > arch/openrisc/include/asm/Kbuild | 1 + > > arch/parisc/include/asm/Kbuild | 1 + > > arch/powerpc/include/asm/Kbuild | 1 + > > arch/riscv/include/asm/Kbuild | 1 + > > arch/s390/include/asm/Kbuild | 1 + > > arch/sh/include/asm/Kbuild | 1 + > > arch/sparc/include/asm/Kbuild | 1 + > > arch/um/include/asm/Kbuild | 2 +- > > arch/x86/Kconfig | 14 ++++++++++++++ > > arch/xtensa/include/asm/Kbuild | 1 + > > include/asm-generic/asi.h | 5 +++++ > > 22 files changed, 41 insertions(+), 1 deletion(-) > > I don't think this all is needed. You can put asi.h with stubs used outside > of arch/x86 in include/linux and save you the hassle of updating every > architecture. ... > If you expect other architectures might implement ASI the config would better > fit into init/Kconfig or mm/Kconfig and in arch/x86/Kconfig will define > ARCH_HAS_MITIGATION_ADDRESS_SPACE_ISOLATION. ... > > +++ b/include/asm-generic/asi.h > > @@ -0,0 +1,5 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#ifndef __ASM_GENERIC_ASI_H > > +#define __ASM_GENERIC_ASI_H > > + > > +#endif > > IMHO it should be include/linux/asi.h, with something like > > #infdef __LINUX_ASI_H > #define __LINUX_ASI_H > > #ifdef CONFIG_MITIGATION_ADDRESS_SPACE_ISOLATION > > #include > > #else /* CONFIG_MITIGATION_ADDRESS_SPACE_ISOLATION */ > > /* stubs for functions used outside arch/ */ > > #endif /* CONFIG_MITIGATION_ADDRESS_SPACE_ISOLATION */ > > #endif /* __LINUX_ASI_H */ Thanks Mike! That does indeed look way tidier. I'll try to adopt it.