From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23637C021B0 for ; Wed, 19 Feb 2025 23:30:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6E19440187; Wed, 19 Feb 2025 18:30:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B4427280276; Wed, 19 Feb 2025 18:30:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A33A3440187; Wed, 19 Feb 2025 18:30:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8313D280276 for ; Wed, 19 Feb 2025 18:30:37 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 23CB2C03F8 for ; Wed, 19 Feb 2025 23:30:37 +0000 (UTC) X-FDA: 83138290914.09.268D41D Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by imf12.hostedemail.com (Postfix) with ESMTP id 0E9744000E for ; Wed, 19 Feb 2025 23:30:34 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kYxyf6+C; spf=pass (imf12.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740007835; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JKnTn46/4Y2PZeZ3N6KkyX0o2kLFr+MjBIJGyqLqLvg=; b=iWKtxA5e8OS8Iw8x3flbF7QEqEpwQ6IKIo04x2pZEGrEVxOaw5ocS1Sj9pLGzrxu2CH1Ft RhMbqw0EtnGbv+2X7Zp/BLAmeoUsxqWRonMLiL6mcJ9OW+6Q3Hli3e/1bWjF2xSNHlxV7j U1hcgFZ+IjGJ2tLWszRnQVc/VVyxqvo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740007835; a=rsa-sha256; cv=none; b=xQlW8NIXNUjBWpLs8YqUBQ2t6aLlXj3ljV0eyPPNOOvVXS/PACW4/QT4JAy7OqvBBUYxmV bkhn4evqgvcC2W1DsFXrm/qcDp4BpWyRTusfhFUJTm1h/jBJxTeFIMVqRCl5mUagUrvrJr 4P5gAqVxO4LrE2zomZQb3OHamwWqGII= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kYxyf6+C; spf=pass (imf12.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-38f1e8efef5so163898f8f.1 for ; Wed, 19 Feb 2025 15:30:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740007834; x=1740612634; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JKnTn46/4Y2PZeZ3N6KkyX0o2kLFr+MjBIJGyqLqLvg=; b=kYxyf6+CAlkf9iizUfUL7HRjYM8o04Sa6r9F29HPICsh+dOXDjwVuYXdv7ElnxZ4M7 IisHK0rWzFVdid6q0mT03+24AwFg8JqoBQ5uJJXv5RGQvzMrm7JnyoQVBg9MfXreS8yz co5OHEAQc96SDL6YLaR7UWS9ZQqk6z7LMPJzNcC0ni6qpiznQ+Csms+RAdpuBKAI0nSS /XZMNiGKX6ko1r2ofMPxp6L8KALBzwbRV+/O9YPqBz0wzs/eY81VcYM/p3GFo0H1gRa6 C9jNs7X1wma4Nt272jybhNd0mU2/u3W37JQbBmZBKs3Q2OIJg7lM4DhHO6hwww0+zmHl T2PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740007834; x=1740612634; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JKnTn46/4Y2PZeZ3N6KkyX0o2kLFr+MjBIJGyqLqLvg=; b=mj+frxtKIhGK0Yq8g0murqDambRPhgBWMpP8aYQ9MJqoj7OOKlhFmwUq+Nfml3KBf9 +AejwK2KUjavMMPsAH1RcOsy/vkPJQ8yBYw9Swf7G60YhqZ9Ok6suajCUvduNSevQv/7 JSzMkbUGEeUB+Ykv8WQbDMnFRdbICjotonfOMUG11/4Qnf05pKiX6sCBhvpSof3+XuoP zqRonawKL2Id3cxu3aN3WvUjv6NkJmeUD7QErgPXwTZsBolfJg0l00G+xh/nPTs3DdVq 7SOJFA+OiRtECQi5QrZ/tuSE6AdriiPZEuFr4dJHWT/Ek4mkPb6eHZXF47tVca2lahql i3Sw== X-Forwarded-Encrypted: i=1; AJvYcCW4QRbXkrPjz5WxwSMYxxPvQWUo1kGJkzBdiJTvl/Wd0svWzXWwcoW0pgDDNm2LPmvJR7Nt9zkT4w==@kvack.org X-Gm-Message-State: AOJu0Yyif+oSnZcWIWEY+cpTMVKbbDeIxepqC8It62z5oWk2BX974stq 2+jlnxYOSEj8KrUMi2uuB4GaT46gzq8AnAutNURTutPKxyHu8QsFzS+6KRTERss2bkuh0hXeGT9 rjz1ybzvNwA8+8bqjiYXP5NPra2k= X-Gm-Gg: ASbGncuEBo6URu7buTlw9peUf28mBdUNk+w9ujWcqqVqnXsith52IN5AC7XtfY97WlC XChCK28/s/7AJQ9h5m+r/nuZYpEUFK0UmrxNa5y6Gjpu1U4uQ2/Ehhya8xsVI+d4ake8HLHG9t5 I= X-Google-Smtp-Source: AGHT+IHFGBp+H9LJ87eH9NcwjPr+u7W+cy6vGPQrVBD8VepuvfiNtoUe7umH1zTNOROzdxEEh6gwl0DkWMx2aD8oMrI= X-Received: by 2002:a05:6000:402c:b0:38f:3b58:fcfc with SMTP id ffacd0b85a97d-38f3b58fe8dmr17435032f8f.13.1740007833626; Wed, 19 Feb 2025 15:30:33 -0800 (PST) MIME-Version: 1.0 References: <20f64170c0b59cb5185cfe02c4bc833073a2ebe6.1739866028.git.maciej.wieczor-retman@intel.com> In-Reply-To: <20f64170c0b59cb5185cfe02c4bc833073a2ebe6.1739866028.git.maciej.wieczor-retman@intel.com> From: Andrey Konovalov Date: Thu, 20 Feb 2025 00:30:22 +0100 X-Gm-Features: AWEUYZlmUvY8zJgQzvnlM_yf4TfmlW5I_F8Q4WL7EAI9RSu7Ct1C7vf6wwcX6ek Message-ID: Subject: Re: [PATCH v2 03/14] kasan: sw_tags: Support outline stack tag generation To: Maciej Wieczor-Retman Cc: kees@kernel.org, julian.stecklina@cyberus-technology.de, kevinloughlin@google.com, peterz@infradead.org, tglx@linutronix.de, justinstitt@google.com, catalin.marinas@arm.com, wangkefeng.wang@huawei.com, bhe@redhat.com, ryabinin.a.a@gmail.com, kirill.shutemov@linux.intel.com, will@kernel.org, ardb@kernel.org, jason.andryuk@amd.com, dave.hansen@linux.intel.com, pasha.tatashin@soleen.com, ndesaulniers@google.com, guoweikang.kernel@gmail.com, dwmw@amazon.co.uk, mark.rutland@arm.com, broonie@kernel.org, apopple@nvidia.com, bp@alien8.de, rppt@kernel.org, kaleshsingh@google.com, richard.weiyang@gmail.com, luto@kernel.org, glider@google.com, pankaj.gupta@amd.com, pawan.kumar.gupta@linux.intel.com, kuan-ying.lee@canonical.com, tony.luck@intel.com, tj@kernel.org, jgross@suse.com, dvyukov@google.com, baohua@kernel.org, samuel.holland@sifive.com, dennis@kernel.org, akpm@linux-foundation.org, thomas.weissschuh@linutronix.de, surenb@google.com, kbingham@kernel.org, ankita@nvidia.com, nathan@kernel.org, ziy@nvidia.com, xin@zytor.com, rafael.j.wysocki@intel.com, andriy.shevchenko@linux.intel.com, cl@linux.com, jhubbard@nvidia.com, hpa@zytor.com, scott@os.amperecomputing.com, david@redhat.com, jan.kiszka@siemens.com, vincenzo.frascino@arm.com, corbet@lwn.net, maz@kernel.org, mingo@redhat.com, arnd@arndb.de, ytcoode@gmail.com, xur@google.com, morbo@google.com, thiago.bauermann@linaro.org, linux-doc@vger.kernel.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 0E9744000E X-Rspamd-Server: rspam07 X-Stat-Signature: xuqtpo97r5j83teebumj4bs1msgea7jn X-HE-Tag: 1740007834-896578 X-HE-Meta: U2FsdGVkX19yK+Z9gwJvT2fSvynyA6J8+skUwG1mtYvryh94atpMj8t+S4bcMPAC7NvhyeKugBMJVvelt+hrKClr8f+anLIhZE6ge6kAiapCN0cDOPOtowOU1mttv5uH26yLwbI5M7v9sf7C3d6XJiNWkmZ+1bzlpAnPhnLsx+yBLBL4jfYoAtILImYi35dWypyQL7gJkVkrqK4XvAAFe1NtNqraFGbqTeSDe73lgz4fqdFPllwslTM1m5omB5Lbr6/THh0SOhgu7P0AwGNtVOYDsRW1Q5BlR6EwOhEQ3oALB/O1jmM15fCYz21Txz2n/RYt5pBKT1w4TNsUwpaehIouH9TPCNxY3tU8nVLMBtQlInB+ts2F2rVP2ZQ/2QiYaal/xgJciFGEIwaZpV5hdf/7gIX4oEwfoHZGg9ainXR983DwAF/FsGIk12bQQJWLHgGjrz6+r8LZxFM6t1gpCM2Iu/LfyZCaxkcTJps18lb+sYytV5BUymUVaph/xxaknzzky9Qc2fGOpapQ9Zw77HgUNNRW2y9e47EvMxAOLicoxL08c9MWf7UMNJadvVF7+fxr1HUnvDBY0wBJI8bi2E6N/o6JTK1OIp+oogmIFD85w36gSR+7K2Zb+If3cOsENTbYskfHyF5PfnlhpwM0SvmNF+ggOlu6vYiAN2UJuonquiZrDtK9NiE7i2wQ4vd4lkv4BbqNdrhGxU+D0N+ucycMcidxRGYWTUbCHJnBHfo2lrL5KI+CVG5t+MYnt1IvNDhhSJHKzxOxdbVFzvQr8zFNaE97ug/LojQQ5p7c1UR59d3c6JmLSQ48rreAJWyhwGP1rGGgznuTDN57vzhn0YTxLP0AwrfWdT3IpLzKKYU6RvuVvpaD2M+ovEfrL1PhewUfHmmeZreomGtYUMCDdGz3+d7F4QvTp+mXObFuywRNnEyhq0j1nS/iF27CZuJ5lVeYjyaY4JH6cc1MNnt PAkMKrhm c+rA9pPhdoQU1XyRsVjHtH/okCnuKguVqBokJZxRGi8LX+fSotJG7JTnqGJoAelv4Mih9TszbGpzKQxcIxmoT92fkrR6UHWCxy0KzLyKkSCwplPY2HxOLdjgMPq46Flq5Ql2+h4vssMtNTXzCULLCWZIYiyEnWYAh220RE+jo8uURWVZV+ckfxwXKHw6yqdnK0jAbFhJtp+xCdtBNQcRiHsLibAm2qVH5IAoLkAcKTUsGy1cplhzsALW0eNV28O/DHqCvjii4jJQEt1prWezwBDTwz2FIg/3OHSLyEvLiF0aKgV5s2GRHid+c+lj0hv9BRXIBLyz1lWtQj/0644ol5AOvfJQxbbJs2gxTKQF2R3iv2F61JJQ4uol5Y3R50l+UMNIRWCjbsq/EbNKiD1bgBhoQxknNHg0Fin6n8dd4MdmSnj0qN1I9MqzKKgd3D18ubX90GhB7PD90KdTbHeKAvi1l12HTt9zJtWeQ4CqOKbEQi5kml+ztV2ohZDlvpS3UTMaxhzDoCyC5vQWg0o5xZwWnjrk48T7rYC7l X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 18, 2025 at 9:17=E2=80=AFAM Maciej Wieczor-Retman wrote: > > From: Samuel Holland > > This allows stack tagging to be disabled at runtime by tagging all > stack objects with the match-all tag. This is necessary on RISC-V, > where a kernel with KASAN_SW_TAGS enabled is expected to boot on > hardware without pointer masking support. Same question, is this needed on x86? > > Signed-off-by: Samuel Holland > Reviewed-by: Andrey Konovalov > Signed-off-by: Maciej Wieczor-Retman > --- > mm/kasan/kasan.h | 2 ++ > mm/kasan/sw_tags.c | 9 +++++++++ > 2 files changed, 11 insertions(+) > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index 129178be5e64..2fb26f74dff9 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -636,6 +636,8 @@ void *__asan_memset(void *addr, int c, ssize_t len); > void *__asan_memmove(void *dest, const void *src, ssize_t len); > void *__asan_memcpy(void *dest, const void *src, ssize_t len); > > +u8 __hwasan_generate_tag(void); > + > void __hwasan_load1_noabort(void *); > void __hwasan_store1_noabort(void *); > void __hwasan_load2_noabort(void *); > diff --git a/mm/kasan/sw_tags.c b/mm/kasan/sw_tags.c > index b9382b5b6a37..94465a8a3640 100644 > --- a/mm/kasan/sw_tags.c > +++ b/mm/kasan/sw_tags.c > @@ -71,6 +71,15 @@ u8 kasan_random_tag(void) > return (u8)(state % (KASAN_TAG_MAX + 1)); > } > > +u8 __hwasan_generate_tag(void) > +{ > + if (!kasan_enabled()) > + return KASAN_TAG_KERNEL; > + > + return kasan_random_tag(); > +} > +EXPORT_SYMBOL(__hwasan_generate_tag); > + > bool kasan_check_range(const void *addr, size_t size, bool write, > unsigned long ret_ip) > { > -- > 2.47.1 >