* [PATCH] kasan: sw_tags: Use str_on_off() helper in kasan_init_sw_tags()
@ 2025-01-16 6:24 Thorsten Blum
2025-01-16 7:39 ` Alexander Potapenko
2025-01-16 19:16 ` Andrey Konovalov
0 siblings, 2 replies; 3+ messages in thread
From: Thorsten Blum @ 2025-01-16 6:24 UTC (permalink / raw)
To: Andrey Ryabinin, Alexander Potapenko, Andrey Konovalov,
Dmitry Vyukov, Vincenzo Frascino, Andrew Morton
Cc: Thorsten Blum, Anshuman Khandual, kasan-dev, linux-mm, linux-kernel
Remove hard-coded strings by using the str_on_off() helper function.
Suggested-by: Anshuman Khandual <anshuman.khandual@arm.com>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
mm/kasan/sw_tags.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mm/kasan/sw_tags.c b/mm/kasan/sw_tags.c
index 220b5d4c6876..b9382b5b6a37 100644
--- a/mm/kasan/sw_tags.c
+++ b/mm/kasan/sw_tags.c
@@ -26,6 +26,7 @@
#include <linux/slab.h>
#include <linux/stacktrace.h>
#include <linux/string.h>
+#include <linux/string_choices.h>
#include <linux/types.h>
#include <linux/vmalloc.h>
#include <linux/bug.h>
@@ -45,7 +46,7 @@ void __init kasan_init_sw_tags(void)
kasan_init_tags();
pr_info("KernelAddressSanitizer initialized (sw-tags, stacktrace=%s)\n",
- kasan_stack_collection_enabled() ? "on" : "off");
+ str_on_off(kasan_stack_collection_enabled()));
}
/*
--
2.47.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] kasan: sw_tags: Use str_on_off() helper in kasan_init_sw_tags()
2025-01-16 6:24 [PATCH] kasan: sw_tags: Use str_on_off() helper in kasan_init_sw_tags() Thorsten Blum
@ 2025-01-16 7:39 ` Alexander Potapenko
2025-01-16 19:16 ` Andrey Konovalov
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Potapenko @ 2025-01-16 7:39 UTC (permalink / raw)
To: Thorsten Blum
Cc: Andrey Ryabinin, Andrey Konovalov, Dmitry Vyukov,
Vincenzo Frascino, Andrew Morton, Anshuman Khandual, kasan-dev,
linux-mm, linux-kernel
On Thu, Jan 16, 2025 at 7:24 AM Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> Remove hard-coded strings by using the str_on_off() helper function.
>
> Suggested-by: Anshuman Khandual <anshuman.khandual@arm.com>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: Alexander Potapenko <glider@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kasan: sw_tags: Use str_on_off() helper in kasan_init_sw_tags()
2025-01-16 6:24 [PATCH] kasan: sw_tags: Use str_on_off() helper in kasan_init_sw_tags() Thorsten Blum
2025-01-16 7:39 ` Alexander Potapenko
@ 2025-01-16 19:16 ` Andrey Konovalov
1 sibling, 0 replies; 3+ messages in thread
From: Andrey Konovalov @ 2025-01-16 19:16 UTC (permalink / raw)
To: Thorsten Blum
Cc: Andrey Ryabinin, Alexander Potapenko, Dmitry Vyukov,
Vincenzo Frascino, Andrew Morton, Anshuman Khandual, kasan-dev,
linux-mm, linux-kernel
On Thu, Jan 16, 2025 at 7:24 AM Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> Remove hard-coded strings by using the str_on_off() helper function.
>
> Suggested-by: Anshuman Khandual <anshuman.khandual@arm.com>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> mm/kasan/sw_tags.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/mm/kasan/sw_tags.c b/mm/kasan/sw_tags.c
> index 220b5d4c6876..b9382b5b6a37 100644
> --- a/mm/kasan/sw_tags.c
> +++ b/mm/kasan/sw_tags.c
> @@ -26,6 +26,7 @@
> #include <linux/slab.h>
> #include <linux/stacktrace.h>
> #include <linux/string.h>
> +#include <linux/string_choices.h>
> #include <linux/types.h>
> #include <linux/vmalloc.h>
> #include <linux/bug.h>
> @@ -45,7 +46,7 @@ void __init kasan_init_sw_tags(void)
> kasan_init_tags();
>
> pr_info("KernelAddressSanitizer initialized (sw-tags, stacktrace=%s)\n",
> - kasan_stack_collection_enabled() ? "on" : "off");
> + str_on_off(kasan_stack_collection_enabled()));
> }
>
> /*
> --
> 2.47.1
Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-16 19:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-16 6:24 [PATCH] kasan: sw_tags: Use str_on_off() helper in kasan_init_sw_tags() Thorsten Blum
2025-01-16 7:39 ` Alexander Potapenko
2025-01-16 19:16 ` Andrey Konovalov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox