From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51893C02183 for ; Thu, 16 Jan 2025 19:16:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C29356B0082; Thu, 16 Jan 2025 14:16:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BD92A6B0083; Thu, 16 Jan 2025 14:16:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA0176B0085; Thu, 16 Jan 2025 14:16:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8DAE06B0082 for ; Thu, 16 Jan 2025 14:16:50 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1626AA1184 for ; Thu, 16 Jan 2025 19:16:50 +0000 (UTC) X-FDA: 83014272180.20.86F8088 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by imf14.hostedemail.com (Postfix) with ESMTP id 0D75F100006 for ; Thu, 16 Jan 2025 19:16:47 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=N9PwwcJu; spf=pass (imf14.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737055008; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fxEXl8+g5LwoZnSgSIO6iwq0ws9GZxr6F7mGjKX9OjY=; b=m2EPzrcZ6bprTPLsNx4zRJ2EpiG5i7skTcrFeQQNoGgTy4oWp58ASmi60x77rTQVqEt4E6 3Q13VbMHRAtofJVojIpgeKX50vnUZ9F3oLDLKAyHKIdZf/HgFJOOhFwg3qd2luVjOhdDkA /a7Dk+ciIt5P7wnQeLmwqelIfW5kndg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=N9PwwcJu; spf=pass (imf14.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737055008; a=rsa-sha256; cv=none; b=qScUaM7Y5SI3XrdIZGlQ6p5f8ZiWNUhFeN5nDM1NfQyB8t3nvjRO5J2nbosJeixRpCvvEf zZu2+3DaJK1zQmXRnfxewCOCCtfNXyybFeNifHfCCJG3ZMB8/P3rHC7kP0hSbOZmLb/Ke7 iLUAVpXK0jOutI0BXEWuye6lTnueRkw= Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-385e1fcb0e1so708525f8f.2 for ; Thu, 16 Jan 2025 11:16:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737055006; x=1737659806; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fxEXl8+g5LwoZnSgSIO6iwq0ws9GZxr6F7mGjKX9OjY=; b=N9PwwcJuucoKv9fGplrFUlDxBkefaVi9M4LorB4elyI9de/8NpRwoVvS7xPUcKM4gt X4I3egKY6x+SR0Fe1E6oFim7BZ+Jy3AVbPTZ3ahDAdXSc7u34LVyN2q2qFQYdWu/th2B LAjOF/yRubOI4RV8IjhKlNMxTY+zwog5skZWxdukl3iEO52vY1Cx9Tff6a382EFP35d4 4dYgI+Ko5ZieghOP3O2v+iLdhG0767Z8iSqPQ+u9mIlNclirxgn/k6hSrTEB2ax4BNGM m+kChKYFOBGt8cmDbVoSp11lwzqgLEaJiqJFJTB1+kfJYI+ya8dXSFnFUCAL1RCCPC8P X+Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737055006; x=1737659806; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fxEXl8+g5LwoZnSgSIO6iwq0ws9GZxr6F7mGjKX9OjY=; b=mt1C8AWigDv8gnCdt33yp+20tNdc33j1hdCtyaO++YhPFRhz7XI+RMGxvVhlCWpp8c XqfkyLpQtoltFujanjwjYdI2blevuShZMMIrVbUVTWgCA0M/W7/ZLdXWXQhh/dsVtmR7 n3V8qiNFp6qbPuWCzWmf0lLme4eNrLzPwLEHGHsH6rqEVs0yGxjDzGe4Hn8hiqhnBzZY xK6EFJcpd+wvjcO9ejcI/1nnMA9SIo73hJZe21ckPtTOVQCdg7HMPEw3f4czzryhzDm9 8luIyruz+8KbSyJWw1tzJp56gQMQ/y0Y2KebxIsQpCjtMwrc+MkhNbqeaHKshwzKxi09 WoYQ== X-Forwarded-Encrypted: i=1; AJvYcCWwRigKgqOJwfvlcTdBpc0WbG/FWhg1PCcg4+2SmI3izjV2+5VcPUAMdqlnKBIzrMWa37+MzCYv0g==@kvack.org X-Gm-Message-State: AOJu0YwuPuGa+Shm5aqMkULQSRs20EfGHoODklKUt1TeXyMtue4IaNgb q6PlxO8TP6jQnPW9FRAqSmPdl9s3QBp9Abqe8CIkrLMG9rQxZTK3p4CjtUlE1lNuSAeCNJ6pYSp nZly+rBp0Qbau/wZIAvdn9lJZDXI= X-Gm-Gg: ASbGncvhndq1pdL234p/5/LPVIlAT9DpL1cvvCsb5ydT9l1+kJZF89wOETggYTBnAXl uXNpAgVR2EyJa8K+KnRkxotxWcRn3FQun92TNwY6/ X-Google-Smtp-Source: AGHT+IFNiVFgiFOHLUEp0scRMI6BVSuPvnb5w27efH7OzvkoJ8QPYFKDtSTjjyTzSXfe3wN+uYtQFtpLd2CUHLmEeEI= X-Received: by 2002:a5d:648a:0:b0:38a:4b8a:e47d with SMTP id ffacd0b85a97d-38a8730ac0emr29702774f8f.26.1737055006251; Thu, 16 Jan 2025 11:16:46 -0800 (PST) MIME-Version: 1.0 References: <20250116062403.2496-2-thorsten.blum@linux.dev> In-Reply-To: <20250116062403.2496-2-thorsten.blum@linux.dev> From: Andrey Konovalov Date: Thu, 16 Jan 2025 20:16:35 +0100 X-Gm-Features: AbW1kvYx2BWTuOi1__7Q_bouYtTV5B6qSUEJxXxHQ_ChT-FL1MlESv_pCdPCpmA Message-ID: Subject: Re: [PATCH] kasan: sw_tags: Use str_on_off() helper in kasan_init_sw_tags() To: Thorsten Blum Cc: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , Anshuman Khandual , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0D75F100006 X-Stat-Signature: 8wse35jzdfa7p4q6cy1gpgw3q7naibx3 X-Rspam-User: X-HE-Tag: 1737055007-46601 X-HE-Meta: U2FsdGVkX1+onyWFjLINEQgk2w9sNCXyVN6eblGYx5PVFzIVVD4YHnqyRCF8J9QgUzhtm1h08NtG+hi/bvIU0xfqCdgcMFz+r3nPfzqh8MYERdUyR1JSgEfCM6QoJ8+QC9RJNJRH7WWmfftpZM+56bOfXj0yMgoPlRHoITXBLOeOTA1Rr/NBKVg51vZ83SyP5EUHdJ0V3bOiBG6Tfd+zYug4pOyjKIEHFOBKr3kaaNPknSMnHnLo2pzZZ977CUl7QUtJwYfnFQOcWgzuN44P/4L2iM3Rf+yCtwN/G1k9+TKwQcMpvz/0Spc24sTMZ0OyXf7Pu+VlkuGElKC4KGn9OvovH7btQ61cTtXLEXQCSTSlMjjE6uAAHckk0BGLsbaX2nnK6Jc3AJ8d8vLfxmWcXcTyae0LloZ2rzf0a8tSDjemTk0QzUOYXQ/NQzKgsSdyZlMJ/d9kbapkcIezyR1iPl4/vpov+KBpXu8zVqu2oTDujqbHVnGuopw/Lb1zuZYtdIyw88nJWue8qpAHGgEV7hWjPIxYCtgk+wnN8X1mCTeym2wvc2gtpdgay4e7WjUZ+PFz+ylgfoebyea5al1mzO3f/MQOzlahVo9Pn1fQwQdnibvQ76XNLiqYG+bWxM3LYgdac41cL0JOkbDuPZCO/kyRmVTYRoRJHCSZXdCtLd1kp1+r/57kPVzgAaBqhldsf++y7o93onPjQxlNNp9WIGI7Gf73agGuUUD8a6sdgi+R8UEPmcFGWXSmQJ1C2yu4PkZbXdntzyoq1Yd6OmORUQy5rIAyjAMVJX7nQ14ZXG8DbLl4qyKQOfZbZ/xvp4LKo1q58dNGY0o8saM41jeRuJ/nPuw9k7j+uLQBRii1yVvH7U7oJgq+jz2Jl78F6HzPlmfjJvWNnOM2GLxwOh3mglXGDRhlMzjfg/dgRQ6bIaHXANwaxGLU67eaN6wL8V3bRbfO7GgP9ZAI6AnHNFy ZUvYFadk /EtTOWchOtqSCCyU8l12uGbGWAgULh8sG/R8Eze2TWBZtexAr0DC7bPSFtLMnRoqPHR6EFNnRIQsNs1K8ennqxrgc1zihnEEwRoHj5q/O8srHl0UAf8XzAfB684iM90Zlu88yB+fnDZqUolGRamHFW/BSFlnIgwk118mkZkBuoN3ov97o7LRvsb0QPULEldYmARRFa3Rg6KASJAmiAoIQuON0uYaWWQ6m23x9CQlqjyo4qWyJ8SX/55i2Ne2uh5+wcL7eAMTATXuE0ORj0Uq+F+SNzx8Tl1imhvTciJwJK2gsf7VByqpRiEKs2wm2kKxQfMq7SrjoONxWjq90z1dPzYvD9kjxvfir4KpCThRr0XGlWKw6QCgbembwi/+m0ez3w6sGz8A4PlE9/C80fFqPX5ZoeZSluWvnqQEBCF7Z3NpSKR5P0IYJ8XeqBvv/9DCYdZ1cywyiGBYHIXGkl7rNRAscWlf8die1taEIaZX8unRERuMRuAnadq+ozv90bG6l5/OG7+AH0Hk41Sk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 16, 2025 at 7:24=E2=80=AFAM Thorsten Blum wrote: > > Remove hard-coded strings by using the str_on_off() helper function. > > Suggested-by: Anshuman Khandual > Signed-off-by: Thorsten Blum > --- > mm/kasan/sw_tags.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/kasan/sw_tags.c b/mm/kasan/sw_tags.c > index 220b5d4c6876..b9382b5b6a37 100644 > --- a/mm/kasan/sw_tags.c > +++ b/mm/kasan/sw_tags.c > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -45,7 +46,7 @@ void __init kasan_init_sw_tags(void) > kasan_init_tags(); > > pr_info("KernelAddressSanitizer initialized (sw-tags, stacktrace= =3D%s)\n", > - kasan_stack_collection_enabled() ? "on" : "off"); > + str_on_off(kasan_stack_collection_enabled())); > } > > /* > -- > 2.47.1 Reviewed-by: Andrey Konovalov Thanks!