Re: [PATCH] kasan: sw_tags: Use str_on_off() helper in kasan_init_sw_tags()

[Andrey Konovalov <andreyknvl@gmail.com>]

On Thu, Jan 16, 2025 at 7:24 AM Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> Remove hard-coded strings by using the str_on_off() helper function.
>
> Suggested-by: Anshuman Khandual <anshuman.khandual@arm.com>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  mm/kasan/sw_tags.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/mm/kasan/sw_tags.c b/mm/kasan/sw_tags.c
> index 220b5d4c6876..b9382b5b6a37 100644
> --- a/mm/kasan/sw_tags.c
> +++ b/mm/kasan/sw_tags.c
> @@ -26,6 +26,7 @@
>  #include <linux/slab.h>
>  #include <linux/stacktrace.h>
>  #include <linux/string.h>
> +#include <linux/string_choices.h>
>  #include <linux/types.h>
>  #include <linux/vmalloc.h>
>  #include <linux/bug.h>
> @@ -45,7 +46,7 @@ void __init kasan_init_sw_tags(void)
>         kasan_init_tags();
>
>         pr_info("KernelAddressSanitizer initialized (sw-tags, stacktrace=%s)\n",
> -               kasan_stack_collection_enabled() ? "on" : "off");
> +               str_on_off(kasan_stack_collection_enabled()));
>  }
>
>  /*
> --
> 2.47.1

Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>

Thanks!