From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 861D9C433F5 for ; Tue, 14 Dec 2021 18:29:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBEF66B0071; Tue, 14 Dec 2021 13:29:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D46616B0074; Tue, 14 Dec 2021 13:29:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC0516B0075; Tue, 14 Dec 2021 13:29:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0018.hostedemail.com [216.40.44.18]) by kanga.kvack.org (Postfix) with ESMTP id AE7936B0071 for ; Tue, 14 Dec 2021 13:29:10 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 6DB828249980 for ; Tue, 14 Dec 2021 18:29:00 +0000 (UTC) X-FDA: 78917236440.14.40071E0 Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by imf29.hostedemail.com (Postfix) with ESMTP id 50BBB12000C for ; Tue, 14 Dec 2021 18:28:57 +0000 (UTC) Received: by mail-il1-f179.google.com with SMTP id m12so5163844ild.0 for ; Tue, 14 Dec 2021 10:28:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/eebjakvP32P8uCIh8l8LVBJtnJ0BrHqeLhOnlTGnSw=; b=YtmXK3JnkvyyVA5xRFhf/RPO1p91z6a9njyTx5RFN2G7G/13J5IDhreG/c1fKFOT4x i333CBxEM33ImfuwmdorFD0ok8OalxM6qQVUPgFxQqpPweTPnuf2CH7A/3scLZlsU+rP jgOrWrqTnZ1id+qeVUIgFmPJ0NCSt8KNkrGjH5tzwWfbMXLP4PPnGP4zLz49sSZl+K0J uAxcouHH7s2UXr9u78H4buraJPWOfu2Qud08LaiS06ELHunVhHLZ6JD/WMLPMv/HZMb/ cuTHv3bivib40wW5Ub3izhbKFbZ46yusYbbQrpFqCs9x3NnZpLrXKmjErq0A5dLKDIdb SA9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/eebjakvP32P8uCIh8l8LVBJtnJ0BrHqeLhOnlTGnSw=; b=fntr6aR2cBhbs/NhgIx8twMnWt3AQKYi2jk5mvnyE4GMfk9PCsGW+srS0oG1ll2IZR lZh+T5EkWoyK7u3ivJipogCrn4Gvubop8ApouZi652KeWdxgl60cWjCG360rHhSbwvG1 MJ3i42PRDpI2iMDk78a/HZUe69alCmIi9OQv6Bf0Ho3iDGj/XBvwEg47NmJncPckbtFQ DIvXsdTK5S0smu0wvJeyJH3GhMD7+CCCwvtmd/2p7+x3Jsej4EjwVJt/BMM7h1D+K2sj 4MowkgV9W6EUpscaAlk+QI4qeI1o/YDykQIGDHWyrC1UdvEKHgMjXuXvaT5lq+GutI6N 26YQ== X-Gm-Message-State: AOAM532yrkZ09eSfpDpIUb6TqobKNVF3zyZExQHceLaXWazEmgW4GXjh Ogmmo38ZFSphe/zGhjGiOQ+aQsJ0Vz0stEllRh0= X-Google-Smtp-Source: ABdhPJxhYREczc9iLVovDzjU48QsJU0KQxIpCixjxea5GpU3byn+IKq4EL/Z4k1bbyGdAhZ9hlMtlKWk1xaYURinc9g= X-Received: by 2002:a92:c090:: with SMTP id h16mr4769444ile.235.1639506538741; Tue, 14 Dec 2021 10:28:58 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Tue, 14 Dec 2021 19:28:48 +0100 Message-ID: Subject: Re: [PATCH mm v3 28/38] kasan, page_alloc: allow skipping memory init for HW_TAGS To: Marco Elver Cc: andrey.konovalov@linux.dev, Alexander Potapenko , Andrew Morton , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Linux Memory Management List , Vincenzo Frascino , Catalin Marinas , Will Deacon , Mark Rutland , Linux ARM , Peter Collingbourne , Evgenii Stepanov , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YtmXK3Jn; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.179 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 50BBB12000C X-Stat-Signature: g7733wzcoof6g5oq3ni95zpsf66e9wq3 X-HE-Tag: 1639506537-6300 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 14, 2021 at 7:00 PM Marco Elver wrote: > > On Mon, Dec 13, 2021 at 10:54PM +0100, andrey.konovalov@linux.dev wrote: > > From: Andrey Konovalov > > > > Add a new GFP flag __GFP_SKIP_ZERO that allows to skip memory > > initialization. The flag is only effective with HW_TAGS KASAN. > [...] > > - * is being zeroed (either via __GFP_ZERO or via init_on_alloc). > > + * is being zeroed (either via __GFP_ZERO or via init_on_alloc, provided that > > + * __GFP_SKIP_ZERO is not set). > > + * > > + * %__GFP_SKIP_ZERO makes page_alloc skip zeroing memory. > > + * Only effective when HW_TAGS KASAN is enabled. > > * > > * %__GFP_SKIP_KASAN_UNPOISON makes KASAN skip unpoisoning on page allocation. > > * Only effective in HW_TAGS mode. > > @@ -242,6 +247,7 @@ struct vm_area_struct; > > #define __GFP_COMP ((__force gfp_t)___GFP_COMP) > > #define __GFP_ZERO ((__force gfp_t)___GFP_ZERO) > > #define __GFP_ZEROTAGS ((__force gfp_t)___GFP_ZEROTAGS) > > +#define __GFP_SKIP_ZERO ((__force gfp_t)___GFP_SKIP_ZERO) > > #define __GFP_SKIP_KASAN_UNPOISON ((__force gfp_t)___GFP_SKIP_KASAN_UNPOISON) > > #define __GFP_SKIP_KASAN_POISON ((__force gfp_t)___GFP_SKIP_KASAN_POISON) > > > > @@ -249,7 +255,7 @@ struct vm_area_struct; > > #define __GFP_NOLOCKDEP ((__force gfp_t)___GFP_NOLOCKDEP) > > > > /* Room for N __GFP_FOO bits */ > > -#define __GFP_BITS_SHIFT (26 + IS_ENABLED(CONFIG_LOCKDEP)) > > +#define __GFP_BITS_SHIFT (27 + IS_ENABLED(CONFIG_LOCKDEP)) > > You're adding several new flags, I think you should also make a > corresponding change to include/trace/events/mmflags.h? > > At least __GFP_SKIP_KASAN_POISON is currently in there. Indeed, will fix in v4. Thanks!