From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59686EED619 for ; Fri, 15 Sep 2023 16:51:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B97758D0017; Fri, 15 Sep 2023 12:51:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B47DD8D0005; Fri, 15 Sep 2023 12:51:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A11918D0017; Fri, 15 Sep 2023 12:51:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 931C28D0005 for ; Fri, 15 Sep 2023 12:51:02 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 71DB61CAD8C for ; Fri, 15 Sep 2023 16:51:02 +0000 (UTC) X-FDA: 81239421564.09.ADBDF80 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by imf29.hostedemail.com (Postfix) with ESMTP id A779912001F for ; Fri, 15 Sep 2023 16:51:00 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VkcJcaQU; spf=pass (imf29.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694796660; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C9N4U7m1ENfkMXf6AuPL4MT6Lni4JryuzWdzOGtlKI8=; b=j17izVQL/71lhWSRZzNWsh7KtObc9V8NaFctFP4X+OEF+lKiSZsKZ/IsnHI0eqBhVBH8KV Cmbt+q0x/Y7L7qAhxWofuIWH/Cx0guPExbsp3/sY/hXQiwz3/F6N604LGxwObyqdBscsKc xI1McDuBXSpA/GPdppJc6QCFzSVrH9A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694796660; a=rsa-sha256; cv=none; b=vWGkFYsOHNQH1hhseWTuJDUmBOh6hYGETjVdeGJDJVHNj56N7QjWBuXlGFuceRpwN1Idel HPGhn3U1nJYT0mcuaiRCvEq7GsQo/4099+TEDYWeqlNz2QEC7mQpb607BVzQVp/NJ3SihS 5QWvlp73CpHHz+HE+p4JmPd16avUh7o= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VkcJcaQU; spf=pass (imf29.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-53fa455cd94so1732016a12.2 for ; Fri, 15 Sep 2023 09:51:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694796659; x=1695401459; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=C9N4U7m1ENfkMXf6AuPL4MT6Lni4JryuzWdzOGtlKI8=; b=VkcJcaQU2fu7u7nurkKqSWUFhaB51987owFtBWt2KTeB0EjMjD07Li08QqFjDEG0mx EYoMxALILI9k9gbGfVcyWiMNjFzECJB5DFj5HC1w6c5Ud6Bu/qR9lY0WwmAI6E6PQXyz dsdmgWHsY+TAg8Yd7Imw76Cgzpg2cN9MT+Ahk3ICgLgvjZg5Ds216jBxy6iRNlEdqnun o6Qqo5eGQgb5AbFpGeQMjddw6EfQDWTx5eXoBIOq1KMgifNBBHU81K21fuqNMPdXJWgG d6zWuvcfDyu1jDZi3Ee8Pc/zH/N9VLFTJJxMeu9ypYobSdJKlV7M75WAQs6YlIMJpwOo noGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694796659; x=1695401459; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C9N4U7m1ENfkMXf6AuPL4MT6Lni4JryuzWdzOGtlKI8=; b=DveHp+57lZiDmM9Ed+qO06XeTk+8qlupxeNS2pbyaokgDF6wbHLufY5Gj3zpy+HiDC nSNcOZam2UFSAwXfdEeUeyBnqzHDzdndEeSlzyjoNrvX9SKohUblFg15PqhqU82woSAE Idrw3OhCLH6Q4e8a+9/ETuIDulZsQAebrXMpvzmX9psekZm+u1Bn6Z0VKTVylcWJolAT koAamnpLkCbC64ea6qxdjpKopnZdd55ZUynw38/cV3oC4jRWBsLuB24SLvRaUvDxwKOb cMjdPcznk0paMqWsLgxEbzOwvdFMU8a5SHCJuIYChKZBA4792KJxjHE8KZgj4vM2VSWD OL8A== X-Gm-Message-State: AOJu0YxKX5G5I4GRNX/jMraOsykeIpuXMiNDs5uTskq5Ai5dkOu42AE9 B7A6xA8L/w8ZGAsbF0R3/rfWRYpknfv9fhKhwto= X-Google-Smtp-Source: AGHT+IGbqKZHfQYVZyeiRIfx3Rau8VcK1iGF77tUw+uQyQtNqnu5UagzuHOH8rpnQb8Ka+6MLiQbWH8tpwggqtgwVnk= X-Received: by 2002:a17:90a:f312:b0:273:e42b:34c1 with SMTP id ca18-20020a17090af31200b00273e42b34c1mr1902942pjb.42.1694796659560; Fri, 15 Sep 2023 09:50:59 -0700 (PDT) MIME-Version: 1.0 References: <20230915024559.32806-1-haibo.li@mediatek.com> In-Reply-To: <20230915024559.32806-1-haibo.li@mediatek.com> From: Andrey Konovalov Date: Fri, 15 Sep 2023 18:50:48 +0200 Message-ID: Subject: Re: [PATCH] kasan:fix access invalid shadow address when input is illegal To: Haibo Li , jannh@google.com Cc: akpm@linux-foundation.org, angelogioacchino.delregno@collabora.com, dvyukov@google.com, glider@google.com, kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-mm@kvack.org, mark.rutland@arm.com, matthias.bgg@gmail.com, ryabinin.a.a@gmail.com, vincenzo.frascino@arm.com, xiaoming.yu@mediatek.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A779912001F X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 1gjngsu1tyf7who37h3we45wsrufkjy3 X-HE-Tag: 1694796660-10974 X-HE-Meta: U2FsdGVkX194gWzeb0GP5IGs9Yz0GnKnATR+JoZe604YWZwb0yh1pujyvqAJdt0ZYUx2LZc1+DwigvJfSfFlAoRwwwIKHyPOnUpKBhVecZ1odHD/vNq+2zbSwVjj1r/vaKEqCLBobpMAYuGmBhisTTdtBCXZ5AOKfLlz1j3uXNDQ0GIiGzOWwXCiQ5a5RViU0fEmQc38tnY1KZdskKqDQW1kSYqDARboQXAbZgpRuGxyu8AnfclxH97D36ZjBryQPTvZwO+iIhTyEVL9bPHU5HzMXCn+PG93mJP3/G/KTjA7j42a4iqBT/Prqkkm66qnRGmOmmlTMnaDo5jPdSOX16LGLHdEEl9WpjoCVSi9JPctSHACMXK8AhbnSr960m+RWZBsZ48bHlPHfCutfxDrFF3GwIUJEX4GVzuAyr9qMtDfsMd2y/WaVTKq23vp7G02jP4rSCyWymaBl+BF7sfr/EV7OfOgV2BHfzLh6uvWLM2pi/BfWXhMIEyyxI7gaN2e3+mRekf+Xldpr9E311UxvNejCVkwFuJpDoY3kMzl5hGqJgG79zDQcF4WEmrLK99/jJYR6MttYBIVedYwWc8r6n0QX0j74mxYIms1Aezq32A9tHHVhHoNHJxnDX+eWsXAY4Ige/47cwrPjQJJpqMEfpjMzeD3FvZIsdwYxDLj8WoXs7ir+uQmZkwhaRs+yqKcH24gEBKsW+evp0Qkt5PVEtAvnGapwkfM+atK0YidyYgatB9Xowi9aFsQ7mXbBtWu2i19xotlfBHSDZp0fjWfhilDbIBzK2Kn6/lOyvvl/WKFOFi3TnP+4XhbO9LhrmY6sLx+htNgZJbQe1+xnv6LicKjNfYlANaeP9LXSY2YQv/8NAPo9It/9z7lIGU9MPaDb715KckhYCMcxONDoWVKAV4rebi0KP7pn9EJuzTI1OyLOKQioMJvBapkDsS2pXFbFJ4sLY88FV/Hk07bF6x klXYYcjj w2HG/RypBKEqbYNl7u9p0gW/KNZf3p5I8KcjTTfViYcdc/VyLcxck/EVGjTHAK0kJ9IxftCiUdOyVMT8ZPlbKX8pEr2tvJS0CSU1QstVm5ljx+5YPBrF7ACp0HK2GOuCvgwCEhTGfpBuODSz8B+vhLWx1jXtx5QEQ2ETdzEt6GIh9L60M0WuTBRxI1CPBQsB7F8KO3QU029On2q0iCdnN+pM2f6m8bmtsPXbfGPjL+xjIsg1IgJ1sKQGN+ux11B23hiQ1KcFG0sPt9Bq22Hts5NXf3N7s55wWq/7o96USVW2LRk5h3L6Zd+NBFzhIMrbtawr+rraHH5c9L8eX8u9uly2YBkxnGJtdrSg3gz2g717Om7xY9UAhTkKOWu5b/v2q8QtQPmAsvChmUBdUwgTSZtLHRKIehY45OefPbHQcKmcXij2XTHh8LWwY+fyTWO29G3UcvRCk/J1U2IgCqWAbB2C9ZBXhhfy+y7HZlMt1uQWc/F0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 4:46=E2=80=AFAM 'Haibo Li' via kasan-dev wrote: > > The patch checks each shadow address,so it introduces extra overhead. Ack. Could still be fine, depends on the overhead. But if the message printed by kasan_non_canonical_hook is good enough for your use case, I would rather stick to that. > Now kasan_non_canonical_hook only works for CONFIG_KASAN_INLINE. > > And CONFIG_KASAN_OUTLINE is set in my case. > > Is it possible to make kasan_non_canonical_hook works for both > INLINE and OUTLINE by simply remove the "#ifdef CONFIG_KASAN_INLINE"? Yes, it should just work if you remove the ifdefs in mm/kasan/report.c and in include/linux/kasan.h. Jann, do you have any objections to enabling kasan_non_canonical_hook for the outline mode too? > Since kasan_non_canonical_hook is only used after kernel fault,it > is better if there is no limit.