From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01FEFC001E0 for ; Mon, 23 Oct 2023 16:16:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 94A276B00E7; Mon, 23 Oct 2023 12:16:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FA246B00E8; Mon, 23 Oct 2023 12:16:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C2E46B00E9; Mon, 23 Oct 2023 12:16:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6A2E76B00E7 for ; Mon, 23 Oct 2023 12:16:47 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 47ADD140164 for ; Mon, 23 Oct 2023 16:16:47 +0000 (UTC) X-FDA: 81377229654.28.38CC237 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf17.hostedemail.com (Postfix) with ESMTP id 7A1C84001D for ; Mon, 23 Oct 2023 16:16:45 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ldH0fhS6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698077805; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HgO08PRy6IyNU2zj7g2IPBwXTxM3jF14s2Iin9hZx7o=; b=Tpj+E1n31Hepz0j05gRWueJWrPOnIgsm0je8gUBgUU2BPlebuF6/S4xcnmipDLAFPy3aXz M2NZ7eKzF2TcMqdTiNidyysTt+IVzqWeQX4QRNS0mL28P0Bb1r5cMth33LdeK0e7UhK9ea 0PuYdQFJWRK8rC6bvwVYDf0KLbKqJNE= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ldH0fhS6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698077805; a=rsa-sha256; cv=none; b=XHlbS6dseP7A8/YoJtdEpNg0BfysEYP3eHaSZaNuS8slWLIQOD15st0fdowWjkN6mlKzH+ VAMxjBBTA4k9pVTVHMOfTgabGDjkqS2TE3OApfoK1CNxU24G2NRs7r8vG9hvfjw/3Hb9gL jx7pfk9DswWPoiNwjew7AUDER0ihNRA= Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-27d3c886671so3008734a91.3 for ; Mon, 23 Oct 2023 09:16:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698077804; x=1698682604; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HgO08PRy6IyNU2zj7g2IPBwXTxM3jF14s2Iin9hZx7o=; b=ldH0fhS6NFSHDifYHpp9Upa7Rppy+dkzQDsbpE7KZv336NyiYAT4HmOaQkwD8Bd9NP qhwsAYHFMUx8zs+fTGlUbZwU2nwWGQUHjQQM3+KjS1yf4+sIxq76ksGNd3CRO1g19WjU N4NnaYChRhFezhgS/2GS6bHc2iq0tLtQMX2TH39Dn2H8FLsv7GcCPRyTisL7uRSp4H9g Tyvzi7Q8oA5Z5jj4TCMcEm9/+EA7PrOdJVKJM3iqp9oKMOv9JcUguuzCzE5RHhXRUTao UNx0DaixGTvf6duyS4VQuwtmWIkFsFUdQYukeU8QRVeRvh5HZqvMjPai/kMVw97lyP2D r3TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698077804; x=1698682604; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HgO08PRy6IyNU2zj7g2IPBwXTxM3jF14s2Iin9hZx7o=; b=SG5rfeq/edE5V3sAct7olppDYD0LDVJkuIPDcv5BpjJJt/Zkv60KDTwjVA04qao09x OjuMBlYCiTvUQCA7K4ZdEW+KxovkPRGdvOOuYaLqDX8kZCYwSeXozeel+q34JJR+afNy Z9TInT13SRO/XE/RYRFBfBZYroRJp+dqpEczmgD5qdC0EOccBjez/RnVrF/B8KMa1sZV m2yrRGY653zfYl5pnmEAPXx251yoy1RGGFWE8qtnYhKyPisVHY5sIqJV4Tz8mAmH7k2+ bat+ugfnsonvLH02MFxGryIu+VsAJE6Lq4YEUebrsiw0UeI7g4DNgB6BPm+jQ16Id/UX mugQ== X-Gm-Message-State: AOJu0YybuHTdDCgXXiwLV8bPk0Ey66QzUsXA08QTDi1VUz+Nacym1dd7 UU6ux1ElsvEWMgCjyUmT8+iC3I7euBOyRW9QRxA= X-Google-Smtp-Source: AGHT+IHU8vWzMm3Qu76s5FUntH87DK+b9fMCqsfGw9STYJqnf7wjxC7ijlxvgKyRU4gMl6MQp2SUfOD5j06vnDV1260= X-Received: by 2002:a17:90a:195b:b0:27c:f845:3e3f with SMTP id 27-20020a17090a195b00b0027cf8453e3fmr9585255pjh.1.1698077804386; Mon, 23 Oct 2023 09:16:44 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Mon, 23 Oct 2023 18:16:33 +0200 Message-ID: Subject: Re: [PATCH v2 07/19] lib/stackdepot: rework helpers for depot_alloc_stack To: Alexander Potapenko Cc: andrey.konovalov@linux.dev, Marco Elver , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Oscar Salvador , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7A1C84001D X-Stat-Signature: nrkzpw36gosdspxx8h4e596fpn55rbmc X-HE-Tag: 1698077805-470251 X-HE-Meta: U2FsdGVkX1/+Tu++eh1pZaz5dSxa4mcgZ0O4+0ffsD/aD+YGahgVBO0kr8kFf5ZRhhYnM22cqjo7LZsCFQDSWNX/ZJY3k2Ip/jf2qMuy02OZVItfZTHBhOdyiLtXKJRkFM8MRxStBcOf08C/gieGCBaT/HvrXk+aNLnUoOV1U6jpy2vqlu7YFCL4w6JcVopyTO5r3JOej4sXEVGn6xpCuJfbIb4jHeVbAGDEd1K9W7SJwsogdP5pF5+B6MKxn9INlyv2sZlvuSlsqsLU/mhQbbCKgWQyoumG9+pdk6iYtkMRQiXZ4eWYG+5Of/ZHtc5WebIo6/QVNrQMa/B75FYKSC2U1J4mp/bHppWPRzzG6QcCQbmIVUovccsz5rBGcG2BmM87oiqZ6t2ovCHLUEM077LeFn+5Xg4amAW4k6VmVxq1qdAcHh4xKwS+SAZQoAnAFxXaJElivWCn8RKX1gFVEsjbkn+kLmmTdxBbZ2gE7byOVsEQ6gpfIb9TV+pUiJ/qGwGGMl5bCc92vj7Z8PXGfkl/ee+mLt42d4ixGBBl0Defg/24rq9R0VPj0ZsDsfr2zxl/X6UGZtAJ4Mrq46z2tommnwPmA7/kCMnk3yj9cSeXDojj46uz5XHiNMH9d9oR4wdThzTUJAwLJbVl1X4SYOHbyh+1dyVGX9TTwk+SKZ3/QqZxVIHXUX8WgI8CoSgd28ybeyevwzCT31jGauWlJ3m6xOoHPciZAg4IGeN0yDQKmZsGR31ka/CQZFRDQ0Hc4RVEO1DVbV0A+RZXuQ3x5mqUYlxiFgLmSi7i4Rj6Xgu/x/DNbo6sX8N0CBImZqwhbGR7w8zehu6LG5x6F+gVco0EiHxTDke9DhZ6/KosJcPGBKZDFIfwnyiQlrl4sdYRYgvP/Fn5MXhxxfK8iqjRjVqX01cGHkYLUg8qRHQpzacgfgMitdG4y3SUhur7md6Ek+TJ/Tip61IBM9ZAS0b 6ox2/QAz +G3XRdEd70zCNr9QItMlYywGHmWGIS+ncsa+nN41Bix51wGGwngFBoIutjlyPjXHNfN1n9dJitYwTP6+JAni2YRReFoeaYu1oHXBLSH0UiYTFNN4RKjQEFYRPB8XTKQz6mhOzybeClsiPnTNQzPAA5SfJNPtjZHmWdQMtkvEF48OFY6qV0eQ1BNoF3wvDEkzeuOWYfQuZuwCYvYESLp5w5dSPaMdOazDae6nd6g4CT1rIvwSvaUkA5oZLWZAi5dmwpjN2xObO1zRjWRLw3gu2uMKs8HnGmCG0eUq5OWtoBXE6UyjhJwqAdowyFnSc1yuC70GKOlhxe5DQdLTSZzkw/xK7G+/4GoB2aQIeogKgxrJHyGp8q/TzzPbj4Kv0ll7+XeNX6FZj6duDm1+jgIoqxAVHPcPvcOyFaYMZPDJPkfhSCLV2etL2bPLlaKAxtvgV3Ss2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002726, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 9, 2023 at 11:00=E2=80=AFAM Alexander Potapenko wrote: > > > +static void depot_keep_next_pool(void **prealloc) > > { > > /* > > - * If the next pool is already initialized or the maximum numbe= r of > > + * If the next pool is already saved or the maximum number of > > * pools is reached, do not use the preallocated memory. > > */ > > if (!next_pool_required) > It's not mentioned at the top of the file that next_pool_required is > protected by pool_lock, but it is, correct? > Can you please update the comment to reflect that? I'll add a clarifying comment above this access to the previous patch. I don't think it's worth to describe all locking intricacies of the existing code in other places, as atomic accesses are removed altogether later in the series anyway. Thanks!