From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D269C433EF for ; Mon, 9 May 2022 15:50:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CB306B0072; Mon, 9 May 2022 11:50:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 879DD6B0073; Mon, 9 May 2022 11:50:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 743146B0074; Mon, 9 May 2022 11:50:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6882E6B0072 for ; Mon, 9 May 2022 11:50:05 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 320C160F10 for ; Mon, 9 May 2022 15:50:05 +0000 (UTC) X-FDA: 79446640770.10.5A0580B Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by imf11.hostedemail.com (Postfix) with ESMTP id B2F0D40083 for ; Mon, 9 May 2022 15:49:59 +0000 (UTC) Received: by mail-io1-f41.google.com with SMTP id z26so15766652iot.8 for ; Mon, 09 May 2022 08:50:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OGkep1cFKgrJ0+QYCkcQH8E9lVqym+xbFUqlGchTBdA=; b=GNqB9+dOPOgJAN/Rgmyvw+OC73ISW3HR99MI9WfWlaADf6nDOTS+TBu3SpiRznRYRU 5LOT/9Gz+134yQVjM6txYZRqLxzNgCM4/aOeyqNl75DzVfAKHNrLA8C+0JxLI/RQVHKF 4N70h0G5BK31FXQRH9JAHIiily8CdZhqzalBtINtMtBbkkYvKv/VkS6CfLCsZlWS5tol ert88JvCzo4XUIo+Yg7i6T5WecqnOX/AzanJWBJLgqkXf81RuNESX4SbVEqu0v1h4J5c 2BBetxrqAo/N8KouURZrj8zJOuyIOOnWzA5Kf72qdgHPi1UbHMBQ8tQvF31PPd6QiVHK aHew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OGkep1cFKgrJ0+QYCkcQH8E9lVqym+xbFUqlGchTBdA=; b=ci3IJ9Gvj2KY/YN2uJJt2uxqny8NJD6kasLNHvliveWRMP0D8kaNml39MPnCQp955L lHwhiJzRm3IaNMuRGBWnk98MNxJ/XAcrFdqn8nTU8uasJ3t3MZ5SSzviRc4k4yayyPhZ te5497LjPdPFEnLum9LPZt54SRw7tMJHxAXQxy0S09w6OWH1IrJq93DR9mOtK3WM/cbG q/UwBY91NP4WXqk+xotbnM5ocZpoaXhVBZASaDP/HuHZnBfeMDQV9c/rUyDXOsWDqh0z Ow+6a14mB7E6GMkvg5kSj4/SQDcDS/7/aeIiCGHAAXHGe9S17J4fzyHoVe0cpVYEFPKS CbHg== X-Gm-Message-State: AOAM531nkAyaqAWPtknpAIK4ugZqyuUjL5Gp8Rr1J4DsMHp7YaNT2Itw E87YFEzdhLovfU03nk8vW+tYEfc11kgZ6S6dPIk= X-Google-Smtp-Source: ABdhPJwfjXOo+deeBis/EeuLvTu678Fa2xzj5BBYf3N5OZHQfcNrr+qi8opcvYMoOfZ0Ne3uB2cBJToFbVxyvJgrsMM= X-Received: by 2002:a05:6638:30e:b0:32a:f864:e4d4 with SMTP id w14-20020a056638030e00b0032af864e4d4mr7221878jap.218.1652111403703; Mon, 09 May 2022 08:50:03 -0700 (PDT) MIME-Version: 1.0 References: <3167cbec7a82704c1ed2c6bfe85b77534a836fdc.1651162840.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Mon, 9 May 2022 17:49:53 +0200 Message-ID: Subject: Re: [PATCH 1/3] kasan: clean up comments in internal kasan.h To: Alexander Potapenko Cc: andrey.konovalov@linux.dev, Marco Elver , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Andrew Morton , Linux Memory Management List , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: csb6coqduuwdsd3io1b3faj9k7rkbbea Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=GNqB9+dO; spf=pass (imf11.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.41 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B2F0D40083 X-HE-Tag: 1652111399-468810 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 28, 2022 at 6:42 PM Alexander Potapenko wrote: > > On Thu, Apr 28, 2022 at 6:21 PM wrote: > > > > From: Andrey Konovalov > > > > Clean up comments in mm/kasan/kasan.h: clarify, unify styles, fix > > punctuation, etc. > > > > Signed-off-by: Andrey Konovalov > > Reviewed-by: Alexander Potapenko > > > > > +/* alloca redzone size. Compiler's ABI, do not change. */ > s/Compiler's/Compiler ? > > > #define KASAN_ALLOCA_REDZONE_SIZE 32 > > > > -/* > > - * Stack frame marker (compiler ABI). > > - */ > > +/* Stack frame marker. Compiler's ABI, do not change. */ > Ditto > > > > > -/* The layout of struct dictated by compiler */ > > +/* Do not change the struct layout: compiler's ABI. */ > Ditto > > > -/* The layout of struct dictated by compiler */ > > +/* Do not change the struct layout: compiler's ABI. */ > Ditto > > > - unsigned long has_dynamic_init; /* This needed for C++ */ > > + unsigned long has_dynamic_init; /* This needed for C++. */ > "is needed"? > > > > - * is accepted since SLAB redzones aren't enabled in production builds. > > + * is accepted since slab redzones aren't enabled in production builds. > s/accepted/acceptable ? Will fix all in v2, thanks!