From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21492C4167B for ; Mon, 11 Dec 2023 22:12:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 741036B0249; Mon, 11 Dec 2023 17:12:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F1A56B024A; Mon, 11 Dec 2023 17:12:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DE846B024B; Mon, 11 Dec 2023 17:12:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4B0F96B0249 for ; Mon, 11 Dec 2023 17:12:04 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 21145A0805 for ; Mon, 11 Dec 2023 22:12:04 +0000 (UTC) X-FDA: 81555936168.09.CA9DB38 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf10.hostedemail.com (Postfix) with ESMTP id 5F0E2C0020 for ; Mon, 11 Dec 2023 22:12:02 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=moqq4wJX; spf=pass (imf10.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702332722; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DBxEKBNamMvlGFbzwl1mFmti5qczGRc6ilz0oKWYU1E=; b=1sknzppEh8ghZFUrf13QKqUb1RZtoLJlLP0TgNtIggYgY62lk5nQozLx0Oig9Z8hEux+ja bW4EpcrMt6ntWqW/U3Ze+SxmftiWPnydNlH0bHl+X0HQUylGXykqXCYCqO8K86BzLR2pX9 uEG/SFlHGNam3WT7MuT0B99XyVELE+o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702332722; a=rsa-sha256; cv=none; b=pXDMLDOXkGFgcNuMT2Uzp3J0id9Rv8+i86/SJhSwB09RSc5RfIuM5+IP3O+SrnbdVGs3t0 is6oTcJqdwTqiTEYlT8ERQsckSBLbcfQt+QwI6dypLNkE4Y4suSElNR5ElGLmX/U34owsx gVGlupZRkr7BVe9hJJ5CYL+D5z62oGQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=moqq4wJX; spf=pass (imf10.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1d0c94397c0so29586105ad.2 for ; Mon, 11 Dec 2023 14:12:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702332721; x=1702937521; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DBxEKBNamMvlGFbzwl1mFmti5qczGRc6ilz0oKWYU1E=; b=moqq4wJXBNPUbzutix638qqjZiLEDST+2I+4Wb3i72btnMSEgqhipacX0pf9bqnCwd NgiNp/FpXv/BVI0gjstb4VgZEfu2R2GJVrE0nfuzXSSJNe37KLt5DSA5hjGzjlHzRayD fedgQ8PsIpLqw9u992zuXH9flvC3u4t/vRTc/WVQ+GEsopcCjrGIBvBKEoRSX/QUylyY tpY2JUiI3MkjDgjKOpgk17N6MQF3nZZoxXphSEJ/N+egVMmL4f1W0deaTMsVfSXqJPp+ 2GjVgb0dhvfbEsdjUBqKS+LLCUqUoZU4nlYFjdyC269DfLgtWBbo8CeLLH6mfgJJZsRC uKnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702332721; x=1702937521; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DBxEKBNamMvlGFbzwl1mFmti5qczGRc6ilz0oKWYU1E=; b=ESyMAoN84HE1+KKgd7uVkjn5lTZf9AUaqu+Fl0144d/UKpUex4UUlMmES5qcoeaZQh 1KP9d29sFimi9AiKUaIRjvXeAsIA48h4wUd7gQWXzm076EpB9MtS0LUd6mZzQGFWBzSo tYHKxDuq6lH8l1bumyr1gPGEas89he3OE8KXaw3TIWEQMchI7r2O3ZVPSVwhUuzoljuO IWED+Faxf8GEVdJivLtZ1JCDQY4slwoMhcGE1bU7lngu5RlF9NqnlTR9gou5mzDq1Bqz g8tyFD9oraz7N0Qf9LhdsvzlUlr2190OkoeMw2ssw/2dh9fKU6SgF3XeOjBQHGUKQAP6 8/Pg== X-Gm-Message-State: AOJu0YxrUE9VePYuZ7+G78+pXELedcVayRASEQ2WvJbnZgDyrLJ2d4Us XTXZ+5Tvq3Vqu7KoEtgCDxYVLdf8GCDnQ6dAn8g= X-Google-Smtp-Source: AGHT+IFUW4Y1wSl+tlZXpZOUw7PN1bGTF7r60A8/Qk9ggHCAr7HZp63IhUlul6PSahQAxJWebACXPvmodeXqe1j4W9Y= X-Received: by 2002:a17:90b:2204:b0:286:6cc1:28a with SMTP id kw4-20020a17090b220400b002866cc1028amr2291102pjb.85.1702332721019; Mon, 11 Dec 2023 14:12:01 -0800 (PST) MIME-Version: 1.0 References: <20231204-slub-cleanup-hooks-v1-0-88b65f7cd9d5@suse.cz> <20231204-slub-cleanup-hooks-v1-4-88b65f7cd9d5@suse.cz> <44421a37-4343-46d0-9e5c-17c2cd038cf2@linux.dev> <79e29576-12a2-a423-92f3-d8a7bcd2f0ce@suse.cz> In-Reply-To: From: Andrey Konovalov Date: Mon, 11 Dec 2023 23:11:50 +0100 Message-ID: Subject: Re: [PATCH 4/4] mm/slub: free KFENCE objects in slab_free_hook() To: Marco Elver Cc: Chengming Zhou , Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Alexander Potapenko , Dmitry Vyukov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5F0E2C0020 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: gshwsmrgf5jts9jsqsgdknhbwdq5iwim X-HE-Tag: 1702332722-453099 X-HE-Meta: U2FsdGVkX1+PA54tGfEC5HZo9+2OhUeOAmQvDv/cIGYTxlJUcQSZ03PR5gHBROHZYx9aDc4TxC1bEKXpzTpCp40/fgBPBOX1s+5LJpQ01QQUyC1KJDu0kwxPK+NHy19B6LqLoS9z5tDx/Ptjb5j34aWftdUofGFFWJYHNBe9bbQj0XMjO5RXJEgkEaMLNfHkXD6a5WFEGvEgfLFqtOxOPJzbqIlgjaGnEXchXVjpBHgh/uZlrVxPKcc1/cLPhB5DlZDpJdgoWoZk66554QjKNrKo/Jk5noAajiHk/X5hYAmNHqk0tfYUWi9n9oYYXPNNi6+iDNNJHre6tQ0dmbIkq8FmpP0R+YK59n5oKymHUsLCEn2WRlYwfsIsuCmv+Sa+m0fC422KidRWi/QDXVsIVROlWMyLDnYG1bfRHsCw0Sm7TMiCL4OnGuDeMXTG5DuBEPZPH9O7XJ0QSB244GOUmXEraRVdF4K9XtiNiRkvaGFwYaUs4j54HCujkDil1oKZFXzih/pZOnKNDMYOyobXWqMY6TUXd0wNkilr0pCG3AdIk8JywVks9hmVae54YAD6asJ0D2tgXiwrj0FnwWNtJetBKw9Jw0uL/eBG68i5dOqaDZYXiQA9m3rGVWtEe/O7TPJVNmUzpTonEmijnKLL5YHwrXlZbSa5UYaWbWjJOjhbqbFvK04kx1zEESaaWdg38C6kPdwQ4c+Mz5mCdI369CpWZmWZahw0cl4K5m2oKq4vrcQ8CF9Hsc5pRUtIYvT4JzC0X8goTku/DwFYSJlijykA4yAmFUqSg4fP/xVAoJu2caOlCxAk0PK7/+T1UBnWSA10bnHB+d8qzr5kt1q49/unVhKhr1XwFOs5HL/IRnVmUOtA1TqcHW+Xcd0Xe7fPFoI28yGM2tTs8yiR/iBu/EEyxfiDJ19sgcPMyuQsOKsLY0ZpUJXIeb00vdRKyCQj9ZodbXgGxcL7XtEJT+d wiyuY51y GgJL0S3K2hEAUu7YAOxlYFu9+j4QUnL1ZE3R9wxAX2fIp1AsZZ1ULeV6aS2/5QR/Ddl2a5lSn7E4sMihzv986sFgKDbmt9G+N7CCSwG+PRofhzLjTWAvEzt5sVl2N7qTpflhBvmf/uga3GyTbVBT6BBa1lqMt2nwC5c3Td9dcobAvz8drQ67jwgV3tO9LFZHICz4Y4KfoVNQ7Vdu4goxmxLCFNDm/FomK2y08vrELIojAhiVDb8SIbxrwunf9oCWEmWZ1XfRCrGRC+0OQ5sM+/2kYmBaYpXl0sRQx6Z0mfOOBNloZz/4j8lphpYgcdlRo/u4FjH05JKaHcFHCSWN89t2tsu2LgYrAv0hY6mv6g4zPyB41guQi9j4TiB2PvY/W1PHK1DAD+lBDAt+1x3PFkboRervzYcPELufJPv9YHq0yEMYHwV3+PadEYKBgGjke96LtFruD1VBpVmw9YegpCt9p3E0Qd4B1KfjScvcP7hJtzKPWiRJGsWBPSknLOEkiVyJOnPJUcT+iSt1enOkMogsCM/g7UJNZt+3FCVjljcY7kco= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 6, 2023 at 3:45=E2=80=AFPM Marco Elver wrote= : > > The is_kfence_address() implementation tolerates tagged addresses, > i.e. if it receives a tagged non-kfence address, it will never return > true. > > The KASAN_HW_TAGS patches and KFENCE patches were in development > concurrently, and at the time there was some conflict resolution that > happened when both were merged. The > is_kfence_address(kasan_reset_tag(..)) initially came from [1] but was > squashed into 2b8305260fb. > > [1] https://lore.kernel.org/all/9dc196006921b191d25d10f6e611316db7da2efc.= 1611946152.git.andreyknvl@google.com/ > > Andrey, do you recall what issue you encountered that needed kasan_reset_= tag()? I don't remember at this point, but this could have been just a safety meas= ure. If is_kfence_address tolerates tagged addresses, we should be able to drop these kasan_reset_tag calls.