From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F0FCAC5B3 for ; Wed, 18 Sep 2024 15:15:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73C066B0093; Wed, 18 Sep 2024 11:15:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EC7D6B0095; Wed, 18 Sep 2024 11:15:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B46F6B0096; Wed, 18 Sep 2024 11:15:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3D26A6B0093 for ; Wed, 18 Sep 2024 11:15:37 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8BC1D1606F0 for ; Wed, 18 Sep 2024 15:15:36 +0000 (UTC) X-FDA: 82578208272.28.015F1A0 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by imf07.hostedemail.com (Postfix) with ESMTP id B90E940026 for ; Wed, 18 Sep 2024 15:15:32 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Mzwl82pd; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726672450; a=rsa-sha256; cv=none; b=ZS1jBlF3AdVyBX5OUFLQZ75BKSFRc0OtlyhAnjGgGMa9yzgV2F5N9N5G75g1DptgoempK3 2a/qCkGDWvXiWeiidpWt8bZTpJxuHuVWqbP8TnXgf6g+yxCa7UMpjLOkeK4lbxSbGjaj97 NVAsGOcdlxIXLIVwQLVVQo+xhdODnNU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Mzwl82pd; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726672450; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0e7U1XrXIdEL6SVlFY7nb/dZRU8i4CDxNhm+to+Gq/Q=; b=Mp7zJjqESNCS8lvqQyRJoJW19O15ZhAl8wdJxMrHVIe5U2zT+PC+0Xyn+rzn2Cye9MP9u4 ourydFRaPLEdUZ1dQmpXWvkAATwLmXHL7NYrKIUJxWlaGTsvviLvsK7KifF719xIHryuru cVg3Bf5sExaOBHhNTy7sU7Q9CDcnsV0= Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-374c8cef906so5416287f8f.2 for ; Wed, 18 Sep 2024 08:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726672531; x=1727277331; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0e7U1XrXIdEL6SVlFY7nb/dZRU8i4CDxNhm+to+Gq/Q=; b=Mzwl82pd0zb8vyUUzNPtQw8UELuRK/G+XBxRHS7gl17SmuoUdEHhTg6rdbVcnj47nv SwJiZbHGTVDACYAY9XwLg8Qg+HDoDpJiDDr/5V5qzS9OP3Ixgorek7nFt80i7eOXBZZ2 eESzvhAETlCf7lxa5JugfX+KqKBi65PaBj1rFFMOdNmrSDVQrAMZ5s7ewKtH/eFX+3+E N43Honv1U/rBmJQZIC+wc5O2p/Ma519vMA2wDULaE4TlX6+5AGHFsxsJVp+sh9w7adgD y0wRUNix/Fd9ZG4YE3nF/8yv7nvyO7PA50OOc3uYFJIs7owjsGXW/DVJK2F8U+Rz51Dl m/VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726672531; x=1727277331; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0e7U1XrXIdEL6SVlFY7nb/dZRU8i4CDxNhm+to+Gq/Q=; b=kQzmx3FEPGUq4Yani9FHRoTSOmwCoJqjQq9L4IzPzp73gH7DH1EBXm71YqZPDxH33n mjiSCDUAS+1Hw40kRdSqIDyYwYxRKKEsu5AAKBCT2iFJ0rAA7vek+Ji+BDwLp1WIB2xA 2Q2wfFqHZtzRKczO7y3/LMgK9W4gee/048k3UkGGouF9B8rg2viXyK71SlUO5N70/wmr 02SCEfFAv/6KKNO73NumUkBmZdV+RLu4JRd8QyvexPrQTYrIE7qjrKRGntd4rcLAzrFO Q50lNemxMO3FyD/huIxA+QOVxCx40I57zQrhBNHkGuaqKymZhYWaq1GPhMOLWnCVlxT8 0l5A== X-Forwarded-Encrypted: i=1; AJvYcCVli2TUPWhO2tSu5oAQJfpHv0sfu1qMbWvarNzLOMWOp01TTdlnuUw3J27DjwgkToC0rrBzhG6wQA==@kvack.org X-Gm-Message-State: AOJu0YxrOsyHof0WQLZKT/FAwZXiUBTIn+SPcnM8tNb+QKnpdkYl4ma6 wNedNwcajnpjpJtNNSHHk43JzF6fndUbiKyUjGlB+sOcKFTS4icKCPP6FU1eKVRZz5syc1JJMhY P03pL3vi5GILJrVxzq8VQaVsDCsM= X-Google-Smtp-Source: AGHT+IH7g5X7QV1vQGwl9PQkZ1vX7wZdmUENE/RPdlf7EB0u/MS3daySjnjNdQQwL3J5uNlzaoHz7oobGCSt23K/nW4= X-Received: by 2002:a5d:440f:0:b0:371:8ea0:e63b with SMTP id ffacd0b85a97d-378c2d7275dmr13798552f8f.52.1726672530778; Wed, 18 Sep 2024 08:15:30 -0700 (PDT) MIME-Version: 1.0 References: <20240918105641.704070-1-snovitoll@gmail.com> In-Reply-To: <20240918105641.704070-1-snovitoll@gmail.com> From: Andrey Konovalov Date: Wed, 18 Sep 2024 17:15:18 +0200 Message-ID: Subject: Re: [PATCH v2] mm: x86: instrument __get/__put_kernel_nofault To: Sabyrzhan Tasbolatov Cc: akpm@linux-foundation.org, bp@alien8.de, brauner@kernel.org, dave.hansen@linux.intel.com, dhowells@redhat.com, dvyukov@google.com, glider@google.com, hpa@zytor.com, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mingo@redhat.com, ryabinin.a.a@gmail.com, tglx@linutronix.de, vincenzo.frascino@arm.com, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B90E940026 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: muxx4p11jjp3mem9g8pwi6ihnotnkwk5 X-HE-Tag: 1726672532-379450 X-HE-Meta: U2FsdGVkX18l+V9WPkcU2eUnOs0WkmioE9Gt0tEHFN6O8Sr3tgNiNKleyuSC2lHcb9tMwKP4ibAwlwPQEm87lXYpnsDa5PvzEmmz+VRYFrXHcatmjiav7G0dqdzymfKZvcHLsc4/y/UhVWOnJ14AEN7KKzneiD2c9az7snvKADx3xDKT+derAZ6XGNB6NbimJyDO57T6wVVzC6yXSNLxxbNkgJ8HS45sRJg4SqYSz4aBhYfe6ylhuFLsZvtbKtL68ICOSi90d+lVFuuyNozeiSe6HcxAN3GwJmYQAP+8oBi//uI4ztAq+Ijqt3f8IvBbV1iPxt8R2ZoNVDzEdGO2p9rMQL4bd+kSuQekH9t+1Ge4al5zZGorVrgeY6rD50f5dK2d/0TAMoCw2FDhPRGC4p7NB3CwiibZquq3XxlDGDoObUHk5iCO41XQxYgaK73hqjYd76GW3oI/FXW2MLmb/lDba5SyoonrgQ4FwfUAJmlX3uqpLUYqZhOCL36L9E+WXrrfx6kyhUAMNmMXUOXiLyNdmnDumBTBEK3r+SD0lQ699nP4yIUkmMFykEqkLkHg/k9vpyMF0ObcIfG6OKingAh8H9b52hUIvKtKMmF9aG37almCN2NN0vBRySbDML3CfD3hSa6pkp66KkLZQmUdPMUmbpPOByWIcdPv/IBysEkLHWCZc05VE1F8dR86S+AtwMlOCL5ITovDpiL+qU4q9ADxmYt3CE28VFrdagRa81sv64B6wVh6RHd9GXf9STd9FtJbbHF/W25YJdt9rpfrb//gZUrEqAYD/SvZXyep6nVPrdcS/ljZtioz7OiYSU+ec21/vJ3oyqvlAmdpcJvpAtUKG0kvJvWbhqZTeewZWMhP/3dXS7vt56G28FVUOxG3zUndbRK16vNIuEayS96N57v1jvidCVxECb1h1DkxhHCVZedpE5U9uGZ3ghiNhZaINVJMdHJ6jWzkxFGmcEE posze1PT uEIGafvdnh7fzxtgAlkj3U7NEoS8Qo4lj2GPdmcK56m9SddoLe4Fomd+mg0XuUtRL3LoospF8c9RAm5On9HJ0h+13t3jENxc2t3xx5FvMzPxtEvk0z6d83TFmBCFiaih4DWMhu6QFVR9I6FfA2KigzL9oy6GiBO5S32ip13BV5ZgE1K4ru+QGxorSDa7tk/YcwtextM5Loy2xlFQD1VrPxyu4wrIdbcToEr152ST9bLmY/1GN79q2FHQgIIojJRSe+8kSkw50aUlq8tdyaSgjZpz8YANstTA1KB8wsb+/HGQUEyF2ZCRELnPBwBgwuS/GKwTy6N75l+d/ylFxfpfGA60xGY+CxeoxI7jPyJyALLL5wDbcB+nz22IyCZHx8nOcgH74O/BmE0EggzV/Lw/niU56ZrAwfijURk4U79A82QyrgV66DSoXR6uRtp8sUB47fYeAjV8yGLw2WrQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 18, 2024 at 12:57=E2=80=AFPM Sabyrzhan Tasbolatov wrote: > > diff --git a/mm/kasan/kasan_test.c b/mm/kasan/kasan_test.c > index 7b32be2a3cf0..9a3c4ad91d59 100644 > --- a/mm/kasan/kasan_test.c > +++ b/mm/kasan/kasan_test.c > @@ -1899,6 +1899,26 @@ static void match_all_mem_tag(struct kunit *test) > kfree(ptr); > } > > +static void copy_from_to_kernel_nofault(struct kunit *test) > +{ > + char *ptr; > + char buf[KASAN_GRANULE_SIZE]; > + size_t size =3D sizeof(buf); > + > + ptr =3D kmalloc(size, GFP_KERNEL); > + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ptr); > + kfree(ptr); > + > + KUNIT_EXPECT_KASAN_FAIL(test, > + copy_from_kernel_nofault(&buf[0], ptr, size)); > + KUNIT_EXPECT_KASAN_FAIL(test, > + copy_from_kernel_nofault(ptr, &buf[0], size)); > + KUNIT_EXPECT_KASAN_FAIL(test, > + copy_to_kernel_nofault(&buf[0], ptr, size)); > + KUNIT_EXPECT_KASAN_FAIL(test, > + copy_to_kernel_nofault(ptr, &buf[0], size)); > +} You still have the same problem here. What I meant is: char *ptr; char buf[128 - KASAN_GRANULE_SIZE]; size_t size =3D sizeof(buf); ptr =3D kmalloc(size, GFP_KERNEL); KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ptr); KUNIT_EXPECT_KASAN_FAIL(...); ... kfree(ptr); Thanks!