From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ABCEC433EF for ; Tue, 29 Mar 2022 18:36:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 649B18D0002; Tue, 29 Mar 2022 14:36:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F9208D0001; Tue, 29 Mar 2022 14:36:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C2568D0002; Tue, 29 Mar 2022 14:36:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id 404568D0001 for ; Tue, 29 Mar 2022 14:36:22 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id EDBEAA5A8E for ; Tue, 29 Mar 2022 18:36:21 +0000 (UTC) X-FDA: 79298278962.24.1CA7C6C Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by imf18.hostedemail.com (Postfix) with ESMTP id 8ACBE1C0004 for ; Tue, 29 Mar 2022 18:36:21 +0000 (UTC) Received: by mail-io1-f42.google.com with SMTP id b16so22104778ioz.3 for ; Tue, 29 Mar 2022 11:36:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JUrhq9evNqA9x3IGobvT5hE7CTLMIVYRzbuHHy97Qyw=; b=nj4/aW6Kbl9hIgkEraEI7qLFULOD5EsXDCHMwh1SxLrSK2YgGQ3y+94ZHK97TL7WpP Ch8HtblRcIWAOKuHo8Im5a5bC0dmZJu2ffG2aimykeJQP2qKnYdYTFCuZcgXjPaNoJql 3+6X+JLQYuWQmTCyg8Zgv24+R5OYKlR9xAOxDqyW5ojxT6YdO4C+sT1KkUAcCnHp1v0P Q5kbDOtOJY//ZrhA9Sd6JDY07ZtSBtinAgXN5X8mzwHWjRAkYCuTc6e49DCXRhnyV4aP 8AMGT2yKqSgm1Gjd7CJQ3SPp024WGeIZERrflKsvB2oHa8F8zapXlBfo7um85Qs9YlVF yINg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JUrhq9evNqA9x3IGobvT5hE7CTLMIVYRzbuHHy97Qyw=; b=FlY+7QHO0w86cK6CiMn7uK914QlDbMuyZDTs6ygOW2vnGuZeuuoiCNIXPONbwHU5OY R2xXToIv48ozwUCmKhUcOB0ALY1z5lncapdIcsm7eCB9Jfs9iFu21hLcIWpzhohtQVL7 RybYZ4D6HJEz68UEflgEk5JGNwjveXYp4e/EYAJNp/jqiEv9z1BL3b3vrrzIKw/HLZR/ abOvC7p1wBbW/yrlG0zi+CMnNcl2NM/dq5e+MAEAisVZOEf8TV1g5gEBgnFmDUJVhLUe ui7Ej0iF5cQQXRYMvgEGSzs5/Hp7t3JyvXF8soCrNo0kx/tdFqrl886ngLyQik1E/O9k L2GQ== X-Gm-Message-State: AOAM533/mR6K7RllkkZoxK+pxJR4v9PXdolR+9AlczuIQ7pxo6r1bZG3 sYSZIGNRJsnrryNC/6+IaR6Sl6dEDa7uPN2O4Ys= X-Google-Smtp-Source: ABdhPJwP776hOCDGMQP+vDMRjnkGUHFev1/eqPS4VGu6yaU0gkRv1VzLNw4Un55174Uom6XE7s8ryiokbz3HyW2YlTU= X-Received: by 2002:a02:b687:0:b0:323:60e7:121a with SMTP id i7-20020a02b687000000b0032360e7121amr8803432jam.22.1648578980752; Tue, 29 Mar 2022 11:36:20 -0700 (PDT) MIME-Version: 1.0 References: <21e3e20ea58e242e3c82c19abbfe65b579e0e4b8.1648049113.git.andreyknvl@google.com> <20220325134629.99699c921bb8c8db413e8e35@linux-foundation.org> In-Reply-To: <20220325134629.99699c921bb8c8db413e8e35@linux-foundation.org> From: Andrey Konovalov Date: Tue, 29 Mar 2022 20:36:09 +0200 Message-ID: Subject: Re: [PATCH v2 1/4] stacktrace: add interface based on shadow call stack To: Andrew Morton Cc: andrey.konovalov@linux.dev, Marco Elver , Alexander Potapenko , Catalin Marinas , Will Deacon , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Mark Rutland , Vincenzo Frascino , Sami Tolvanen , Peter Collingbourne , Evgenii Stepanov , Florian Mayer , Linux Memory Management List , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 1xkybjrha7mki6rbo8h5x1d48m3rkizs Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="nj4/aW6K"; spf=pass (imf18.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.42 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8ACBE1C0004 X-HE-Tag: 1648578981-73538 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 25, 2022 at 9:46 PM Andrew Morton wrote: > > On Wed, 23 Mar 2022 16:32:52 +0100 andrey.konovalov@linux.dev wrote: > > > From: Andrey Konovalov > > > > Add a new interface stack_trace_save_shadow() for collecting stack traces > > by copying frames from the Shadow Call Stack. > > > > Collecting stack traces this way is significantly faster: boot time > > of a defconfig build with KASAN enabled gets descreased by ~30%. > > > > The few patches following this one add an implementation of > > stack_trace_save_shadow() for arm64. > > > > The implementation of the added interface is not meant to use > > stack_trace_consume_fn to avoid making a function call for each > > collected frame to further improve performance. > > > > ... > > > > @@ -108,4 +111,16 @@ static inline int stack_trace_save_tsk_reliable(struct task_struct *tsk, > > } > > #endif > > > > +#if defined(CONFIG_STACKTRACE) && defined(CONFIG_HAVE_SHADOW_STACKTRACE) > > +int stack_trace_save_shadow(unsigned long *store, unsigned int size, > > + unsigned int skipnr); > > +#else > > +static inline int stack_trace_save_shadow(unsigned long *store, > > + unsigned int size, > > + unsigned int skipnr) > > +{ > > + return -ENOSYS; > > +} > > +#endif > > checkpatch sayeth "WARNING: ENOSYS means 'invalid syscall nr' and > nothing else". This is done deliberately to mimic stack_trace_save_tsk_reliable(). I'll mention this in the changelog. > checkpatch also picked up a typo in a changelog. Useful thing to run, > is checkpatch. My bad, I ran it on diff instead of the patch. Will fix in v3. Thanks!