From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB22FC433F5 for ; Wed, 25 May 2022 17:43:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67D058D0003; Wed, 25 May 2022 13:43:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 629298D0002; Wed, 25 May 2022 13:43:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 515D38D0003; Wed, 25 May 2022 13:43:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 43FA48D0002 for ; Wed, 25 May 2022 13:43:29 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 1F16281310 for ; Wed, 25 May 2022 17:43:29 +0000 (UTC) X-FDA: 79504987338.24.FB5FC0B Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) by imf05.hostedemail.com (Postfix) with ESMTP id 9B95B10003A for ; Wed, 25 May 2022 17:42:59 +0000 (UTC) Received: by mail-il1-f175.google.com with SMTP id 3so14335401ily.2 for ; Wed, 25 May 2022 10:43:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9Y1ppk7B46JVKK7NkaOrpQ5493dk2qksQrupKiexSz0=; b=Lz+Il6ThJJatz8Ur6i5iU0ceuVC5VFUAZpYN1elm5YYuqfTkQEOKa0EySEnREG2MZT 4pu5E5+TM9kOKMH27rA1UGkf+EfhhucDE/6hKaO41QOJXiTJyRh6OFKozsgeUQjVJW/l GAuYsrXl6F+mt+SSgVXvCPj+xipn+/dVXoB+QSyoRcAJ1/FQYyzs9gqR00UNrkz9uWEK 31vYtGQovUIWTwpMptXgaSxwUHSkehWRIHWrJ4fPTm3gUqm10Ru2R2YyglBLmwh30atk f36RboKM/w9WhKkHz9kggxr2qm3IajSI7sRJMeKldeA2f+qgswGR4CHgCEHVnEPuY4zM JdyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9Y1ppk7B46JVKK7NkaOrpQ5493dk2qksQrupKiexSz0=; b=ewbkJRfkTE457u4xvniuTlVL8FgQSibBComuCyTj53wdbeyHg0wKgO8dM6zpPOP6CX EBtgSPYNfvs+0/zWHgeTAYd6KAbJq89azJWMBaALcLzoqrmv8LkQNCSwfKMeBA3ePco4 VEem/yzyprpoYcR6S/XQq3URVvfu/U032YkvUUvYEv2fGOF3c+uu3KOGC3MWDMVJERPg kJkwg+nsTw88OZAWH6Svdggwj2fYksN8VJZkbBjc4IEUhkbxlzjXFn8b0ObqeqgJW9rU btLj+EksQElnIFqIGucUkhCDvWt1ZH4WUw60U+eC9FqTbSaYm8MDU3WP0UuCxLFtJLSg U0kg== X-Gm-Message-State: AOAM530kocJ3Nw4FW5Klwt8OUoDT9f3lIf1q0SOJoAQFE+sLqCP92Gz4 LMbSgqTE0qpBTOUzE6926GLkCUGDSf8XZo/x92I= X-Google-Smtp-Source: ABdhPJwCZm28XqJGp5fTvbYI6LME8/48+6CYtKjsPdgnXp2pOicpNbew0hzH6nlz5DM54/lnJeEi7kh2+sMcZqIDc1g= X-Received: by 2002:a05:6e02:1be2:b0:2d1:5818:a454 with SMTP id y2-20020a056e021be200b002d15818a454mr18036546ilv.248.1653500608130; Wed, 25 May 2022 10:43:28 -0700 (PDT) MIME-Version: 1.0 References: <20220525120804.38155-1-wangkefeng.wang@huawei.com> In-Reply-To: <20220525120804.38155-1-wangkefeng.wang@huawei.com> From: Andrey Konovalov Date: Wed, 25 May 2022 19:43:17 +0200 Message-ID: Subject: Re: [PATCH] mm: kasan: Fix input of vmalloc_to_page() To: Kefeng Wang Cc: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Vincenzo Frascino , kasan-dev , Linux Memory Management List , LKML , Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9B95B10003A X-Stat-Signature: wkhiiwersiumsm15zyimxt3pdnayepdn Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Lz+Il6Th; spf=pass (imf05.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.175 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-HE-Tag: 1653500579-244670 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 25, 2022 at 1:58 PM Kefeng Wang wrote: > > When print virtual mapping info for vmalloc address, it should pass > the addr not page, fix it. > > Fixes: c056a364e954 ("kasan: print virtual mapping info in reports") > Signed-off-by: Kefeng Wang > --- > mm/kasan/report.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index 199d77cce21a..b341a191651d 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -347,7 +347,7 @@ static void print_address_description(void *addr, u8 tag) > va->addr, va->addr + va->size, va->caller); > pr_err("\n"); > > - page = vmalloc_to_page(page); > + page = vmalloc_to_page(addr); > } > } > > -- > 2.35.3 > Nice catch, thanks! Reviewed-by: Andrey Konovalov