From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14805C46CD2 for ; Wed, 27 Dec 2023 21:42:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D9636B0071; Wed, 27 Dec 2023 16:42:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 78A636B0075; Wed, 27 Dec 2023 16:42:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 652116B0078; Wed, 27 Dec 2023 16:42:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 54A336B0071 for ; Wed, 27 Dec 2023 16:42:55 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 21C5BC0533 for ; Wed, 27 Dec 2023 21:42:55 +0000 (UTC) X-FDA: 81613923510.28.FA2C49A Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by imf14.hostedemail.com (Postfix) with ESMTP id 5C6D510000D for ; Wed, 27 Dec 2023 21:42:53 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ShU4hPVx; spf=pass (imf14.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703713373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hDLD4+/i2vMq1fQYbzWj7QeJ4PZ6TaAuPhlpaYobBH0=; b=Tao5j4MZ4Vel2zqc/eLTyLF9OLkg/cGTQdL4SUqX7mo88z8w2VZW+1G/Kv1fH4KIXiINYt bIC0lo4cPLrNfyXGJDbch7/mIXL/txcfF5+42i9aVMnNYtdBsbROCMBUC6lAyxMxivwdp6 dQ3RElBRBc9DgHVrlOb9IZfPTUtS/v4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703713373; a=rsa-sha256; cv=none; b=cLPgo9AO1OlbnqhSb00KK7On9NtmNrOZrQXQlICiHFN6LV8oobZ7J4xxy94xuJ8lGeRc4V oA9irwTZ32+2w8LUHT4BsDjQY94wpjWFBDydh6pXBxigLoQvKDNT0zP8bWI04MF5w649p9 W9b5mtuV5FLZ6CHp5t+rjpH4gIF2Gic= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ShU4hPVx; spf=pass (imf14.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-336746c7b6dso5006408f8f.0 for ; Wed, 27 Dec 2023 13:42:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703713372; x=1704318172; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hDLD4+/i2vMq1fQYbzWj7QeJ4PZ6TaAuPhlpaYobBH0=; b=ShU4hPVxh6DKYtJ++dkYRgjgydRAgHHfHtQ6HLT02mnZ0dvTFMJfy9GSsKMbHw4m6g V7LMKpoxQvoSYRdBeeFmrr7XRTcbwb4XldSWdLmzO3FmE4cKJgl1Izbka/yPun0+u89a FIA9Ad39sCeiC11rdK4TU1zgr3BqmtAt7OrMpDP/1J7weW1lSrBPSRI5RPm6qqbffOTE Rvn4rU0Mo06c87mvm21Vp+JZo8+IGYWJgEmtEcD9Uwc4NU/dQ/iuH3kMHmYzV0Zn+Sod 59n+1iFokQD6/FpGGqDStyZF64xtLCIr24HshI38t907+rQyhoc06tpt0R4rDv2QLExE VsNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703713372; x=1704318172; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hDLD4+/i2vMq1fQYbzWj7QeJ4PZ6TaAuPhlpaYobBH0=; b=eBGGkw6y5/6uu2M9zXsWpE+BYwdxkfHEtYzBJACU4rbTW76cbp2VdNStx6q/1xVqPk cUWFjE90KRaHcz72zdET8SWZk30Aq/WiLypgwm7HWXKfRYr8wv1zfYsPrqsZqH+YetHz x+xkbeV875EBe9cz6ZOOHRFGIGs8dIcRS14yYdie2tCstDARSPOOLXRwQVFdquhddlBB WeU3+dI1sK0xuMBuELUjqDM5Gj+zqcTqk3nZOQsXXgiyGqTaEky172OQlqdVcaWRguDI K+92W/ae9345Py/BiXL7Me0klFvr6nVWFAMo3ibsRu3LCNf7Lb86G/M0Jhl5IR79toWK YRVg== X-Gm-Message-State: AOJu0Yxzxw6vDD6CGObgiiGKcxcAG11nsovLoP+p1uf5fa73sZtvdxvk bPQjrwuX2111vU1XjoxKhWposdDzVxcXu9pCmKk= X-Google-Smtp-Source: AGHT+IGgAO7AFAZan3TC+1/9LKYfUXC+HyHtjJ/qCR7SSlhOKpX4cDm/waGRD608xGQ/bf1FuGvPMzJSEc/Y1XJQO9A= X-Received: by 2002:a5d:598c:0:b0:336:e8da:e17f with SMTP id n12-20020a5d598c000000b00336e8dae17fmr1859975wri.113.1703713371579; Wed, 27 Dec 2023 13:42:51 -0800 (PST) MIME-Version: 1.0 References: <20231226225121.235865-1-andrey.konovalov@linux.dev> <202312280213.6j147JJb-lkp@intel.com> <20231227132311.557c302e92bdc9ffb88b42d5@linux-foundation.org> In-Reply-To: <20231227132311.557c302e92bdc9ffb88b42d5@linux-foundation.org> From: Andrey Konovalov Date: Wed, 27 Dec 2023 22:42:40 +0100 Message-ID: Subject: Re: [PATCH mm] kasan: stop leaking stack trace handles To: Andrew Morton Cc: kernel test robot , andrey.konovalov@linux.dev, Marco Elver , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5C6D510000D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: mrmyotbfjbw5mmqb63zytkjgkixsxoic X-HE-Tag: 1703713373-755728 X-HE-Meta: U2FsdGVkX18OzkksKh0LrKkGVoX4f817FYE2WkPR75kOgRXNveXkxLnsJoic6Ohm/MphH0Mb5MWGbux/NDuODhV3BYlJphMBS7Cy2/zsTDVSjo1VWmfv7Br+xE8yk/Rds8YdI39sI1VNl7tcuUJbSBmIwu8FKXUekwiwlcxeCoPF9hB6lkJS1VljEGwXhc4gy8cu9dFqUf1KJYcqEFEgticwWU561tS6y5hfIN0jrl0LJPmPcN8bxG+TZLZaFAQNnFf86EVZsMPJExuL8tNkylI2uL8PfjmbZw/2fx2LhH6RbXznZbxoIjzUftj62gwTD2GEXgY8OKDeu8y9Gim3BT4m5J5LMzwptURcSzYAJh6fjpedrHKP7/MPfUlNLkqmgTPFmVDKBrPei+jlGelpWb5ybCQie4vgiKblgl/jRL6lmLqB2iQIwanrQcU//MIeSFFwR57MhZz2z0VtXckWLdJjgNd1hWvKmIVBjge6GsrP3rk5S341AmIJW5vmRdNy5JCYbIMt135jCwszRYCWqWVD6MPz2YENfG0KUOow8FAD2ypd4okBNkBUMSN7Bwne7whbyiK02CA/HQC8Pr1N2GRXztBWn1G/WgQba7ozC0UUwy+FfGy/r1tHWuvsUW7Evv6xQgJSrjO+uv58t80uaHWdX95HvYd2RaU9oZT0WXNaBswD/APkPS2oXv7fl+iMjaASROQ4btA8sMYUsdy/6NnC4lbbdk/TbK6zY8KPZM911MjZGgw8/wiKdquE6KbXSmEEyr3SAO2hTuNzjcUX+XqqZM3GObuSsxZlEAvNdt4Ql7hJLbiw+hVPAvZyivW9knlMr1qNBKBAFqtrPJZolSQzLhfCil5Up3Sb0M2hzxXVN08BsVeIrTjMw8F8rFkAzT6eDbVrATmO6zD8R7n8bOTYHb4ijRLSdycuiudJBQFFtvzBz/uSCsiZpaMfphUfy4Ivy3pqavLdkdCYX99 bawnsWrt b1zKkY2drOJ42OEoKV3tQXupzbY1ewKkW+OpFfx16b7N6eH5yWVclCu4Og/XvrLE97cAlOLFt1YhsFkhp4vegsJY8KexBTXzuI9AluFqnwU152UjoG+bX2rBEb4jcALl80XP0cA9xpNTKRwkGIKQj1CCshXpP2eaRGa0+ObWFdA54WQqF7RMOlbaQOThnmF6i7ZsOjV5/Y991CBswCqa8QaKytStsx7apOH0QHNHLtlGqrpoAGlNwfMm/9zKx/eLFleCpdZKgE5s3QPCmi02WpkDDKdicUlXVwnm7wt+YMCgE8zSd7HgX8hIX/agn9JL/QbxFybeDxYBe3R6unBPez7LKMqAUG5LEhpiEF0JEIRKPpiuupz/PWryVyCIGG/p1gpyP8UyAKPWJyH1aPnDCgcMaXyUvucw/jSrrJ+1sYS917llOKjAwgdIjwLuieW00SMaeXUoYwaBArnZvnwHeLh1UKkhW7NHOtAiIndMMdgnh4dA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 27, 2023 at 10:23=E2=80=AFPM Andrew Morton wrote: > > Thanks, I added this fix: > > --- a/mm/kasan/generic.c~kasan-stop-leaking-stack-trace-handles-fix > +++ a/mm/kasan/generic.c > @@ -503,7 +503,7 @@ void kasan_init_object_meta(struct kmem_ > */ > } > > -void release_alloc_meta(struct kasan_alloc_meta *meta) > +static void release_alloc_meta(struct kasan_alloc_meta *meta) > { > /* Evict the stack traces from stack depot. */ > stack_depot_put(meta->alloc_track.stack); > @@ -514,7 +514,7 @@ void release_alloc_meta(struct kasan_all > __memset(meta, 0, sizeof(*meta)); > } > > -void release_free_meta(const void *object, struct kasan_free_meta *meta) > +static void release_free_meta(const void *object, struct kasan_free_meta= *meta) > { > /* Check if free meta is valid. */ > if (*(u8 *)kasan_mem_to_shadow(object) !=3D KASAN_SLAB_FREE_META) > _ > Could you mark them as "static inline" even? I'll fix this if I end up sending v2. Thank you, Andrew!