From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E92EC05027 for ; Fri, 17 Feb 2023 09:46:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1984C6B0072; Fri, 17 Feb 2023 04:46:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 149336B0073; Fri, 17 Feb 2023 04:46:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 010476B0074; Fri, 17 Feb 2023 04:46:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E613F6B0072 for ; Fri, 17 Feb 2023 04:46:47 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AEA1B1415E0 for ; Fri, 17 Feb 2023 09:46:47 +0000 (UTC) X-FDA: 80476304454.21.DEB9105 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf06.hostedemail.com (Postfix) with ESMTP id CC25A180005 for ; Fri, 17 Feb 2023 09:46:45 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=I16dYVnV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676627205; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9SH8M+iqgIr8G+65VlZ0io44yWlIQXBEHAm0eyAdZpw=; b=60wHX9WKUZ4aCMXUXsMZN4vERvkCrLxGdJrcvPDFfSzXVGxiiOApDAZSbSzkPzjRtzxXeZ Kl1ksCm6wZo0UMwgdt43jUZ0+qBLDQ2KiFlib+qhbgXRWLm7jZ7FSTeI+V4VvgjeM56s20 zFL34T7a3VyLMBc1fY1n/1kr2SW9Hjk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=I16dYVnV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676627205; a=rsa-sha256; cv=none; b=wRppsWT8QopcvD+9W/k6YtcIzbWhk0xS2T3QIQaNlPn/8ZgUM4f0ko1Uaj4ozEE1StG+QT W6QvjP7gECM9FWVZNptBj+NDwLegEiyW4F7+ANFrscBFAyve7s0WQvhuiQBe04kp73tWRE ETnCItrmXrlLwTEUu/7aSPsPD5Hnu/8= Received: by mail-pl1-f169.google.com with SMTP id i15so2216755plr.8 for ; Fri, 17 Feb 2023 01:46:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9SH8M+iqgIr8G+65VlZ0io44yWlIQXBEHAm0eyAdZpw=; b=I16dYVnVg0XOdpqW3CxmiwV9XP2BJjqTz2eYIGN2626xfNuu9PkE+LkIgDtMQa0LfP EX0J7IyRqeoxA+oCdwaU/8umO+EHkSD+/UMOFzCnqR3m72uABeIs/USYQFZahCqjsyCD SrEALrKndVzuWGWAqgw/iAkyMf22F9IYpuEGR+3dFx6ynj9zddqFaOQXsPbZzDC4alba 44B3He/oCz5v3EBmVRVcmTLUECkt9mqlV5ragF6sDnYijYzWSV2NYi1zddGFKu0dif1T Fhf/8Ni93PcoNjiHfkv90rUSnuOtXxoevvbYtoJ+UALXfTkgA/IXB02L1d2jNEURtct0 OEEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9SH8M+iqgIr8G+65VlZ0io44yWlIQXBEHAm0eyAdZpw=; b=GQuFpzHyAdyBYXw1NE+Qe7+MfiKDwfyDmJaD5e6sACRHv+K0Zj2wpHc1MTeHnkAj4D KVaRDHFIkAh5DT0E8UrbzHsEr4zeK4WpTg5vEjf2BvJ4tfKkWu1MqSFdVPfDOliDyvRZ etESOII4f6tl8kYc0FCi5uf1xBgoEaguuGGbKVfLtRpzhrzsbypwCFx2BjcC+IpnuBAb vUokFkyA4ClyWk/h1DQFt/OySxiZmDOpB3FDOvd+4MWGRvaWfynU+48yFmfdKXKM9SN8 Q35tKCJY+vfzDo1rk45I91MFjBpArtoVEM8+bLTVh+qWymMdkG0lU4nmMYjiMN5QMrIy XUxQ== X-Gm-Message-State: AO0yUKXuLivFuQjjpmNpN80XPSfGrgs2e8PB3zvqbgQNAqWBR4E/CF5S hg7UTK0kQ2IDas4Juf5AB4kB2OIHfKKGggQwgR0= X-Google-Smtp-Source: AK7set8cf5yh6zy9YQwtWISzI389HBLjQA5O7nNvnjVWnB0VUlENZPzFv11FPIZEfQgmVMDgBswuUjc1fFcHpPcSSA8= X-Received: by 2002:a17:902:d4d2:b0:199:6e3:187a with SMTP id o18-20020a170902d4d200b0019906e3187amr263451plg.6.1676627204614; Fri, 17 Feb 2023 01:46:44 -0800 (PST) MIME-Version: 1.0 References: <5836231b7954355e2311fc9b5870f697ea8e1f7d.1676063693.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Fri, 17 Feb 2023 10:46:33 +0100 Message-ID: Subject: Re: [PATCH v2 17/18] lib/stackdepot: various comments clean-ups To: Alexander Potapenko Cc: andrey.konovalov@linux.dev, Marco Elver , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: CC25A180005 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: phyn5cqi7ihcixcjxrrkpx5drpyyo17r X-HE-Tag: 1676627205-857624 X-HE-Meta: U2FsdGVkX19sNJ8KiTd2rcD2hrDPRxY9++yPeO6qqDzHEvKR8B1SktrVllhQbOcxgAiaY/7Q8oZeF14jjpgdZ5UB5FV8dgnvCp2AgmLQMErQY7qhbA++NciiW6Yx7ZX9BzwehJnvDFoAG2JISsSiXm2mIGXeR2rfsmJtp7Ng8H6vFS2tH7IsGKMhUycUVcfduYwQf/8/+7+tPkOp1ogyR4KUuG8u3mimwkE2GHLxuFTALwB3pVvoKiXaiceG+1qMidnN2l9mTlLK8e0B5aoVMi8bwPQfCHypBgHI3/u0pdkhyQ254dDgmGBnKo+ex/JjVm1R65Ee/xNkov9XXkyDw1G85146xAKRS6D+3GLE/agBoSc3DStmkWsXe0V6aoH94OeomJRHzfjftlmljU4VZ7eBWFxO1GcdFfmwhTLqjus1pkY1XS8VMy1U73BBjHLKibSclTvNtedFKG69lsqSHiWjgZgHRQqnR09bGbE+AFikAN3IYAv5NzAvZZbPVpYvd3/3PV3d6bzKt4UsFxaUWin10BOhy4q7HfuLKFYT5O3J5sCFdd5avhA9XcNIjtJ4HGFD491H/95lfox1kQ44bJKUS7bzcScq665owBnABRJBbGaiTpOkCg3vLmW413Fob+4HogDoIeFWGcVDmeX1O3xoIOSuZqvXQ0FFxS2tgi3QGZ02oVV+LaeTH9x/ZbpdLf3nf5PPsQ2kS8MXeuBK6R8xJCAbU9uOnK16C/tXuEgJohcaG0X/404BdAxc64d/2b0d0SkZz70RQPgyL4pitcq+l9TvwRfNS75JJq+vUBH8PlwkWf37Bv4l4dHCXv8b5qqL/Bu4jCZAZUPICraPtLtUlc1rXOViSEAL7qFpvkSiJXpLme53ASpNaCb20KA4lxIF7/o9tZktiq3TJs36EH1V9j0boeQeGEI9JI3VooF7hg9fCI88TVgI9pFhOSKTOJbM3KhVYHnSWq0rZI+ XAcpCrTb S3hBYBneiN6kmEenZoc6NB4RsdknG5suYpbQvd/nJByUW81LdSftb7P3jdM19VLtj8hYuzon9GNNxs3WvV6OxRB1GFAvSny1b+lyn5QRSqArwJxsMO2Af7JlZlWJO8xgJpQmHOOTYl6NPqOdemLQTwOxVHgWUqK33QfA6OWpzhbXmnY+jwlPwiWubci7/4wT/QvIf7XN0iPp9W1IOGhrHIqJdn3PukS5oqws9jNg5PcNF+w69iuwzqRPL83kTe/Cdj9OeX7zix3t6hGfgSkuw0lPeeEgan6H7rQtKuxsM5cx1/vVkGYkOJxtJB9d9G0wZ+x0gDGzePfs+fIxrqgVMTofKq2pj7wcKXVwdnnU3j2RWKjikfIdTKAFj6eNo1gDY3/USsZqsLOcK9jVRFjxTBCt5Y7lvBlwz7NWopzvX0LsslxQGtRQaW8/53Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 13, 2023 at 2:26 PM Alexander Potapenko wrote: > > On Fri, Feb 10, 2023 at 10:18 PM wrote: > > > > From: Andrey Konovalov > > > > Clean up comments in include/linux/stackdepot.h and lib/stackdepot.c: > > > > 1. Rework the initialization comment in stackdepot.h. > > 2. Rework the header comment in stackdepot.c. > > 3. Various clean-ups for other comments. > > > > Also adjust whitespaces for find_stack and depot_alloc_stack call sites. > > > > No functional changes. > > > > Signed-off-by: Andrey Konovalov > Reviewed-by: Alexander Potapenko > > > - * Instead, stack depot maintains a hashtable of unique stacktraces. Since alloc > > - * and free stacks repeat a lot, we save about 100x space. > > - * Stacks are never removed from depot, so we store them contiguously one after > > - * another in a contiguous memory allocation. > > + * For example, KASAN needs to save allocation and free stack traces for each > > s/free/deallocation, maybe? (Here and below) Either way looks good to me. The patches are in mm-stable now though, so lets save this change for another potential set of clean-ups. Thank you!