From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2074BC00140 for ; Tue, 2 Aug 2022 20:45:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 75DC58E0002; Tue, 2 Aug 2022 16:45:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 70CCC8E0001; Tue, 2 Aug 2022 16:45:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D4BB8E0002; Tue, 2 Aug 2022 16:45:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4DEFA8E0001 for ; Tue, 2 Aug 2022 16:45:39 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AC9901C6939 for ; Tue, 2 Aug 2022 20:45:38 +0000 (UTC) X-FDA: 79755833556.29.B609203 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by imf14.hostedemail.com (Postfix) with ESMTP id 128B0100008 for ; Tue, 2 Aug 2022 20:45:37 +0000 (UTC) Received: by mail-qk1-f178.google.com with SMTP id b25so11510949qka.11 for ; Tue, 02 Aug 2022 13:45:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=kGCFQktL9LEp0y8IboY5IhTEHaLuC/gj8xxem3T8C/Y=; b=qbPlwMtMO5h/PDQTD8omxj4fSd7e7PJsjjKJOHmg6R8Y6RwqvKQtLeDFdaUz7pKZH7 b97h1eWAK77yYBaSl8vDfywpavsYhldW93mZi8CqRdUlnjKyeLQ+fIOVrk/PF3KEVSgX TOoGLjsfn54mSJesiRUE07L8lhbBGwGbqjQsri2+AE56hIeM0W4KgWTQf3nbCvDt3BPG O3XK6HrtsOAhjoNfeO6aWc2YD7T2pzNIig11vNuREQeuVq1YW/CQiaHeNk8c3xbg+liW Ic61OcBVAgXD4+URBD3+Id0NMZr+1CKA4OG/rUlpbbMOCtafkqYdcgjRpmaxgFS6zo4v De1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=kGCFQktL9LEp0y8IboY5IhTEHaLuC/gj8xxem3T8C/Y=; b=lYMkw6MMRydF8ggR41SF27pZMuXiEyjGljp4uQBygrHDU/GoqxkvUBCN6LFu9e0gNj iiGsChh6B8qyVvCxzFuc1oB11xBkOMQ6wBBx2mjLpRUjKHg/lZZqYbTRtkcCJ/SM06aF +BinLLok2wuH8SPtEEDyah8YdOMTqDteBPZBUF+toln8WjFa/66HfW6VT4BdMbxsAWoL 5BQMvzQzJOGghGHuxEejDO29g5em/KttzsSDPgz/U6eQLu2o+aiAEXTdUIMFs/8tNRPz 2hw9VpCdB588nhcYLt6TQ8sBm0+CS2AKDDIFUJ8StCSPK4BfkzQFbjDYjgZ/FH+e+hTo jj6Q== X-Gm-Message-State: AJIora9fA/43/skHgsq0VlxEvtB+j+emJMHqSoeyYGaYlqlbepy4ZXEG 0sJaGdoJV4JUoo21kmhu730Dt8pg9vk/WVAtV6Q= X-Google-Smtp-Source: AGRyM1umKJtNCrs4hrfgwN7muG5bVwvcpGitnzHL6ZwMvrU+pP803PG5HaODUCUcvMiIZjeqUwDAGyAObHQdJMFB6yk= X-Received: by 2002:a05:620a:f93:b0:6b5:c8ff:d2d8 with SMTP id b19-20020a05620a0f9300b006b5c8ffd2d8mr16640819qkn.386.1659473137334; Tue, 02 Aug 2022 13:45:37 -0700 (PDT) MIME-Version: 1.0 References: <0e910197bfbcf505122f6dae2ee9b90ff8ee31f7.1658189199.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Tue, 2 Aug 2022 22:45:26 +0200 Message-ID: Subject: Re: [PATCH mm v2 30/33] kasan: implement stack ring for tag-based modes To: Marco Elver Cc: andrey.konovalov@linux.dev, Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Peter Collingbourne , Evgenii Stepanov , Florian Mayer , Andrew Morton , Linux Memory Management List , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qbPlwMtM; spf=pass (imf14.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.222.178 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659473138; a=rsa-sha256; cv=none; b=4bI78J+6OrZ7NfOemy4hZgEYJCgKmRS0HxRJ/EQBR5E7h7O1kemZo1ovetuamek9eQbwp5 q3CeEEU1AFHHVBcta5qEbukDb5M+ANckRqwXtP81eKddTn7toc41HA9pk91XRe5mTHRdi3 Uzy+uAmq9N2xGzCAD0noJET7KbKEzXU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659473138; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kGCFQktL9LEp0y8IboY5IhTEHaLuC/gj8xxem3T8C/Y=; b=MAuhFSlWGLzntjjjRHR/jzlWEEbJHMFJ5QotQ58OzUVh1Mu8S1Ty40gjAkEQuxBnSddhth tqJ9SMyIEO3JVcqeamwGRotWxFUyJ207RGBckJILcuOt+WwK2RP5//3zkglj1NuWSjZuhN LRPlenzFlIBsSIYDnkba7CVf5Q2iHlA= Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qbPlwMtM; spf=pass (imf14.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.222.178 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: bmkfmq98etdtmujaqw9j41wof58u1uao X-Rspamd-Queue-Id: 128B0100008 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1659473137-911046 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 21, 2022 at 10:41 PM Andrey Konovalov wrote: > > On Tue, Jul 19, 2022 at 1:41 PM Marco Elver wrote: > > > > > + for (u64 i = pos - 1; i != pos - 1 - KASAN_STACK_RING_SIZE; i--) { > > > + if (alloc_found && free_found) > > > + break; > > > + > > > + entry = &stack_ring.entries[i % KASAN_STACK_RING_SIZE]; > > > + > > > + /* Paired with smp_store_release() in save_stack_info(). */ > > > + ptr = (void *)smp_load_acquire(&entry->ptr); > > > + > > > + if (kasan_reset_tag(ptr) != info->object || > > > + get_tag(ptr) != get_tag(info->access_addr)) > > > + continue; > > > + > > > + pid = READ_ONCE(entry->pid); > > > + stack = READ_ONCE(entry->stack); > > > + is_free = READ_ONCE(entry->is_free); > > > + > > > + /* Try detecting if the entry was changed while being read. */ > > > + smp_mb(); > > > + if (ptr != (void *)READ_ONCE(entry->ptr)) > > > + continue; > > > > I thought the re-validation is no longer needed because of the rwlock > > protection? > > Oh, yes, forgot to remove this. Will either do in v3 if there are more > things to fix, or will just send a small fix-up patch if the rest of > the series looks good. > > > The rest looks fine now. > > Thank you, Marco! Hi Marco, I'm thinking of sending a v3. Does your "The rest looks fine now" comment refer only to this patch or to the whole series? If it's the former, could you PTAL at the other patches? Thanks!