From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FF6CC004C0 for ; Mon, 23 Oct 2023 16:17:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B46626B00F0; Mon, 23 Oct 2023 12:17:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF62C6B00F1; Mon, 23 Oct 2023 12:17:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0CFA6B00F2; Mon, 23 Oct 2023 12:17:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 952336B00F0 for ; Mon, 23 Oct 2023 12:17:55 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6FBAAB5C0C for ; Mon, 23 Oct 2023 16:17:55 +0000 (UTC) X-FDA: 81377232510.24.19E90D2 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf01.hostedemail.com (Postfix) with ESMTP id A2A4B40019 for ; Mon, 23 Oct 2023 16:17:53 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WN5LE5U0; spf=pass (imf01.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698077873; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6yATWwHsptne51eJuPF88jokz2oPp7uVzj/nBvs3wVg=; b=4/8sSifAJd6wSnl42+dujrfYzJ8YOCFoUEw8Gow+3Wo7nrRd+lL2U+10ilcATXJhCRxuB3 DG+wXyHq/ugo2d8y+L2eYOT8qyI+X0an7IlpW+1tHsU8Y82IGYpHSro1FK2+hhZKOVkGM1 tJl49D+TKG1+eXZzwisiODF5HIDFWD0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698077873; a=rsa-sha256; cv=none; b=V6CrlK8JpVJWmlbjx7YWChE58axLIe/t4BPvjVklAma6RB2OJkgWOHskbI4jIivD3J+B6m sA/GlLwH5XPCOll7nRKcHXigpQTieZR3vFKzRGEQZPd19JXqJdHlF+N9bhUlxenyh4Ie0X 6YpVJ+R7Qq9B72dWe9KTPBLE35PecO0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WN5LE5U0; spf=pass (imf01.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-27d8e2ac2b1so2137153a91.2 for ; Mon, 23 Oct 2023 09:17:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698077872; x=1698682672; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6yATWwHsptne51eJuPF88jokz2oPp7uVzj/nBvs3wVg=; b=WN5LE5U0c8svP0rk0oNGTaZW2JB4RT6Lm0XYH68uBeeoacUSLFr20ZuD9qGpTcQLjV ppDnOcdOoNh/Njr4OQYNTt2m9igMjAUTM1SmHKT6D3m0+Cf9ltwUilxlMWmypZXFrfqN 8QfSsHJe1bhsD0aP0r/+JrXbfuAdX9PtDUx3TDFmg/I+xMWcf+jhKXQ/txlX62uIFxxn PKPalnmegO0wWMeolAkRm9Z9H1HN2+21mTTStquEsBRJS99cTRDj+Wn6eYGVKONHm2M3 h1SNoWTIdZdEXkfB2JhzDuGHjo0FAc1fE1yk+hlA5WTKBskLRy4fScaAbfQp24+jCBL+ B9oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698077872; x=1698682672; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6yATWwHsptne51eJuPF88jokz2oPp7uVzj/nBvs3wVg=; b=WzDA8+nHLTMVHb7qAZO5Zo6Mu6+wDnSMNZkT2BZrY5XnrGI1Loo9Zag2uH68b5vhbw 7f+lshC0MeG9EwYAq9iGV6lFT5/10aArsOxn+H6NbYCh+60JZaR5AZoLlI8FcRwMeF58 MXxm4CYsWp4KhV8fo4jO9jEyhaRTiPpL72mj40UHwBFXlQVs2VGmyky2XRKUs7h4TIE1 AJpX5MekWMIRWN0VcYxTdCtrKMIo8kjdJ1q0GbTd5pcvwyS9yfJk5rtBhJF9dmlEOQwM Bwf1raEoe5PKe/80v2W51EYColJ2zRXz9Vm4o/QZA5YWz8PRbHiFMfWs6HuZEgpaa8yy MWsA== X-Gm-Message-State: AOJu0YyQ2Fz2E7gEs9xQDPgeXBGnwGzDNsMsqHQwKFm9Kz4mNjVftuA9 xVaNbcrlDJTnjJSJPZI9F+v/1EfeXzjOsu87t+A= X-Google-Smtp-Source: AGHT+IFXVb9U4SM4HwA3U46Mat4CbYSvspwWg7CriO0BHYKCNOqWiRma5uHwBcmlkoNHTK6PPF5WWh4PGgFxANz7WII= X-Received: by 2002:a17:90a:19c5:b0:27d:e73:3077 with SMTP id 5-20020a17090a19c500b0027d0e733077mr7197699pjj.1.1698077872354; Mon, 23 Oct 2023 09:17:52 -0700 (PDT) MIME-Version: 1.0 References: <20230916174334.GA1030024@mutt> <20230916130412.bdd04e5344f80af583332e9d@linux-foundation.org> In-Reply-To: From: Andrey Konovalov Date: Mon, 23 Oct 2023 18:17:40 +0200 Message-ID: Subject: Re: [PATCH v2 12/19] lib/stackdepot: use list_head for stack record links To: Alexander Potapenko , Anders Roxell Cc: Andrew Morton , andrey.konovalov@linux.dev, Marco Elver , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Oscar Salvador , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov , arnd@arndb.de, sfr@canb.auug.org.au Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A2A4B40019 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 33g4uy9agf7ubmx45icbmaycibuaubso X-HE-Tag: 1698077873-937200 X-HE-Meta: U2FsdGVkX1+a/vqdi92rS1Z6EarbRfYPd7tQ97Oxfs1JKnuAP41S6AUHzAJT8o/OL6a5UqSW0pJzo7sBX07ZbtN1Bcm8Qgm+SzH/EGfYFXlnPgou5YZ+TonmuZJFBu8YZCZCbBFWUE89UYZZw1qpmTkndt6GXoU473QuKXs9/AL/dqgmaOTkiqFMg5LBexsBe2N4QxL0Gx+MhLLhKiEqYM22IfrdJxpnp4cwhrXBHoX7DmDijLkQH8F2K7Rw5XVhpDCjZVko0hMiW0GwPk0YzW070jObbMS6pQMUGVxy/1CyRi4nj3swEkrEII+lvsSm+rcSCA6W2elQbHMefLIFz7rF5dlSBgDmg9wsb9zL9UaAdoTktlVL5hgVBG1YT4vuOWk93Fm6CySUKQAi3gTX8UeHOkwEHvxM6CwfDYFx2ZFO2YFAN0pi+TnQI1dDQ/hj7S9TZ/vXzIFzXmB6DuUYu5389mY08ZDhQo/jExCV58Mf3mR0I4s8Pltuo+AZPpGm/En0VcVmTeTswY3uCtyTOfBW2Vr/9fgqRt6TU/ma5iHZyXp/lvsK+pmtxONCEGxT6LERhbLZCAK9guN5dQJJuBrG1pcaGva+z2IiXZJqJ38mI0x+LdXb5xcalQmsI0kEtcizH9lbEGASiOo2vErcLpc2ILIDzX91JKhrRKQ3ZSXoIhkUM9r2bAgpQrsiwkHIOIbHVxSUXhVD6jwKMQT5joK1NK4nvDyj8AoY1QMEyhQ8sY/4Jm/+ANBlfJlSTFcvP/0KGPVFoKj6TEFCRVkUJdnP5p0DSy4Gcnft4x8p2ePUFLfplq1ao/kzjGI9waVKY0oH3S5AoyZLwrJRPssGF8P7GabKK/oulxnyaRadmWohfFkTkmgRf1ggalK/yNgHXaMEDMUcu7GQ8noTvMOdhnVyrZNETtUo9txE76R3lIJ1x0nGVjEI1F1nuGmyy4rzI6M3Vd7ptWy4xr3ZBAt rqDoXUfG Gx0BgcBVC1SXZyBRU8pMcll5Kbh1MyWP87PeIMjka/sHb6pjdWZu+1hD2i1p7AvJrvoBpm/xV9PkRBewpAUiHvOPVrFLx4H3YjgTDzlhHYum66ZhIZ3liADA7NHZUcRmGFI1QOHKsOIkolINSe4t11zCkl30h0BVobbTWvaO2Hf27IoLvUjOY3ozq1r3E0eg9cBGDPzYcdALZ3xOfXVlMTgQUEQUHSQ988ELr9WH/LcfhCIZU/WewV+EYaDEzBpbpa2ZOxjqI4b/fsX1R6X8bvuUfNbQN+9RTe97wDFHV72XOthM7o09Ub5qt9A1fad9OR1PrzXcZfnWnYyqqklCcA+QgeAWEuDHMrIxSOoZDm+MwGBNdAeQh7sc751oWcrMBgCIPRATEQf/grCAk+JZGkFmmlvj1rjR9DXXO0/tMK1GqJ9XOKIV6SqC8P6G8xUXmm3AF08yFWSHAs2A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 9, 2023 at 2:16=E2=80=AFPM Alexander Potapenko wrote: > > On Sat, Sep 16, 2023 at 10:04=E2=80=AFPM Andrew Morton > wrote: > > > > On Sat, 16 Sep 2023 19:43:35 +0200 Anders Roxell wrote: > > > > > On 2023-09-13 19:14, andrey.konovalov@linux.dev wrote: > > > > From: Andrey Konovalov > > > > > > > > Switch stack_record to use list_head for links in the hash table > > > > and in the freelist. > > > > > > > > This will allow removing entries from the hash table buckets. > > > > > > > > This is preparatory patch for implementing the eviction of stack re= cords > > > > from the stack depot. > > > > > > > > Signed-off-by: Andrey Konovalov > > > > > > > > > > Building on an arm64 kernel from linux-next tag next-20230915, and bo= ot > > > that in QEMU. I see the following kernel panic. > > > > > > ... > > > > > > The full log can be found [1] and the .config file [2]. I bisected do= wn > > > to this commit, see the bisect log [3]. > > I am also seeing similar crashes on an x86 KMSAN build. > > They are happening when in the following code: > > list_for_each(pos, bucket) { > found =3D list_entry(pos, struct stack_record, list); > if (found->hash =3D=3D hash && > found->size =3D=3D size && > !stackdepot_memcmp(entries, found->entries, size)) > return found; > } > > `found` is NULL > > @Andrey, could you please take a look? Found a bug, will fix in v3. Thank you!