From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 293ACC433EF for ; Tue, 14 Dec 2021 19:42:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 928246B0071; Tue, 14 Dec 2021 14:42:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D6B46B0073; Tue, 14 Dec 2021 14:42:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C5146B0074; Tue, 14 Dec 2021 14:42:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id 695656B0071 for ; Tue, 14 Dec 2021 14:42:24 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2AE248699A for ; Tue, 14 Dec 2021 19:42:14 +0000 (UTC) X-FDA: 78917420988.23.8CCD3CD Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by imf13.hostedemail.com (Postfix) with ESMTP id 64EF720011 for ; Tue, 14 Dec 2021 19:42:09 +0000 (UTC) Received: by mail-io1-f51.google.com with SMTP id m9so26275283iop.0 for ; Tue, 14 Dec 2021 11:42:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=46avN96nbskMUAFWXD0G4IICxhuVMqWM0c7esNIiqMg=; b=ew5BVOtU7X5oUwTQZlarYRrQHTSpfsszZXVQ0r8X5Bs2Vcymhf6eOzOKE3Ji49kpxr zgI/89XMXPio0g8DWR5Uxztyd+MizHHtvVqKHcfJiUlpjXlaQ5xcilvaOvzJAwlGpIb5 /+svTql0qmsj1ig4VPS/Zysy4s51h8M3LTD3+1Uiv9P8G1m8ybV2QO/KZGG8Yb9Spepf 0wyJE4hDrI5D1XxUBrWDyB3SUhZKjd6wxRFEWSg1c7vOoKh3Kl2xVvZPbhUnhL52wFtt /Vq2wRN4hlQPVVSaUt1AvCrUC9aisapMYJxTMH+dFQD/XGqa8GhKTjykvkdoRsiMdrdE iFWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=46avN96nbskMUAFWXD0G4IICxhuVMqWM0c7esNIiqMg=; b=AypX25jbAfsVven69sJa8cWk2Qq0iSG+KdPzCTDYvKEtHuB/2bzuBhzc/NUOCuTS4h BpLPAxfbW11fX/IoIkyK1jegFUBpPF0wAkvioDrvKcfKEBbb0bJieyoRtWbliOywkk0m o6Dw7TZWcnD1kTweV6Nis8Ys1yG7Guk4NReGno33CTo531PjhtnL/+epaVlFEMT0ltWY k03oUWd2NI8YkJux9WmSdQf8UW+h6H4i+9pU+/2yDHueX3djusLKUX75yLj2HGonkXbf JBmtE5O2D1nPqE9OfudDswIFU25w8i/6fd37qnZFgufTLTU20pg6HgTSEKuOS34SVRcZ GnLw== X-Gm-Message-State: AOAM533w+ZnMDuRk6KUtJtrNq6azHtbgTPp4QEL+OTpGlmDtu7SQEqr1 Io1e6MoyCeKb/DiQkkljYZ+fav5+B7mXkMRFdIM= X-Google-Smtp-Source: ABdhPJxdsOqYQ1pKobWbQy/onfaa6DITWMD3VZOL7D7HM5A5kmhnFDRiADZ4ifd/Bo6glHWYCqsO7qRPFNji1uE5688= X-Received: by 2002:a02:830e:: with SMTP id v14mr4174019jag.644.1639510930962; Tue, 14 Dec 2021 11:42:10 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Tue, 14 Dec 2021 20:42:00 +0100 Message-ID: Subject: Re: [PATCH mm v3 30/38] kasan, vmalloc: don't tag executable vmalloc allocations To: andrey.konovalov@linux.dev Cc: Marco Elver , Alexander Potapenko , Andrew Morton , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Linux Memory Management List , Vincenzo Frascino , Catalin Marinas , Will Deacon , Mark Rutland , Linux ARM , Peter Collingbourne , Evgenii Stepanov , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 64EF720011 X-Stat-Signature: nkyyqgweqce9ybb3ccurii4nen9tz971 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ew5BVOtU; spf=pass (imf13.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.51 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1639510929-311345 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 13, 2021 at 10:54 PM wrote: > [...] > @@ -3133,10 +3133,14 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align, > * (except for the should_skip_init() check) to make sure that memory > * is initialized under the same conditions regardless of the enabled > * KASAN mode. > + * Tag-based KASAN modes only assign tags to non-executable > + * allocations, see __kasan_unpoison_vmalloc(). > */ > kasan_flags = KASAN_VMALLOC_VM_ALLOC; > if (!want_init_on_free() && want_init_on_alloc(gfp_mask)) > kasan_flags |= KASAN_VMALLOC_INIT; > + if (pgprot_val(prot) == pgprot_val(pgprot_nx(prot))) Can simply compare with PAGE_KERNEL here to match the check in arch_vmalloc_pgprot_modify(). Will do in v4. > + kasan_flags |= KASAN_VMALLOC_NOEXEC; > addr = kasan_unpoison_vmalloc(addr, real_size, kasan_flags); > > /* > @@ -3844,7 +3848,7 @@ struct vm_struct **pcpu_get_vm_areas(const unsigned long *offsets, > for (area = 0; area < nr_vms; area++) > vms[area]->addr = kasan_unpoison_vmalloc(vms[area]->addr, > vms[area]->size, > - KASAN_VMALLOC_NONE); > + KASAN_VMALLOC_NOEXEC); > > kfree(vas); > return vms; > -- > 2.25.1 >