From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F0A1C433EF for ; Tue, 29 Mar 2022 18:36:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 980648D0006; Tue, 29 Mar 2022 14:36:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92C918D0005; Tue, 29 Mar 2022 14:36:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F5EA8D0006; Tue, 29 Mar 2022 14:36:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 708998D0005 for ; Tue, 29 Mar 2022 14:36:58 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 43EEA23AF9 for ; Tue, 29 Mar 2022 18:36:58 +0000 (UTC) X-FDA: 79298280516.11.AE7AA7D Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by imf14.hostedemail.com (Postfix) with ESMTP id AD45010000D for ; Tue, 29 Mar 2022 18:36:57 +0000 (UTC) Received: by mail-io1-f54.google.com with SMTP id h63so22049706iof.12 for ; Tue, 29 Mar 2022 11:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZahETGQ5QFUGU9cdr5iIBFtuwsgQ6vA8xk/koQJqNS8=; b=hIo45tQdIyHSPqQxFA7cSGVqQAnnccWCcVxAPl+j61kcrTdvGs9L6Z7QfGblvZHskW /ZH26jVAGveFN3wqlh6mHLHWhTwxdwvTUpk7zKHOKHFw3WMnlBqLm8UVaxSt2JlujyDm wyATLvxsF6/pkIk4aBMtp+n9UZHgMCj4czzC8IONRr7cYeN1nxDL5Llqib9rAvl+eFXm bGOLbAsfBsQE4U4GVjXueGWhWegCAub+RhffcZF/FUlxuyCsgZBX9ZynT5LhrSqg+Qi6 40IqGBWNbKtEUnsLc052T7BhOiD0DtGVm6I9C72hjuJrArU9PpnkE4TJFmW9PFYxTHbC qu4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZahETGQ5QFUGU9cdr5iIBFtuwsgQ6vA8xk/koQJqNS8=; b=5etiJvLljHqx3v+r8xcxqW0clrlOxMdv6L+V1s9qs44YZn7APVW1sYpw/mvYtZOC1m D30wFWaxopD9zNxPpJYCztMaDfubbSnF4t/B3vznPKn+aYxWLDTktYuP4LZrkbv5zGKQ dYLmCb6DSrXKFaQ7G8cwd/s8ELOYk3F0Wa7Xrt1IHLPlX3g7f/72JKILNQuVPub2army B7wFi7XySpQmCFM2Ifz7FddZ0En8banz4gY0V1MCvAHfAADC4ggQXtlXQkUYA1SJaL2J mM5wuC1yr3fXco6GBcRBNWB6lxg4r5AEQT4FKobjX0soXXM9Ke03bDIuraWnHRb3kZsP PIEg== X-Gm-Message-State: AOAM532QGuhpwTExGmyjKEDttbnonl+m7kite71eqmJbi2kyBF5o6FFB YPcuK4Pf8hg0rL2+3LoFwY01cfWksQIYe0IvThmQDwod X-Google-Smtp-Source: ABdhPJyTRLtj5DQrHa/sg1LvTsPlKL0Wwps0PgPiKlJMJ5rQa8tTrMo9X1HvP2LSo3ty04jqtHTK/85LvaB4Az2iRj8= X-Received: by 2002:a05:6602:3c5:b0:64c:727d:6e95 with SMTP id g5-20020a05660203c500b0064c727d6e95mr6978541iov.118.1648579017088; Tue, 29 Mar 2022 11:36:57 -0700 (PDT) MIME-Version: 1.0 References: <7027b9b6b0cae2921ff65739582ae499bf61470c.1648049113.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Tue, 29 Mar 2022 20:36:46 +0200 Message-ID: Subject: Re: [PATCH v2 4/4] kasan: use stack_trace_save_shadow To: Marco Elver Cc: andrey.konovalov@linux.dev, Alexander Potapenko , Catalin Marinas , Will Deacon , Andrew Morton , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Mark Rutland , Vincenzo Frascino , Sami Tolvanen , Peter Collingbourne , Evgenii Stepanov , Florian Mayer , Linux Memory Management List , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: hxpo4o1sk57g9taiobng1acdg4yoytus Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=hIo45tQd; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.54 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: AD45010000D X-HE-Tag: 1648579017-549558 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 28, 2022 at 2:49 PM Marco Elver wrote: > > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > > index d9079ec11f31..8d9d35c6562b 100644 > > --- a/mm/kasan/common.c > > +++ b/mm/kasan/common.c > > @@ -33,10 +33,13 @@ > > depot_stack_handle_t kasan_save_stack(gfp_t flags, bool can_alloc) > > { > > unsigned long entries[KASAN_STACK_DEPTH]; > > - unsigned int nr_entries; > > + unsigned int size; > > Why did this variable name change? So the lines below fit within one line. It won't be needed with the other change you suggested. > > - nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 0); > > - return __stack_depot_save(entries, nr_entries, flags, can_alloc); > > + if (IS_ENABLED(CONFIG_HAVE_SHADOW_STACKTRACE)) > > Would it be more reliable to check the return-code? I.e. do: > > int size; > > size = stack_trace_save_shadow(...) > if (size < 0) > size = stack_trace_save(...); Sounds good, will do in v3. Thanks!