From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 721C6C35274 for ; Thu, 21 Dec 2023 17:33:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE1DB8D0003; Thu, 21 Dec 2023 12:33:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B925F8D0002; Thu, 21 Dec 2023 12:33:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A595A8D0003; Thu, 21 Dec 2023 12:33:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 924BF8D0002 for ; Thu, 21 Dec 2023 12:33:36 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 66510A0B60 for ; Thu, 21 Dec 2023 17:33:36 +0000 (UTC) X-FDA: 81591522432.30.3450396 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf20.hostedemail.com (Postfix) with ESMTP id 7F4B71C001B for ; Thu, 21 Dec 2023 17:33:34 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Az2mliUj; spf=pass (imf20.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703180014; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E1w4+dtGj/8F8JaerQ8KRIMdSrjR4dovsf8QQX0Vak4=; b=3+e7pmki9eNgLlNh96Ewd3y78i4RXkCbbjNxF1mdxCIB+zRCNwLSHLmcT3j5hlGLihPn84 efLNWsEoUdePAgIlhyWHLRCdSzEX0JnT291Enyv15m1Bku51nhFDdcdhWiJtcqsDci7AAV o4oEToEYKZtaou2m1x9a6DtQfhMuvAI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703180014; a=rsa-sha256; cv=none; b=0A5q5VJ+kozQIB5hCRclAB2bWFA5nPouKbNRzcupeKOb2A2uUTK/9PNhGTXlfiJUrWUsVu 3x3InHoIz4qb1UxjbUwcLZVxrKTnDFS2XSrvbXMjGFNzlBgalyXvw1p31PiWA7I+y/JQq6 UoEZmnqe7cPK7RmO7fU/k/Ihw5o7DgM= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Az2mliUj; spf=pass (imf20.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-28bd734aab4so855842a91.3 for ; Thu, 21 Dec 2023 09:33:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703180013; x=1703784813; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=E1w4+dtGj/8F8JaerQ8KRIMdSrjR4dovsf8QQX0Vak4=; b=Az2mliUjGB5Hb7R66eLR3Co15COOieDxgAdQ7VRp9lk1trjzF4kT9FiE+iA27/Oc0x p8fj1U4UjbqU1T4DXV4lPCIMhLLiDo5l+c9X6xXjj3TMVRHY6nMHzmMFNxiQKmFosExA Vl/uOtI9kahAMYjQBMXsFfy2rfw34WGwy7q9ujDM4Tn8LS8tTOKvZczSg6Za6GAZps4Y v2OI14mB/TT6CJIyUzOJ/XRef1gCqnLYr//FxrTS6mRHzvts9sdTo4f+64N1vS4ogwfz yOPUSwpZEIWfRNAbn5ac7fG4NLrdWDJgn8KGnTWLh+hBG/uzNa5FpGczLQqpmPospBIJ 4yvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703180013; x=1703784813; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E1w4+dtGj/8F8JaerQ8KRIMdSrjR4dovsf8QQX0Vak4=; b=ry5eHuxidx4j51ACjKxDyXOVQ+3WXTMixcGK00ANkxsssJmqoY0RxtPtGombK0FChk 9nAz5weew5ewLDrWsBxkOVSWF5/JRlRFqLPJnBXy3INH17e9BIL3aogXzvEvPfIcWVDt mXXKdKsfftOx3k7OHAh0kpDh0XZqL/gpE0arA1K/Tpa5WfBGymj+wlrh2ONKl7cCmpe0 3Ya6MWsBVXCRAUBSWg1g/wG3Goh9yPtK6iW8V0S70j3veiWRdBF7FKc8EgsExK//VtQn I2/Evs85h7HQDPTrL0TxL1X7r4syH1mAOMeNtDnLP55PvrM+AurxgY26DTOyRB4p0I8J //8g== X-Gm-Message-State: AOJu0YzAU7CBlS1c771HLbe4ZHYPbOqMag5t6PJv5eZJNebCa4k1Xwoj RWVtP7WbIylvPgbGnqmK2+KjtlVE0nNUrfi1XEc= X-Google-Smtp-Source: AGHT+IFsL8/D5VxUmULRHQiMZ8ANxgatyXPvIfAIxc3jgvF2biAA1U6q1k2/LML0p8Rl2cVG3grKgaef3R5poLhQHGc= X-Received: by 2002:a17:90b:46d7:b0:28b:e688:6b97 with SMTP id jx23-20020a17090b46d700b0028be6886b97mr95676pjb.1.1703180013162; Thu, 21 Dec 2023 09:33:33 -0800 (PST) MIME-Version: 1.0 References: <20231221-mark-unpoison_slab_object-as-static-v1-1-bf24f0982edc@kernel.org> In-Reply-To: <20231221-mark-unpoison_slab_object-as-static-v1-1-bf24f0982edc@kernel.org> From: Andrey Konovalov Date: Thu, 21 Dec 2023 18:33:21 +0100 Message-ID: Subject: Re: [PATCH] kasan: Mark unpoison_slab_object() as static To: Nathan Chancellor Cc: akpm@linux-foundation.org, ryabinin.a.a@gmail.com, glider@google.com, dvyukov@google.com, vincenzo.frascino@arm.com, kasan-dev@googlegroups.com, linux-mm@kvack.org, patches@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 7F4B71C001B X-Rspam-User: X-Stat-Signature: cwmspj5ei9oss5zh3jj8nsw7pfrn1n68 X-Rspamd-Server: rspam03 X-HE-Tag: 1703180014-93747 X-HE-Meta: U2FsdGVkX1+m39jjsddVJWkptvNxemZSgRVrLryHwEpDa/m6jltlMs88JNDwB7NnFGSukfgXvc/6/EtH14pewZraV0xSvh6IjpXC3c1ECe+gpesaNOtzjR+U3PGkvsOKur7VkwZwr4QoO8EvIchw7I/XsFp6Pl/J/feG8/DM4Kb2Shx3cBWqMsHxxo5vZmaxpCLV8x2AjF9CyEW/n2G4YEAi88Ax0MnAacC/TGOqLz6czLVrXWR7wfQO5WJeNUo4rwm/McYCnxMQDoSk+BNvGCaKYJghoKOgDjnKC/yTgJZUVPA/xr98X7f1zLoekA0sH/Crw26N13QvKfNUcQZP6SXCHHDqMNcqoALnXz3cniJfK9Sh0mCNAGHTunDvhpfFNDUADRHxdz5c0oJQt02JLeu6ynNwplXJNgIn41tnYmioQtnQVNPh77GXAlNXXUWyYYlIXy2JmgaIpf1BPNalbXLhxTstEOZUpi6w1Jupw1uwLGf1HlLKNBRuIDYdQtxzDpBu/yHX4ZuSnGENxoodDexCyiddftEkHbUo7JWuz8rPQOpK4B2hyZ9UJTsvNgrLyUn270IZQWI3XfPpPI8kVgFLOr3rCtQUdwn2SSyD59EVFFwhZ1LFpxQOROO5IOrOha0coe9WZhbiMluJp0d0ucCdyf7BRhhmn+C64objx2tQEsYnw+/A/kw/kjg8c5ElX6RUs2XXzDiNhU1FuvgEy7QPT4ZOI7gXyyupXct/5MJyDkFjfWe0neyjkY8knpn5ReFlkulrMdBqHyIcQdtOhATLFQS6nYOjXMcQNdsFp2vDOea8Rd5U8HViYRrrp2dR315wkUDj5TCCDBOM7F1nHNMtGvxgjOoY4yoXk6Vow7BubiYwEB4I4OK68MHTszp1dHAiw+6eHvShajiW4oGhzO1QDsWchKOjQk59XORaRdWj3gA4E6eKWJsBI3x2x6GtWoynvZPOuZZND02cRfQ ylx6v0s1 OfBgU9bu68biA524eEB5gDR3SECyDtrmT+FFmo8K0fVGUCfbkYXUg3piCE2og4Uuc7/I4mtKHe+7sAOf+8jsqZ+evO5LUH6800xrTUWX+hFE51Yt9RWien3sZ31bj1ceqKDbI2In8nz0kbB2ylKc8dGd1Ix6wKdyffgr+LHa9H7GSPOxChzMuJYmtNi1XbLMX/z9IeBU8vVuG2goV3+1RJyA6w/rlYnGgxOeslwGcsHqE5bnHbhu/TLemMhQB4IFqUXEdiLJk9MElFdOoEsACXT1gxX0LK5hNA2MLzAijQaaTqtbTYLm13LJ08h10QO+v1Pm64qacumASBcQ3QINpw7oSjQl8nnT/ijgFmO9IqvFRSjCYkIx731sFDBYP7X+S9CxK/519gXoD2dvuh22CG8Z+4RRac2/LILt+319qM15qKdchMi5kM3pzE8DMdWR4305JXBP8a3Iu4ogxeWuWyh05ukigVV3/uHQ3jE+l8GaLXfiCeSCqmknKC/cCehWNpSm2c3H1b1ZDEes05NUw+vVS1cee5BuaX0uHRxKpFluBLNc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001458, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 21, 2023 at 6:27=E2=80=AFPM Nathan Chancellor wrote: > > With -Wmissing-prototypes enabled, there is a warning that > unpoison_slab_object() has no prototype, breaking the build with > CONFIG_WERROR=3Dy: > > mm/kasan/common.c:271:6: error: no previous prototype for 'unpoison_sla= b_object' [-Werror=3Dmissing-prototypes] > 271 | void unpoison_slab_object(struct kmem_cache *cache, void *objec= t, gfp_t flags, > | ^~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > Mark the function as static, as it is not used outside of this > translation unit, clearing up the warning. > > Fixes: 3f38c3c5bc40 ("kasan: save alloc stack traces for mempool") > Signed-off-by: Nathan Chancellor > --- > mm/kasan/common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index ebb1b23d6480..563cda95240b 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -277,8 +277,8 @@ void __kasan_kfree_large(void *ptr, unsigned long ip) > /* The object will be poisoned by kasan_poison_pages(). */ > } > > -void unpoison_slab_object(struct kmem_cache *cache, void *object, gfp_t = flags, > - bool init) > +static void unpoison_slab_object(struct kmem_cache *cache, void *object, > + gfp_t flags, bool init) > { > /* > * Unpoison the whole object. For kmalloc() allocations, > > --- > base-commit: eacce8189e28717da6f44ee492b7404c636ae0de > change-id: 20231221-mark-unpoison_slab_object-as-static-3bf224e1527f > > Best regards, > -- > Nathan Chancellor > Reviewed-by: Andrey Konovalov I'll fold this fix into v2 if I end up resending the series. Thank you, Nathan!