From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B259CC07E99 for ; Mon, 5 Jul 2021 11:23:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 569416135F for ; Mon, 5 Jul 2021 11:23:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 569416135F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DC8616B0036; Mon, 5 Jul 2021 07:23:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D781A6B005D; Mon, 5 Jul 2021 07:23:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C18A76B006C; Mon, 5 Jul 2021 07:23:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0101.hostedemail.com [216.40.44.101]) by kanga.kvack.org (Postfix) with ESMTP id 9FFFE6B0036 for ; Mon, 5 Jul 2021 07:23:29 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2D40F1F35C for ; Mon, 5 Jul 2021 11:23:29 +0000 (UTC) X-FDA: 78328298538.21.32C4CF2 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf18.hostedemail.com (Postfix) with ESMTP id D2B984002097 for ; Mon, 5 Jul 2021 11:23:28 +0000 (UTC) Received: by mail-ed1-f41.google.com with SMTP id t3so23233877edt.12 for ; Mon, 05 Jul 2021 04:23:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Mdfkoj1lAbFutKa5lBXnsN9adsQUOWmNA/ZLqwOPGpk=; b=mWQhQjCBOWSXySjEfeb+vg4svQ/XwhAXPPEo50VHAEZRasrSO+6ohY4TfpRzrtkqlH r+7J2MKKBUvUrzkp89xszDBMBhn12q8RcynhlOASlSD84qAWtBY6a9kpkXAfwLn7BfYr KhOPY4RbDkPocGy4p8F8GREaZcXanMXSZJRyTdRjf8wfAvcEnnXx45RPYn4YYeL6eZe4 p5kw5DTy8ehyG9HLBvM5rWQJXkXsZ+2ghsYU95lf2XOcIodK4a9HVXWOUY2rv5vvv4vS 9D40H0/Qx+omS2SLjW0jfE9HKBJgS40somM3aAmiRd0rh1u+MU1eA7awdQpFxNeACyBv yMJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Mdfkoj1lAbFutKa5lBXnsN9adsQUOWmNA/ZLqwOPGpk=; b=pH/nKlSPbGtyeQDMy1i+xeMh7YqcapkEqxLfOrj46RQFy9jFHZN2tsHOZqCx1IAcF8 76uO1QTnMxll9WRbgJR6/1GxHdsDwwrg+8HJZ6BNO1vQmVlN3D02G3k1tfSzr5UyrysW 0GocRTPM60e8OVvdxOcDJFx4VI57paxMJz8BkHyhXpKFSl8stlQZcLQBnVWpKnn1DtXv BQQT9LsQ0tCZz1C9Syug0+srkVqUpilrQ7j3uDpceEC6fkUuNLnWiLTKjG5BGu+My1Qt 8FGEn6lvF3pIioUI0ukl5jRD2qxCZsUju2vBwJwVuPfzlOOjvuSa0CbYbM9bvLlpPi4T aweA== X-Gm-Message-State: AOAM532vXaIFQUNBK8VJ3Z2+Ol+21q8RzE9YWVlnSgVcdgNbv9mmhWpX qG+YgfTc5f3Lr+gOh7Ir5QjYK7NH/stqEgHupmI= X-Google-Smtp-Source: ABdhPJwGH0p/imAnekqZjXgvncy4w5jEtjNHUlH1jV4COzYm+dvF06JV51V2eJSLAgxDFSYriStliogFD/cCFmOocbI= X-Received: by 2002:a05:6402:5c9:: with SMTP id n9mr3126699edx.30.1625484207801; Mon, 05 Jul 2021 04:23:27 -0700 (PDT) MIME-Version: 1.0 References: <20210705103229.8505-1-yee.lee@mediatek.com> <20210705103229.8505-3-yee.lee@mediatek.com> In-Reply-To: From: Andrey Konovalov Date: Mon, 5 Jul 2021 13:23:17 +0200 Message-ID: Subject: Re: [PATCH v6 2/2] kasan: Add memzero int for unaligned size at DEBUG To: Marco Elver Cc: yee.lee@mediatek.com, LKML , nicholas.tang@mediatek.com, Kuan-Ying Lee , chinwen.chang@mediatek.com, Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Andrew Morton , Matthias Brugger , "open list:KASAN" , "open list:MEMORY MANAGEMENT" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=mWQhQjCB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com X-Rspamd-Server: rspam02 X-Stat-Signature: et9s3dnrman7hx1tektdkdpupgfo7o3r X-Rspamd-Queue-Id: D2B984002097 X-HE-Tag: 1625484208-126848 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 5, 2021 at 1:18 PM Marco Elver wrote: > > On Mon, 5 Jul 2021 at 13:12, Andrey Konovalov wrote: > [...] > > > + /* > > > + * Explicitly initialize the memory with the precise object size to > > > + * avoid overwriting the SLAB redzone. This disables initialization in > > > + * the arch code and may thus lead to performance penalty. The penalty > > > + * is accepted since SLAB redzones aren't enabled in production builds. > > > + */ > > > + if (__slub_debug_enabled() && > > > > What happened to slub_debug_enabled_unlikely()? Was it renamed? Why? I > > didn't receive patch #1 of v6 (nor of v5). > > Somebody had the same idea with the helper: > https://lkml.kernel.org/r/YOKsC75kJfCZwySD@elver.google.com > and Matthew didn't like the _unlikely() prefix. > > Which meant we should just move the existing helper introduced in the > merge window. > > Patch 1/2: https://lkml.kernel.org/r/20210705103229.8505-2-yee.lee@mediatek.com Got it. Thank you, Marco!