From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34D63C6379F for ; Thu, 9 Feb 2023 22:21:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 956E56B0073; Thu, 9 Feb 2023 17:21:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DF786B00AD; Thu, 9 Feb 2023 17:21:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 759BB6B00AE; Thu, 9 Feb 2023 17:21:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 62D5B6B0073 for ; Thu, 9 Feb 2023 17:21:23 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2FC9E16105E for ; Thu, 9 Feb 2023 22:21:23 +0000 (UTC) X-FDA: 80449175646.17.54CBAE8 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by imf16.hostedemail.com (Postfix) with ESMTP id 6BC68180008 for ; Thu, 9 Feb 2023 22:21:20 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=l4GZzGUs; spf=pass (imf16.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675981280; a=rsa-sha256; cv=none; b=5YoLO6zW1ZA/0AqUQd+Mqdl59eD9cTydADFx24Kt1JsoVdtvz2bkJmczPjg7zoOSfpjGZs ajFauqcIGN4MZZl0gEdxTEBM4plV1xjX5sv3dgVgxg36N+bsfewj+8F3itfYaomKBR+WnO yAkoovuEpYcrAtx8zrdAxoiGm8q5Mw8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=l4GZzGUs; spf=pass (imf16.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675981280; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=INi0TWgkRSLsbjVpaGDFPzQPHb0f2T5aCT1XYe2Z1mU=; b=BFJgOjj2mxAIYadE6RaNGFBM7JuZHNunMi01E56IjlPlPosh+OejaNyQf+V0Km7LFjniD+ +lOxubNviRPOlCa1+d6DdVrICeNZtrp/OmfF+N5GJT4sVnDJcQapJmePnwsIK9yQ9abAq4 voWA3ueRNHWlZCDXSNnSMr/QiUsTSmM= Received: by mail-pg1-f179.google.com with SMTP id r18so2515917pgr.12 for ; Thu, 09 Feb 2023 14:21:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1675981279; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=INi0TWgkRSLsbjVpaGDFPzQPHb0f2T5aCT1XYe2Z1mU=; b=l4GZzGUs4iwqALdBT1nng7ENnjNApXxSAe7gFo1wDjZK3CcEQQcytBT9RjV2hS487J iLPWhCoHgGEwQ8Wje5CuUSKm0tRu/xLa6b1uAA0iiFeu6IK23bgbd+r/OuUKS2LAIqYa SNGXZOSY7oOVcbMnKbQp/w5Wyj/HNjknqAvH4NSZTIHKI9hPIolVLsQd1fo6uv+q5WXx kswiqJbS5b7DMaMuCjSNEXpimzFuTqAnupW5XqyXM8wTzLddX4s9GCxl4URWvw3NJeg0 UmWimymTrp0fISsOyI8YqeWTJRnGT7a4gYp93ChcRjGnyCPsNeMe+jUBmUr/H7LtcBWO EZXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1675981279; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=INi0TWgkRSLsbjVpaGDFPzQPHb0f2T5aCT1XYe2Z1mU=; b=CvPJgeLfj/WOazROV5ZQmhvx96qOpnnb7bUEEeJdBmvhAmBSwjSGCQueDPqZGbqXVi gkI8mswJe6olzTMaZ4IF3gKdlyvTBfgn+JqkFDlPbh4UpYKBZ7wLW2t8E7vZBp86HUMc s6jvX/dQRtX5Lktw6DUrRXkTTTeQ4MwYLqXKmAu5/ZUcwsAnMqnzh4jRfpks5tAFOCZZ 3UwfZaMDrPd+yh7GsV4sALEjOv96S0NFQpgOXyD8RHlvVmxVdUGBqkeH2gLHwIWjRpkJ lOKtJLz6NlnFT5PzZ+M3G7znE2fw1HXMS7EGnvpJiU9sTTGDEmswlamA8oLsQN3Rhw9b qJ+A== X-Gm-Message-State: AO0yUKXPcBM1aFi4PMiLgdpwFzvsaxH31T+OxoHCIkvQFj9gmj1MzswE aBO8iMm1Dq4k5lkUqRftQcKGIoT7Othk8h4ulz0= X-Google-Smtp-Source: AK7set9Zb2XVF3aLUAZ2wGf+htOd4S/StdXwXwM0398AxxTqrXUBKz8Os/qa2ZXd2z6eHputQ1wQdGbcxaIXQ36SsBY= X-Received: by 2002:a62:79cf:0:b0:593:b73e:49af with SMTP id u198-20020a6279cf000000b00593b73e49afmr2777705pfc.24.1675981279155; Thu, 09 Feb 2023 14:21:19 -0800 (PST) MIME-Version: 1.0 References: <20230201071312.2224452-1-arnd@kernel.org> In-Reply-To: <20230201071312.2224452-1-arnd@kernel.org> From: Andrey Konovalov Date: Thu, 9 Feb 2023 23:21:08 +0100 Message-ID: Subject: Re: [PATCH] kasan: use %zd format for printing size_t To: Arnd Bergmann Cc: Andrey Ryabinin , Andrew Morton , Kuan-Ying Lee , Arnd Bergmann , Alexander Potapenko , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 6BC68180008 X-Rspamd-Server: rspam01 X-Stat-Signature: 7p9si836bc9q78dy9gmjt676g9eegs85 X-HE-Tag: 1675981280-718542 X-HE-Meta: U2FsdGVkX19UPmDmTjpuLuhma/FL+7ABHfTCBJrCi0JHQDvjCyR6Or07c5kNTXH21H9zt49cR2Um/USGtHNsG7wlVMvYiPfixZ1JEO+AJV97veV8bOtrMY6iua4+oN3/ArmA9v5UOBxYVh5niqUkAULlrDtlKRI3Aic+tli4hp2Yxsl6bbIcLLWbmrJWrxKbtte9gWzsqgnjEF2DYTSl3BrAv/g1GFQzdAdSGUmsgFdtFgEQb3U8iQylRjjXqTO60AVag5fPewi6A1qAyHNN4MwuwB6Ls9QIuslRqq6MoQ8NBuVRCwPVcoVD7yt0gv/HwDnBVcFr/tydLZ3mLy5UW/LKNg5b155g0HfZra47widn/W2jqWLlsBz6XAcKkImM0B4rTWsni2zGxzId7kvmCIH+rxpZymU2aexdsqNTKXxJcB244R805iiuioZ/oz5qKb3+ZsfZ/VK4eZ+3sSyIu4wMZqwIpBZNm7HgqAcPTjVu6Maak9/9unGSYzz71cFpVNjSpOIJBy4o/7q+i8q51JHmIGkBDbx1CrTzrarTOqPkq5m46bZo9h10mYhUxycGi6bB6V0rqJJsWDOWvnt0fQIldE+0vXfssxBTSuBZSCPBvTBXY3s/wKBiktkh1YniUT41cEqlvCC/KX0E+wwxhJgNeK66lKJx4G67Qfo0PzE6anSwS6XRonCprm61IXTBwCPdatSMtMG+2NjnKA1Mos49I02a/7yHZrY+xkuaEll+2EnmJK8mtrLXTh7Tsm0Fgm04k7x3dgD6xY39NcsSHQnwds6zlsgvQliuydLq+ekqg0fQPnbJw6gdEU8Efb0kyW+XFOzkNiia67HjqGCt4LWTI+N/dlCDCWdG6C8axBX4urPS5VtRCByMC9pgOIyygK4Qzb+BNq5lyMci0Or6g5l9KFw2wxHrUXKVy47nfV4RPkuVTVXsZvIB0l0elOjH6BMz0FoARkkgzv7ME7k oh0qMSrf kw6k+NViRGPvxng7PuUzKQudifzrBpfwP2NXLsHZytq2wzUdmRUzawCHl49sd0vtzAfuTCXBKfskTr9fFnb59dSz+oc8aszFoG1KbPCZGVN8T2TEdJ/OgIHEN7ZehaG/37/lBNm2OTXkJrpQRu2OWjqDFIKB6enTSgmGBpywN2b93Y9JGzbW8W1AqB99P7Y4vuH11p4HUI95T4TK2dVWnkm73aXm1WQKtLfHy1q13ThN0OX7ie728K3OcYOGwxMaCQIqmE1m6txVQlLnvmFNmOZp4l3lM6wFdzq4lS2pE9mOmXXtSOJ3ti7q/dovvN9YhiLfA7lgXRRfNk7yZlBwREue2swwFUhc5P6XmYYN4bmq771cskmrPOKKpUcu3+QOndnnIQmS4RhxsG+dMbcanADs79EDU2ZZ5OvV1BXK3xEzcNxej3KnuuwCZO6XmEvJwddg5Gi/HMc6HLkHpisryFtWNnSZWiEvuLTvVk85CC6naVDIw+T6lQGO9KQkMJxbxycQFuMF5a+bx8V7WnHeHL79quhYtafaHk3vUXeQFrYHVSjUDXnETPwHL6mk8BKQiwEk4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 1, 2023 at 8:13 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > The size_t type depends on the architecture, so %lu does not work > on most 32-bit ones: > > In file included from include/kunit/assert.h:13, > from include/kunit/test.h:12, > from mm/kasan/report.c:12: > mm/kasan/report.c: In function 'describe_object_addr': > include/linux/kern_levels.h:5:25: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Werror=format=] > mm/kasan/report.c:270:9: note: in expansion of macro 'pr_err' > 270 | pr_err("The buggy address is located %d bytes %s of\n" > | ^~~~~~ > > Fixes: 0e301731f558 ("kasan: infer allocation size by scanning metadata") > Signed-off-by: Arnd Bergmann > --- > mm/kasan/report.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index e0492124e90a..89078f912827 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -268,7 +268,7 @@ static void describe_object_addr(const void *addr, struct kasan_report_info *inf > } > > pr_err("The buggy address is located %d bytes %s of\n" > - " %s%lu-byte region [%px, %px)\n", > + " %s%zu-byte region [%px, %px)\n", > rel_bytes, rel_type, region_state, info->alloc_size, > (void *)object_addr, (void *)(object_addr + info->alloc_size)); > } > -- > 2.39.0 > Reviewed-by: Andrey Konovalov Thanks!